Skip to contentSkip to conversation

ARM: tegra: Re-add removed SoC id macro to tegra_resume()

PATCH Applied Dmitry Osipenko 2 participants 2 messages Oct 10, 2014 – Nov 17, 2014

Subsystems (4)
Stable branch Arm (32-bit) Arm sub-architectures Tegra architecture support
lore
Share & tools
lore

Dmitry Osipenko

author
#0 lore raw

PATCH v3 1/1 ARM: tegra: Re-add removed SoC id macro to tegra_resume()

Commit d127e9c ("ARM: tegra: make tegra_resume can work with current and later chips") removed tegra_get_soc_id macro leaving used cpu register corrupted after branching to v7_invalidate_l1() and as result causing execution of unintended code on tegra20. Possibly it was expected that r6 would be SoC id func argument since common cpu reset handler is setting r6 before branching to tegra_resume(), but neither tegra20_lp1_reset() nor tegra30_lp1_reset() aren't setting r6 register before jumping to resume function. Fix it by re-adding macro.

Fixes d127e9c (ARM: tegra: make tegra_resume can work with current and later chips)
Cc <[email protected]> # v3.13+
Reviewed-by Felipe Balbi <[email protected]>
Signed-off-by Dmitry Osipenko <[email protected]>

---
V2: added Cc's for lakml and stable, added "Reviewed-by:" Felipe Balbi
V3: changed commit description, tested on real hw

PS: It wasn't a bug in my emulator :)

 arch/arm/mach-tegra/reset-handler.S | 1 +
 1 file changed, 1 insertion(+)
arch/arm/mach-tegra/reset-handler.S +1 -0
index 7b2baab..71be4af 100644
@@ -51,6 +51,7 @@ ENTRY(tegra_resume)
  THUMB(	it	ne )
 	bne	cpu_resume			@ no
 
+	tegra_get_soc_id TEGRA_APB_MISC_BASE, r6
 	/* Are we on Tegra20? */
 	cmp	r6, #TEGRA20
 	beq	1f				@ Yes
Signature · 1 line
2.1.1
Applied
#1 lore raw
Quoted 12 lines · Dmitry Osipenko

Commit d127e9c ("ARM: tegra: make tegra_resume can work with current and later chips") removed tegra_get_soc_id macro leaving used cpu register corrupted after branching to v7_invalidate_l1() and as result causing execution of unintended code on tegra20. Possibly it was expected that r6 would be SoC id func argument since common cpu reset handler is setting r6 before branching to tegra_resume(), but neither tegra20_lp1_reset() nor tegra30_lp1_reset() aren't setting r6 register before jumping to resume function. Fix it by re-adding macro.

Fixes d127e9c (ARM: tegra: make tegra_resume can work with current and later chips)
Cc <[email protected]> # v3.13+
Reviewed-by Felipe Balbi <[email protected]>
Signed-off-by Dmitry Osipenko <[email protected]>
Quoted 8 lines

---
V2: added Cc's for lakml and stable, added "Reviewed-by:" Felipe Balbi
V3: changed commit description, tested on real hw

PS: It wasn't a bug in my emulator :)

 arch/arm/mach-tegra/reset-handler.S | 1 +
 1 file changed, 1 insertion(+)

Applied, thanks.

Thierry
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20141117/48b17ba4/attachment.sig>