Skip to contentSkip to conversation

Enable various Renesas drivers on all ARM platforms

PATCH Superseded Laurent Pinchart 13 participants 46 messages Oct 28, 2013 – Nov 6, 2013 4 messages not in the archive

Subsystems (20)

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

cover Enable various Renesas drivers on all ARM platforms

Hello,

This patch series, based on v3.12-rc7, prepares various Renesas drivers for migration to multiplatform kernels by enabling their compilation or otherwise fixing them on all ARM platforms. The patches are pretty straightforward and are described in their commit message.

I'd like to get all these patches merged in v3.14. As they will need to go through their respective subsystems' trees, I would appreciate if all maintainers involved could notify me when they merge patches from this series in their tree to help me tracking the merge status. I don't plan to send pull requests individually for these patches, and I will repost patches individually if changes are requested during review.

If you believe the issue should be solved in a different way (for instance by removing the architecture dependency completely) please reply to the cover letter to let other maintainers chime in.

Cc Chris Ball <[email protected]>
Cc "David S. Miller" <[email protected]>
Cc David Woodhouse <[email protected]>
Cc dmaengine at vger.kernel.org
Cc Dmitry Torokhov <[email protected]>
Cc Eduardo Valentin <[email protected]>
Cc Greg Kroah-Hartman <[email protected]>
Cc Guennadi Liakhovetski <[email protected]>
Cc Ian Molton <[email protected]>
Cc iommu at lists.linux-foundation.org
Cc Jean-Christophe Plagniol-Villard <[email protected]>
Cc Joerg Roedel <[email protected]>
Cc Linus Walleij <[email protected]>
Cc linux-fbdev at vger.kernel.org
Cc linux-i2c at vger.kernel.org
Cc linux-input at vger.kernel.org
Cc linux-kernel at vger.kernel.org
Cc linux-media at vger.kernel.org
Cc linux-mmc at vger.kernel.org
Cc linux-mtd at lists.infradead.org
Cc linux-pm at vger.kernel.org
Cc linux-pwm at vger.kernel.org
Cc linux-serial at vger.kernel.org
Cc linux-spi at vger.kernel.org
Cc Magnus Damm <[email protected]>
Cc Mark Brown <[email protected]>
Cc Mauro Carvalho Chehab <[email protected]>
Cc netdev at vger.kernel.org
Cc Samuel Ortiz <[email protected]>
Cc Sergei Shtylyov <[email protected]>
Cc Thierry Reding <[email protected]>
Cc Tomi Valkeinen <[email protected]>
Cc Vinod Koul <[email protected]>
Cc Wolfram Sang <[email protected]>
Cc Zhang Rui <[email protected]>

Laurent Pinchart (19):
serial: sh-sci: Enable the driver on all ARM platforms
DMA: shdma: Enable the driver on all ARM platforms
i2c: sh_mobile: Enable the driver on all ARM platforms
input: sh_keysc: Enable the driver on all ARM platforms
iommu: shmobile: Enable the driver on all ARM platforms
i2c: rcar: Enable the driver on all ARM platforms
v4l: sh_vou: Enable the driver on all ARM platforms
mmc: sdhi: Enable the driver on all ARM platforms
mmc: sh_mmcif: Enable the driver on all ARM platforms
mtd: sh_flctl: Enable the driver on all ARM platforms
net: sh_eth: Set receive alignment correctly on all ARM platforms
irda: sh_irda: Enable the driver on all ARM platforms
pinctrl: sh-pfc: Enable the driver on all ARM platforms
pwm: pwm-renesas-tpu: Enable the driver on all ARM platforms
sh: intc: Enable the driver on all ARM platforms
spi: sh_msiof: Enable the driver on all ARM platforms
spi: sh_hspi: Enable the driver on all ARM platforms
thermal: rcar-thermal: Enable the driver on all ARM platforms
fbdev: sh-mobile-lcdcfb: Enable the driver on all ARM platforms

 drivers/dma/sh/Kconfig                | 2 +-
 drivers/dma/sh/shdmac.c               | 6 +++---
 drivers/i2c/busses/Kconfig            | 4 ++--
 drivers/input/keyboard/Kconfig        | 2 +-
 drivers/iommu/Kconfig                 | 2 +-
 drivers/media/platform/Kconfig        | 2 +-
 drivers/mmc/host/Kconfig              | 4 ++--
 drivers/mmc/host/tmio_mmc_dma.c       | 2 +-
 drivers/mtd/nand/Kconfig              | 2 +-
 drivers/net/ethernet/renesas/sh_eth.c | 2 +-
 drivers/net/ethernet/renesas/sh_eth.h | 2 +-
 drivers/net/irda/Kconfig              | 2 +-
 drivers/pinctrl/Makefile              | 2 +-
 drivers/pinctrl/sh-pfc/Kconfig        | 2 +-
 drivers/pwm/Kconfig                   | 2 +-
 drivers/sh/intc/Kconfig               | 2 +-
 drivers/spi/Kconfig                   | 4 ++--
 drivers/thermal/Kconfig               | 2 +-
 drivers/tty/serial/Kconfig            | 2 +-
 drivers/video/Kconfig                 | 6 +++---
 20 files changed, 27 insertions(+), 27 deletions(-)
Signature · 3 lines
Regards,

Laurent Pinchart
#1 lore raw

PATCH 1/19 serial: sh-sci: Enable the driver on all ARM platforms

Renesas ARM platforms are transitioning from single-platform to multi-platform kernels using the new ARCH_SHMOBILE_MULTI. Make the driver available on all ARM platforms to enable it on both ARCH_SHMOBILE and ARCH_SHMOBILE_MULTI and increase build testing coverage.

Cc Greg Kroah-Hartman <[email protected]>
Cc linux-serial at vger.kernel.org
---
 drivers/tty/serial/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/tty/serial/Kconfig +1 -1
index febd45c..2976fa4 100644
@@ -709,7 +709,7 @@ config SERIAL_IP22_ZILOG_CONSOLE
 
 config SERIAL_SH_SCI
 	tristate "SuperH SCI(F) serial port support"
-	depends on HAVE_CLK && (SUPERH || ARCH_SHMOBILE)
+	depends on HAVE_CLK && (SUPERH || ARM)
 	select SERIAL_CORE
 
 config SERIAL_SH_SCI_NR_UARTS
Signature · 1 line
1.8.1.5
#2 lore raw

PATCH 2/19 DMA: shdma: Enable the driver on all ARM platforms

In reply to Laurent Pinchart

Renesas ARM platforms are transitioning from single-platform to multi-platform kernels using the new ARCH_SHMOBILE_MULTI. Make the driver available on all ARM platforms to enable it on both ARCH_SHMOBILE and ARCH_SHMOBILE_MULTI and increase build testing coverage.

Cc Guennadi Liakhovetski <[email protected]>
Cc Vinod Koul <[email protected]>
Cc dmaengine at vger.kernel.org
---
 drivers/dma/sh/Kconfig  | 2 +-
 drivers/dma/sh/shdmac.c | 6 +++---
 2 files changed, 4 insertions(+), 4 deletions(-)
drivers/dma/sh/Kconfig +1 -1
index dadd9e01..4aab56d 100644
@@ -4,7 +4,7 @@
 
 config SH_DMAE_BASE
 	bool "Renesas SuperH DMA Engine support"
-	depends on (SUPERH && SH_DMA) || (ARM && ARCH_SHMOBILE)
+	depends on (SUPERH && SH_DMA) || ARM
 	depends on !SH_DMA_API
 	default y
 	select DMA_ENGINE
drivers/dma/sh/shdmac.c +3 -3
index 1069e88..3625078 100644
@@ -787,7 +787,7 @@ static int sh_dmae_probe(struct platform_device *pdev)
 	if (err)
 		goto rst_err;
 
-#if defined(CONFIG_CPU_SH4) || defined(CONFIG_ARCH_SHMOBILE)
+#if defined(CONFIG_CPU_SH4) || defined(CONFIG_ARM)
 	chanirq_res = platform_get_resource(pdev, IORESOURCE_IRQ, 1);
 
 	if (!chanirq_res)
@@ -812,7 +812,7 @@ static int sh_dmae_probe(struct platform_device *pdev)
 
 #else
 	chanirq_res = errirq_res;
-#endif /* CONFIG_CPU_SH4 || CONFIG_ARCH_SHMOBILE */
+#endif /* CONFIG_CPU_SH4 || CONFIG_ARM */
 
 	if (chanirq_res->start == chanirq_res->end &&
 	    !platform_get_resource(pdev, IORESOURCE_IRQ, 1)) {
@@ -879,7 +879,7 @@ edmadevreg:
 chan_probe_err:
 	sh_dmae_chan_remove(shdev);
 
-#if defined(CONFIG_CPU_SH4) || defined(CONFIG_ARCH_SHMOBILE)
+#if defined(CONFIG_CPU_SH4) || defined(CONFIG_ARM)
 eirq_err:
 #endif
 rst_err:
Signature · 1 line
1.8.1.5
#3 lore raw

PATCH 3/19 i2c: sh_mobile: Enable the driver on all ARM platforms

In reply to Laurent Pinchart

Renesas ARM platforms are transitioning from single-platform to multi-platform kernels using the new ARCH_SHMOBILE_MULTI. Make the driver available on all ARM platforms to enable it on both ARCH_SHMOBILE and ARCH_SHMOBILE_MULTI and increase build testing coverage.

Cc Wolfram Sang <[email protected]>
Cc linux-i2c at vger.kernel.org
---
 drivers/i2c/busses/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/i2c/busses/Kconfig +1 -1
index cdcbd83..6adce91 100644
@@ -665,7 +665,7 @@ config I2C_SH7760
 
 config I2C_SH_MOBILE
 	tristate "SuperH Mobile I2C Controller"
-	depends on SUPERH || ARCH_SHMOBILE
+	depends on SUPERH || ARM
 	help
 	  If you say yes to this option, support will be included for the
 	  built-in I2C interface on the Renesas SH-Mobile processor.
Signature · 1 line
1.8.1.5
#4 lore raw

PATCH 3/19 i2c: sh_mobile: Enable the driver on all ARM platforms

Quoted 8 lines · Laurent Pinchart

Renesas ARM platforms are transitioning from single-platform to multi-platform kernels using the new ARCH_SHMOBILE_MULTI. Make the driver available on all ARM platforms to enable it on both ARCH_SHMOBILE and ARCH_SHMOBILE_MULTI and increase build testing coverage.

Cc Wolfram Sang <[email protected]>
Cc linux-i2c at vger.kernel.org

I wonder if those two Kconfig patches couldn't be squashed, but other than that:

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20131029/7153a6f9/attachment.sig>

#5 lore raw

PATCH 3/19 i2c: sh_mobile: Enable the driver on all ARM platforms

Hi Wolfram,

Quoted 11 lines · On Tuesday 29 October 2013 06:03:37 Wolfram Sang wrote:
Quoted 9 lines · Laurent Pinchart

Renesas ARM platforms are transitioning from single-platform to multi-platform kernels using the new ARCH_SHMOBILE_MULTI. Make the driver available on all ARM platforms to enable it on both ARCH_SHMOBILE and ARCH_SHMOBILE_MULTI and increase build testing coverage.

Cc: Wolfram Sang <[email protected]>
Cc: linux-i2c at vger.kernel.org
Signed-off-by: Laurent Pinchart
<[email protected]>

Quoted 4 lines

I wonder if those two Kconfig patches couldn't be squashed, but other than that:

Thank you. Please feel free to squash the patches together when applying if needed.

Signature · 10 lines
Regards,

Laurent Pinchart
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 490 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20131029/3d91fcf8/attachment.sig>
#6 lore raw

PATCH 4/19 input: sh_keysc: Enable the driver on all ARM platforms

In reply to Laurent Pinchart

Renesas ARM platforms are transitioning from single-platform to multi-platform kernels using the new ARCH_SHMOBILE_MULTI. Make the driver available on all ARM platforms to enable it on both ARCH_SHMOBILE and ARCH_SHMOBILE_MULTI and increase build testing coverage.

---
 drivers/input/keyboard/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/input/keyboard/Kconfig +1 -1
index c1edd39..7ac6a716e 100644
@@ -525,7 +525,7 @@ config KEYBOARD_SUNKBD
 
 config KEYBOARD_SH_KEYSC
 	tristate "SuperH KEYSC keypad support"
-	depends on SUPERH || ARCH_SHMOBILE
+	depends on SUPERH || ARM
 	help
 	  Say Y here if you want to use a keypad attached to the KEYSC block
 	  on SuperH processors such as sh7722 and sh7343.
Signature · 1 line
1.8.1.5
#7 lore raw

PATCH 5/19 iommu: shmobile: Enable the driver on all ARM platforms

In reply to Laurent Pinchart

Renesas ARM platforms are transitioning from single-platform to multi-platform kernels using the new ARCH_SHMOBILE_MULTI. Make the driver available on all ARM platforms to enable it on both ARCH_SHMOBILE and ARCH_SHMOBILE_MULTI and increase build testing coverage.

Cc Joerg Roedel <[email protected]>
Cc iommu at lists.linux-foundation.org
---
 drivers/iommu/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/iommu/Kconfig +1 -1
index c880eba..3e7fdbb 100644
@@ -206,7 +206,7 @@ config SHMOBILE_IPMMU_TLB
 config SHMOBILE_IOMMU
 	bool "IOMMU for Renesas IPMMU/IPMMUI"
 	default n
-	depends on (ARM && ARCH_SHMOBILE)
+	depends on ARM
 	select IOMMU_API
 	select ARM_DMA_USE_IOMMU
 	select SHMOBILE_IPMMU
Signature · 1 line
1.8.1.5
#8 lore raw

PATCH 6/19 i2c: rcar: Enable the driver on all ARM platforms

In reply to Laurent Pinchart

Renesas ARM platforms are transitioning from single-platform to multi-platform kernels using the new ARCH_SHMOBILE_MULTI. Make the driver available on all ARM platforms to enable it on both ARCH_SHMOBILE and ARCH_SHMOBILE_MULTI and increase build testing coverage.

Remove the explicit I2C dependency as the configuration option is already unavailable when I2C support is disabled.

Cc Wolfram Sang <[email protected]>
Cc linux-i2c at vger.kernel.org
---
 drivers/i2c/busses/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/i2c/busses/Kconfig +1 -1
index 6adce91..468c28a 100644
@@ -768,7 +768,7 @@ config I2C_XLR
 
 config I2C_RCAR
 	tristate "Renesas R-Car I2C Controller"
-	depends on ARCH_SHMOBILE && I2C
+	depends on ARM
 	help
 	  If you say yes to this option, support will be included for the
 	  R-Car I2C controller.
Signature · 1 line
1.8.1.5
#9 lore raw

PATCH 6/19 i2c: rcar: Enable the driver on all ARM platforms

Quoted 11 lines · Laurent Pinchart

Renesas ARM platforms are transitioning from single-platform to multi-platform kernels using the new ARCH_SHMOBILE_MULTI. Make the driver available on all ARM platforms to enable it on both ARCH_SHMOBILE and ARCH_SHMOBILE_MULTI and increase build testing coverage.

Remove the explicit I2C dependency as the configuration option is already unavailable when I2C support is disabled.

Cc Wolfram Sang <[email protected]>
Cc linux-i2c at vger.kernel.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20131029/cc4564bf/attachment.sig>

#10 lore raw

PATCH 7/19 v4l: sh_vou: Enable the driver on all ARM platforms

In reply to Laurent Pinchart

Renesas ARM platforms are transitioning from single-platform to multi-platform kernels using the new ARCH_SHMOBILE_MULTI. Make the driver available on all ARM platforms to enable it on both ARCH_SHMOBILE and ARCH_SHMOBILE_MULTI and increase build testing coverage.

---
 drivers/media/platform/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/media/platform/Kconfig +1 -1
index c7caf94..a726f86 100644
@@ -36,7 +36,7 @@ source "drivers/media/platform/blackfin/Kconfig"
 config VIDEO_SH_VOU
 	tristate "SuperH VOU video output driver"
 	depends on MEDIA_CAMERA_SUPPORT
-	depends on VIDEO_DEV && ARCH_SHMOBILE && I2C
+	depends on VIDEO_DEV && ARM && I2C
 	select VIDEOBUF_DMA_CONTIG
 	help
 	  Support for the Video Output Unit (VOU) on SuperH SoCs.
Signature · 1 line
1.8.1.5
#11 lore raw

PATCH 7/19 v4l: sh_vou: Enable the driver on all ARM platforms

Hi Laurent,

Em Tue, 29 Oct 2013 00:46:55 +0100
Laurent Pinchart <[email protected]> escreveu:

Quoted 8 lines

Renesas ARM platforms are transitioning from single-platform to multi-platform kernels using the new ARCH_SHMOBILE_MULTI. Make the driver available on all ARM platforms to enable it on both ARCH_SHMOBILE and ARCH_SHMOBILE_MULTI and increase build testing coverage.

Cc Mauro Carvalho Chehab <[email protected]>
Cc linux-media at vger.kernel.org

I'm understanding that the plan is to commit it via an ARM tree, right?

If so:

PS.: With regards to the discussions about this patch series, I'm ok on having this enabled for all archs or just for the archs that are known have this IP block, of course provided that not includes to march are there.

The rationale is that, in the specific case of V4L, the platform drivers are already on a separate Kconfig menu, with makes no sense to be enabled on any non SoC configuration.

Quoted 17 lines
---
 drivers/media/platform/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/media/platform/Kconfig +1 -1
index c7caf94..a726f86 100644
@@ -36,7 +36,7 @@ source "drivers/media/platform/blackfin/Kconfig"
 config VIDEO_SH_VOU
 	tristate "SuperH VOU video output driver"
 	depends on MEDIA_CAMERA_SUPPORT
-	depends on VIDEO_DEV && ARCH_SHMOBILE && I2C
+	depends on VIDEO_DEV && ARM && I2C
 	select VIDEOBUF_DMA_CONTIG
 	help
 	  Support for the Video Output Unit (VOU) on SuperH SoCs.
Signature · 2 lines
Cheers,
Mauro
#12 lore raw

PATCH 7/19 v4l: sh_vou: Enable the driver on all ARM platforms

Hi Mauro,

Quoted 6 lines · On Wednesday 30 October 2013 10:26:23 Mauro Carvalho Chehab wrote:

Em Tue, 29 Oct 2013 00:46:55 +0100 Laurent Pinchart escreveu:

Quoted 5 lines

Renesas ARM platforms are transitioning from single-platform to multi-platform kernels using the new ARCH_SHMOBILE_MULTI. Make the driver available on all ARM platforms to enable it on both ARCH_SHMOBILE and ARCH_SHMOBILE_MULTI and increase build testing coverage.

Quoted 6 lines
Quoted 4 lines

Cc: Mauro Carvalho Chehab <[email protected]>
Cc: [email protected]
Signed-off-by: Laurent Pinchart
<[email protected]>

I'm understanding that the plan is to commit it via an ARM tree, right?

Actually the plan is to get this upstream through you tree :-) However, I'm trying a different approach to the problem, so I'll post a new version of the patch set in the near future.

Quoted 10 lines

If so:

PS.: With regards to the discussions about this patch series, I'm ok on having this enabled for all archs or just for the archs that are known have this IP block, of course provided that not includes to march are there.

The rationale is that, in the specific case of V4L, the platform drivers are already on a separate Kconfig menu, with makes no sense to be enabled on any non SoC configuration.

We will likely split dependencies on two lines in Kconfig, one for the build- time dependencies and one for the runtime dependencies. A driver that compiles on ARM only and supports hardware that is present on ARCH_SHMOBILE SoCs only would thus have

	depends on ARM
	depends on ARCH_SHMOBILE || COMPILE_TEST

Build-time dependencies on other software components (I2C for instance) would be listed on the first line. The code below would become

	depends on VIDEO_DEV && I2C
	depends on ARCH_SHMOBILE || COMPILE_TEST
Quoted 18 lines
Quoted 18 lines

---

 drivers/media/platform/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
(quoted diff) +0 -0

b/drivers/media/platform/Kconfig index c7caf94..a726f86 100644

drivers/media/platform/Kconfig +1 -1
@@ -36,7 +36,7 @@ source "drivers/media/platform/blackfin/Kconfig"
 config VIDEO_SH_VOU
 	tristate "SuperH VOU video output driver"
 	depends on MEDIA_CAMERA_SUPPORT
-	depends on VIDEO_DEV && ARCH_SHMOBILE && I2C
+	depends on VIDEO_DEV && ARM && I2C
 	select VIDEOBUF_DMA_CONTIG
 	help
 	  Support for the Video Output Unit (VOU) on SuperH SoCs.
Signature · 3 lines
Regards,

Laurent Pinchart
#13 lore raw

PATCH 8/19 mmc: sdhi: Enable the driver on all ARM platforms

In reply to Laurent Pinchart

Renesas ARM platforms are transitioning from single-platform to multi-platform kernels using the new ARCH_SHMOBILE_MULTI. Make the driver available on all ARM platforms to enable it on both ARCH_SHMOBILE and ARCH_SHMOBILE_MULTI and increase build testing coverage.

Cc Chris Ball <[email protected]>
Cc Guennadi Liakhovetski <[email protected]>
Cc Ian Molton <[email protected]>
---
 drivers/mmc/host/Kconfig        | 2 +-
 drivers/mmc/host/tmio_mmc_dma.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
drivers/mmc/host/Kconfig +1 -1
index 7fc5099..51957d4 100644
@@ -479,7 +479,7 @@ config MMC_TMIO
 
 config MMC_SDHI
 	tristate "SH-Mobile SDHI SD/SDIO controller support"
-	depends on SUPERH || ARCH_SHMOBILE
+	depends on SUPERH || ARM
 	select MMC_TMIO_CORE
 	help
 	  This provides support for the SDHI SD/SDIO controller found in
drivers/mmc/host/tmio_mmc_dma.c +1 -1
index 65edb4a..535bc35 100644
@@ -28,7 +28,7 @@ void tmio_mmc_enable_dma(struct tmio_mmc_host *host, bool enable)
 	if (!host->chan_tx || !host->chan_rx)
 		return;
 
-#if defined(CONFIG_SUPERH) || defined(CONFIG_ARCH_SHMOBILE)
+#if defined(CONFIG_SUPERH) || defined(CONFIG_ARM)
 	/* Switch DMA mode on or off - SuperH specific? */
 	sd_ctrl_write16(host, CTL_DMA_ENABLE, enable ? 2 : 0);
 #endif
Signature · 1 line
1.8.1.5
#14 lore raw

PATCH 8/19 mmc: sdhi: Enable the driver on all ARM platforms

Hi Laurent

Quoted 33 lines · Laurent Pinchart

Renesas ARM platforms are transitioning from single-platform to multi-platform kernels using the new ARCH_SHMOBILE_MULTI. Make the driver available on all ARM platforms to enable it on both ARCH_SHMOBILE and ARCH_SHMOBILE_MULTI and increase build testing coverage.

Cc Chris Ball <[email protected]>
Cc Guennadi Liakhovetski <[email protected]>
Cc Ian Molton <[email protected]>
Cc linux-mmc at vger.kernel.org
---
 drivers/mmc/host/Kconfig        | 2 +-
 drivers/mmc/host/tmio_mmc_dma.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
drivers/mmc/host/Kconfig +1 -1
index 7fc5099..51957d4 100644
@@ -479,7 +479,7 @@ config MMC_TMIO
 
 config MMC_SDHI
 	tristate "SH-Mobile SDHI SD/SDIO controller support"
-	depends on SUPERH || ARCH_SHMOBILE
+	depends on SUPERH || ARM
 	select MMC_TMIO_CORE
 	help
 	  This provides support for the SDHI SD/SDIO controller found in
drivers/mmc/host/tmio_mmc_dma.c +0 -0
index 65edb4a..535bc35 100644

drivers/mmc/host/tmio_mmc_dma.c void tmio_mmc_enable_dma(struct tmio_mmc_host *host, bool enable) · line 31

Quoted 5 lines
drivers/mmc/host/tmio_mmc_dma.c +1 -1
@@ -28,7 +28,7 @@ void tmio_mmc_enable_dma(struct tmio_mmc_host *host, bool enable)
 	if (!host->chan_tx || !host->chan_rx)
 		return;
 
-#if defined(CONFIG_SUPERH) || defined(CONFIG_ARCH_SHMOBILE)
+#if defined(CONFIG_SUPERH) || defined(CONFIG_ARM)

I'm not sure about this one. In principle DMA so far is only used on SDHI with TMIO. But this #if was for a theoretical case, when a TMIO MMC IP inside an MFD is also used with DMA. Bus since I had no indormation about whether the CTL_DMA_ENABLE register was SDHI specific or not, I put it under an #if for the time being. In any case, I don't think making it #ifdef CONFIG_ARM makes much sense. We can either remove the #if completely, or keep it to limit the scope of this write to sh-mobile arches.

Thanks
Guennadi

Quoted 6 lines
drivers/mmc/host/tmio_mmc_dma.c +0 -0
 	/* Switch DMA mode on or off - SuperH specific? */
 	sd_ctrl_write16(host, CTL_DMA_ENABLE, enable ? 2 : 0);
 #endif
Signature · 1 line
1.8.1.5

---
Guennadi Liakhovetski, Ph.D.
Freelance Open-Source Software Developer
http://www.open-technology.de/

#15 lore raw

PATCH 8/19 mmc: sdhi: Enable the driver on all ARM platforms

Hi Guennadi,

Quoted 48 lines · On Tuesday 29 October 2013 10:07:29 Guennadi Liakhovetski wrote:

Hi Laurent

Quoted 45 lines · Laurent Pinchart

Renesas ARM platforms are transitioning from single-platform to multi-platform kernels using the new ARCH_SHMOBILE_MULTI. Make the driver available on all ARM platforms to enable it on both ARCH_SHMOBILE and ARCH_SHMOBILE_MULTI and increase build testing coverage.

Cc: Chris Ball <[email protected]>
Cc: Guennadi Liakhovetski <[email protected]>
Cc: Ian Molton <[email protected]>
Cc: [email protected]
Signed-off-by: Laurent Pinchart
<[email protected]>
---

 drivers/mmc/host/Kconfig        | 2 +-
 drivers/mmc/host/tmio_mmc_dma.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
drivers/mmc/host/Kconfig +1 -1
index 7fc5099..51957d4 100644
@@ -479,7 +479,7 @@ config MMC_TMIO
 
 config MMC_SDHI
 
 	tristate "SH-Mobile SDHI SD/SDIO controller support"
 
-	depends on SUPERH || ARCH_SHMOBILE
+	depends on SUPERH || ARM
 
drivers/mmc/host/Kconfig +0 -0
 	select MMC_TMIO_CORE
 	help
 
 	  This provides support for the SDHI SD/SDIO controller found in
(quoted diff) +0 -0

b/drivers/mmc/host/tmio_mmc_dma.c index 65edb4a..535bc35 100644

drivers/mmc/host/tmio_mmc_dma.c +0 -0
@@ -28,7 +28,7 @@ void tmio_mmc_enable_dma(struct tmio_mmc_host *host,

bool enable)>

drivers/mmc/host/tmio_mmc_dma.c +0 -0
 	if (!host->chan_tx || !host->chan_rx)
 
 		return;
Quoted 11 lines

drivers/mmc/host/tmio_mmc_dma.c void tmio_mmc_enable_dma(struct tmio_mmc_host *host, bool enable) · line 31

Quoted 2 lines
drivers/mmc/host/tmio_mmc_dma.c +1 -1
-#if defined(CONFIG_SUPERH) || defined(CONFIG_ARCH_SHMOBILE)
+#if defined(CONFIG_SUPERH) || defined(CONFIG_ARM)

I'm not sure about this one. In principle DMA so far is only used on SDHI with TMIO. But this #if was for a theoretical case, when a TMIO MMC IP inside an MFD is also used with DMA. Bus since I had no indormation about whether the CTL_DMA_ENABLE register was SDHI specific or not, I put it under an #if for the time being. In any case, I don't think making it #ifdef CONFIG_ARM makes much sense. We can either remove the #if completely, or keep it to limit the scope of this write to sh-mobile arches.

SUPERH || ARCH_SHMOBILE covers all the platforms this driver currently builds on. Now that we're adding ARCH_SHMOBILE_MULTI the #if needs to cover that case as well. I'm fine with limiting the CTL_DMA_ENABLE write to SUPERH only (which would modify the driver's behaviour) or enabling it unconditionally, but I don't think adding a defined(CONFIG_ARCH_SHMOBILE_MULTI) to the above #if makes sense, unless there's a plan to add support for DMA for non-SH (including both SUPERH and ARCH_SHMOBILE) platforms.

Quoted 4 lines
Quoted 4 lines
drivers/mmc/host/tmio_mmc_dma.c +0 -0
 	/* Switch DMA mode on or off - SuperH specific? */
 	sd_ctrl_write16(host, CTL_DMA_ENABLE, enable ? 2 : 0);
 
 #endif
Signature · 3 lines
Regards,

Laurent Pinchart
#16 lore raw

PATCH 8/19 mmc: sdhi: Enable the driver on all ARM platforms

Hello.

Quoted 11 lines · Laurent Pinchart
Quoted 11 lines
Quoted 11 lines

Renesas ARM platforms are transitioning from single-platform to multi-platform kernels using the new ARCH_SHMOBILE_MULTI. Make the driver available on all ARM platforms to enable it on both ARCH_SHMOBILE and ARCH_SHMOBILE_MULTI and increase build testing coverage.

Cc: Chris Ball <[email protected]>
Cc: Guennadi Liakhovetski <[email protected]>
Cc: Ian Molton <[email protected]>
Cc: linux-mmc at vger.kernel.org
Signed-off-by: Laurent Pinchart
<[email protected]>

[...]

Quoted 22 lines
Quoted 10 lines
Quoted 10 lines
(quoted diff) +0 -0

b/drivers/mmc/host/tmio_mmc_dma.c index 65edb4a..535bc35 100644

drivers/mmc/host/tmio_mmc_dma.c +0 -0
@@ -28,7 +28,7 @@ void tmio_mmc_enable_dma(struct tmio_mmc_host *host,

bool enable)>
if (!host->chan_tx || !host->chan_rx)

return;

Quoted 11 lines

drivers/mmc/host/tmio_mmc_dma.c void tmio_mmc_enable_dma(struct tmio_mmc_host *host, bool enable) · line 31

Quoted 2 lines
drivers/mmc/host/tmio_mmc_dma.c +1 -1
-#if defined(CONFIG_SUPERH) || defined(CONFIG_ARCH_SHMOBILE)
+#if defined(CONFIG_SUPERH) || defined(CONFIG_ARM)

I'm not sure about this one. In principle DMA so far is only used on SDHI with TMIO. But this #if was for a theoretical case, when a TMIO MMC IP inside an MFD is also used with DMA. Bus since I had no indormation about whether the CTL_DMA_ENABLE register was SDHI specific or not, I put it under an #if for the time being. In any case, I don't think making it #ifdef CONFIG_ARM makes much sense. We can either remove the #if completely, or keep it to limit the scope of this write to sh-mobile arches.

Quoted 4 lines

SUPERH || ARCH_SHMOBILE covers all the platforms this driver currently builds on. Now that we're adding ARCH_SHMOBILE_MULTI the #if needs to cover that case as well. I'm fine with limiting the CTL_DMA_ENABLE write to SUPERH only (which would modify the driver's behaviour)

I'm afraid that would break the driver's ability to work in DMA mode on
SH-Mobile SoCs.

Quoted 4 lines

or enabling it unconditionally, but I
don't think adding a defined(CONFIG_ARCH_SHMOBILE_MULTI) to the above #if makes sense, unless there's a plan to add support for DMA for non-SH (including both SUPERH and ARCH_SHMOBILE) platforms.

Not only the plan -- I have already posted the patches to do it for
R8A777x, and Simon has queued them for 3.13.

Quoted 4 lines
Quoted 4 lines
Quoted 4 lines

/* Switch DMA mode on or off - SuperH specific? */ sd_ctrl_write16(host, CTL_DMA_ENABLE, enable ? 2 : 0);

  #endif

WBR, Sergei

#17 lore raw

PATCH 8/19 mmc: sdhi: Enable the driver on all ARM platforms

Hi Sergei,

Quoted 38 lines · On Tuesday 29 October 2013 16:12:49 Sergei Shtylyov wrote:
Quoted 11 lines · Laurent Pinchart
Quoted 11 lines
Quoted 11 lines

Renesas ARM platforms are transitioning from single-platform to multi-platform kernels using the new ARCH_SHMOBILE_MULTI. Make the driver available on all ARM platforms to enable it on both ARCH_SHMOBILE and ARCH_SHMOBILE_MULTI and increase build testing coverage.

Cc: Chris Ball <[email protected]>
Cc: Guennadi Liakhovetski <[email protected]>
Cc: Ian Molton <[email protected]>
Cc: linux-mmc at vger.kernel.org
Signed-off-by: Laurent Pinchart
<[email protected]>

[...]

Quoted 23 lines
Quoted 22 lines

drivers/mmc/host/tmio_mmc_dma.c void tmio_mmc_enable_dma(struct tmio_mmc_host *host, bool enable) · line 31

Quoted 13 lines
(quoted diff) +0 -0

b/drivers/mmc/host/tmio_mmc_dma.c index 65edb4a..535bc35 100644

drivers/mmc/host/tmio_mmc_dma.c +0 -0
@@ -28,7 +28,7 @@ void tmio_mmc_enable_dma(struct tmio_mmc_host *host,

bool enable)>

  	if (!host->chan_tx || !host->chan_rx)

return;

drivers/mmc/host/tmio_mmc_dma.c +1 -1
-#if defined(CONFIG_SUPERH) || defined(CONFIG_ARCH_SHMOBILE)
+#if defined(CONFIG_SUPERH) || defined(CONFIG_ARM)

I'm not sure about this one. In principle DMA so far is only used on SDHI with TMIO. But this #if was for a theoretical case, when a TMIO MMC IP inside an MFD is also used with DMA. Bus since I had no indormation about whether the CTL_DMA_ENABLE register was SDHI specific or not, I put it under an #if for the time being. In any case, I don't think making it #ifdef CONFIG_ARM makes much sense. We can either remove the #if completely, or keep it to limit the scope of this write to sh-mobile arches.

Quoted 7 lines
Quoted 4 lines

SUPERH || ARCH_SHMOBILE covers all the platforms this driver currently builds on. Now that we're adding ARCH_SHMOBILE_MULTI the #if needs to cover that case as well. I'm fine with limiting the CTL_DMA_ENABLE write to SUPERH only (which would modify the driver's behaviour)

I'm afraid that would break the driver's ability to work in DMA mode on SH- Mobile SoCs.

So can you confirm that writing the CTL_DMA_ENABLE register is required on all Renesas ARM SoCs (including SH-Mobile, R-Mobile and R-Car) ?

Quoted 7 lines
Quoted 4 lines

or enabling it unconditionally, but I don't think adding a defined(CONFIG_ARCH_SHMOBILE_MULTI) to the above #if makes sense, unless there's a plan to add support for DMA for non-SH (including both SUPERH and ARCH_SHMOBILE) platforms.

Not only the plan -- I have already posted the patches to do it for R8A777x, and Simon has queued them for 3.13.

Could you please point me to those patches ?

Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines

/* Switch DMA mode on or off - SuperH specific? */ sd_ctrl_write16(host, CTL_DMA_ENABLE, enable ? 2 : 0);

  #endif
Signature · 3 lines
Regards,

Laurent Pinchart
#18 lore raw

PATCH 8/19 mmc: sdhi: Enable the driver on all ARM platforms

Quoted 42 lines · Laurent Pinchart
Quoted 41 lines
Quoted 11 lines
Quoted 11 lines
Quoted 11 lines

Renesas ARM platforms are transitioning from single-platform to multi-platform kernels using the new ARCH_SHMOBILE_MULTI. Make the driver available on all ARM platforms to enable it on both ARCH_SHMOBILE and ARCH_SHMOBILE_MULTI and increase build testing coverage.

Cc: Chris Ball <[email protected]>
Cc: Guennadi Liakhovetski <[email protected]>
Cc: Ian Molton <[email protected]>
Cc: [email protected]
Signed-off-by: Laurent Pinchart
<[email protected]>

[...]

Quoted 27 lines
Quoted 11 lines
Quoted 10 lines
(quoted diff) +0 -0

b/drivers/mmc/host/tmio_mmc_dma.c index 65edb4a..535bc35 100644

drivers/mmc/host/tmio_mmc_dma.c +0 -0
@@ -28,7 +28,7 @@ void tmio_mmc_enable_dma(struct tmio_mmc_host *host,

bool enable)>

   	if (!host->chan_tx || !host->chan_rx)
   		return;
Quoted 11 lines

drivers/mmc/host/tmio_mmc_dma.c void tmio_mmc_enable_dma(struct tmio_mmc_host *host, bool enable) · line 31

Quoted 2 lines
drivers/mmc/host/tmio_mmc_dma.c +1 -1
-#if defined(CONFIG_SUPERH) || defined(CONFIG_ARCH_SHMOBILE)
+#if defined(CONFIG_SUPERH) || defined(CONFIG_ARM)

I'm not sure about this one. In principle DMA so far is only used on SDHI with TMIO. But this #if was for a theoretical case, when a TMIO MMC IP inside an MFD is also used with DMA. Bus since I had no indormation about whether the CTL_DMA_ENABLE register was SDHI specific or not, I put it under an #if for the time being. In any case, I don't think making it #ifdef CONFIG_ARM makes much sense. We can either remove the #if completely, or keep it to limit the scope of this write to sh-mobile arches.

SUPERH || ARCH_SHMOBILE covers all the platforms this driver currently builds on. Now that we're adding ARCH_SHMOBILE_MULTI the #if needs to cover that case as well. I'm fine with limiting the CTL_DMA_ENABLE write to SUPERH only (which would modify the driver's behaviour)

Quoted 5 lines
Quoted 2 lines

I'm afraid that would break the driver's ability to work in DMA mode on SH- Mobile SoCs.

So can you confirm that writing the CTL_DMA_ENABLE register is required on all Renesas ARM SoCs (including SH-Mobile, R-Mobile and R-Car) ?

I can't actually say anything about all SH-Mobile and R-Mobile SoCs, only
about the R-Car SoCs: though the datasheets don't contain the SDHI register info, from my experience the register exists on R8A777x (I had to fix up the broken PIO fallback in the SDHI driver).

Quoted 9 lines
Quoted 7 lines
Quoted 4 lines

or enabling it unconditionally, but I don't think adding a defined(CONFIG_ARCH_SHMOBILE_MULTI) to the above #if makes sense, unless there's a plan to add support for DMA for non-SH (including both SUPERH and ARCH_SHMOBILE) platforms.

Not only the plan -- I have already posted the patches to do it for R8A777x, and Simon has queued them for 3.13.

Could you please point me to those patches ?

https://git.kernel.org/cgit/linux/kernel/git/horms/renesas.git/commit/?h=next&id=1eb6b5a0e55bfcfb0852b7d0f9442841ff807345
https://git.kernel.org/cgit/linux/kernel/git/horms/renesas.git/commit/?h=next&id=a43e5bd76a4a3df58167d85e8020a1c9e566ad75
https://git.kernel.org/cgit/linux/kernel/git/horms/renesas.git/commit/?h=next&id=5d6aa3435275a5308684f90c17424b055ef7f572
https://git.kernel.org/cgit/linux/kernel/git/horms/renesas.git/commit/?h=next&id=e6a8b11b82fdeaa78dad52552f945b772ee1a5c9

WBR, Sergei

#19 lore raw

PATCH 8/19 mmc: sdhi: Enable the driver on all ARM platforms

Hi Sergei,

Quoted 47 lines · On Tuesday 29 October 2013 23:47:36 Sergei Shtylyov wrote:
Quoted 46 lines · Laurent Pinchart
Quoted 45 lines
Quoted 12 lines
Quoted 12 lines
Quoted 12 lines

Renesas ARM platforms are transitioning from single-platform to multi-platform kernels using the new ARCH_SHMOBILE_MULTI. Make the driver available on all ARM platforms to enable it on both ARCH_SHMOBILE and ARCH_SHMOBILE_MULTI and increase build testing coverage.

Cc: Chris Ball <[email protected]>
Cc: Guennadi Liakhovetski <[email protected]>
Cc: Ian Molton <[email protected]>
Cc: linux-mmc at vger.kernel.org
Signed-off-by: Laurent Pinchart
<[email protected]>

[...]

Quoted 23 lines
Quoted 11 lines
Quoted 11 lines
(quoted diff) +0 -0

b/drivers/mmc/host/tmio_mmc_dma.c index 65edb4a..535bc35 100644

drivers/mmc/host/tmio_mmc_dma.c +0 -0
@@ -28,7 +28,7 @@ void tmio_mmc_enable_dma(struct tmio_mmc_host *host,

bool enable)>

   	if (!host->chan_tx || !host->chan_rx)
   		return;
Quoted 11 lines

drivers/mmc/host/tmio_mmc_dma.c void tmio_mmc_enable_dma(struct tmio_mmc_host *host, bool enable) · line 31

Quoted 2 lines
drivers/mmc/host/tmio_mmc_dma.c +1 -1
-#if defined(CONFIG_SUPERH) || defined(CONFIG_ARCH_SHMOBILE)
+#if defined(CONFIG_SUPERH) || defined(CONFIG_ARM)

I'm not sure about this one. In principle DMA so far is only used on SDHI with TMIO. But this #if was for a theoretical case, when a TMIO MMC IP inside an MFD is also used with DMA. Bus since I had no indormation about whether the CTL_DMA_ENABLE register was SDHI specific or not, I put it under an #if for the time being. In any case, I don't think making it #ifdef CONFIG_ARM makes much sense. We can either remove the #if completely, or keep it to limit the scope of this write to sh-mobile arches.

Quoted 4 lines

SUPERH || ARCH_SHMOBILE covers all the platforms this driver currently builds on. Now that we're adding ARCH_SHMOBILE_MULTI the #if needs to cover that case as well. I'm fine with limiting the CTL_DMA_ENABLE write to SUPERH only (which would modify the driver's behaviour)

I'm afraid that would break the driver's ability to work in DMA mode on SH-Mobile SoCs.

Quoted 7 lines
Quoted 2 lines

So can you confirm that writing the CTL_DMA_ENABLE register is required on all Renesas ARM SoCs (including SH-Mobile, R-Mobile and R-Car) ?

I can't actually say anything about all SH-Mobile and R-Mobile SoCs, only about the R-Car SoCs: though the datasheets don't contain the SDHI register info, from my experience the register exists on R8A777x (I had to fix up the broken PIO fallback in the SDHI driver).

OK.

Quoted 10 lines
Quoted 9 lines
Quoted 7 lines
Quoted 4 lines

or enabling it unconditionally, but I don't think adding a defined(CONFIG_ARCH_SHMOBILE_MULTI) to the above #if makes sense, unless there's a plan to add support for DMA for non-SH (including both SUPERH and ARCH_SHMOBILE) platforms.

Not only the plan -- I have already posted the patches to do it for R8A777x, and Simon has queued them for 3.13.

Could you please point me to those patches ?

Quoted 8 lines

https://git.kernel.org/cgit/linux/kernel/git/horms/renesas.git/commit/?h=nex
t&id=1eb6b5a0e55bfcfb0852b7d0f9442841ff807345
https://git.kernel.org/cgit/linux/kernel/git/horms/renesas.git/commit/?h=ne
xt&id=a43e5bd76a4a3df58167d85e8020a1c9e566ad75
https://git.kernel.org/cgit/linux/kernel/git/horms/renesas.git/commit/?h=ne
xt&id=5d6aa3435275a5308684f90c17424b055ef7f572
https://git.kernel.org/cgit/linux/kernel/git/horms/renesas.git/commit/?h=ne
xt&id=e6a8b11b82fdeaa78dad52552f945b772ee1a5c9

But that's still an ARCH_SHMOBILE platform. Guennadi's point, if I understood it correctly, was that whether the CTL_DMA_ENABLE register is part of the standard TMIO controller, or is Renesas-specific, is unknown. As we have no current or planned TMIO DMA users other than SUPERH and ARCH_SHMOBILE this is impossible to test. That is why the code is conditionally compiled.

We could either get rid of the #if completely and always write to the register, or add ARCH_SHMOBILE_MULTI to the condition. I now agree that adding ARM as a dependency makes no sense. Given that this will break on multiplatform kernels anyway, I'm enclined to write to the CTL_DMA_ENABLE register unconditionally. I'll update the patch accordingly.

Signature · 3 lines
Regards,

Laurent Pinchart
#20 lore raw

PATCH 9/19 mmc: sh_mmcif: Enable the driver on all ARM platforms

In reply to Laurent Pinchart

Renesas ARM platforms are transitioning from single-platform to multi-platform kernels using the new ARCH_SHMOBILE_MULTI. Make the driver available on all ARM platforms to enable it on both ARCH_SHMOBILE and ARCH_SHMOBILE_MULTI and increase build testing coverage.

Cc Chris Ball <[email protected]>
Cc linux-mmc at vger.kernel.org
---
 drivers/mmc/host/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/mmc/host/Kconfig +1 -1
index 51957d4..1f3a0c1 100644
@@ -588,7 +588,7 @@ config MMC_DW_PCI
 
 config MMC_SH_MMCIF
 	tristate "SuperH Internal MMCIF support"
-	depends on MMC_BLOCK && (SUPERH || ARCH_SHMOBILE)
+	depends on MMC_BLOCK && (SUPERH || ARM)
 	help
 	  This selects the MMC Host Interface controller (MMCIF).
 
Signature · 1 line
1.8.1.5
#21 lore raw

PATCH 10/19 mtd: sh_flctl: Enable the driver on all ARM platforms

In reply to Laurent Pinchart

Renesas ARM platforms are transitioning from single-platform to multi-platform kernels using the new ARCH_SHMOBILE_MULTI. Make the driver available on all ARM platforms to enable it on both ARCH_SHMOBILE and ARCH_SHMOBILE_MULTI and increase build testing coverage.

Cc David Woodhouse <[email protected]>
Cc linux-mtd at lists.infradead.org
---
 drivers/mtd/nand/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/mtd/nand/Kconfig +1 -1
index d885298..f491f5b 100644
@@ -486,7 +486,7 @@ config MTD_NAND_MXC
 
 config MTD_NAND_SH_FLCTL
 	tristate "Support for NAND on Renesas SuperH FLCTL"
-	depends on SUPERH || ARCH_SHMOBILE
+	depends on SUPERH || ARM
 	help
 	  Several Renesas SuperH CPU has FLCTL. This option enables support
 	  for NAND Flash using FLCTL.
Signature · 1 line
1.8.1.5
#22 lore raw

PATCH 11/19 net: sh_eth: Set receive alignment correctly on all ARM platforms

In reply to Laurent Pinchart

Renesas ARM platforms are transitioning from single-platform to multi-platform kernels using the new ARCH_SHMOBILE_MULTI. Configure the receive alignement correctly on all ARM platforms to enable the driver on both ARCH_SHMOBILE and ARCH_SHMOBILE_MULTI.

Cc "David S. Miller" <[email protected]>
Cc Sergei Shtylyov <[email protected]>
---
 drivers/net/ethernet/renesas/sh_eth.c | 2 +-
 drivers/net/ethernet/renesas/sh_eth.h | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
drivers/net/ethernet/renesas/sh_eth.c +1 -1
index b57c278..990fd5b 100644
@@ -809,7 +809,7 @@ out:
 	return ret;
 }
 
-#if defined(CONFIG_CPU_SH4) || defined(CONFIG_ARCH_SHMOBILE)
+#if defined(CONFIG_CPU_SH4) || defined(CONFIG_ARM)
 static void sh_eth_set_receive_align(struct sk_buff *skb)
 {
 	int reserve;
drivers/net/ethernet/renesas/sh_eth.h +1 -1
index a0db02c..41509f7 100644
@@ -165,7 +165,7 @@ enum {
 };
 
 /* Driver's parameters */
-#if defined(CONFIG_CPU_SH4) || defined(CONFIG_ARCH_SHMOBILE)
+#if defined(CONFIG_CPU_SH4) || defined(CONFIG_ARM)
 #define SH4_SKB_RX_ALIGN	32
 #else
 #define SH2_SH3_SKB_RX_ALIGN	2
Signature · 1 line
1.8.1.5
#23 lore raw

PATCH 12/19 irda: sh_irda: Enable the driver on all ARM platforms

In reply to Laurent Pinchart

Renesas ARM platforms are transitioning from single-platform to multi-platform kernels using the new ARCH_SHMOBILE_MULTI. Make the driver available on all ARM platforms to enable it on both ARCH_SHMOBILE and ARCH_SHMOBILE_MULTI and increase build testing coverage.

Cc Samuel Ortiz <[email protected]>
Cc netdev at vger.kernel.org
---
 drivers/net/irda/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/irda/Kconfig +1 -1
index 2a30193..54b4101 100644
@@ -403,7 +403,7 @@ config MCS_FIR
 
 config SH_IRDA
 	tristate "SuperH IrDA driver"
-	depends on IRDA && ARCH_SHMOBILE
+	depends on IRDA && ARM
 	help
 	  Say Y here if your want to enable SuperH IrDA devices.
 
Signature · 1 line
1.8.1.5
#24 lore raw

PATCH 13/19 pinctrl: sh-pfc: Enable the driver on all ARM platforms

In reply to Laurent Pinchart

Renesas ARM platforms are transitioning from single-platform to multi-platform kernels using the new ARCH_SHMOBILE_MULTI. Make the driver available on all ARM platforms to enable it on both ARCH_SHMOBILE and ARCH_SHMOBILE_MULTI and increase build testing coverage.

---
 drivers/pinctrl/Makefile       | 2 +-
 drivers/pinctrl/sh-pfc/Kconfig | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
drivers/pinctrl/Makefile +1 -1
index 496d9bf..bef5a9f 100644
@@ -56,7 +56,7 @@ obj-$(CONFIG_PINCTRL_ST) 	+= pinctrl-st.o
 obj-$(CONFIG_PINCTRL_VF610)	+= pinctrl-vf610.o
 
 obj-$(CONFIG_PLAT_ORION)        += mvebu/
-obj-$(CONFIG_ARCH_SHMOBILE)	+= sh-pfc/
+obj-$(CONFIG_ARM)		+= sh-pfc/
 obj-$(CONFIG_SUPERH)		+= sh-pfc/
 obj-$(CONFIG_PLAT_SPEAR)	+= spear/
 obj-$(CONFIG_ARCH_VT8500)	+= vt8500/
drivers/pinctrl/sh-pfc/Kconfig +1 -1
index 636a882..1d6182e 100644
@@ -2,7 +2,7 @@
 # Renesas SH and SH Mobile PINCTRL drivers
 #
 
-if ARCH_SHMOBILE || SUPERH
+if ARM || SUPERH
 
 config PINCTRL_SH_PFC
 	select GPIO_SH_PFC if ARCH_REQUIRE_GPIOLIB
Signature · 1 line
1.8.1.5
#25 lore raw

PATCH 14/19 pwm: pwm-renesas-tpu: Enable the driver on all ARM platforms

In reply to Laurent Pinchart

Renesas ARM platforms are transitioning from single-platform to multi-platform kernels using the new ARCH_SHMOBILE_MULTI. Make the driver available on all ARM platforms to enable it on both ARCH_SHMOBILE and ARCH_SHMOBILE_MULTI and increase build testing coverage.

Cc Thierry Reding <[email protected]>
Cc linux-pwm at vger.kernel.org
---
 drivers/pwm/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/pwm/Kconfig +1 -1
index 75840b5..d851fdb 100644
@@ -130,7 +130,7 @@ config PWM_PXA
 
 config PWM_RENESAS_TPU
 	tristate "Renesas TPU PWM support"
-	depends on ARCH_SHMOBILE
+	depends on ARM
 	help
 	  This driver exposes the Timer Pulse Unit (TPU) PWM controller found
 	  in Renesas chips through the PWM API.
Signature · 1 line
1.8.1.5
#26 lore raw

PATCH 15/19 sh: intc: Enable the driver on all ARM platforms

In reply to Laurent Pinchart

Renesas ARM platforms are transitioning from single-platform to multi-platform kernels using the new ARCH_SHMOBILE_MULTI. Make the driver available on all ARM platforms to enable it on both ARCH_SHMOBILE and ARCH_SHMOBILE_MULTI and increase build testing coverage.

---
 drivers/sh/intc/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/sh/intc/Kconfig +1 -1
index a305731..9546a7a 100644
@@ -6,7 +6,7 @@ comment "Interrupt controller options"
 
 config INTC_USERIMASK
 	bool "Userspace interrupt masking support"
-	depends on ARCH_SHMOBILE || (SUPERH && CPU_SH4A)
+	depends on ARM || (SUPERH && CPU_SH4A)
 	help
 	  This enables support for hardware-assisted userspace hardirq
 	  masking.
Signature · 1 line
1.8.1.5
#27 lore raw

PATCH 16/19 spi: sh_msiof: Enable the driver on all ARM platforms

In reply to Laurent Pinchart

Renesas ARM platforms are transitioning from single-platform to multi-platform kernels using the new ARCH_SHMOBILE_MULTI. Make the driver available on all ARM platforms to enable it on both ARCH_SHMOBILE and ARCH_SHMOBILE_MULTI and increase build testing coverage.

Cc Mark Brown <[email protected]>
Cc linux-spi at vger.kernel.org
---
 drivers/spi/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/spi/Kconfig +1 -1
index b9c53cc..a69b740 100644
@@ -406,7 +406,7 @@ config SPI_SC18IS602
 
 config SPI_SH_MSIOF
 	tristate "SuperH MSIOF SPI controller"
-	depends on (SUPERH || ARCH_SHMOBILE) && HAVE_CLK
+	depends on (SUPERH || ARM) && HAVE_CLK
 	select SPI_BITBANG
 	help
 	  SPI driver for SuperH and SH Mobile MSIOF blocks.
Signature · 1 line
1.8.1.5
maintainer
#28 lore raw

PATCH 16/19 spi: sh_msiof: Enable the driver on all ARM platforms

Quoted 4 lines · Laurent Pinchart

Renesas ARM platforms are transitioning from single-platform to multi-platform kernels using the new ARCH_SHMOBILE_MULTI. Make the driver available on all ARM platforms to enable it on both ARCH_SHMOBILE and ARCH_SHMOBILE_MULTI and increase build testing coverage.

Why is this driver specific to ARM?
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20131029/6edc84e7/attachment.sig>

#29 lore raw

PATCH 17/19 spi: sh_hspi: Enable the driver on all ARM platforms

In reply to Laurent Pinchart

Renesas ARM platforms are transitioning from single-platform to multi-platform kernels using the new ARCH_SHMOBILE_MULTI. Make the driver available on all ARM platforms to enable it on both ARCH_SHMOBILE and ARCH_SHMOBILE_MULTI.

Cc Mark Brown <[email protected]>
Cc linux-spi at vger.kernel.org
---
 drivers/spi/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/spi/Kconfig +1 -1
index a69b740..ab98033 100644
@@ -426,7 +426,7 @@ config SPI_SH_SCI
 
 config SPI_SH_HSPI
 	tristate "SuperH HSPI controller"
-	depends on ARCH_SHMOBILE || COMPILE_TEST
+	depends on ARM || COMPILE_TEST
 	help
 	  SPI driver for SuperH HSPI blocks.
 
Signature · 1 line
1.8.1.5
#30 lore raw

PATCH 18/19 thermal: rcar-thermal: Enable the driver on all ARM platforms

In reply to Laurent Pinchart

Renesas ARM platforms are transitioning from single-platform to multi-platform kernels using the new ARCH_SHMOBILE_MULTI. Make the driver available on all ARM platforms to enable it on both ARCH_SHMOBILE and ARCH_SHMOBILE_MULTI and increase build testing coverage.

Cc Zhang Rui <[email protected]>
Cc Eduardo Valentin <[email protected]>
Cc linux-pm at vger.kernel.org
---
 drivers/thermal/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/thermal/Kconfig +1 -1
index dbfc390..a243bc0 100644
@@ -121,7 +121,7 @@ config SPEAR_THERMAL
 
 config RCAR_THERMAL
 	tristate "Renesas R-Car thermal driver"
-	depends on ARCH_SHMOBILE
+	depends on ARM
 	help
 	  Enable this to plug the R-Car thermal sensor driver into the Linux
 	  thermal framework
Signature · 1 line
1.8.1.5
#31 lore raw

PATCH 19/19 fbdev: sh-mobile-lcdcfb: Enable the driver on all ARM platforms

In reply to Laurent Pinchart

Renesas ARM platforms are transitioning from single-platform to multi-platform kernels using the new ARCH_SHMOBILE_MULTI. Make the driver available on all ARM platforms to enable it on both ARCH_SHMOBILE and ARCH_SHMOBILE_MULTI and increase build testing coverage.

Cc Jean-Christophe Plagniol-Villard <[email protected]>
Cc Tomi Valkeinen <[email protected]>
Cc linux-fbdev at vger.kernel.org
---
 drivers/video/Kconfig | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/video/Kconfig +3 -3
index 84b685f..681858e 100644
@@ -10,7 +10,7 @@ config HAVE_FB_ATMEL
 
 config SH_MIPI_DSI
 	tristate
-	depends on (SUPERH || ARCH_SHMOBILE) && HAVE_CLK
+	depends on (SUPERH || ARM) && HAVE_CLK
 
 config SH_LCD_MIPI_DSI
 	bool
@@ -1995,7 +1995,7 @@ config FB_W100
 
 config FB_SH_MOBILE_LCDC
 	tristate "SuperH Mobile LCDC framebuffer support"
-	depends on FB && (SUPERH || ARCH_SHMOBILE) && HAVE_CLK
+	depends on FB && (SUPERH || ARM) && HAVE_CLK
 	select FB_SYS_FILLRECT
 	select FB_SYS_COPYAREA
 	select FB_SYS_IMAGEBLIT
@@ -2482,7 +2482,7 @@ endif
 
 config FB_SH_MOBILE_MERAM
 	tristate "SuperH Mobile MERAM read ahead support"
-	depends on (SUPERH || ARCH_SHMOBILE)
+	depends on (SUPERH || ARM)
 	select GENERIC_ALLOCATOR
 	---help---
 	  Enable MERAM support for the SuperH controller.
Signature · 1 line
1.8.1.5
#32 lore raw
In reply to Laurent Pinchart
Quoted 14 lines · Laurent Pinchart

Hello,

This patch series, based on v3.12-rc7, prepares various Renesas drivers for migration to multiplatform kernels by enabling their compilation or otherwise fixing them on all ARM platforms. The patches are pretty straightforward and are described in their commit message.

I'd like to get all these patches merged in v3.14. As they will need to go through their respective subsystems' trees, I would appreciate if all maintainers involved could notify me when they merge patches from this series in their tree to help me tracking the merge status. I don't plan to send pull requests individually for these patches, and I will repost patches individually if changes are requested during review.

Quoted 3 lines

If you believe the issue should be solved in a different way (for instance by removing the architecture dependency completely) please reply to the cover letter to let other maintainers chime in.

I think this is a step in a good direction.
However, I think it would be even better if the architecture dependency was removed completely.

Quoted 91 lines
Cc Chris Ball <[email protected]>
Cc "David S. Miller" <[email protected]>
Cc David Woodhouse <[email protected]>
Cc dmaengine at vger.kernel.org
Cc Dmitry Torokhov <[email protected]>
Cc Eduardo Valentin <[email protected]>
Cc Greg Kroah-Hartman <[email protected]>
Cc Guennadi Liakhovetski <[email protected]>
Cc Ian Molton <[email protected]>
Cc iommu at lists.linux-foundation.org
Cc Jean-Christophe Plagniol-Villard <[email protected]>
Cc Joerg Roedel <[email protected]>
Cc Linus Walleij <[email protected]>
Cc linux-fbdev at vger.kernel.org
Cc linux-i2c at vger.kernel.org
Cc linux-input at vger.kernel.org
Cc linux-kernel at vger.kernel.org
Cc linux-media at vger.kernel.org
Cc linux-mmc at vger.kernel.org
Cc linux-mtd at lists.infradead.org
Cc linux-pm at vger.kernel.org
Cc linux-pwm at vger.kernel.org
Cc linux-serial at vger.kernel.org
Cc linux-spi at vger.kernel.org
Cc Magnus Damm <[email protected]>
Cc Mark Brown <[email protected]>
Cc Mauro Carvalho Chehab <[email protected]>
Cc netdev at vger.kernel.org
Cc Samuel Ortiz <[email protected]>
Cc Sergei Shtylyov <[email protected]>
Cc Thierry Reding <[email protected]>
Cc Tomi Valkeinen <[email protected]>
Cc Vinod Koul <[email protected]>
Cc Wolfram Sang <[email protected]>
Cc Zhang Rui <[email protected]>

Laurent Pinchart (19):
serial: sh-sci: Enable the driver on all ARM platforms
DMA: shdma: Enable the driver on all ARM platforms
i2c: sh_mobile: Enable the driver on all ARM platforms
input: sh_keysc: Enable the driver on all ARM platforms
iommu: shmobile: Enable the driver on all ARM platforms
i2c: rcar: Enable the driver on all ARM platforms
v4l: sh_vou: Enable the driver on all ARM platforms
mmc: sdhi: Enable the driver on all ARM platforms
mmc: sh_mmcif: Enable the driver on all ARM platforms
mtd: sh_flctl: Enable the driver on all ARM platforms
net: sh_eth: Set receive alignment correctly on all ARM platforms
irda: sh_irda: Enable the driver on all ARM platforms
pinctrl: sh-pfc: Enable the driver on all ARM platforms
pwm: pwm-renesas-tpu: Enable the driver on all ARM platforms
sh: intc: Enable the driver on all ARM platforms
spi: sh_msiof: Enable the driver on all ARM platforms
spi: sh_hspi: Enable the driver on all ARM platforms
thermal: rcar-thermal: Enable the driver on all ARM platforms
fbdev: sh-mobile-lcdcfb: Enable the driver on all ARM platforms

 drivers/dma/sh/Kconfig                | 2 +-
 drivers/dma/sh/shdmac.c               | 6 +++---
 drivers/i2c/busses/Kconfig            | 4 ++--
 drivers/input/keyboard/Kconfig        | 2 +-
 drivers/iommu/Kconfig                 | 2 +-
 drivers/media/platform/Kconfig        | 2 +-
 drivers/mmc/host/Kconfig              | 4 ++--
 drivers/mmc/host/tmio_mmc_dma.c       | 2 +-
 drivers/mtd/nand/Kconfig              | 2 +-
 drivers/net/ethernet/renesas/sh_eth.c | 2 +-
 drivers/net/ethernet/renesas/sh_eth.h | 2 +-
 drivers/net/irda/Kconfig              | 2 +-
 drivers/pinctrl/Makefile              | 2 +-
 drivers/pinctrl/sh-pfc/Kconfig        | 2 +-
 drivers/pwm/Kconfig                   | 2 +-
 drivers/sh/intc/Kconfig               | 2 +-
 drivers/spi/Kconfig                   | 4 ++--
 drivers/thermal/Kconfig               | 2 +-
 drivers/tty/serial/Kconfig            | 2 +-
 drivers/video/Kconfig                 | 6 +++---
 20 files changed, 27 insertions(+), 27 deletions(-)
Signature · 9 lines
Regards,

Laurent Pinchart


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel at lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
maintainer
#33 lore raw
Quoted 3 lines · Simon Horman

I think this is a step in a good direction.
However, I think it would be even better if the architecture dependency was removed completely.

Yes, please.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20131029/7aa427b4/attachment.sig>

A message that is not in the archive (sent off-list or not yet received): [email protected]

#35 lore raw

Hi Mark,

Quoted 6 lines · On Tuesday 29 October 2013 09:04:49 Mark Brown wrote:
Quoted 3 lines · Simon Horman

I think this is a step in a good direction.
However, I think it would be even better if the architecture dependency was removed completely.

Yes, please.

I've kept it for two reasons.

The first one is that I can't compile-test all those drivers on all architectures. The spi-sh-msiof driver, for instance, uses io(read|write)(16|
32) which are not available on all architectures. There might be other similar problems that I can't catch, and I don't want to introduce build breakages in the kernel.

The second reason is that, as the IP cores have never been used on anything but SuperH and ARM, I don't like the idea of clobbering the config process with drivers that are useless on the target architecture. Now that we have a COMPILE_TEST Kconfig option, my preference would thus go to SUPERH || ARM || COMPILE_TEST over no dependency at all.

Signature · 10 lines
Regards,

Laurent Pinchart
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 490 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20131029/fb192e83/attachment.sig>
#36 lore raw
Quoted 2 lines · Laurent Pinchart

The first one is that I can't compile-test all those drivers on all architectures. The spi-sh-msiof driver, for instance, uses io(read|write)(16|

Which architectures are these and is there not a symbol we can depend on for them?

Quoted 3 lines

32) which are not available on all architectures. There might be other similar problems that I can't catch, and I don't want to introduce build breakages in the kernel.

This is easy enough to handle if we do run into issues, it seems better to get things available than try to step through architecture by architecture.

Quoted 5 lines

The second reason is that, as the IP cores have never been used on anything but SuperH and ARM, I don't like the idea of clobbering the config process with drivers that are useless on the target architecture. Now that we have a COMPILE_TEST Kconfig option, my preference would thus go to SUPERH || ARM || COMPILE_TEST over no dependency at all.

That's not what you did, though - you're not adding COMPILE_TEST.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20131029/c0101057/attachment.sig>

A message that is not in the archive (sent off-list or not yet received): [email protected]

#38 lore raw

Hi Mark,

Quoted 7 lines · On Tuesday 29 October 2013 10:23:31 Mark Brown wrote:
Quoted 3 lines · Laurent Pinchart

The first one is that I can't compile-test all those drivers on all architectures. The spi-sh-msiof driver, for instance, uses io(read|write)(16|

Which architectures are these and is there not a symbol we can depend on for them?

arch/cris for instance. We can use readl/writel instead (maybe it would be time to rationalize and document the I/O accessors across all architectures, but that's another topic).

My point is that there might be other issues that I won't be able to easily catch. This would break compilation for everybody for no reason, as the drivers are useless on non-SuperH, non-ARM platforms. That's why I believe COMPILE_TEST would be a better option as a first step.

Quoted 7 lines
Quoted 3 lines

32) which are not available on all architectures. There might be other similar problems that I can't catch, and I don't want to introduce build breakages in the kernel.

This is easy enough to handle if we do run into issues, it seems better to get things available than try to step through architecture by architecture.

Quoted 7 lines
Quoted 5 lines

The second reason is that, as the IP cores have never been used on anything but SuperH and ARM, I don't like the idea of clobbering the config process with drivers that are useless on the target architecture. Now that we have a COMPILE_TEST Kconfig option, my preference would thus go to SUPERH || ARM || COMPILE_TEST over no dependency at all.

That's not what you did, though - you're not adding COMPILE_TEST.

No, but I can add it :-) If this gets agreed upon, I'll respin the series with || COMPILE_TEST.

Signature · 10 lines
Regards,

Laurent Pinchart
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 490 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20131029/308736c6/attachment-0001.sig>
#39 lore raw
Quoted 6 lines · Laurent Pinchart
Quoted 4 lines · On Tuesday 29 October 2013 10:23:31 Mark Brown wrote:
Quoted 3 lines · Laurent Pinchart

The first one is that I can't compile-test all those drivers on all architectures. The spi-sh-msiof driver, for instance, uses io(read|write)(16|

Quoted 6 lines
Quoted 2 lines

Which architectures are these and is there not a symbol we can depend on for them?

arch/cris for instance. We can use readl/writel instead (maybe it would be time to rationalize and document the I/O accessors across all architectures, but that's another topic).

It'd certainly be sensible, or adding a config option to depend on if you rely on these functions.

Quoted 4 lines

My point is that there might be other issues that I won't be able to easily catch. This would break compilation for everybody for no reason, as the drivers are useless on non-SuperH, non-ARM platforms. That's why I believe COMPILE_TEST would be a better option as a first step.

Yes, it would - please do that. Note that it won't stop anyone running
into build issues on other architectures though, it's just about
stopping Kconfig noise.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20131029/f7cb98ae/attachment.sig>

#40 lore raw
Quoted 17 lines · Mark Brown
Quoted 6 lines · Laurent Pinchart
Quoted 4 lines · On Tuesday 29 October 2013 10:23:31 Mark Brown wrote:
Quoted 3 lines · Laurent Pinchart

The first one is that I can't compile-test all those drivers on all architectures. The spi-sh-msiof driver, for instance, uses io(read|write)(16|

Quoted 6 lines
Quoted 2 lines

Which architectures are these and is there not a symbol we can depend on for them?

arch/cris for instance. We can use readl/writel instead (maybe it would be time to rationalize and document the I/O accessors across all architectures, but that's another topic).

It'd certainly be sensible, or adding a config option to depend on if you rely on these functions.

Quoted 8 lines
Quoted 4 lines

My point is that there might be other issues that I won't be able to easily catch. This would break compilation for everybody for no reason, as the drivers are useless on non-SuperH, non-ARM platforms. That's why I believe COMPILE_TEST would be a better option as a first step.

Yes, it would - please do that. Note that it won't stop anyone running into build issues on other architectures though, it's just about stopping Kconfig noise.

FWIW, I am happy with using COMPILE_TEST for this series.

#41 lore raw
Quoted 23 lines · Simon Horman
Quoted 22 lines · Mark Brown
Quoted 6 lines · Laurent Pinchart
Quoted 4 lines · On Tuesday 29 October 2013 10:23:31 Mark Brown wrote:
Quoted 3 lines · Laurent Pinchart

The first one is that I can't compile-test all those drivers on all architectures. The spi-sh-msiof driver, for instance, uses io(read|write)(16|

Quoted 6 lines
Quoted 2 lines

Which architectures are these and is there not a symbol we can depend on for them?

arch/cris for instance. We can use readl/writel instead (maybe it would be time to rationalize and document the I/O accessors across all architectures, but that's another topic).

It'd certainly be sensible, or adding a config option to depend on if you rely on these functions.

Quoted 4 lines

My point is that there might be other issues that I won't be able to easily catch. This would break compilation for everybody for no reason, as the drivers are useless on non-SuperH, non-ARM platforms. That's why I believe COMPILE_TEST would be a better option as a first step.

Quoted 5 lines
Quoted 3 lines

Yes, it would - please do that. Note that it won't stop anyone running into build issues on other architectures though, it's just about stopping Kconfig noise.

FWIW, I am happy with using COMPILE_TEST for this series.

I'd also go for COMPILE_TEST. I once enabled omapdss and omapfb to be compilable without any extra dependencies, and Linus wasn't fond of getting asked if he wants to compile omapfb or not...

Tomi

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 901 bytes
Desc: OpenPGP digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20131030/b75b2a9a/attachment.sig>

#42 lore raw
In reply to Laurent Pinchart

Hi Laurent

Quoted 14 lines · Laurent Pinchart

Hello,

This patch series, based on v3.12-rc7, prepares various Renesas drivers for migration to multiplatform kernels by enabling their compilation or otherwise fixing them on all ARM platforms. The patches are pretty straightforward and are described in their commit message.

I'd like to get all these patches merged in v3.14. As they will need to go through their respective subsystems' trees, I would appreciate if all maintainers involved could notify me when they merge patches from this series in their tree to help me tracking the merge status. I don't plan to send pull requests individually for these patches, and I will repost patches individually if changes are requested during review.

Quoted 3 lines

If you believe the issue should be solved in a different way (for instance by removing the architecture dependency completely) please reply to the cover letter to let other maintainers chime in.

Exactly this was my doubt. If we let these drivers build on all ARM platforms... Maybe we should just let them build everywhere? Unless there are real ARM dependencies. Maybe you could try to remove the restriction and try to build them all on x86?

Thanks
Guennadi

Quoted 71 lines
Cc Chris Ball <[email protected]>
Cc "David S. Miller" <[email protected]>
Cc David Woodhouse <[email protected]>
Cc dmaengine at vger.kernel.org
Cc Dmitry Torokhov <[email protected]>
Cc Eduardo Valentin <[email protected]>
Cc Greg Kroah-Hartman <[email protected]>
Cc Guennadi Liakhovetski <[email protected]>
Cc Ian Molton <[email protected]>
Cc iommu at lists.linux-foundation.org
Cc Jean-Christophe Plagniol-Villard <[email protected]>
Cc Joerg Roedel <[email protected]>
Cc Linus Walleij <[email protected]>
Cc linux-fbdev at vger.kernel.org
Cc linux-i2c at vger.kernel.org
Cc linux-input at vger.kernel.org
Cc linux-kernel at vger.kernel.org
Cc linux-media at vger.kernel.org
Cc linux-mmc at vger.kernel.org
Cc linux-mtd at lists.infradead.org
Cc linux-pm at vger.kernel.org
Cc linux-pwm at vger.kernel.org
Cc linux-serial at vger.kernel.org
Cc linux-spi at vger.kernel.org
Cc Magnus Damm <[email protected]>
Cc Mark Brown <[email protected]>
Cc Mauro Carvalho Chehab <[email protected]>
Cc netdev at vger.kernel.org
Cc Samuel Ortiz <[email protected]>
Cc Sergei Shtylyov <[email protected]>
Cc Thierry Reding <[email protected]>
Cc Tomi Valkeinen <[email protected]>
Cc Vinod Koul <[email protected]>
Cc Wolfram Sang <[email protected]>
Cc Zhang Rui <[email protected]>

Laurent Pinchart (19):
serial: sh-sci: Enable the driver on all ARM platforms
DMA: shdma: Enable the driver on all ARM platforms
i2c: sh_mobile: Enable the driver on all ARM platforms
input: sh_keysc: Enable the driver on all ARM platforms
iommu: shmobile: Enable the driver on all ARM platforms
i2c: rcar: Enable the driver on all ARM platforms
v4l: sh_vou: Enable the driver on all ARM platforms
mmc: sdhi: Enable the driver on all ARM platforms
mmc: sh_mmcif: Enable the driver on all ARM platforms
mtd: sh_flctl: Enable the driver on all ARM platforms
net: sh_eth: Set receive alignment correctly on all ARM platforms
irda: sh_irda: Enable the driver on all ARM platforms
pinctrl: sh-pfc: Enable the driver on all ARM platforms
pwm: pwm-renesas-tpu: Enable the driver on all ARM platforms
sh: intc: Enable the driver on all ARM platforms
spi: sh_msiof: Enable the driver on all ARM platforms
spi: sh_hspi: Enable the driver on all ARM platforms
thermal: rcar-thermal: Enable the driver on all ARM platforms
fbdev: sh-mobile-lcdcfb: Enable the driver on all ARM platforms

 drivers/dma/sh/Kconfig                | 2 +-
 drivers/dma/sh/shdmac.c               | 6 +++---
 drivers/i2c/busses/Kconfig            | 4 ++--
 drivers/input/keyboard/Kconfig        | 2 +-
 drivers/iommu/Kconfig                 | 2 +-
 drivers/media/platform/Kconfig        | 2 +-
 drivers/mmc/host/Kconfig              | 4 ++--
 drivers/mmc/host/tmio_mmc_dma.c       | 2 +-
 drivers/mtd/nand/Kconfig              | 2 +-
 drivers/net/ethernet/renesas/sh_eth.c | 2 +-
 drivers/net/ethernet/renesas/sh_eth.h | 2 +-
 drivers/net/irda/Kconfig              | 2 +-
 drivers/pinctrl/Makefile              | 2 +-
Quoted 14 lines
 drivers/pinctrl/sh-pfc/Kconfig        | 2 +-
 drivers/pwm/Kconfig                   | 2 +-
 drivers/sh/intc/Kconfig               | 2 +-
 drivers/spi/Kconfig                   | 4 ++--
 drivers/thermal/Kconfig               | 2 +-
 drivers/tty/serial/Kconfig            | 2 +-
 drivers/video/Kconfig                 | 6 +++---
 20 files changed, 27 insertions(+), 27 deletions(-)
Signature · 3 lines
Regards,

Laurent Pinchart

---
Guennadi Liakhovetski, Ph.D.
Freelance Open-Source Software Developer
http://www.open-technology.de/

A message that is not in the archive (sent off-list or not yet received): Pine.LNX.4.64.1310291009121.8404-0199iw4Nj15frtckUFj5Ag@public.gmane.org

#44 lore raw

Hi Simon and Guennadi,

Quoted 15 lines · On Tuesday 29 October 2013 10:12:17 Guennadi Liakhovetski wrote:
Quoted 14 lines · Laurent Pinchart

Hello,

This patch series, based on v3.12-rc7, prepares various Renesas drivers for migration to multiplatform kernels by enabling their compilation or otherwise fixing them on all ARM platforms. The patches are pretty straightforward and are described in their commit message.

I'd like to get all these patches merged in v3.14. As they will need to go through their respective subsystems' trees, I would appreciate if all maintainers involved could notify me when they merge patches from this series in their tree to help me tracking the merge status. I don't plan to send pull requests individually for these patches, and I will repost patches individually if changes are requested during review.

Quoted 8 lines
Quoted 3 lines

If you believe the issue should be solved in a different way (for instance by removing the architecture dependency completely) please reply to the cover letter to let other maintainers chime in.

Exactly this was my doubt. If we let these drivers build on all ARM platforms... Maybe we should just let them build everywhere? Unless there are real ARM dependencies. Maybe you could try to remove the restriction and try to build them all on x86?

My concern is that they might not build on some architectures for which I don't have a cross-compiler. For instance not all architecture define ioread32 and iowrite32, which some drivers might rely on. What about depending on SUPERH || ARM || COMPILE_TEST to start with, in order not to push compilation breakages to mainline ?

Quoted 78 lines
Quoted 78 lines
Cc Chris Ball <[email protected]>
Cc "David S. Miller" <[email protected]>
Cc David Woodhouse <[email protected]>
Cc dmaengine at vger.kernel.org
Cc Dmitry Torokhov <[email protected]>
Cc Eduardo Valentin <[email protected]>
Cc Greg Kroah-Hartman <[email protected]>
Cc Guennadi Liakhovetski <[email protected]>
Cc Ian Molton <[email protected]>
Cc iommu at lists.linux-foundation.org
Cc Jean-Christophe Plagniol-Villard <[email protected]>
Cc Joerg Roedel <[email protected]>
Cc Linus Walleij <[email protected]>
Cc linux-fbdev at vger.kernel.org
Cc linux-i2c at vger.kernel.org
Cc linux-input at vger.kernel.org
Cc linux-kernel at vger.kernel.org
Cc linux-media at vger.kernel.org
Cc linux-mmc at vger.kernel.org
Cc linux-mtd at lists.infradead.org
Cc linux-pm at vger.kernel.org
Cc linux-pwm at vger.kernel.org
Cc linux-serial at vger.kernel.org
Cc linux-spi at vger.kernel.org
Cc Magnus Damm <[email protected]>
Cc Mark Brown <[email protected]>
Cc Mauro Carvalho Chehab <[email protected]>
Cc netdev at vger.kernel.org
Cc Samuel Ortiz <[email protected]>
Cc Sergei Shtylyov <[email protected]>
Cc Thierry Reding <[email protected]>
Cc Tomi Valkeinen <[email protected]>
Cc Vinod Koul <[email protected]>
Cc Wolfram Sang <[email protected]>
Cc Zhang Rui <[email protected]>

Laurent Pinchart (19):
serial: sh-sci: Enable the driver on all ARM platforms
DMA: shdma: Enable the driver on all ARM platforms
i2c: sh_mobile: Enable the driver on all ARM platforms
input: sh_keysc: Enable the driver on all ARM platforms
iommu: shmobile: Enable the driver on all ARM platforms
i2c: rcar: Enable the driver on all ARM platforms
v4l: sh_vou: Enable the driver on all ARM platforms
mmc: sdhi: Enable the driver on all ARM platforms
mmc: sh_mmcif: Enable the driver on all ARM platforms
mtd: sh_flctl: Enable the driver on all ARM platforms
net: sh_eth: Set receive alignment correctly on all ARM platforms
irda: sh_irda: Enable the driver on all ARM platforms
pinctrl: sh-pfc: Enable the driver on all ARM platforms
pwm: pwm-renesas-tpu: Enable the driver on all ARM platforms
sh: intc: Enable the driver on all ARM platforms
spi: sh_msiof: Enable the driver on all ARM platforms
spi: sh_hspi: Enable the driver on all ARM platforms
thermal: rcar-thermal: Enable the driver on all ARM platforms
fbdev: sh-mobile-lcdcfb: Enable the driver on all ARM platforms

 drivers/dma/sh/Kconfig                | 2 +-
 drivers/dma/sh/shdmac.c               | 6 +++---
 drivers/i2c/busses/Kconfig            | 4 ++--
 drivers/input/keyboard/Kconfig        | 2 +-
 drivers/iommu/Kconfig                 | 2 +-
 drivers/media/platform/Kconfig        | 2 +-
 drivers/mmc/host/Kconfig              | 4 ++--
 drivers/mmc/host/tmio_mmc_dma.c       | 2 +-
 drivers/mtd/nand/Kconfig              | 2 +-
 drivers/net/ethernet/renesas/sh_eth.c | 2 +-
 drivers/net/ethernet/renesas/sh_eth.h | 2 +-
 drivers/net/irda/Kconfig              | 2 +-
 drivers/pinctrl/Makefile              | 2 +-
 drivers/pinctrl/sh-pfc/Kconfig        | 2 +-
 drivers/pwm/Kconfig                   | 2 +-
 drivers/sh/intc/Kconfig               | 2 +-
 drivers/spi/Kconfig                   | 4 ++--
 drivers/thermal/Kconfig               | 2 +-
 drivers/tty/serial/Kconfig            | 2 +-
 drivers/video/Kconfig                 | 6 +++---
 20 files changed, 27 insertions(+), 27 deletions(-)
Signature · 3 lines
Regards,

Laurent Pinchart
#45 lore raw
In reply to Guennadi Liakhovetski
Quoted 18 lines · Guennadi Liakhovetski

Hi Laurent

Quoted 14 lines · Laurent Pinchart

Hello,

This patch series, based on v3.12-rc7, prepares various Renesas drivers for migration to multiplatform kernels by enabling their compilation or otherwise fixing them on all ARM platforms. The patches are pretty straightforward and are described in their commit message.

I'd like to get all these patches merged in v3.14. As they will need to go through their respective subsystems' trees, I would appreciate if all maintainers involved could notify me when they merge patches from this series in their tree to help me tracking the merge status. I don't plan to send pull requests individually for these patches, and I will repost patches individually if changes are requested during review.

Quoted 8 lines
Quoted 3 lines

If you believe the issue should be solved in a different way (for instance by removing the architecture dependency completely) please reply to the cover letter to let other maintainers chime in.

Exactly this was my doubt. If we let these drivers build on all ARM platforms... Maybe we should just let them build everywhere? Unless there are real ARM dependencies. Maybe you could try to remove the restriction and try to build them all on x86?

If they have never been used on anything but ARM, why would you remove ARM dependencies? Just for the sake of compile-checking?

Also, if ARM dependency is ever removed, all these should become 'n' by default in the Kconfig, in order to make sure they do not slip into defconfigs of different architectures.

Signature · 2 lines
Best Regards,
Artem Bityutskiy

A message that is not in the archive (sent off-list or not yet received): 1383051980.29619.33.camel-Bxnoe/[email protected]

#47 lore raw

Hi Artem,

Quoted 25 lines · On Tuesday 29 October 2013 15:06:20 Artem Bityutskiy wrote:
Quoted 15 lines · Guennadi Liakhovetski
Quoted 14 lines · Laurent Pinchart

Hello,

This patch series, based on v3.12-rc7, prepares various Renesas drivers for migration to multiplatform kernels by enabling their compilation or otherwise fixing them on all ARM platforms. The patches are pretty straightforward and are described in their commit message.

I'd like to get all these patches merged in v3.14. As they will need to go through their respective subsystems' trees, I would appreciate if all maintainers involved could notify me when they merge patches from this series in their tree to help me tracking the merge status. I don't plan to send pull requests individually for these patches, and I will repost patches individually if changes are requested during review.

Quoted 8 lines
Quoted 3 lines

If you believe the issue should be solved in a different way (for instance by removing the architecture dependency completely) please reply to the cover letter to let other maintainers chime in.

Exactly this was my doubt. If we let these drivers build on all ARM platforms... Maybe we should just let them build everywhere? Unless there are real ARM dependencies. Maybe you could try to remove the restriction and try to build them all on x86?

Quoted 6 lines

If they have never been used on anything but ARM, why would you remove ARM dependencies? Just for the sake of compile-checking?

Also, if ARM dependency is ever removed, all these should become 'n' by default in the Kconfig, in order to make sure they do not slip into defconfigs of different architectures.

The idea is that, if ARM is neither a compile-time nor runtime dependency, it should not be specified in Kconfig. However, if the IP core has never been used on anything but SuperH and ARM, I don't think clobbering the config process with drivers that can't be used on the target architecture would be a really good idea, especially now that we have a COMPILE_TEST Kconfig option. My preference does goes to SUPERH || ARM || COMPILE_TEST over no dependency at all.

Signature · 3 lines
Regards,

Laurent Pinchart
#48 lore raw
Quoted 11 lines · Laurent Pinchart
Quoted 3 lines

Also, if ARM dependency is ever removed, all these should become 'n' by default in the Kconfig, in order to make sure they do not slip into defconfigs of different architectures.

The idea is that, if ARM is neither a compile-time nor runtime dependency, it should not be specified in Kconfig. However, if the IP core has never been used on anything but SuperH and ARM, I don't think clobbering the config process with drivers that can't be used on the target architecture would be a really good idea, especially now that we have a COMPILE_TEST Kconfig option. My preference does goes to SUPERH || ARM || COMPILE_TEST over no dependency at all.

Ah, OK, I missed the entire COMPILE_TEST story.

Signature · 2 lines
Best Regards,
Artem Bityutskiy
#49 lore raw
In reply to Laurent Pinchart
Quoted 3 lines · Laurent Pinchart

If you believe the issue should be solved in a different way (for instance by removing the architecture dependency completely) please reply to the cover letter to let other maintainers chime in.

I have no real opinions on whether this is a good itermediate step towards complete arch-independence or not, but I just noticed that you still have the <mach/*> hierarchy in mach-shmobile/include/mach/*, and grep:ing around this seems totally unnecessary, I think it would be easy to produce a patch set eliminating <mach/*> from shmobile.

(Usually we will just move all the headers down into the mach-shmobile folder.)

Yours,
Linus Walleij