Skip to contentSkip to conversation

Fix the dma state machine lockup for the ATA_CMD_SMART PIO mode command.

PATCH Superseded Suman Tripathi 3 participants 7 messages Feb 2, 2015 – Feb 3, 2015 1 message not in the archive

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH v3 1/1 Fix the dma state machine lockup for the ATA_CMD_SMART PIO mode command.

v1 changes:
* Update the commit id as per Tejun's comments.
* Add a bit explanation.

v2 changes:
* Update the comments from sergei.

v3 changes:
* More changes in comments.

---

Suman Tripathi (1):
ahci_xgene: Fix the dma state machine lockup for the ATA_CMD_SMART PIO
mode command.

 drivers/ata/ahci_xgene.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

--
1.8.2.1

#1 lore raw

PATCH v3 1/1 ahci_xgene: Fix the dma state machine lockup for the ATA_CMD_SMART PIO mode command.

This patch addresses the issue with ATA_CMD_SMART pio mode command for enumeration and device detection with ATA devices. The X-Gene AHCI controller has an errata in which it cannot clear the BSY bit after the PIO setup FIS. The dma state machine enters CMFatalErrorUpdate state and locks up. It is the same issue as in the commit 2a0bdff6b958d1b2523d2754b6cd5e0ea4053016 (ahci-xgene:
fix the dma state machine lockup for the IDENTIFY DEVICE PIO mode command).

For example : without this patch it results in READ DMA command failure as shown below :

 [  126.700072] ata2.00: exception Emask 0x0 SAct 0x0
		SErr 0x0 action 0x6 frozen
 [  126.707089] ata2.00: failed command: READ DMA
 [  126.711426] ata2.00: cmd c8/00:08:00:55:57/00:00:00:00:00/e1 tag 1
                dma 4096 in
 [  126.711426]  res 40/00:ff:00:00:00/00:00:00:00:00/40 Emask
		0x4 (timeout)
 [  126.725956] ata2.00: status: { DRDY }

---

---
 drivers/ata/ahci_xgene.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/ata/ahci_xgene.c +2 -1
index 7f68875..506cf5f 100644
@@ -211,7 +211,8 @@ static unsigned int xgene_ahci_qc_issue(struct ata_queued_cmd *qc)
 	}
 
 	if (unlikely((ctx->last_cmd[ap->port_no] == ATA_CMD_ID_ATA) ||
-	    (ctx->last_cmd[ap->port_no] == ATA_CMD_PACKET)))
+	    (ctx->last_cmd[ap->port_no] == ATA_CMD_PACKET) ||
+	    (ctx->last_cmd[ap->port_no] == ATA_CMD_SMART)))
 		xgene_ahci_restart_engine(ap);
 
 	rc = ahci_qc_issue(qc);

--
1.8.2.1

#2 lore raw

PATCH v3 1/1 ahci_xgene: Fix the dma state machine lockup for the ATA_CMD_SMART PIO mode command.

Hello.

Quoted 4 lines · Suman Tripathi

This patch addresses the issue with ATA_CMD_SMART pio mode command for enumeration and device detection with ATA devices. The X-Gene AHCI controller has an errata in which it cannot clear the BSY bit after the PIO setup FIS. The dma state machine enters

Hum, if this happens after every PIO command (PIO setup FISes are not
specific to the command, right?), perhaps it would make more sense to record the *protocol* used by the last command?

Quoted 7 lines

CMFatalErrorUpdate state and locks up. It is the same issue as in the commit 2a0bdff6b958d1b2523d2754b6cd5e0ea4053016 (ahci-xgene:
fix the dma state machine lockup for the IDENTIFY DEVICE PIO mode command).

For example : without this patch it results in READ DMA command failure as shown below :

[...]

Quoted 2 lines

MBR, Sergei

A message that is not in the archive (sent off-list or not yet received): CAOHikRBMPbyS0q6814+Xkez7ToBwrC7Yzp4sy=NMmPDg-5wCBA@mail.gmail.com

#4 lore raw

PATCH v3 1/1 ahci_xgene: Fix the dma state machine lockup for the ATA_CMD_SMART PIO mode command.

On 02/02/2015 10:37 PM, Suman Tripathi wrote:

Ugh, please avoid using HTML when posting to the lists hosted on
vger.kernel.org -- it's configured to ignore such mails AFAIK.

Quoted 11 lines
Quoted 8 lines
Quoted 4 lines

This patch addresses the issue with ATA_CMD_SMART pio mode command for enumeration and device detection with ATA devices. The X-Gene AHCI controller has an errata in which it cannot clear the BSY bit after the PIO setup FIS. The dma state machine enters

Hum, if this happens after every PIO command (PIO setup FISes are not
specific to the command, right?), perhaps it would make more sense to record the *protocol* used by the last command?

No it happens for IDENTIFY DEVICE, ATA_CMD_PACKET and ATA_CMD_SMART commands . It is actually the commands associated with a BSY bit clearing.

I don't understand that -- BSY bit is cleared for *every* command, either
at the end of it, or along with setting the DRQ bit for PIO data transfer.

Quoted 11 lines
Quoted 11 lines
Quoted 4 lines

CMFatalErrorUpdate state and locks up. It is the same issue as in the commit 2a0bdff6b958d1b2523d2754b6cd5e__0ea4053016 (ahci-xgene:
fix the dma state machine lockup for the IDENTIFY DEVICE PIO mode command).

[...]

Quoted 4 lines
Signed-off-by Suman Tripathi <stripathi at apm.com <mailto:[email protected]>>

<mailto:[email protected]>>

MBR, Sergei

#5 lore raw

PATCH v3 1/1 ahci_xgene: Fix the dma state machine lockup for the ATA_CMD_SMART PIO mode command.

Ugh, please avoid using HTML when posting to the lists hosted on
vger.kernel.org -- it's configured to ignore such mails AFAIK. Yeah forgot to set the plain text mode. Sorry for that

Quoted 6 lines
Quoted 4 lines
Quoted 4 lines

This patch addresses the issue with ATA_CMD_SMART pio mode command for enumeration and device detection with ATA devices. The X-Gene AHCI controller has an errata in which it cannot clear the BSY bit after the PIO setup FIS. The dma state machine enters

Quoted 7 lines
Quoted 3 lines

Hum, if this happens after every PIO command (PIO setup FISes are not
specific to the command, right?), perhaps it would make more sense to record the *protocol* used by the last command?

No it happens for IDENTIFY DEVICE, ATA_CMD_PACKET and ATA_CMD_SMART commands . It is actually the commands associated with a BSY bit clearing.

I don't understand that -- BSY bit is cleared for *every* command,
either at the end of it, or along with setting the DRQ bit for PIO data transfer.
BSY bit is cleared after the end of these commands by the controller. So due to the bug it doesn't clear it. When the DMA commands is issued , it check for the BSY bit cleared or not and finds not cleared and results in CMFatalErrorUpdate and hangs.

Quoted 6 lines
Quoted 4 lines
Quoted 4 lines

CMFatalErrorUpdate state and locks up. It is the same issue as in the commit 2a0bdff6b958d1b2523d2754b6cd5e__0ea4053016 (ahci-xgene:
fix the dma state machine lockup for the IDENTIFY DEVICE PIO mode command).

Quoted 7 lines
Quoted 7 lines

[...]

Quoted 4 lines
Signed-off-by Suman Tripathi <stripathi at apm.com <mailto:[email protected]>>

<mailto:[email protected]>>

MBR, Sergei

Quoted 43 lines · Sergei Shtylyov

On 02/02/2015 10:37 PM, Suman Tripathi wrote:

Ugh, please avoid using HTML when posting to the lists hosted on
vger.kernel.org -- it's configured to ignore such mails AFAIK.

Quoted 12 lines
Quoted 10 lines
Quoted 4 lines

This patch addresses the issue with ATA_CMD_SMART pio mode command for enumeration and device detection with ATA devices. The X-Gene AHCI controller has an errata in which it cannot clear the BSY bit after the PIO setup FIS. The dma state machine enters

Hum, if this happens after every PIO command (PIO setup FISes are not
specific to the command, right?), perhaps it would make more sense to record
the *protocol* used by the last command?

Quoted 3 lines

No it happens for IDENTIFY DEVICE, ATA_CMD_PACKET and ATA_CMD_SMART commands .
It is actually the commands associated with a BSY bit clearing.

I don't understand that -- BSY bit is cleared for *every* command, either
at the end of it, or along with setting the DRQ bit for PIO data transfer.

Quoted 7 lines
Quoted 5 lines
Quoted 5 lines

CMFatalErrorUpdate state and locks up. It is the same issue as in the commit 2a0bdff6b958d1b2523d2754b6cd5e__0ea4053016
(ahci-xgene:
fix the dma state machine lockup for the IDENTIFY DEVICE PIO mode command).

Quoted 8 lines
Quoted 8 lines

[...]

Quoted 5 lines

<mailto:[email protected]>>

<mailto:[email protected]>>

MBR, Sergei

Signature · 3 lines
Thanks,
with regards,
Suman Tripathi
#6 lore raw

PATCH v3 1/1 ahci_xgene: Fix the dma state machine lockup for the ATA_CMD_SMART PIO mode command.

Ugh, please avoid using HTML when posting to the lists hosted on
vger.kernel.org -- it's configured to ignore such mails AFAIK. Yeah forgot to set the plain text mode. Sorry for that

Quoted 6 lines
Quoted 4 lines
Quoted 4 lines

This patch addresses the issue with ATA_CMD_SMART pio mode command for enumeration and device detection with ATA devices. The X-Gene AHCI controller has an errata in which it cannot clear the BSY bit after the PIO setup FIS. The dma state machine enters

Quoted 7 lines
Quoted 3 lines

Hum, if this happens after every PIO command (PIO setup FISes are not
specific to the command, right?), perhaps it would make more sense to record the *protocol* used by the last command?

No it happens for IDENTIFY DEVICE, ATA_CMD_PACKET and ATA_CMD_SMART commands . It is actually the commands associated with a BSY bit clearing.

I don't understand that -- BSY bit is cleared for *every* command,
either at the end of it, or along with setting the DRQ bit for PIO data transfer.
BSY bit is cleared after the end of these commands by the controller. So due to the bug it doesn't clear it. When the DMA commands is issued , it check for the BSY bit cleared or not and finds not cleared and results in CMFatalErrorUpdate and hangs.

Ping ?? Any problem with this last posted version Actually Mark from redhat reported this issue while using smartctl and we found that ATA_CMD_SMART also has BSY bit not clearing issue..

Quoted 95 lines · Suman Tripathi

Ugh, please avoid using HTML when posting to the lists hosted on
vger.kernel.org -- it's configured to ignore such mails AFAIK. Yeah forgot to set the plain text mode. Sorry for that

Quoted 6 lines
Quoted 4 lines
Quoted 4 lines

This patch addresses the issue with ATA_CMD_SMART pio mode command for enumeration and device detection with ATA devices. The X-Gene AHCI controller has an errata in which it cannot clear the BSY bit after the PIO setup FIS. The dma state machine enters

Quoted 7 lines
Quoted 3 lines

Hum, if this happens after every PIO command (PIO setup FISes are not
specific to the command, right?), perhaps it would make more sense to record the *protocol* used by the last command?

No it happens for IDENTIFY DEVICE, ATA_CMD_PACKET and ATA_CMD_SMART commands . It is actually the commands associated with a BSY bit clearing.

I don't understand that -- BSY bit is cleared for *every* command,
either at the end of it, or along with setting the DRQ bit for PIO data transfer.
BSY bit is cleared after the end of these commands by the controller. So due to the bug it doesn't clear it. When the DMA commands is issued , it check for the BSY bit cleared or not and finds not cleared and results in CMFatalErrorUpdate and hangs.

Quoted 6 lines
Quoted 4 lines
Quoted 4 lines

CMFatalErrorUpdate state and locks up. It is the same issue as in the commit 2a0bdff6b958d1b2523d2754b6cd5e__0ea4053016 (ahci-xgene:
fix the dma state machine lockup for the IDENTIFY DEVICE PIO mode command).

Quoted 7 lines
Quoted 7 lines

[...]

Quoted 4 lines
Signed-off-by Suman Tripathi <stripathi at apm.com <mailto:[email protected]>>

<mailto:[email protected]>>

MBR, Sergei

Quoted 35 lines · Sergei Shtylyov

On 02/02/2015 10:37 PM, Suman Tripathi wrote:

Ugh, please avoid using HTML when posting to the lists hosted on
vger.kernel.org -- it's configured to ignore such mails AFAIK.

Quoted 12 lines
Quoted 10 lines
Quoted 4 lines

This patch addresses the issue with ATA_CMD_SMART pio mode command for enumeration and device detection with ATA devices. The X-Gene AHCI controller has an errata in which it cannot clear the BSY bit after the PIO setup FIS. The dma state machine enters

Hum, if this happens after every PIO command (PIO setup FISes are not
specific to the command, right?), perhaps it would make more sense to record
the *protocol* used by the last command?

Quoted 3 lines

No it happens for IDENTIFY DEVICE, ATA_CMD_PACKET and ATA_CMD_SMART commands .
It is actually the commands associated with a BSY bit clearing.

I don't understand that -- BSY bit is cleared for *every* command, either
at the end of it, or along with setting the DRQ bit for PIO data transfer.

Quoted 8 lines
Quoted 8 lines
Quoted 5 lines

CMFatalErrorUpdate state and locks up. It is the same issue as in the commit 2a0bdff6b958d1b2523d2754b6cd5e__0ea4053016
(ahci-xgene:
fix the dma state machine lockup for the IDENTIFY DEVICE PIO mode command).

[...]

Quoted 8 lines
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines

<mailto:[email protected]>>

<mailto:[email protected]>>

MBR, Sergei

--
Thanks,
with regards,
Suman Tripathi

Signature · 3 lines
Thanks,
with regards,
Suman Tripathi
Applied
#7 lore raw

PATCH v3 1/1 ahci_xgene: Fix the dma state machine lockup for the ATA_CMD_SMART PIO mode command.

In reply to Suman Tripathi
Quoted 6 lines · Suman Tripathi

This patch addresses the issue with ATA_CMD_SMART pio mode command for enumeration and device detection with ATA devices. The X-Gene AHCI controller has an errata in which it cannot clear the BSY bit after the PIO setup FIS. The dma state machine enters CMFatalErrorUpdate state and locks up. It is the same issue as in the commit 2a0bdff6b958d1b2523d2754b6cd5e0ea4053016 (ahci-xgene:

The right format is 2a0bdff6b958 ("ahci-xgene: fix the dma state machine lockup for the IDENTIFY DEVICE PIO mode command").

Quoted 15 lines

fix the dma state machine lockup for the IDENTIFY DEVICE PIO mode command).

For example : without this patch it results in READ DMA command failure as shown below :

 [  126.700072] ata2.00: exception Emask 0x0 SAct 0x0
		SErr 0x0 action 0x6 frozen
 [  126.707089] ata2.00: failed command: READ DMA
 [  126.711426] ata2.00: cmd c8/00:08:00:55:57/00:00:00:00:00/e1 tag 1
                dma 4096 in
 [  126.711426]  res 40/00:ff:00:00:00/00:00:00:00:00/40 Emask
		0x4 (timeout)
 [  126.725956] ata2.00: status: { DRDY }
Quoted 2 lines

Applied to libata/for-3.19-fixes.

Thanks.

Signature · 1 line
tejun