Skip to contentSkip to conversation

* Add support for Philips (or NXP) PTA01 Wireless Adapter

PATCH New Leon Nardella 2 participants 4 messages Feb 7, 2015 Qualcomm Atheros ATH9K wireless driver

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 * Add support for Philips (or NXP) PTA01 Wireless Adapter

---
 drivers/net/wireless/ath/ath9k/hif_usb.c | 1 +
 1 file changed, 1 insertion(+)
drivers/net/wireless/ath/ath9k/hif_usb.c +1 -0
index 8e7153b..10c02f5 100644
@@ -40,6 +40,7 @@ static struct usb_device_id ath9k_hif_usb_ids[] = {
 	{ USB_DEVICE(0x0cf3, 0xb003) }, /* Ubiquiti WifiStation Ext */
 	{ USB_DEVICE(0x0cf3, 0xb002) }, /* Ubiquiti WifiStation */
 	{ USB_DEVICE(0x057c, 0x8403) }, /* AVM FRITZ!WLAN 11N v2 USB */
+	{ USB_DEVICE(0x0471, 0x209e) }, /* Philips (or NXP) PTA01 */
 
 	{ USB_DEVICE(0x0cf3, 0x7015),
 	  .driver_info = AR9287_USB },  /* Atheros */
Signature · 1 line
2.1.0
#1 lore raw

PATCH 1/1 * Add support for Philips (or NXP) PTA01 Wireless Adapter

Quoted 10 lines · Leon Nardella
---
  drivers/net/wireless/ath/ath9k/hif_usb.c | 1 +
  1 file changed, 1 insertion(+)
drivers/net/wireless/ath/ath9k/hif_usb.c +0 -0
index 8e7153b..10c02f5 100644

drivers/net/wireless/ath/ath9k/hif_usb.c static struct usb_device_id ath9k_hif_usb_ids[] = { · line 46

Quoted 7 lines
drivers/net/wireless/ath/ath9k/hif_usb.c +1 -0
@@ -40,6 +40,7 @@ static struct usb_device_id ath9k_hif_usb_ids[] = {
  	{ USB_DEVICE(0x0cf3, 0xb003) }, /* Ubiquiti WifiStation Ext */
  	{ USB_DEVICE(0x0cf3, 0xb002) }, /* Ubiquiti WifiStation */
  	{ USB_DEVICE(0x057c, 0x8403) }, /* AVM FRITZ!WLAN 11N v2 USB */
+	{ USB_DEVICE(0x0471, 0x209e) }, /* Philips (or NXP) PTA01 */
 
  	{ USB_DEVICE(0x0cf3, 0x7015),
  	  .driver_info = AR9287_USB },  /* Atheros */

Leon,

Your patch is correct, but your subject and commit message needs a little work.

When I add a new USB ID for a driver, my subject usually includes the driver name followed by a colon, and the "Add new USB ID". In your case, that would be "[PATCH] ath9k_htc: Add new USB ID". Then in the commit message I include the make and model of the device, and some indication of why that device ID should be added. For example, was that ID found in a Windows driver? Finally, indicate that the patch has been tested. Such a statement should not be necessary, but recently there have been a number of patches submitted that have not been tested on real hardware.

Larry

#2 lore raw

PATCH 1/1 * Add support for Philips (or NXP) PTA01 Wireless Adapter

Larry,

Thank for your remarks! I'll submit it again!

Att,

Leon Nardella

Quoted 36 lines · Larry Finger
Quoted 12 lines · Leon Nardella
---
  drivers/net/wireless/ath/ath9k/hif_usb.c | 1 +
  1 file changed, 1 insertion(+)
drivers/net/wireless/ath/ath9k/hif_usb.c +0 -0
index 8e7153b..10c02f5 100644

drivers/net/wireless/ath/ath9k/hif_usb.c static struct usb_device_id ath9k_hif_usb_ids[] = { · line 46

Quoted 7 lines
drivers/net/wireless/ath/ath9k/hif_usb.c +1 -0
@@ -40,6 +40,7 @@ static struct usb_device_id ath9k_hif_usb_ids[] = {
        { USB_DEVICE(0x0cf3, 0xb003) }, /* Ubiquiti WifiStation Ext */
        { USB_DEVICE(0x0cf3, 0xb002) }, /* Ubiquiti WifiStation */
        { USB_DEVICE(0x057c, 0x8403) }, /* AVM FRITZ!WLAN 11N v2 USB */
+       { USB_DEVICE(0x0471, 0x209e) }, /* Philips (or NXP) PTA01 */
 
        { USB_DEVICE(0x0cf3, 0x7015),
          .driver_info = AR9287_USB },  /* Atheros */

Leon,

Your patch is correct, but your subject and commit message needs a little work.

When I add a new USB ID for a driver, my subject usually includes the driver name followed by a colon, and the "Add new USB ID". In your case, that would be "[PATCH] ath9k_htc: Add new USB ID". Then in the commit message I include the make and model of the device, and some indication of why that device ID should be added. For example, was that ID found in a Windows driver? Finally, indicate that the patch has been tested. Such a statement should not be necessary, but recently there have been a number of patches submitted that have not been tested on real hardware.

Quoted 4 lines

Larry

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.ath9k.org/pipermail/ath9k-devel/attachments/20150207/f55cf2c9/attachment.htm

#3 lore raw

PATCH 1/1 * Add support for Philips (or NXP) PTA01 Wireless Adapter

In reply to Larry Finger

Larry,

Thank for your remarks! I'll submit it again!

Att,

Leon Nardella

Quoted 39 lines · Larry Finger
Quoted 12 lines · Leon Nardella
---
  drivers/net/wireless/ath/ath9k/hif_usb.c | 1 +
  1 file changed, 1 insertion(+)
drivers/net/wireless/ath/ath9k/hif_usb.c +0 -0
index 8e7153b..10c02f5 100644

drivers/net/wireless/ath/ath9k/hif_usb.c static struct usb_device_id ath9k_hif_usb_ids[] = { · line 46

Quoted 7 lines
drivers/net/wireless/ath/ath9k/hif_usb.c +1 -0
@@ -40,6 +40,7 @@ static struct usb_device_id ath9k_hif_usb_ids[] = {
        { USB_DEVICE(0x0cf3, 0xb003) }, /* Ubiquiti WifiStation Ext */
        { USB_DEVICE(0x0cf3, 0xb002) }, /* Ubiquiti WifiStation */
        { USB_DEVICE(0x057c, 0x8403) }, /* AVM FRITZ!WLAN 11N v2 USB */
+       { USB_DEVICE(0x0471, 0x209e) }, /* Philips (or NXP) PTA01 */
 
        { USB_DEVICE(0x0cf3, 0x7015),
          .driver_info = AR9287_USB },  /* Atheros */

Leon,

Your patch is correct, but your subject and commit message needs a little work.

When I add a new USB ID for a driver, my subject usually includes the driver name followed by a colon, and the "Add new USB ID". In your case, that would be "[PATCH] ath9k_htc: Add new USB ID". Then in the commit message I include the make and model of the device, and some indication of why that device ID should be added. For example, was that ID found in a Windows driver? Finally, indicate that the patch has been tested. Such a statement should not be necessary, but recently there have been a number of patches submitted that have not been tested on real hardware.

Larry