Skip to contentSkip to conversation

tools/libxl: cleanup one libxl__calloc() usage

PATCH In review Tiejun Chen 3 participants 3 messages Mar 10, 2015 – Mar 11, 2015

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 tools/libxl: cleanup one libxl__calloc() usage

Its pointless because internally, libxl__calloc() would always terminate program execution if failed,

libxl__calloc()
|
+ void *ptr = calloc(nmemb, size);
+ if (!ptr) libxl__alloc_failed(CTX, __func__, nmemb, size); |
+ _exit(-1);

---
 tools/libxl/libxl_dm.c | 4 ----
 1 file changed, 4 deletions(-)
tools/libxl/libxl_dm.c +0 -4
index 8599a6a..cb006df 100644
@@ -1175,10 +1175,6 @@ static void spawn_stub_launch_dm(libxl__egc *egc,
         num_console++;
 
     console = libxl__calloc(gc, num_console, sizeof(libxl__device_console));
-    if (!console) {
-        ret = ERROR_NOMEM;
-        goto out;
-    }
 
     for (i = 0; i < num_console; i++) {
         libxl__device device;
Signature · 1 line
1.9.1
Acked-by on v1 1/1
#1 lore raw
Quoted 11 lines · Tiejun Chen

Its pointless because internally, libxl__calloc() would always terminate program execution if failed,

libxl__calloc()
|
+ void *ptr = calloc(nmemb, size);
+ if (!ptr) libxl__alloc_failed(CTX, __func__, nmemb, size); |
+ _exit(-1);

Quoted 21 lines
---
 tools/libxl/libxl_dm.c | 4 ----
 1 file changed, 4 deletions(-)
tools/libxl/libxl_dm.c +0 -4
index 8599a6a..cb006df 100644
@@ -1175,10 +1175,6 @@ static void spawn_stub_launch_dm(libxl__egc *egc,
         num_console++;
 
     console = libxl__calloc(gc, num_console, sizeof(libxl__device_console));
-    if (!console) {
-        ret = ERROR_NOMEM;
-        goto out;
-    }
 
     for (i = 0; i < num_console; i++) {
         libxl__device device;
Signature · 1 line
1.9.1
#2 lore raw
Quoted 11 lines · Wei Liu
Quoted 10 lines · Tiejun Chen

Its pointless because internally, libxl__calloc() would always terminate program execution if failed,

libxl__calloc()
|
+ void *ptr = calloc(nmemb, size);
+ if (!ptr) libxl__alloc_failed(CTX, __func__, nmemb, size); |
+ _exit(-1);

Quoted 3 lines
Quoted 1 line

Likewise + applied, thanks.