Skip to contentSkip to conversation

add support for Freescale's MMA8653FC 10 bit accelerometer

PATCH Superseded Martin Kepplinger 6 participants 12 messages Mar 18, 2015 – Mar 20, 2015

Subsystems (4)

v2 of 6 Superseded Latest is v6 →

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 add support for Freescale's MMA8653FC 10 bit accelerometer

From: Martin Kepplinger <[email protected]>

The MMA8653FC is a low-power, three-axis, capacitive micromachined accelerometer with 10 bits of resolution with flexible user-programmable options.

Embedded interrupt functions enable overall power savings, by relieving the host processor from continuously polling data, for example using the poll() system call.

The device can be configured to generate wake-up interrupt signals from any combination of the configurable embedded functions, enabling the MMA8653FC to monitor events while remaining in a low-power mode during periods of inactivity.

This driver provides devicetree properties to program the device's behaviour and a simple, tested and documented sysfs interface. The data sheet and more information is available on Freescale's website.

---
applies to v4.0-rc4 and the current -next.

patch revision history
......................
v2 corrects licensing and commit messages and adds appropriate recipients

 .../testing/sysfs-bus-i2c-devices-fsl-mma8653fc    |  39 +
 .../devicetree/bindings/misc/fsl,mma8653fc.txt     |  96 +++
 MAINTAINERS                                        |   5 +
 drivers/input/misc/Kconfig                         |  11 +
 drivers/input/misc/Makefile                        |   1 +
 drivers/input/misc/mma8653fc.c                     | 913 +++++++++++++++++++++
 6 files changed, 1065 insertions(+)
 create mode 100644 Documentation/ABI/testing/sysfs-bus-i2c-devices-fsl-mma8653fc
 create mode 100644 Documentation/devicetree/bindings/misc/fsl,mma8653fc.txt
 create mode 100644 drivers/input/misc/mma8653fc.c
Documentation/ABI/testing/sysfs-bus-i2c-devices-fsl-mma8653fc new file +39 -0
new file mode 100644
index 0000000..8172c27
@@ -0,0 +1,39 @@
+What:		/sys/bus/i2c/drivers/mma8653fc/*/standby
+Date:		March 2015
+Contact:	Martin Kepplinger <[email protected]>
+Description:
+		Write 0 to this in order to turn on the device, and 1 to turn
+		it off. Read to see if it is turned on or off.
+
+
+What:		/sys/bus/i2c/drivers/mma8653fc/*/currentmode
+Date:		March 2015
+Contact:	Martin Kepplinger <[email protected]>
+Description:
+		Reading this provides the current state of the device, read
+		directly from a register. This can be "standby", "wake" or
+		"sleep".
+
+
+What:		/sys/bus/i2c/drivers/mma8653fc/*/position
+Date:		March 2015
+Contact:	Martin Kepplinger <[email protected]>
+Description:
+		Read only. Without interrupts enabled gets current position
+		values by reading. Poll "position" with interrupt conditions
+		set, to get notified; see Documentation/.../fsl,mma8653fc.txt
+
+		position file format:
+		"x y z [landscape/portrait status] [front/back status]"
+
+		x y z values:
+			in mg
+		landscape/portrait status char:
+			r	landscape right
+			d	portrait down
+			u	portrait up
+			l	landscape left
+		front/back status char:
+			f	front facing
+			b	back facing
+
Documentation/devicetree/bindings/misc/fsl,mma8653fc.txt new file +96 -0

96 lines not on this page · raw message

MAINTAINERS +5 -0
index 0e1abe8..04c080d 100644
@@ -4104,6 +4104,11 @@ S:	Maintained
 F:	include/linux/platform_data/video-imxfb.h
 F:	drivers/video/fbdev/imxfb.c
 
+FREESCALE MMA8653FC ACCELEROMETER I2C DRIVER
+M:	Martin Kepplinger <[email protected]>
+S:	Maintained
+F:	drivers/input/misc/mma8653fc.c
+
 FREESCALE QUAD SPI DRIVER
 M:	Han Xu <[email protected]>
 L:	[email protected]
drivers/input/misc/Kconfig +11 -0
index 6deb8da..70d9bf5 100644
@@ -208,6 +208,17 @@ config INPUT_MMA8450
 	  To compile this driver as a module, choose M here: the
 	  module will be called mma8450.
 
+config INPUT_MMA8653FC
+	tristate "MMA8653FC - Freescale's 3-Axis, 10-bit Digital Accelerometer"
+	depends on I2C
+	default n
+	help
+	  Say Y here if you want to support Freescale's MMA8653FC Accelerometer
+	  through I2C interface.
+
+	  To compile this driver as a module, choose M here: the
+	  module will be called mma8653fc.
+
 config INPUT_MPU3050
 	tristate "MPU3050 Triaxial gyroscope sensor"
 	depends on I2C
drivers/input/misc/Makefile +1 -0
index 403a1a5..0bcd878 100644
@@ -43,6 +43,7 @@ obj-$(CONFIG_INPUT_MAX8925_ONKEY)	+= max8925_onkey.o
 obj-$(CONFIG_INPUT_MAX8997_HAPTIC)	+= max8997_haptic.o
 obj-$(CONFIG_INPUT_MC13783_PWRBUTTON)	+= mc13783-pwrbutton.o
 obj-$(CONFIG_INPUT_MMA8450)		+= mma8450.o
+obj-$(CONFIG_INPUT_MMA8653FC)		+= mma8653fc.o
 obj-$(CONFIG_INPUT_MPU3050)		+= mpu3050.o
 obj-$(CONFIG_INPUT_PALMAS_PWRBUTTON)	+= palmas-pwrbutton.o
 obj-$(CONFIG_INPUT_PCAP)		+= pcap_keys.o
drivers/input/misc/mma8653fc.c new file +913 -0

913 lines not on this page · raw message

Signature · 1 line
2.1.4
#1 lore raw
Quoted 28 lines · Martin Kepplinger

From: Martin Kepplinger <[email protected]>

The MMA8653FC is a low-power, three-axis, capacitive micromachined accelerometer with 10 bits of resolution with flexible user-programmable options.

Embedded interrupt functions enable overall power savings, by relieving the host processor from continuously polling data, for example using the poll() system call.

The device can be configured to generate wake-up interrupt signals from any combination of the configurable embedded functions, enabling the MMA8653FC to monitor events while remaining in a low-power mode during periods of inactivity.

This driver provides devicetree properties to program the device's behaviour and a simple, tested and documented sysfs interface. The data sheet and more information is available on Freescale's website.

---
applies to v4.0-rc4 and the current -next.

patch revision history
......................
v2 corrects licensing and commit messages and adds appropriate recipients

Quoted 10 lines
 .../testing/sysfs-bus-i2c-devices-fsl-mma8653fc    |  39 +
 .../devicetree/bindings/misc/fsl,mma8653fc.txt     |  96 +++
 MAINTAINERS                                        |   5 +
 drivers/input/misc/Kconfig                         |  11 +
 drivers/input/misc/Makefile                        |   1 +
 drivers/input/misc/mma8653fc.c                     | 913 +++++++++++++++++++++
 6 files changed, 1065 insertions(+)
 create mode 100644 Documentation/ABI/testing/sysfs-bus-i2c-devices-fsl-mma8653fc
 create mode 100644 Documentation/devicetree/bindings/misc/fsl,mma8653fc.txt
 create mode 100644 drivers/input/misc/mma8653fc.c

Shouldn't this go to drivers/iio/magnetometer instead of defining a new sysfs ABI?

Best regards,
Alexander

Signature · 12 lines
Dipl.-Inf. Alexander Stein

SYS TEC electronic GmbH
Am Windrad 2
08468 Heinsdorfergrund
Tel.: 03765 38600-1156
Fax: 03765 38600-4100
Email: [email protected]
Website: www.systec-electronic.com
 
Managing Director: Dipl.-Phys. Siegmar Schmidt
Commercial registry: Amtsgericht Chemnitz, HRB 28082
#2 lore raw

Am 2015-03-18 um 17:21 schrieb Alexander Stein:

Quoted 40 lines · Martin Kepplinger
Quoted 28 lines

From: Martin Kepplinger <[email protected]>

The MMA8653FC is a low-power, three-axis, capacitive micromachined accelerometer with 10 bits of resolution with flexible user-programmable options.

Embedded interrupt functions enable overall power savings, by relieving the host processor from continuously polling data, for example using the poll() system call.

The device can be configured to generate wake-up interrupt signals from any combination of the configurable embedded functions, enabling the MMA8653FC to monitor events while remaining in a low-power mode during periods of inactivity.

This driver provides devicetree properties to program the device's behaviour and a simple, tested and documented sysfs interface. The data sheet and more information is available on Freescale's website.

---
applies to v4.0-rc4 and the current -next.

patch revision history
......................
v2 corrects licensing and commit messages and adds appropriate recipients

Quoted 10 lines
 .../testing/sysfs-bus-i2c-devices-fsl-mma8653fc    |  39 +
 .../devicetree/bindings/misc/fsl,mma8653fc.txt     |  96 +++
 MAINTAINERS                                        |   5 +
 drivers/input/misc/Kconfig                         |  11 +
 drivers/input/misc/Makefile                        |   1 +
 drivers/input/misc/mma8653fc.c                     | 913 +++++++++++++++++++++
 6 files changed, 1065 insertions(+)
 create mode 100644 Documentation/ABI/testing/sysfs-bus-i2c-devices-fsl-mma8653fc
 create mode 100644 Documentation/devicetree/bindings/misc/fsl,mma8653fc.txt
 create mode 100644 drivers/input/misc/mma8653fc.c
Quoted 2 lines

Shouldn't this go to drivers/iio/magnetometer instead of defining a new sysfs ABI?

It could have gone to drivers/iio/accel if it would use an iio interface, which would make more sense, you are right, but I simply don't have the time to merge it in to iio.

It doesn't use an input interface either but I don't see a good place for an accelerometer that uses sysfs only.

It works well, is a relatively recent chip and a clean dirver. But this is all I can provide.

Quoted 3 lines

Best regards,
Alexander

maintainer
#3 lore raw
Quoted 44 lines · Martin Kepplinger

Am 2015-03-18 um 17:21 schrieb Alexander Stein:

Quoted 40 lines · Martin Kepplinger
Quoted 28 lines

From: Martin Kepplinger <[email protected]>

The MMA8653FC is a low-power, three-axis, capacitive micromachined accelerometer with 10 bits of resolution with flexible user-programmable options.

Embedded interrupt functions enable overall power savings, by relieving the host processor from continuously polling data, for example using the poll() system call.

The device can be configured to generate wake-up interrupt signals from any combination of the configurable embedded functions, enabling the MMA8653FC to monitor events while remaining in a low-power mode during periods of inactivity.

This driver provides devicetree properties to program the device's behaviour and a simple, tested and documented sysfs interface. The data sheet and more information is available on Freescale's website.

---
applies to v4.0-rc4 and the current -next.

patch revision history
......................
v2 corrects licensing and commit messages and adds appropriate recipients

Quoted 10 lines
 .../testing/sysfs-bus-i2c-devices-fsl-mma8653fc    |  39 +
 .../devicetree/bindings/misc/fsl,mma8653fc.txt     |  96 +++
 MAINTAINERS                                        |   5 +
 drivers/input/misc/Kconfig                         |  11 +
 drivers/input/misc/Makefile                        |   1 +
 drivers/input/misc/mma8653fc.c                     | 913 +++++++++++++++++++++
 6 files changed, 1065 insertions(+)
 create mode 100644 Documentation/ABI/testing/sysfs-bus-i2c-devices-fsl-mma8653fc
 create mode 100644 Documentation/devicetree/bindings/misc/fsl,mma8653fc.txt
 create mode 100644 drivers/input/misc/mma8653fc.c
Quoted 2 lines

Shouldn't this go to drivers/iio/magnetometer instead of defining a new sysfs ABI?

Quoted 6 lines

It could have gone to drivers/iio/accel if it would use an iio interface, which would make more sense, you are right, but I simply don't have the time to merge it in to iio.

It doesn't use an input interface either but I don't see a good place for an accelerometer that uses sysfs only.

drivers/misc? Since it is not using input infrastructure (nor should it), it does not belong in drivers/input.

Thanks.

Signature · 1 line
Dmitry
#4 lore raw
In reply to Martin Kepplinger
Quoted 1 line · Martin Kepplinger

<snip>

Quoted 9 lines

It could have gone to drivers/iio/accel if it would use an iio interface, which would make more sense, you are right, but I simply don't have the time to merge it in to iio.

It doesn't use an input interface either but I don't see a good place for an accelerometer that uses sysfs only.

It works well, is a relatively recent chip and a clean dirver. But this is all I can provide.

As a person who works on the user-space interaction of those with desktops [1]: Urgh.

I already have 3 (probably 4) types of accelerometers to contend with, I'm not fond of adding yet another type.

Is there any way to get this hardware working outside the SoCs it's designed for (say, a device with I2C like a Raspberry Pi), so that a kind soul could handle getting this using the right interfaces?

Cheers

[1]: https://github.com/hadess/iio-sensor-proxy

#5 lore raw

Am 2015-03-18 um 17:59 schrieb Bastien Nocera:

Quoted 16 lines · Martin Kepplinger
Quoted 1 line

<snip>

Quoted 9 lines

It could have gone to drivers/iio/accel if it would use an iio interface, which would make more sense, you are right, but I simply don't have the time to merge it in to iio.

It doesn't use an input interface either but I don't see a good place for an accelerometer that uses sysfs only.

It works well, is a relatively recent chip and a clean dirver. But this is all I can provide.

As a person who works on the user-space interaction of those with desktops [1]: Urgh.

Quoted 7 lines

I already have 3 (probably 4) types of accelerometers to contend with, I'm not fond of adding yet another type.

Is there any way to get this hardware working outside the SoCs it's designed for (say, a device with I2C like a Raspberry Pi), so that a kind soul could handle getting this using the right interfaces?

It works on basically any SoC and is in no way limited in this regard. Sure, userspace has to expicitely support it and I hear you. Using the iio interface would make more sense. I can only say I'd love to have the time to move this driver over. I'm very sorry.

Quoted 4 lines

Cheers

[1]: https://github.com/hadess/iio-sensor-proxy

#6 lore raw
Quoted 26 lines · Martin Kepplinger

Am 2015-03-18 um 17:59 schrieb Bastien Nocera:

Quoted 16 lines · Martin Kepplinger
Quoted 1 line

<snip>

Quoted 9 lines

It could have gone to drivers/iio/accel if it would use an iio interface, which would make more sense, you are right, but I simply don't have the time to merge it in to iio.

It doesn't use an input interface either but I don't see a good place for an accelerometer that uses sysfs only.

It works well, is a relatively recent chip and a clean dirver. But this is all I can provide.

As a person who works on the user-space interaction of those with desktops [1]: Urgh.

Quoted 8 lines

I already have 3 (probably 4) types of accelerometers to contend with, I'm not fond of adding yet another type.

Is there any way to get this hardware working outside the SoCs it's designed for (say, a device with I2C like a Raspberry Pi), so that a kind soul could handle getting this using the right interfaces?

Quoted 4 lines

It works on basically any SoC and is in no way limited in this regard. Sure, userspace has to expicitely support it and I hear you. Using the iio interface would make more sense. I can only say I'd love to have the time to move this driver over. I'm very sorry.

How can we get the hardware for somebody to use on their own laptops/embedded boards to implement this driver?

#7 lore raw

Am 2015-03-18 um 19:05 schrieb Bastien Nocera:

Quoted 27 lines · Martin Kepplinger
Quoted 26 lines

Am 2015-03-18 um 17:59 schrieb Bastien Nocera:

Quoted 24 lines · Martin Kepplinger
Quoted 1 line

<snip>

Quoted 9 lines

It could have gone to drivers/iio/accel if it would use an iio interface, which would make more sense, you are right, but I simply don't have the time to merge it in to iio.

It doesn't use an input interface either but I don't see a good place for an accelerometer that uses sysfs only.

It works well, is a relatively recent chip and a clean dirver. But this is all I can provide.

As a person who works on the user-space interaction of those with desktops [1]: Urgh.

I already have 3 (probably 4) types of accelerometers to contend with, I'm not fond of adding yet another type.

Is there any way to get this hardware working outside the SoCs it's designed for (say, a device with I2C like a Raspberry Pi), so that a kind soul could handle getting this using the right interfaces?

Quoted 8 lines
Quoted 4 lines

It works on basically any SoC and is in no way limited in this regard. Sure, userspace has to expicitely support it and I hear you. Using the iio interface would make more sense. I can only say I'd love to have the time to move this driver over. I'm very sorry.

How can we get the hardware for somebody to use on their own laptops/embedded boards to implement this driver?

It's connected over I2C. If the included documentation is not clear please tell me what exacly. Thanks!

#8 lore raw
Quoted 35 lines · Martin Kepplinger

Am 2015-03-18 um 19:05 schrieb Bastien Nocera:

Quoted 34 lines · Martin Kepplinger
Quoted 32 lines

Am 2015-03-18 um 17:59 schrieb Bastien Nocera:

Quoted 17 lines · Martin Kepplinger
Quoted 1 line

<snip>

Quoted 10 lines

It could have gone to drivers/iio/accel if it would use an
iio interface, which would make more sense, you are right,
but I
simply don't have the time to merge it in to iio.

It doesn't use an input interface either but I don't see a
good place for an accelerometer that uses sysfs only.

It works well, is a relatively recent chip and a clean dirver. But this is all I can provide.

As a person who works on the user-space interaction of those
with desktops [1]: Urgh.

Quoted 8 lines

I already have 3 (probably 4) types of accelerometers to contend with, I'm not fond of adding yet another type.

Is there any way to get this hardware working outside the SoCs it's designed for (say, a device with I2C like a Raspberry Pi), so that a kind soul could handle getting this using the right interfaces?

It works on basically any SoC and is in no way limited in this regard. Sure, userspace has to expicitely support it and I hear you. Using the iio interface would make more sense. I can only say I'd love to have the time to move this driver over. I'm very sorry.

Quoted 6 lines
Quoted 3 lines

How can we get the hardware for somebody to use on their own laptops/embedded boards to implement this driver?

It's connected over I2C. If the included documentation is not clear please tell me what exacly. Thanks!

I'll ask the question a different way: can you please give the address of a shop where that hardware is available?

#9 lore raw

Am 2015-03-19 um 11:22 schrieb Bastien Nocera:

Quoted 40 lines · Martin Kepplinger
Quoted 39 lines

Am 2015-03-18 um 19:05 schrieb Bastien Nocera:

Quoted 37 lines · Martin Kepplinger
Quoted 27 lines

Am 2015-03-18 um 17:59 schrieb Bastien Nocera:

Quoted 17 lines · Martin Kepplinger
Quoted 1 line

<snip>

Quoted 10 lines

It could have gone to drivers/iio/accel if it would use an
iio interface, which would make more sense, you are right,
but I
simply don't have the time to merge it in to iio.

It doesn't use an input interface either but I don't see a
good place for an accelerometer that uses sysfs only.

It works well, is a relatively recent chip and a clean dirver. But this is all I can provide.

As a person who works on the user-space interaction of those
with desktops [1]: Urgh.

Quoted 8 lines

I already have 3 (probably 4) types of accelerometers to contend with, I'm not fond of adding yet another type.

Is there any way to get this hardware working outside the SoCs it's designed for (say, a device with I2C like a Raspberry Pi), so that a kind soul could handle getting this using the right interfaces?

Quoted 5 lines

It works on basically any SoC and is in no way limited in this regard. Sure, userspace has to expicitely support it and I hear you. Using the iio interface would make more sense. I can only say I'd love to have the time to move this driver over. I'm very sorry.

How can we get the hardware for somebody to use on their own laptops/embedded boards to implement this driver?

Quoted 7 lines
Quoted 2 lines

It's connected over I2C. If the included documentation is not clear please tell me what exacly. Thanks!

I'll ask the question a different way: can you please give the address of a shop where that hardware is available?

there is
http://www.freescale.com/webapp/sps/site/prod_summary.jsp?code=RDMMA865x&lang_cd=
and http://linux-sunxi.org/Inet_K970 for example. I think I saw Android devices with it too, and I would guess it would be used more often if it were in linux.

Please refer to v4 of the patch for different questions. thanks!

#10 lore raw
Quoted 49 lines · Martin Kepplinger

Am 2015-03-19 um 11:22 schrieb Bastien Nocera:

Quoted 40 lines · Martin Kepplinger
Quoted 39 lines

Am 2015-03-18 um 19:05 schrieb Bastien Nocera:

Quoted 37 lines · Martin Kepplinger
Quoted 27 lines

Am 2015-03-18 um 17:59 schrieb Bastien Nocera:

Quoted 17 lines · Martin Kepplinger
Quoted 1 line

<snip>

Quoted 10 lines

It could have gone to drivers/iio/accel if it would use an
iio interface, which would make more sense, you are right,
but I
simply don't have the time to merge it in to iio.

It doesn't use an input interface either but I don't see a
good place for an accelerometer that uses sysfs only.

It works well, is a relatively recent chip and a clean dirver. But this is all I can provide.

As a person who works on the user-space interaction of those
with desktops [1]: Urgh.

Quoted 8 lines

I already have 3 (probably 4) types of accelerometers to contend with, I'm not fond of adding yet another type.

Is there any way to get this hardware working outside the SoCs it's designed for (say, a device with I2C like a Raspberry Pi), so that a kind soul could handle getting this using the right interfaces?

Quoted 5 lines

It works on basically any SoC and is in no way limited in this regard. Sure, userspace has to expicitely support it and I hear you. Using the iio interface would make more sense. I can only say I'd love to have the time to move this driver over. I'm very sorry.

How can we get the hardware for somebody to use on their own laptops/embedded boards to implement this driver?

Quoted 7 lines
Quoted 2 lines

It's connected over I2C. If the included documentation is not clear please tell me what exacly. Thanks!

I'll ask the question a different way: can you please give the address of a shop where that hardware is available?

Quoted 5 lines

there is
http://www.freescale.com/webapp/sps/site/prod_summary.jsp?code=RDMMA865x&lang_cd=
and http://linux-sunxi.org/Inet_K970 for example. I think I saw Android devices with it too, and I would guess it would be used more often if it were in linux.

I am going to say again (in a different way) what Bastien said. In its current form, even in drivers/misc, this is a NACK for me (v1, v2, v3 & v4).

Putting a driver in Linux means we have to support it forever, and definitively, nobody will use an accelerometer in Android if it is in drivers/misc.
Android requires drivers to follow the IIO protocol. Period. So having your own will not help android, it will just be a burden.

The sysfs you are proposing seems simple enough, but we can not afford having a 3rd custom way of relying the accelerometer information in the Linux tree (they were first handled in input, then IIO, then a custom sysfs).

If you really want to have the driver in the tree, I won't be opposed if you put in under staging. This way, you can break it whenever you want and people won't rely on it. And then, we can use your driver as a base to port it to IIO.

Sorry for being rude, but I am starting to get tired of people saying that they don't have the time to follow what the reviewers said. You obviously spent some time polishing this driver, why not making it right from its first inclusion in the tree?

Cheers,
Benjamin

Quoted 6 lines

Please refer to v4 of the patch for different questions. thanks! --
To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html

#11 lore raw

Am 2015-03-20 um 13:27 schrieb Benjamin Tissoires:

Quoted 72 lines
Quoted 49 lines · Martin Kepplinger

Am 2015-03-19 um 11:22 schrieb Bastien Nocera:

Quoted 40 lines · Martin Kepplinger
Quoted 39 lines

Am 2015-03-18 um 19:05 schrieb Bastien Nocera:

Quoted 37 lines · Martin Kepplinger
Quoted 27 lines

Am 2015-03-18 um 17:59 schrieb Bastien Nocera:

Quoted 17 lines · Martin Kepplinger
Quoted 1 line

<snip>

Quoted 10 lines

It could have gone to drivers/iio/accel if it would use an
iio interface, which would make more sense, you are right,
but I
simply don't have the time to merge it in to iio.

It doesn't use an input interface either but I don't see a
good place for an accelerometer that uses sysfs only.

It works well, is a relatively recent chip and a clean dirver. But this is all I can provide.

As a person who works on the user-space interaction of those
with desktops [1]: Urgh.

Quoted 8 lines

I already have 3 (probably 4) types of accelerometers to contend with, I'm not fond of adding yet another type.

Is there any way to get this hardware working outside the SoCs it's designed for (say, a device with I2C like a Raspberry Pi), so that a kind soul could handle getting this using the right interfaces?

Quoted 5 lines

It works on basically any SoC and is in no way limited in this regard. Sure, userspace has to expicitely support it and I hear you. Using the iio interface would make more sense. I can only say I'd love to have the time to move this driver over. I'm very sorry.

How can we get the hardware for somebody to use on their own laptops/embedded boards to implement this driver?

Quoted 7 lines
Quoted 2 lines

It's connected over I2C. If the included documentation is not clear please tell me what exacly. Thanks!

I'll ask the question a different way: can you please give the address of a shop where that hardware is available?

Quoted 5 lines

there is
http://www.freescale.com/webapp/sps/site/prod_summary.jsp?code=RDMMA865x&lang_cd=
and http://linux-sunxi.org/Inet_K970 for example. I think I saw Android devices with it too, and I would guess it would be used more often if it were in linux.

I am going to say again (in a different way) what Bastien said. In its current form, even in drivers/misc, this is a NACK for me (v1, v2, v3 & v4).

Putting a driver in Linux means we have to support it forever, and definitively, nobody will use an accelerometer in Android if it is in drivers/misc.
Android requires drivers to follow the IIO protocol. Period. So having your own will not help android, it will just be a burden.

The sysfs you are proposing seems simple enough, but we can not afford having a 3rd custom way of relying the accelerometer information in the Linux tree (they were first handled in input, then IIO, then a custom sysfs).

Quoted 4 lines

If you really want to have the driver in the tree, I won't be opposed if you put in under staging. This way, you can break it whenever you want and people won't rely on it. And then, we can use your driver as a base to port it to IIO.

That seems reasonable. I have prepared a (little more cleaned up) v5 of the patch and moved it to staging, with a TODO file containing also the current documentation. I hope to be able to do the iio integration sometime "soon", but this could speed things up.

Quoted 5 lines

Sorry for being rude, but I am starting to get tired of people saying that they don't have the time to follow what the reviewers said. You obviously spent some time polishing this driver, why not making it right from its first inclusion in the tree?

That's totally fine. Of course iio is the way to go. I had the driver before I really knew iio and this was lazyness (when I found Documentation/ABI/testing), plus the desire to publish it before the chip itself is deprecated.

Quoted 10 lines

Cheers,
Benjamin

Quoted 6 lines

Please refer to v4 of the patch for different questions. thanks! --
To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html