coccinelle: pm_runtime: Insert blank line
PATCH 1/4 coccinelle: pm_runtime: Insert blank line
From: Fabio Estevam <[email protected]>
Insert a blank line in order to improve the readability of the generated patch and also make it consistent with the other .cocci files.
--- scripts/coccinelle/api/pm_runtime.cocci | 1 + 1 file changed, 1 insertion(+)
scripts/coccinelle/api/pm_runtime.cocci +1 -0
@@ -1,4 +1,5 @@ /// Make sure pm_runtime_* calls does not use unnecessary IS_ERR_VALUE +/// // // Keywords: pm_runtime // Confidence: Medium
Signature · 1 line
1.9.1
PATCH 2/4 coccinelle: returnvar: Use imperative mood
From: Fabio Estevam <[email protected]>
According to Documentation/SubmittingPatches:
"Describe your changes in imperative mood, e.g. "make xyzzy do frotz" instead of "[This patch] makes xyzzy do frotz" or "[I] changed xyzzy to do frotz", as if you are giving orders to the codebase to change its behaviour."
So do as recommended.
--- scripts/coccinelle/misc/returnvar.cocci | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
scripts/coccinelle/misc/returnvar.cocci +1 -1
@@ -1,5 +1,5 @@ /// -/// Removes unneeded variable used to store return value. +/// Remove unneeded variable used to store return value. /// // Confidence: Moderate // Copyright: (C) 2012 Peter Senna Tschudin, INRIA/LIP6. GPLv2.
Signature · 1 line
1.9.1
PATCH 2/4 coccinelle: returnvar: Use imperative mood
Quoted 4 lines · Fabio Estevam
From: Fabio Estevam <[email protected]>
According to
Documentation/SubmittingPatches:
Quoted 8 lines
"Describe your changes in imperative mood, e.g. "make xyzzy do frotz" instead of "[This patch] makes xyzzy do frotz" or "[I] changed xyzzy to do frotz", as if you are giving orders to the codebase to change its behaviour."
So do as recommended.
Signed-off-by Fabio Estevam <[email protected]>
Quoted 19 lines
--- scripts/coccinelle/misc/returnvar.cocci | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)scripts/coccinelle/misc/returnvar.cocci +1
-1@@ -1,5 +1,5 @@ /// -/// Removes unneeded variable used to store return value. +/// Remove unneeded variable used to store return value. /// // Confidence: Moderate // Copyright: (C) 2012 Peter Senna Tschudin, INRIA/LIP6. GPLv2.Signature · 1 line
1.9.1
PATCH 3/4 coccinelle: ifaddr: Fix the sentence
In reply to Fabio EstevamFrom: Fabio Estevam <[email protected]>
Make the sentence sensible.
--- scripts/coccinelle/misc/ifaddr.cocci | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
scripts/coccinelle/misc/ifaddr.cocci +1 -2
@@ -1,5 +1,4 @@ -/// the address of a variable or field is non-zero is likely always to bo -/// non-zero +/// The address of a variable or field is likely always to be non-zero. /// // Confidence: High // Copyright: (C) 2012 Julia Lawall, INRIA/LIP6. GPLv2.
Signature · 1 line
1.9.1
PATCH 3/4 coccinelle: ifaddr: Fix the sentence
Quoted 5 lines · Fabio Estevam
From: Fabio Estevam <[email protected]>
Make the sentence sensible.
Signed-off-by Fabio Estevam <[email protected]>
Quoted 19 lines
--- scripts/coccinelle/misc/ifaddr.cocci | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)scripts/coccinelle/misc/ifaddr.cocci +1
-2@@ -1,5 +1,4 @@ -/// the address of a variable or field is non-zero is likely always to bo -/// non-zero +/// The address of a variable or field is likely always to be non-zero. /// // Confidence: High // Copyright: (C) 2012 Julia Lawall, INRIA/LIP6. GPLv2.Signature · 1 line
1.9.1
PATCH 4/4 coccinelle: simple_open: Use imperative mood
In reply to Fabio EstevamFrom: Fabio Estevam <[email protected]>
According to Documentation/SubmittingPatches:
"Describe your changes in imperative mood, e.g. "make xyzzy do frotz" instead of "[This patch] makes xyzzy do frotz" or "[I] changed xyzzy to do frotz", as if you are giving orders to the codebase to change its behaviour."
So do as recommended.
--- scripts/coccinelle/api/simple_open.cocci | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
scripts/coccinelle/api/simple_open.cocci +2 -2
@@ -1,5 +1,5 @@ -/// This removes an open coded simple_open() function -/// and replaces file operations references to the function +/// Remove an open coded simple_open() function +/// and replace file operations references to the function /// with simple_open() instead. /// // Confidence: High
Signature · 1 line
1.9.1
PATCH 4/4 coccinelle: simple_open: Use imperative mood
Quoted 4 lines · Fabio Estevam
From: Fabio Estevam <[email protected]>
According to
Documentation/SubmittingPatches:
Quoted 8 lines
"Describe your changes in imperative mood, e.g. "make xyzzy do frotz" instead of "[This patch] makes xyzzy do frotz" or "[I] changed xyzzy to do frotz", as if you are giving orders to the codebase to change its behaviour."
So do as recommended.
Signed-off-by Fabio Estevam <[email protected]>
Quoted 20 lines
--- scripts/coccinelle/api/simple_open.cocci | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)scripts/coccinelle/api/simple_open.cocci +2
-2@@ -1,5 +1,5 @@ -/// This removes an open coded simple_open() function -/// and replaces file operations references to the function +/// Remove an open coded simple_open() function +/// and replace file operations references to the function /// with simple_open() instead. /// // Confidence: HighSignature · 1 line
1.9.1
PATCH 1/4 coccinelle: pm_runtime: Insert blank line
In reply to Fabio EstevamQuoted 16 lines · Fabio Estevam
From: Fabio Estevam <[email protected]>
Insert a blank line in order to improve the readability of the generated patch and also make it consistent with the other .cocci files.
Signed-off-by Fabio Estevam <[email protected]>--- scripts/coccinelle/api/pm_runtime.cocci | 1 + 1 file changed, 1 insertion(+)scripts/coccinelle/api/pm_runtime.cocci +0
-0
scripts/coccinelle/api/pm_runtime.cocci line 3
Quoted 3 lines
scripts/coccinelle/api/pm_runtime.cocci +1
-0@@ -1,4 +1,5 @@ /// Make sure pm_runtime_* calls does not use unnecessary IS_ERR_VALUE +/// //
Looking at the examples in the other fixes you have sent, it seems that what is wanted it to convert the // to /// rather than adding a /// before it.
Thanks for your help.
julia
Quoted 6 lines
scripts/coccinelle/api/pm_runtime.cocci +0
-0// Keywords: pm_runtime // Confidence: MediumSignature · 1 line
1.9.1