Skip to contentSkip to conversation

ARM: BCM5301X: Fix chip typo in ARCH_BCM_5301X help message

PATCH New Rafał Miłecki 3 participants 4 messages May 13, 2015

Subsystems (3)
Arm (32-bit) Arm sub-architectures Broadcom BCM281XX/BCM11XXX/BCM216XX Arm architecture
lore
Share & tools
lore

Rafał Miłecki

author
#0 lore raw

PATCH 1/1 ARM: BCM5301X: Fix chip typo in ARCH_BCM_5301X help message

Signed-off-by Rafa? Mi?ecki <[email protected]>
---
 arch/arm/mach-bcm/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/mach-bcm/Kconfig +1 -1
index 8b11f44..7fec7e8 100644
@@ -47,7 +47,7 @@ config ARCH_BCM_5301X
 	  BCM53014, BCM53015, BCM53016, BCM53017, BCM53018, BCM4707,
 	  BCM4708 and BCM4709.
 
-	  Do not confuse this with the BCM4760 which is a totally
+	  Do not confuse this with the BCM4706 which is a totally
 	  different SoC or with the older BCM47XX and BCM53XX based
 	  network SoC using a MIPS CPU, they are supported by arch/mips/bcm47xx
Signature · 1 line
1.8.4.5
#1 lore raw

PATCH 1/1 ARM: BCM5301X: Fix chip typo in ARCH_BCM_5301X help message

Quoted 10 lines · Rafa? Mi?ecki
Signed-off-by Rafa? Mi?ecki <[email protected]>
---
 arch/arm/mach-bcm/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/mach-bcm/Kconfig +0 -0
index 8b11f44..7fec7e8 100644

arch/arm/mach-bcm/Kconfig config ARCH_BCM_5301X · line 52

Quoted 7 lines
arch/arm/mach-bcm/Kconfig +1 -1
@@ -47,7 +47,7 @@ config ARCH_BCM_5301X
 	  BCM53014, BCM53015, BCM53016, BCM53017, BCM53018, BCM4707,
 	  BCM4708 and BCM4709.
 
-	  Do not confuse this with the BCM4760 which is a totally
+	  Do not confuse this with the BCM4706 which is a totally
 	  different SoC or with the older BCM47XX and BCM53XX based
 	  network SoC using a MIPS CPU, they are supported by arch/mips/bcm47xx

This is not a real typo per-se, there is a 4760 chip (GPS), do you want to resubmit to include both?

Signature · 1 line
Florian
author
#2 lore raw

PATCH 1/1 ARM: BCM5301X: Fix chip typo in ARCH_BCM_5301X help message

Quoted 14 lines · Florian Fainelli
Quoted 13 lines · Rafa? Mi?ecki
Signed-off-by Rafa? Mi?ecki <[email protected]>
---
 arch/arm/mach-bcm/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/mach-bcm/Kconfig +0 -0
index 8b11f44..7fec7e8 100644
@@ -47,7 +47,7 @@ config ARCH_BCM_5301X
        BCM53014, BCM53015, BCM53016, BCM53017, BCM53018, BCM4707,
        BCM4708 and BCM4709.
Quoted 7 lines

arch/arm/mach-bcm/Kconfig config ARCH_BCM_5301X · line 52

Quoted 4 lines
arch/arm/mach-bcm/Kconfig +1 -1
-       Do not confuse this with the BCM4760 which is a totally
+       Do not confuse this with the BCM4706 which is a totally
        different SoC or with the older BCM47XX and BCM53XX based
        network SoC using a MIPS CPU, they are supported by arch/mips/bcm47xx

This is not a real typo per-se, there is a 4760 chip (GPS), do you want to resubmit to include both?

Oops, drop it please.

Signature · 1 line
Rafa?
NAK
#3 lore raw

PATCH 1/1 ARM: BCM5301X: Fix chip typo in ARCH_BCM_5301X help message

In reply to Rafał Miłecki
Quoted 11 lines · Rafa? Mi?ecki
Signed-off-by Rafa? Mi?ecki <[email protected]>
---
 arch/arm/mach-bcm/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/mach-bcm/Kconfig +0 -0
index 8b11f44..7fec7e8 100644

arch/arm/mach-bcm/Kconfig config ARCH_BCM_5301X · line 53

Quoted 8 lines
arch/arm/mach-bcm/Kconfig +1 -1
@@ -47,7 +47,7 @@ config ARCH_BCM_5301X
 	  BCM53014, BCM53015, BCM53016, BCM53017, BCM53018, BCM4707,
 	  BCM4708 and BCM4709.
 
-	  Do not confuse this with the BCM4760 which is a totally
+	  Do not confuse this with the BCM4706 which is a totally
 	  different SoC or with the older BCM47XX and BCM53XX based
 	  network SoC using a MIPS CPU, they are supported by arch/mips/bcm47xx

Nack

Like Florian said this is not a typo. There is a BCM4760 SoC and it was or is supported by Linux.

See this for BCM4760: https://lwn.net/Articles/563957/

I forgot about this at first too. Nice naming Broadcom. (the other companies are not better). ;-)

Hauke