Skip to contentSkip to conversation

coda: Do not define TRACE_SYSTEM_STRING

PATCH In review Steven Rostedt 2 participants 3 messages May 15, 2015 – May 20, 2015 Media (V4L/DVB)

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 coda: Do not define TRACE_SYSTEM_STRING

TRACE_SYSTEM_STRING is used internally to the TRACE_EVENT system. It should not be defined by tracepoint files. I'm not even sure who started that (I hope it wasn't me!)

---

drivers/media/platform/coda/trace.h +0 -2
index d1d06cbd1f6a..781bf7286d53 100644
@@ -9,8 +9,6 @@
 
 #include "coda.h"
 
-#define TRACE_SYSTEM_STRING __stringify(TRACE_SYSTEM)
-
 TRACE_EVENT(coda_bit_run,
 	TP_PROTO(struct coda_ctx *ctx, int cmd),
 
#1 lore raw
Quoted 3 lines · On Thu, 14 May 2015 22:52:50 -0400 Steven Rostedt <[email protected]> wrote:

TRACE_SYSTEM_STRING is used internally to the TRACE_EVENT system. It should not be defined by tracepoint files. I'm not even sure who started that (I hope it wasn't me!)

According to git history, that define first showed up in

commit 1c5d22f76dc721f3acb7a3dadc657a221e487fb7

Author: Chris Wilson <[email protected]>
Date:   Tue Aug 25 11:15:50 2009 +0100

drm/i915: Add tracepoints

And it must have spread with cut and paste. Now I need to start administering a vaccine to keep developers from catching it!

-- Steve

Quoted 17 lines

---

drivers/media/platform/coda/trace.h +0 -2
index d1d06cbd1f6a..781bf7286d53 100644
@@ -9,8 +9,6 @@
 
 #include "coda.h"
 
-#define TRACE_SYSTEM_STRING __stringify(TRACE_SYSTEM)
-
 TRACE_EVENT(coda_bit_run,
 	TP_PROTO(struct coda_ctx *ctx, int cmd),
 
Acked-by on v1 1/1
#2 lore raw
In reply to Steven Rostedt

Am Donnerstag, den 14.05.2015, 22:52 -0400 schrieb Steven Rostedt:

Quoted 12 lines

TRACE_SYSTEM_STRING is used internally to the TRACE_EVENT system. It should not be defined by tracepoint files. I'm not even sure who started that (I hope it wasn't me!)

---

drivers/media/platform/coda/trace.h +0 -0
index d1d06cbd1f6a..781bf7286d53 100644

drivers/media/platform/coda/trace.h line 13

Quoted 7 lines
drivers/media/platform/coda/trace.h +0 -2
@@ -9,8 +9,6 @@
 
 #include "coda.h"
 
-#define TRACE_SYSTEM_STRING __stringify(TRACE_SYSTEM)
-
 TRACE_EVENT(coda_bit_run,
 	TP_PROTO(struct coda_ctx *ctx, int cmd),

thanks
Philipp