coda: Do not define TRACE_SYSTEM_STRING
PATCH 1/1 coda: Do not define TRACE_SYSTEM_STRING
TRACE_SYSTEM_STRING is used internally to the TRACE_EVENT system. It should not be defined by tracepoint files. I'm not even sure who started that (I hope it wasn't me!)
---
drivers/media/platform/coda/trace.h +0 -2
@@ -9,8 +9,6 @@#include "coda.h" -#define TRACE_SYSTEM_STRING __stringify(TRACE_SYSTEM) - TRACE_EVENT(coda_bit_run, TP_PROTO(struct coda_ctx *ctx, int cmd),
Quoted 3 lines · On Thu, 14 May 2015 22:52:50 -0400 Steven Rostedt <[email protected]> wrote:
TRACE_SYSTEM_STRINGis used internally to theTRACE_EVENTsystem. It should not be defined by tracepoint files. I'm not even sure who started that (I hope it wasn't me!)
According to git history, that define first showed up in
commit 1c5d22f76dc721f3acb7a3dadc657a221e487fb7
Author: Chris Wilson <[email protected]> Date: Tue Aug 25 11:15:50 2009 +0100
drm/i915: Add tracepoints
And it must have spread with cut and paste. Now I need to start administering a vaccine to keep developers from catching it!
-- Steve
Quoted 17 lines
Reported-by kbuild test robot <[email protected]>Signed-off-by Steven Rostedt <[email protected].---
drivers/media/platform/coda/trace.h +0
-2@@ -9,8 +9,6 @@#include "coda.h" -#define TRACE_SYSTEM_STRING __stringify(TRACE_SYSTEM) - TRACE_EVENT(coda_bit_run, TP_PROTO(struct coda_ctx *ctx, int cmd),
Am Donnerstag, den 14.05.2015, 22:52 -0400 schrieb Steven Rostedt:
Quoted 12 lines
TRACE_SYSTEM_STRINGis used internally to theTRACE_EVENTsystem. It should not be defined by tracepoint files. I'm not even sure who started that (I hope it wasn't me!)Reported-by kbuild test robot <[email protected]>Signed-off-by Steven Rostedt <[email protected].---
drivers/media/platform/coda/trace.h +0
-0
drivers/media/platform/coda/trace.h line 13
Quoted 7 lines
drivers/media/platform/coda/trace.h +0
-2@@ -9,8 +9,6 @@#include "coda.h" -#define TRACE_SYSTEM_STRING __stringify(TRACE_SYSTEM) - TRACE_EVENT(coda_bit_run, TP_PROTO(struct coda_ctx *ctx, int cmd),
thanks
Philipp