ASoC: qcom: Remove QCOM dependency from LPASS variants
Subsystems (4)
PATCH v2 1/1 ASoC: qcom: Remove QCOM dependency from LPASS variants
From: Kenneth Westfield <[email protected]>
Building with the following config options ...
CONFIG_COMPILE_TEST=y
# CONFIG_SND_SOC_QCOM is not set
CONFIG_SND_SOC_LPASS_IPQ806X=m
CONFIG_SND_SOC_STORM=m
... causes the following build warning:
warning: (SND_SOC_STORM) selects SND_SOC_LPASS_IPQ806X which has unmet direct dependencies (SOUND && !M68K && !UML && SND && SND_SOC && SND_SOC_QCOM)
To fix this, the dependency on SND_SOC_QCOM from the user-invisible LPASS variant config options has been removed. This will allow for successful randconfig builds that use COMPILE_TEST.
driver")
---
Created fix in response to Jim's bug report:
http://mailman.alsa-project.org/pipermail/alsa-devel/2015-May/092870.html
sound/soc/qcom/Kconfig | 2 -- 1 file changed, 2 deletions(-)
sound/soc/qcom/Kconfig +0 -2
@@ -14,13 +14,11 @@ config SND_SOC_LPASS_PLATFORM config SND_SOC_LPASS_IPQ806X tristate - depends on SND_SOC_QCOM select SND_SOC_LPASS_CPU select SND_SOC_LPASS_PLATFORM config SND_SOC_LPASS_APQ8016 tristate - depends on SND_SOC_QCOM select SND_SOC_LPASS_CPU select SND_SOC_LPASS_PLATFORM
Signature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project
Mark Brown
maintainerQuoted 8 lines · Kenneth Westfield
Building with the following config options ...
CONFIG_COMPILE_TEST=y
#CONFIG_SND_SOC_QCOMis not set
CONFIG_SND_SOC_LPASS_IPQ806X=m
CONFIG_SND_SOC_STORM=m... causes the following build warning:
It's not obvious to me that the above set of options should be allowed in the first place - surely the machine drivers depend on SND_SOC_QCOM so the fix should be to add the missing dependency to the machine drivers?