Skip to contentSkip to conversation

ASoC: qcom: Remove QCOM dependency from LPASS variants

PATCH Superseded Kenneth Westfield 2 participants 3 messages Jun 2, 2015 – Jul 7, 2015

Subsystems (4)

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ASoC: qcom: Remove QCOM dependency from LPASS variants

From: Kenneth Westfield <[email protected]>

Remove the dependency on SND_SOC_QCOM from the user- invisible LPASS variant options. This will fix randconfig build errors.

Fixes dc1ebd1811e9 ("ASoC: qcom: Add apq8016 lpass driver support")
Fixes 9bae4880acee ("ASoC: qcom: move ipq806x specific bits out of lpass

driver")

---

Created fix in response to Jim's bug report:
http://mailman.alsa-project.org/pipermail/alsa-devel/2015-May/092870.html

Note: I did some searching but didn't see an example of a fix for the same type of bug introduced by 2 commits. If this needs to be split into two fixes, let me know.

 sound/soc/qcom/Kconfig | 2 --
 1 file changed, 2 deletions(-)
sound/soc/qcom/Kconfig +0 -2
index 29fff6d..10837bd 100644
@@ -14,13 +14,11 @@ config SND_SOC_LPASS_PLATFORM
 
 config SND_SOC_LPASS_IPQ806X
 	tristate
-	depends on SND_SOC_QCOM
 	select SND_SOC_LPASS_CPU
 	select SND_SOC_LPASS_PLATFORM
 
 config SND_SOC_LPASS_APQ8016
 	tristate
-	depends on SND_SOC_QCOM
 	select SND_SOC_LPASS_CPU
 	select SND_SOC_LPASS_PLATFORM
 
Signature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
maintainer
#1 lore raw
Quoted 3 lines · Kenneth Westfield

Remove the dependency on SND_SOC_QCOM from the user- invisible LPASS variant options. This will fix randconfig build errors.

I can't tell from this commit message what the patch is supposed to do - what are the bugs and in what way will this fix them?

maintainer
#2 lore raw

Applied "ASoC: qcom: remove Kconfig deps from variant configs" to the asoc tree

In reply to Kenneth Westfield

The patch

ASoC: qcom: remove Kconfig deps from variant configs

has been applied to the asoc tree at

git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git

All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

Thanks,
Mark

Quoted 1 line

From 7f005256f70a8c1c60b2f8a7449137da0c5e5bd9 Mon Sep 17 00:00:00 2001

From: Kenneth Westfield <[email protected]>
Date: Thu, 18 Jun 2015 15:16:08 -0700
Subject: [PATCH] ASoC: qcom: remove Kconfig deps from variant configs

Remove the SND_SOC_QCOM dependency from the variant configs. The board configs, which select the variants, already have this dependency.

---
 sound/soc/qcom/Kconfig | 2 --
 1 file changed, 2 deletions(-)
sound/soc/qcom/Kconfig +0 -2
index d6ccda7..3cc252e 100644
@@ -15,13 +15,11 @@ config SND_SOC_LPASS_PLATFORM
 
 config SND_SOC_LPASS_IPQ806X
 	tristate
-	depends on SND_SOC_QCOM
 	select SND_SOC_LPASS_CPU
 	select SND_SOC_LPASS_PLATFORM
 
 config SND_SOC_LPASS_APQ8016
 	tristate
-	depends on SND_SOC_QCOM
 	select SND_SOC_LPASS_CPU
 	select SND_SOC_LPASS_PLATFORM
 
Signature · 1 line
2.1.4