ARM: dts: imx6sl: Complete the dcp node
Subsystems (2)
Fabio Estevam
reviewerPATCH 1/1 ARM: dts: imx6sl: Complete the dcp node
From: Fabio Estevam <[email protected]>
The DCP block present on MX6SL is compatible with the one on MX28, so add the compatible string and also complete the interrupt entries.
--- arch/arm/boot/dts/imx6sl.dtsi | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-)
arch/arm/boot/dts/imx6sl.dtsi +5 -1
@@ -670,8 +670,12 @@ }; dcp: dcp at 020fc000 { + compatible = "fsl,imx28-dcp"; reg = <0x020fc000 0x4000>; - interrupts = <0 99 IRQ_TYPE_LEVEL_HIGH>; + interrupts = <0 99 IRQ_TYPE_LEVEL_HIGH>, + <0 100 IRQ_TYPE_LEVEL_HIGH>, + <0 101 IRQ_TYPE_LEVEL_HIGH>; + status = "okay"; }; };
Signature · 1 line
1.9.1
PATCH 1/1 ARM: dts: imx6sl: Complete the dcp node
Am Mittwoch, den 02.09.2015, 12:06 -0300 schrieb Fabio Estevam:
Quoted 15 lines
From: Fabio Estevam <[email protected]>
The DCP block present on MX6SL is compatible with the one on MX28, so add the compatible string and also complete the interrupt entries.
Signed-off-by Fabio Estevam <[email protected]>--- arch/arm/boot/dts/imx6sl.dtsi | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-)arch/arm/boot/dts/imx6sl.dtsi +0
-0
arch/arm/boot/dts/imx6sl.dtsi line 673
Quoted 4 lines
arch/arm/boot/dts/imx6sl.dtsi +1
-0@@ -670,8 +670,12 @@ }; dcp: dcp at 020fc000 { + compatible = "fsl,imx28-dcp";
Can we please start to make it good habit to always introduce a new compatible to the DTs, even if the blocks are the same in theory?
We already had situations where the SoC IP integration exposed bugs, which need driver workarounds and the only way to detect such situations is to check the machine compatible in the driver, which is really ugly.
So can we please make this:
compatible = "fsl,imx6sl-dcp", "fsl,imx28-dcp";
This way we can bind any required driver changes to the new compatible if necessary, without the need to change the DT again. Keep in mind that we try to push DTs as ABI that doesn't need to be updated in steplock with the kernel.
Regards,
Lucas
Quoted 9 lines
arch/arm/boot/dts/imx6sl.dtsi +4
-1reg = <0x020fc000 0x4000>; - interrupts = <0 99 IRQ_TYPE_LEVEL_HIGH>; + interrupts = <0 99 IRQ_TYPE_LEVEL_HIGH>, + <0 100 IRQ_TYPE_LEVEL_HIGH>, + <0 101 IRQ_TYPE_LEVEL_HIGH>; + status = "okay"; }; };
Signature · 2 lines
Pengutronix e.K. | Lucas Stach | Industrial Linux Solutions | http://www.pengutronix.de/ |
Fabio Estevam
reviewerPATCH 1/1 ARM: dts: imx6sl: Complete the dcp node
Quoted 9 lines · Lucas Stach
Can we please start to make it good habit to always introduce a new compatible to the DTs, even if the blocks are the same in theory?
We already had situations where the SoC IP integration exposed bugs, which need driver workarounds and the only way to detect such situations is to check the machine compatible in the driver, which is really ugly.
So can we please make this:
compatible = "fsl,imx6sl-dcp", "fsl,imx28-dcp";
Thanks for the suggestion. Did this in v2.
Regards,
Fabio Estevam