ASoC: rt5645: Add the HW EQ for the customized speaker output of Google Celes

PATCH Superseded Oder Chiou 2 participants 2 messages Oct 8, 2015 – Oct 12, 2015

Subsystems (3)

Sound ASoC Realtek audio codecs

lore

Share & tools

lore

Oder Chiou

author maintainer

2015-10-08 03:21 UTC #0 lore raw

PATCH v3 1/1 ASoC: rt5645: Add the HW EQ for the customized speaker output of Google Celes

Signed-off-by Oder Chiou <[email protected]>

---
 include/sound/rt5645.h    |  1 +
 sound/soc/codecs/rt5645.c | 86 ++++++++++++++++++++++++++++++++++++++++++++++-
 2 files changed, 86 insertions(+), 1 deletion(-)

include/sound/rt5645.h +1 -0

index a5cf615..42f0842 100644
@@ -23,6 +23,7 @@ struct rt5645_platform_data {
 	unsigned int jd_mode;
 	/* Invert JD when jack insert */
 	bool jd_invert;
+	bool hweq;
 };
 
 #endif

sound/soc/codecs/rt5645.c +85 -1

137 lines not on this page · raw message

Signature · 1 line

1.8.1.1.439.g50a6b54

Mark Brown

maintainer

2015-10-12 16:45 UTC #1 lore raw

sound/soc/codecs/rt5645.c static int is_using_asrc(struct snd_soc_dapm_widget *source, · line 656

Quoted 5 lines · Oder Chiou

sound/soc/codecs/rt5645.c +5 -0

+	if (!request_firmware(&fw, "rt5645_hweq.bin", codec->dev)) {
+		rt5645->hweq.num = fw->size / sizeof(struct rt5645_eq_param_s);
+		rt5645->hweq.param = devm_kmemdup(codec->dev, fw->data,
+					fw->size, GFP_KERNEL);
+		if (rt5645->hweq.param) {

I was expecting to see an ALSA binary control (I believe I explicitly mentioned that...). Why move to firmware? If nothing else it's more cumbersome during tuning.