Skip to contentSkip to conversation

x86/io_apic: suppress compiler warning

PATCH In review Andy Shevchenko 2 participants 2 messages Oct 8, 2015 – Oct 9, 2015 x86

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 x86/io_apic: suppress compiler warning

We have to define internally used function as static, otherwise the following warning will be generated:

arch/x86/kernel/apic/io_apic.c:532:6: warning: no previous prototype for ‘eoi_ioapic_pin’ [-Wmissing-prototypes]

---
 arch/x86/kernel/apic/io_apic.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/x86/kernel/apic/io_apic.c +1 -1
index 5c60bb1..b5a0e3c 100644
@@ -529,7 +529,7 @@ static void __eoi_ioapic_pin(int apic, int pin, int vector)
 	}
 }
 
-void eoi_ioapic_pin(int vector, struct mp_chip_data *data)
+static void eoi_ioapic_pin(int vector, struct mp_chip_data *data)
 {
 	unsigned long flags;
 	struct irq_pin_list *entry;
Signature · 1 line
2.5.3
Reviewed-by on v1 1/1
#1 lore raw
Quoted 4 lines · Andy Shevchenko

We have to define internally used function as static, otherwise the following warning will be generated:

arch/x86/kernel/apic/io_apic.c:532:6: warning: no previous prototype for ‘eoi_ioapic_pin’ [-Wmissing-prototypes]

Hi Andy,
Thanks for fixing this.

Quoted 20 lines
---
 arch/x86/kernel/apic/io_apic.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/x86/kernel/apic/io_apic.c +1 -1
index 5c60bb1..b5a0e3c 100644
@@ -529,7 +529,7 @@ static void __eoi_ioapic_pin(int apic, int pin, int vector)
 	}
 }
 
-void eoi_ioapic_pin(int vector, struct mp_chip_data *data)
+static void eoi_ioapic_pin(int vector, struct mp_chip_data *data)
 {
 	unsigned long flags;
 	struct irq_pin_list *entry;