x86/io_apic: suppress compiler warning
PATCH 1/1 x86/io_apic: suppress compiler warning
We have to define internally used function as static, otherwise the following warning will be generated:
arch/x86/kernel/apic/io_apic.c:532:6: warning: no previous prototype for ‘eoi_ioapic_pin’ [-Wmissing-prototypes]
Signed-off-by Andy Shevchenko <[email protected]>
--- arch/x86/kernel/apic/io_apic.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/x86/kernel/apic/io_apic.c +1 -1
@@ -529,7 +529,7 @@ static void __eoi_ioapic_pin(int apic, int pin, int vector) } } -void eoi_ioapic_pin (int vector,struct mp_chip_data *data) +static void eoi_ioapic_pin (int vector,struct mp_chip_data *data) {unsigned long flags;struct irq_pin_list *entry;
Signature · 1 line
2.5.3
Quoted 4 lines · Andy Shevchenko
We have to define internally used function as static, otherwise the following warning will be generated:
arch/x86/kernel/apic/io_apic.c:532:6: warning: no previous prototype for ‘eoi_ioapic_pin’ [-Wmissing-prototypes]
Hi Andy,
Thanks for fixing this.
Reviewed-by Jiang Liu <[email protected]>
Quoted 20 lines
Signed-off-by Andy Shevchenko <[email protected]>--- arch/x86/kernel/apic/io_apic.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)arch/x86/kernel/apic/io_apic.c +1
-1@@ -529,7 +529,7 @@ static void __eoi_ioapic_pin(int apic, int pin, int vector) } } -void eoi_ioapic_pin (int vector,struct mp_chip_data *data) +static void eoi_ioapic_pin (int vector,struct mp_chip_data *data) {unsigned long flags;struct irq_pin_list *entry;