Staging: rtl8712: Fix coding style warnings

Put constant on the right side of a test.Problem found using checkpatch:

Warning:Comparisons should place the constant on the right side of the test

Signed-off-by Punit Vara <[email protected]>

---
 drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

Quoted 8 lines · Punit Vara

Put constant on the right side of a test.Problem found using checkpatch:

Warning:Comparisons should place the constant on the right side of the test

Signed-off-by Punit Vara <[email protected]>

---
 drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

Didn't apply to my tree :(

Quoted 5 lines · Greg KH

Quoted 4 lines · Punit Vara

Put constant on the right side of a test.Problem found using checkpatch:

Warning:Comparisons should place the constant on the right side of the test

Quoted 6 lines

Quoted 4 lines

Signed-off-by Punit Vara <[email protected]>

---
 drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

Didn't apply to my tree :(

In this case what should I do ? Should I do git reset , git pull and then do changes on latest tree ?

Hi,

Greg is probably trying to apply this series to the staging-next branch of his staging tree[0]
so you need to clone that one, or add it as an additional remote[1] to your clone of the kernel tree (much better option IMHO). After this you need to rebase[2] your changes onto the stating-next branch, fix up all conflicts in your code, and resend the patch.

I hope this helps

Tillmann

[0] https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git
[1] https://git-scm.com/book/en/v2/Git-Basics-Working-with-Remotes
[2] https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git

Quoted 5 lines · Greg KH

Quoted 4 lines · Punit Vara

Put constant on the right side of a test.Problem found using checkpatch:

Warning:Comparisons should place the constant on the right side of the test

Quoted 6 lines

Quoted 4 lines

Signed-off-by Punit Vara <[email protected]>

---
 drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

Didn't apply to my tree :(

In this case what should I do ? Should I do git reset , git pull and then do changes on latest tree ?

One more thing I would like suggestion how can start switching this driver to LIB80211 ,MAC80211 ? Which is the first file I should focus ? Simultaneously I am trying to understand the flow of driver . I would like to know the start point from where I can start doing small changes.

Quoted 5 lines · punit vara

One more thing I would like suggestion how can start switching this driver to LIB80211 ,MAC80211 ? Which is the first file I should focus ? Simultaneously I am trying to understand the flow of driver . I would like to know the start point from where I can start doing small changes.

If you don't understand the wireless stack, I suggest you do some research on it first, converting a driver to the in-kernel stack is a _very_ difficult thing and not something that someone without any experience in this area is going to be able to do easily.

Quoted 10 lines · Greg KH

Quoted 6 lines · punit vara

One more thing I would like suggestion how can start switching this driver to LIB80211 ,MAC80211 ? Which is the first file I should focus ? Simultaneously I am trying to understand the flow of driver . I would like to know the start point from where I can start doing small changes.

Quoted 4 lines

If you don't understand the wireless stack, I suggest you do some research on it first, converting a driver to the in-kernel stack is a _very_ difficult thing and not something that someone without any experience in this area is going to be able to do easily.

I second this suggestion. Your skill level is not nearly sufficient for this sort of task. Note that there is a group working on driver rtl8192su, which should be able to replace rtl8712u. The participants are very highly skilled wireless developers; however, they are having trouble. The internals of the Realtek chips are not revealed to anyone in any form other than the code they release.

Larry

Quoted 17 lines · Larry Finger

Quoted 10 lines · Greg KH

Quoted 6 lines · punit vara

One more thing I would like suggestion how can start switching this driver to LIB80211 ,MAC80211 ? Which is the first file I should focus ? Simultaneously I am trying to understand the flow of driver . I would like to know the start point from where I can start doing small changes.

Quoted 4 lines

If you don't understand the wireless stack, I suggest you do some research on it first, converting a driver to the in-kernel stack is a _very_ difficult thing and not something that someone without any experience in this area is going to be able to do easily.

Quoted 10 lines

I second this suggestion. Your skill level is not nearly sufficient for this sort of task. Note that there is a group working on driver rtl8192su, which should be able to replace rtl8712u. The participants are very highly skilled wireless developers; however, they are having trouble. The internals of the Realtek chips are not revealed to anyone in any form other than the code they release.

Larry

Thank you Larry ,Tillman , Greg for your valuable suggestions. I am interested to learn wireless stack .I have already read wireless wiki documentation , sort of rtl8712 code , cfg80112 APIs . Yeah I agree with you Greg and Larry that its _very_ difficult to thing to convert driver in kernel and also rtl8712 has more files compare to others. Anyway however difficult or tough it may be but I have to go through it once to become highly skilled or good engineer . I would give it a try even if I will fail I believe at least 1% of my knowledge will be improved . More suggestions are welcome.

I have did

git remote add gregkh
http://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git

git pull gregkh

git rebase my_local_branch

I have got some conflicts .I can solve them but they are too many . I am trying to solve it . After that I will soon resend this patch.

Thanks

Quoted 52 lines · punit vara

Quoted 17 lines · Larry Finger

Quoted 10 lines · Greg KH

Quoted 6 lines · punit vara

One more thing I would like suggestion how can start switching this driver to LIB80211 ,MAC80211 ? Which is the first file I should focus ? Simultaneously I am trying to understand the flow of driver . I would like to know the start point from where I can start doing small changes.

Quoted 4 lines

If you don't understand the wireless stack, I suggest you do some research on it first, converting a driver to the in-kernel stack is a _very_ difficult thing and not something that someone without any experience in this area is going to be able to do easily.

Quoted 10 lines

I second this suggestion. Your skill level is not nearly sufficient for this sort of task. Note that there is a group working on driver rtl8192su, which should be able to replace rtl8712u. The participants are very highly skilled wireless developers; however, they are having trouble. The internals of the Realtek chips are not revealed to anyone in any form other than the code they release.

Larry

Thank you Larry ,Tillman , Greg for your valuable suggestions. I am interested to learn wireless stack .I have already read wireless wiki documentation , sort of rtl8712 code , cfg80112 APIs . Yeah I agree with you Greg and Larry that its _very_ difficult to thing to convert driver in kernel and also rtl8712 has more files compare to others. Anyway however difficult or tough it may be but I have to go through it once to become highly skilled or good engineer . I would give it a try even if I will fail I believe at least 1% of my knowledge will be improved . More suggestions are welcome.

I have did

git remote add gregkh
http://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git

git pull gregkh

git rebase my_local_branch

I have got some conflicts .I can solve them but they are too many . I am trying to solve it . After that I will soon resend this patch.

Quoted 1 line

Thanks

@Greg KH
I am working on linux-next .I have tried to rebase my local branch on your staging tree but I am getting too many conflict .and I have tried to clone your staging tree separately but due slow internet I am unable to clone it fully . Is there any other way I can get your staging tree by downloading ?

I am working on linux-next .I have tried to rebase my local branch on your staging tree but I am getting too many conflict .and I have tried to clone your staging tree separately but due slow internet I am unable to clone it fully . Is there any other way I can get your staging tree by downloading ?

Quoted 5 lines · punit vara

I am working on linux-next .I have tried to rebase my local branch on your staging tree but I am getting too many conflict .and I have tried to clone your staging tree separately but due slow internet I am unable to clone it fully . Is there any other way I can get your staging tree by downloading ?

For a while, I had the worst internet of any kernel dev. I can help. :)

Do you have any complete kernel git repository? If you download it one time then you just do a git fetch and git checkout after that. Never do a git pull.

Downloading the linux kernel git repository the first time over bad internet is a huge headache because if you lose the connection then you have to restart. See if someone can post a .tar.gz of the kernel .git directory on a webpage for you then you can download it bit by bit using wget. Unpack it and do a git reset --hard.

regards,
dan carpenter

Quoted 1 line

git branch -a

Quoted 1 line

git remote -v

Quoted 5 lines

git checkout origin/master

git checkout -b experimental origin/master

git fetch gregkh

First fetch the changes, then check them out.

$ git fetch git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git staging-next
$ git checkout FETCH_HEAD

regards,
dan carpenter