extcon: arizona: Add extcon specific device tree binding document

PATCH Superseded Charles Keepax 2 participants 5 messages Oct 15, 2015 – Oct 26, 2015

Subsystems (4)

Device tree bindings Multifunction devices (MFD) Voltage and current regulator framework External connector subsystem (extcon)

lore

Share & tools

lore

Charles Keepax

author

2015-10-15 13:47 UTC #0 lore raw

PATCH v2 1/3 extcon: arizona: Add extcon specific device tree binding document

Subystem specific bindings for the Arizona devices are being factored out of the MFD binding document into seperate documents for each subsystem. This patch adds a binding document that covers the existing extcon specific bindings.

Acked-by Chanwoo Choi <[email protected]>

Signed-off-by Charles Keepax <ckeepax-yzvPICuk2AATkU/[email protected]>

---

Changes since v1:
- Added more commit message

Thanks,
Charles

 .../devicetree/bindings/extcon/extcon-arizona.txt  |   15 +++++++++++++++
 MAINTAINERS                                        |    1 +
 2 files changed, 16 insertions(+), 0 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/extcon/extcon-arizona.txt

Documentation/devicetree/bindings/extcon/extcon-arizona.txt new file +15 -0

new file mode 100644
index 0000000..e1705fa
@@ -0,0 +1,15 @@
+Cirrus Logic Arizona class audio SoCs
+
+These devices are audio SoCs with extensive digital capabilities and a range
+of analogue I/O.
+
+This document lists Extcon specific bindings, see the primary binding document:
+  ../mfd/arizona.txt
+
+Optional properties:
+
+  - wlf,hpdet-channel : Headphone detection channel.
+    ARIZONA_ACCDET_MODE_HPL or 1 - Headphone detect mode is set to HPDETL
+    ARIZONA_ACCDET_MODE_HPR or 2 - Headphone detect mode is set to HPDETR
+    If this node is not mentioned or if the value is unknown, then
+    headphone detection mode is set to HPDETL.

MAINTAINERS +1 -0

index fb2ba3d..915f9ec 100644
@@ -11380,6 +11380,7 @@ T:	git git://opensource.wolfsonmicro.com/linux-2.6-audioplus
 W:	http://opensource.wolfsonmicro.com/content/linux-drivers-wolfson-devices
 S:	Supported
 F:	Documentation/hwmon/wm83??
+F:	Documentation/devicetree/bindings/extcon/extcon-arizona.txt
 F:	arch/arm/mach-s3c64xx/mach-crag6410*
 F:	drivers/clk/clk-wm83*.c
 F:	drivers/extcon/extcon-arizona.c

Signature · 6 lines

1.7.2.5

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Charles Keepax

author

2015-10-15 13:47 UTC #1 lore raw

PATCH v2 2/3 regulator: arizona: Add regulator specific device tree binding document

Signed-off-by Charles Keepax <[email protected]>

---

Changes since v1:
- Added more commit message

Thanks,
Charles

 .../bindings/regulator/arizona-regulator.txt       |   34 ++++++++++++++++++++
 MAINTAINERS                                        |    1 +
 2 files changed, 35 insertions(+), 0 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/regulator/arizona-regulator.txt

Documentation/devicetree/bindings/regulator/arizona-regulator.txt new file +34 -0

new file mode 100644
index 0000000..25bb7f3
@@ -0,0 +1,34 @@
+Cirrus Logic Arizona class audio SoCs
+
+These devices are audio SoCs with extensive digital capabilities and a range
+of analogue I/O.
+
+This document lists regulator specific bindings, see the primary binding
+document:
+  ../mfd/arizona.txt
+
+Required properties:
+
+  - AVDD-supply, DBVDD1-supply, CPVDD-supply : Power supplies for the device,
+    as covered in regulator.txt
+
+  - DBVDD2-supply, DBVDD3-supply : Additional databus power supplies (wm5102,
+    wm5110, wm8280, wm8998, wm1814)
+
+  - SPKVDDL-supply, SPKVDDR-supply : Speaker driver power supplies (wm5102,
+    wm5110, wm8280, wm8998, wm1814)
+
+  - SPKVDD-supply : Speaker driver power supply (wm8997)
+
+Optional properties:
+  - wlf,ldoena : GPIO specifier for the GPIO controlling LDOENA
+
+  - DCVDD-supply, MICVDD-supply : Power supplies, only need to be specified if
+    they are being externally supplied. As covered in
+    Documentation/devicetree/bindings/regulator/regulator.txt
+
+Optional subnodes:
+  - ldo1 : Initial data for the LDO1 regulator, as covered in
+    Documentation/devicetree/bindings/regulator/regulator.txt
+  - micvdd : Initial data for the MICVDD regulator, as covered in
+    Documentation/devicetree/bindings/regulator/regulator.txt

MAINTAINERS +1 -0

index 915f9ec..0e0889b 100644
@@ -11381,6 +11381,7 @@ W:	http://opensource.wolfsonmicro.com/content/linux-drivers-wolfson-devices
 S:	Supported
 F:	Documentation/hwmon/wm83??
 F:	Documentation/devicetree/bindings/extcon/extcon-arizona.txt
+F:	Documentation/devicetree/bindings/regulator/arizona-regulator.txt
 F:	arch/arm/mach-s3c64xx/mach-crag6410*
 F:	drivers/clk/clk-wm83*.c
 F:	drivers/extcon/extcon-arizona.c

Signature · 1 line

1.7.2.5

Mark Brown

maintainer

2015-10-22 12:44 UTC #2 lore raw

Re: [PATCH v2 2/3] regulator: arizona: Add regulator specific device tree binding document

Quoted 7 lines · Charles Keepax

Documentation/devicetree/bindings/regulator/arizona-regulator.txt new file +7 -0

+This document lists regulator specific bindings, see the primary binding
+document:
+  ../mfd/arizona.txt
+
+Required properties:
+
+  - AVDD-supply, DBVDD1-supply, CPVDD-supply : Power supplies for the device,

Documentation/devicetree/bindings/regulator/arizona-regulator.txt line 22

Quoted 10 lines

Documentation/devicetree/bindings/regulator/arizona-regulator.txt new file +10 -0

+    as covered in regulator.txt
+
+  - DBVDD2-supply, DBVDD3-supply : Additional databus power supplies (wm5102,
+    wm5110, wm8280, wm8998, wm1814)
+
+  - SPKVDDL-supply, SPKVDDR-supply : Speaker driver power supplies (wm5102,
+    wm5110, wm8280, wm8998, wm1814)
+
+  - SPKVDD-supply : Speaker driver power supply (wm8997)
+

I'd expect these to be on the MFD since they're (with the exception of AVDD which supplies the regulators IIRC) not part of the regulator component of the device and are core for bringing it online.

Documentation/devicetree/bindings/regulator/arizona-regulator.txt line 34

Quoted 8 lines

Documentation/devicetree/bindings/regulator/arizona-regulator.txt new file +8 -0

+Optional properties:
+  - wlf,ldoena : GPIO specifier for the GPIO controlling LDOENA
+
+Optional subnodes:
+  - ldo1 : Initial data for the LDO1 regulator, as covered in
+    Documentation/devicetree/bindings/regulator/regulator.txt
+  - micvdd : Initial data for the MICVDD regulator, as covered in
+    Documentation/devicetree/bindings/regulator/regulator.txt

These are the properties for the regulator itself.

MAINTAINERS W: http://opensource.wolfsonmicro.com/content/linux-drivers-wolfson-devices · line 11387

Quoted 9 lines

+++ b/MAINTAINERS

MAINTAINERS +1 -0

@@ -11381,6 +11381,7 @@ W:	http://opensource.wolfsonmicro.com/content/linux-drivers-wolfson-devices
 S:	Supported
 F:	Documentation/hwmon/wm83??
 F:	Documentation/devicetree/bindings/extcon/extcon-arizona.txt
+F:	Documentation/devicetree/bindings/regulator/arizona-regulator.txt
 F:	arch/arm/mach-s3c64xx/mach-crag6410*
 F:	drivers/clk/clk-wm83*.c
 F:	drivers/extcon/extcon-arizona.c

I'd suggest moving this to a separate patch which adds all the new files together to make it easier to merge things.

Charles Keepax

author

2015-10-26 11:28 UTC #3 lore raw

Re: [PATCH v2 2/3] regulator: arizona: Add regulator specific device tree binding document

Quoted 15 lines · Mark Brown

Quoted 13 lines · Charles Keepax

Documentation/devicetree/bindings/regulator/arizona-regulator.txt new file +13 -0

+This document lists regulator specific bindings, see the primary binding
+document:
+  ../mfd/arizona.txt
+
+Required properties:
+
+  - AVDD-supply, DBVDD1-supply, CPVDD-supply : Power supplies for the device,
+    as covered in regulator.txt
+
+  - DBVDD2-supply, DBVDD3-supply : Additional databus power supplies (wm5102,
+    wm5110, wm8280, wm8998, wm1814)
+
+  - SPKVDDL-supply, SPKVDDR-supply : Speaker driver power supplies (wm5102,

Quoted 8 lines

Documentation/devicetree/bindings/regulator/arizona-regulator.txt line 22
Quoted 4 lines
Documentation/devicetree/bindings/regulator/arizona-regulator.txt new file +4 -0
+    wm5110, wm8280, wm8998, wm1814)
+
+  - SPKVDD-supply : Speaker driver power supply (wm8997)
+
I'd expect these to be on the MFD since they're (with the exception of AVDD which supplies the regulators IIRC) not part of the regulator component of the device and are core for bringing it online.

Yeah, fair enough I will move those back into the MFD part.

Quoted 12 lines

Documentation/devicetree/bindings/regulator/arizona-regulator.txt line 34
Quoted 9 lines
Documentation/devicetree/bindings/regulator/arizona-regulator.txt new file +8 -0
+Optional properties:
+  - wlf,ldoena : GPIO specifier for the GPIO controlling LDOENA
+
+Optional subnodes:
+  - ldo1 : Initial data for the LDO1 regulator, as covered in
+    Documentation/devicetree/bindings/regulator/regulator.txt
+  - micvdd : Initial data for the MICVDD regulator, as covered in
+    Documentation/devicetree/bindings/regulator/regulator.txt
These are the properties for the regulator itself.

Quoted 12 lines

MAINTAINERS W: http://opensource.wolfsonmicro.com/content/linux-drivers-wolfson-devices · line 11387
Quoted 9 lines
+++ b/MAINTAINERS
MAINTAINERS +1 -0
@@ -11381,6 +11381,7 @@ W:	http://opensource.wolfsonmicro.com/content/linux-drivers-wolfson-devices
 S:	Supported
 F:	Documentation/hwmon/wm83??
 F:	Documentation/devicetree/bindings/extcon/extcon-arizona.txt
+F:	Documentation/devicetree/bindings/regulator/arizona-regulator.txt
 F:	arch/arm/mach-s3c64xx/mach-crag6410*
 F:	drivers/clk/clk-wm83*.c
 F:	drivers/extcon/extcon-arizona.c
I'd suggest moving this to a separate patch which adds all the new files together to make it easier to merge things.

Yeah no problem with making that a seperate patch.

Thanks,
Charles
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html

Charles Keepax

author

2015-10-15 13:47 UTC #4 lore raw

PATCH v2 3/3 mfd: arizona: Remove bindings covered in new subsystem specific docs

In reply to Charles Keepax

Binding documentation has been added in new subsystem specific binding documents. This patch removes the now duplicate documentation from the MFD documentation. Also whilst we are at it add a missing maintainers entry for the MFD binding document.

Signed-off-by Charles Keepax <ckeepax-yzvPICuk2AATkU/[email protected]>

Acked-by Lee Jones <[email protected]>

---

No change since v1.

Thanks,
Charles

 Documentation/devicetree/bindings/mfd/arizona.txt |   30 ++------------------
 MAINTAINERS                                       |    1 +
 2 files changed, 4 insertions(+), 27 deletions(-)

Documentation/devicetree/bindings/mfd/arizona.txt +3 ~~-27~~

index a8fee60..077c4fe 100644
@@ -30,21 +30,9 @@ Required properties:
   - #gpio-cells : Must be 2. The first cell is the pin number and the
     second cell is used to specify optional parameters (currently unused).
 
-  - AVDD-supply, DBVDD1-supply, CPVDD-supply : Power supplies for the device,
-    as covered in Documentation/devicetree/bindings/regulator/regulator.txt
-
-  - DBVDD2-supply, DBVDD3-supply : Additional databus power supplies (wm5102,
-    wm5110, wm8280, wm8998, wm1814)
-
-  - SPKVDDL-supply, SPKVDDR-supply : Speaker driver power supplies (wm5102,
-    wm5110, wm8280, wm8998, wm1814)
-
-  - SPKVDD-supply : Speaker driver power supply (wm8997)
-
 Optional properties:
 
   - wlf,reset : GPIO specifier for the GPIO controlling /RESET
-  - wlf,ldoena : GPIO specifier for the GPIO controlling LDOENA
 
   - wlf,gpio-defaults : A list of GPIO configuration register values. Defines
     for the appropriate values can found in <dt-bindings/mfd/arizona.txt>. If

@@ -67,21 +55,9 @@ Optional properties:
     present, the number of values should be less than or equal to the
     number of inputs, unspecified inputs will use the chip default.
 
-  - wlf,hpdet-channel : Headphone detection channel.
-    ARIZONA_ACCDET_MODE_HPL or 1 - Headphone detect mode is set to HPDETL
-    ARIZONA_ACCDET_MODE_HPR or 2 - Headphone detect mode is set to HPDETR
-    If this node is not mentioned or if the value is unknown, then
-    headphone detection mode is set to HPDETL.
-
-  - DCVDD-supply, MICVDD-supply : Power supplies, only need to be specified if
-    they are being externally supplied. As covered in
-    Documentation/devicetree/bindings/regulator/regulator.txt
-
-Optional subnodes:
-  - ldo1 : Initial data for the LDO1 regulator, as covered in
-    Documentation/devicetree/bindings/regulator/regulator.txt
-  - micvdd : Initial data for the MICVDD regulator, as covered in
-    Documentation/devicetree/bindings/regulator/regulator.txt
+Also see child specific device properties:
+  Regulator - ../regulator/arizona-regulator.txt
+  Extcon    - ../extcon/extcon-arizona.txt
 
 Example:

MAINTAINERS +1 -0

index 0e0889b..047f5d8 100644
@@ -11382,6 +11382,7 @@ S:	Supported
 F:	Documentation/hwmon/wm83??
 F:	Documentation/devicetree/bindings/extcon/extcon-arizona.txt
 F:	Documentation/devicetree/bindings/regulator/arizona-regulator.txt
+F:	Documentation/devicetree/bindings/mfd/arizona.txt
 F:	arch/arm/mach-s3c64xx/mach-crag6410*
 F:	drivers/clk/clk-wm83*.c
 F:	drivers/extcon/extcon-arizona.c

Signature · 6 lines

1.7.2.5

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html