Skip to contentSkip to conversation

extcon: arizona: Add extcon specific device tree binding document

PATCH Applied Charles Keepax 3 participants 12 messages Oct 27, 2015 – Oct 28, 2015

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH v3 1/4 extcon: arizona: Add extcon specific device tree binding document

Subsystem specific bindings for the Arizona devices are being factored out of the MFD binding document into separate documents for each subsystem. This patch adds a binding document that covers the existing extcon specific bindings.

---

Changes since v2:
- Moved the maintainer updates into a separate patch

Thanks,
Charles

 .../devicetree/bindings/extcon/extcon-arizona.txt  |   15 +++++++++++++++
 1 files changed, 15 insertions(+), 0 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/extcon/extcon-arizona.txt
Documentation/devicetree/bindings/extcon/extcon-arizona.txt new file +15 -0
new file mode 100644
index 0000000..e1705fa
@@ -0,0 +1,15 @@
+Cirrus Logic Arizona class audio SoCs
+
+These devices are audio SoCs with extensive digital capabilities and a range
+of analogue I/O.
+
+This document lists Extcon specific bindings, see the primary binding document:
+  ../mfd/arizona.txt
+
+Optional properties:
+
+  - wlf,hpdet-channel : Headphone detection channel.
+    ARIZONA_ACCDET_MODE_HPL or 1 - Headphone detect mode is set to HPDETL
+    ARIZONA_ACCDET_MODE_HPR or 2 - Headphone detect mode is set to HPDETR
+    If this node is not mentioned or if the value is unknown, then
+    headphone detection mode is set to HPDETL.
Signature · 1 line
1.7.2.5
#1 lore raw

PATCH v3 2/4 regulator: arizona: Add regulator specific device tree binding document

Subsystem specific bindings for the Arizona devices are being factored out of the MFD binding document into separate documents for each subsystem. This patch adds a binding document that covers the existing regulator specific bindings.

---

Changes since v2:
- Moved the core regulators back into the MFD component
- Moved the maintainer updates into a separate patch

Thanks,
Charles

 .../bindings/regulator/arizona-regulator.txt       |   17 +++++++++++++++++
 1 files changed, 17 insertions(+), 0 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/regulator/arizona-regulator.txt
Documentation/devicetree/bindings/regulator/arizona-regulator.txt new file +17 -0
new file mode 100644
index 0000000..443564d
@@ -0,0 +1,17 @@
+Cirrus Logic Arizona class audio SoCs
+
+These devices are audio SoCs with extensive digital capabilities and a range
+of analogue I/O.
+
+This document lists regulator specific bindings, see the primary binding
+document:
+  ../mfd/arizona.txt
+
+Optional properties:
+  - wlf,ldoena : GPIO specifier for the GPIO controlling LDOENA
+
+Optional subnodes:
+  - ldo1 : Initial data for the LDO1 regulator, as covered in
+    Documentation/devicetree/bindings/regulator/regulator.txt
+  - micvdd : Initial data for the MICVDD regulator, as covered in
+    Documentation/devicetree/bindings/regulator/regulator.txt
Signature · 1 line
1.7.2.5
#2 lore raw

PATCH v3 3/4 mfd: arizona: Remove bindings covered in new subsystem specific docs

In reply to Charles Keepax

Binding documentation has been added in new subsystem specific binding documents. This patch removes the now duplicate documentation from the MFD documentation.

---

Changes since v2:
- No longer moving the core regulators into the regulator binding document, as they are properties of the device as a whole not just the regulators
- Moved the maintainer updates into a seperate patch

Lee, I have removed your ack because the patch has changed a fair amount. Apologies if this would not have been your preference.

Thanks,
Charles

 Documentation/devicetree/bindings/mfd/arizona.txt |   15 +++------------
 1 files changed, 3 insertions(+), 12 deletions(-)
Documentation/devicetree/bindings/mfd/arizona.txt +3 -12
index a8fee60..18be0cb 100644
@@ -44,7 +44,6 @@ Required properties:
 Optional properties:
 
   - wlf,reset : GPIO specifier for the GPIO controlling /RESET
-  - wlf,ldoena : GPIO specifier for the GPIO controlling LDOENA
 
   - wlf,gpio-defaults : A list of GPIO configuration register values. Defines
     for the appropriate values can found in <dt-bindings/mfd/arizona.txt>. If
@@ -67,21 +66,13 @@ Optional properties:
     present, the number of values should be less than or equal to the
     number of inputs, unspecified inputs will use the chip default.
 
-  - wlf,hpdet-channel : Headphone detection channel.
-    ARIZONA_ACCDET_MODE_HPL or 1 - Headphone detect mode is set to HPDETL
-    ARIZONA_ACCDET_MODE_HPR or 2 - Headphone detect mode is set to HPDETR
-    If this node is not mentioned or if the value is unknown, then
-    headphone detection mode is set to HPDETL.
-
   - DCVDD-supply, MICVDD-supply : Power supplies, only need to be specified if
     they are being externally supplied. As covered in
     Documentation/devicetree/bindings/regulator/regulator.txt
 
-Optional subnodes:
-  - ldo1 : Initial data for the LDO1 regulator, as covered in
-    Documentation/devicetree/bindings/regulator/regulator.txt
-  - micvdd : Initial data for the MICVDD regulator, as covered in
-    Documentation/devicetree/bindings/regulator/regulator.txt
+Also see child specific device properties:
+  Regulator - ../regulator/arizona-regulator.txt
+  Extcon    - ../extcon/extcon-arizona.txt
 
 Example:
 
Signature · 1 line
1.7.2.5
Applied
#3 lore raw

Re: [PATCH v3 3/4] mfd: arizona: Remove bindings covered in new subsystem specific docs

Quoted 7 lines · Charles Keepax

Binding documentation has been added in new subsystem specific binding documents. This patch removes the now duplicate documentation from the MFD documentation.

---

Quoted 7 lines

Changes since v2:
- No longer moving the core regulators into the regulator binding document, as they are properties of the device as a whole not just the regulators
- Moved the maintainer updates into a seperate patch

Lee, I have removed your ack because the patch has changed a fair amount. Apologies if this would not have been your preference.

That was the right thing to do.

Quoted 5 lines

Thanks,
Charles

 Documentation/devicetree/bindings/mfd/arizona.txt |   15 +++------------
 1 files changed, 3 insertions(+), 12 deletions(-)

Applied, thanks.

Quoted 37 lines
Documentation/devicetree/bindings/mfd/arizona.txt +3 -12
index a8fee60..18be0cb 100644
@@ -44,7 +44,6 @@ Required properties:
 Optional properties:
 
   - wlf,reset : GPIO specifier for the GPIO controlling /RESET
-  - wlf,ldoena : GPIO specifier for the GPIO controlling LDOENA
 
   - wlf,gpio-defaults : A list of GPIO configuration register values. Defines
     for the appropriate values can found in <dt-bindings/mfd/arizona.txt>. If
@@ -67,21 +66,13 @@ Optional properties:
     present, the number of values should be less than or equal to the
     number of inputs, unspecified inputs will use the chip default.
 
-  - wlf,hpdet-channel : Headphone detection channel.
-    ARIZONA_ACCDET_MODE_HPL or 1 - Headphone detect mode is set to HPDETL
-    ARIZONA_ACCDET_MODE_HPR or 2 - Headphone detect mode is set to HPDETR
-    If this node is not mentioned or if the value is unknown, then
-    headphone detection mode is set to HPDETL.
-
   - DCVDD-supply, MICVDD-supply : Power supplies, only need to be specified if
     they are being externally supplied. As covered in
     Documentation/devicetree/bindings/regulator/regulator.txt
 
-Optional subnodes:
-  - ldo1 : Initial data for the LDO1 regulator, as covered in
-    Documentation/devicetree/bindings/regulator/regulator.txt
-  - micvdd : Initial data for the MICVDD regulator, as covered in
-    Documentation/devicetree/bindings/regulator/regulator.txt
+Also see child specific device properties:
+  Regulator - ../regulator/arizona-regulator.txt
+  Extcon    - ../extcon/extcon-arizona.txt
 
 Example:
 
Signature · 4 lines
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
maintainer
#4 lore raw

Re: [PATCH v3 3/4] mfd: arizona: Remove bindings covered in new subsystem specific docs

Hi Lee,

Quoted 19 lines · Lee Jones
Quoted 7 lines · Charles Keepax

Binding documentation has been added in new subsystem specific binding documents. This patch removes the now duplicate documentation from the MFD documentation.

---

Quoted 7 lines

Changes since v2:
- No longer moving the core regulators into the regulator binding document, as they are properties of the device as a whole not just the regulators
- Moved the maintainer updates into a seperate patch

Lee, I have removed your ack because the patch has changed a fair amount. Apologies if this would not have been your preference.

That was the right thing to do.

Quoted 7 lines
Quoted 5 lines

Thanks,
Charles

 Documentation/devicetree/bindings/mfd/arizona.txt |   15 +++------------
 1 files changed, 3 insertions(+), 12 deletions(-)

Applied, thanks.

If you possible, could you pick patch1[1] which has already the acked tag of me?
[1] [PATCH v3 1/4] extcon: arizona: Add extcon specific device tree binding document

Thanks,
Chanwoo Choi
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html

#5 lore raw

Re: [PATCH v3 3/4] mfd: arizona: Remove bindings covered in new subsystem specific docs

Quoted 23 lines · Chanwoo Choi
Quoted 22 lines · Lee Jones
Quoted 7 lines · Charles Keepax

Binding documentation has been added in new subsystem specific binding documents. This patch removes the now duplicate documentation from the MFD documentation.

---

Quoted 7 lines

Changes since v2:
- No longer moving the core regulators into the regulator binding document, as they are properties of the device as a whole not just the regulators
- Moved the maintainer updates into a seperate patch

Lee, I have removed your ack because the patch has changed a fair amount. Apologies if this would not have been your preference.

That was the right thing to do.

Quoted 3 lines

Thanks,
Charles

Quoted 7 lines
Quoted 4 lines
Quoted 2 lines
 Documentation/devicetree/bindings/mfd/arizona.txt |   15 +++------------
 1 files changed, 3 insertions(+), 12 deletions(-)

Applied, thanks.

If you possible, could you pick patch1[1] which has already the acked tag of me?
[1] [PATCH v3 1/4] extcon: arizona: Add extcon specific device tree binding document

Yes, no problem.

Signature · 4 lines
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
#6 lore raw

PATCH v3 4/4 MAINTAINERS: Add binding docs for Cirrus Logic/Wolfson Arizona devices

In reply to Charles Keepax

Add device tree binding documentation for the Arizona drivers to the MAINTAINERS file.

---

Changes since v2:
- Moved all the maintainer updates into this patch

Thanks,
Charles

 MAINTAINERS |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)
MAINTAINERS +3 -0
index 0658fec..4dc45de 100644
@@ -11392,6 +11392,9 @@ T:	git https://github.com/CirrusLogic/linux-drivers.git
 W:	https://github.com/CirrusLogic/linux-drivers/wiki
 S:	Supported
 F:	Documentation/hwmon/wm83??
+F:	Documentation/devicetree/bindings/extcon/extcon-arizona.txt
+F:	Documentation/devicetree/bindings/regulator/arizona-regulator.txt
+F:	Documentation/devicetree/bindings/mfd/arizona.txt
 F:	arch/arm/mach-s3c64xx/mach-crag6410*
 F:	drivers/clk/clk-wm83*.c
 F:	drivers/extcon/extcon-arizona.c
Signature · 6 lines
1.7.2.5

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Acked-by on v3 4/4
#7 lore raw

Re: [PATCH v3 4/4] MAINTAINERS: Add binding docs for Cirrus Logic/Wolfson Arizona devices

Quoted 20 lines · Charles Keepax

Add device tree binding documentation for the Arizona drivers to the MAINTAINERS file.

---

Changes since v2:
- Moved all the maintainer updates into this patch

Thanks,
Charles

 MAINTAINERS |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)
MAINTAINERS +0 -0
index 0658fec..4dc45de 100644

MAINTAINERS T: git https://github.com/CirrusLogic/linux-drivers.git · line 11397

Quoted 6 lines
MAINTAINERS +3 -0
@@ -11392,6 +11392,9 @@ T:	git https://github.com/CirrusLogic/linux-drivers.git
 W:	https://github.com/CirrusLogic/linux-drivers/wiki
 S:	Supported
 F:	Documentation/hwmon/wm83??
+F:	Documentation/devicetree/bindings/extcon/extcon-arizona.txt
+F:	Documentation/devicetree/bindings/regulator/arizona-regulator.txt
+F:	Documentation/devicetree/bindings/mfd/arizona.txt
Quoted 3 lines
MAINTAINERS +0 -0
 F:	arch/arm/mach-s3c64xx/mach-crag6410*
 F:	drivers/clk/clk-wm83*.c
 F:	drivers/extcon/extcon-arizona.c
Signature · 8 lines
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Applied
#8 lore raw

Re: [PATCH v3 4/4] MAINTAINERS: Add binding docs for Cirrus Logic/Wolfson Arizona devices

Quoted 17 lines · Lee Jones
Quoted 15 lines · Charles Keepax

Add device tree binding documentation for the Arizona drivers to the MAINTAINERS file.

---

Changes since v2:
- Moved all the maintainer updates into this patch

Thanks,
Charles

 MAINTAINERS |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)
Quoted 13 lines

MAINTAINERS T: git https://github.com/CirrusLogic/linux-drivers.git · line 11397

Quoted 11 lines
MAINTAINERS +3 -0
index 0658fec..4dc45de 100644
@@ -11392,6 +11392,9 @@ T:	git https://github.com/CirrusLogic/linux-drivers.git
 W:	https://github.com/CirrusLogic/linux-drivers/wiki
 S:	Supported
 F:	Documentation/hwmon/wm83??
+F:	Documentation/devicetree/bindings/extcon/extcon-arizona.txt
+F:	Documentation/devicetree/bindings/regulator/arizona-regulator.txt
+F:	Documentation/devicetree/bindings/mfd/arizona.txt

Actually, this patch is so uncontroversial:

Applied, thanks.

Quoted 4 lines
Quoted 3 lines
MAINTAINERS +0 -0
 F:	arch/arm/mach-s3c64xx/mach-crag6410*
 F:	drivers/clk/clk-wm83*.c
 F:	drivers/extcon/extcon-arizona.c
Signature · 8 lines
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
maintainer Acked-by on v3 4/4
#9 lore raw

Re: [PATCH v3 4/4] MAINTAINERS: Add binding docs for Cirrus Logic/Wolfson Arizona devices

In reply to Charles Keepax

Hi Charles,

Quoted 21 lines · Charles Keepax

Add device tree binding documentation for the Arizona drivers to the MAINTAINERS file.

---

Changes since v2:
- Moved all the maintainer updates into this patch

Thanks,
Charles

 MAINTAINERS |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)
MAINTAINERS +0 -0
index 0658fec..4dc45de 100644

MAINTAINERS T: git https://github.com/CirrusLogic/linux-drivers.git · line 11400

Quoted 9 lines
MAINTAINERS +3 -0
@@ -11392,6 +11392,9 @@ T:	git https://github.com/CirrusLogic/linux-drivers.git
 W:	https://github.com/CirrusLogic/linux-drivers/wiki
 S:	Supported
 F:	Documentation/hwmon/wm83??
+F:	Documentation/devicetree/bindings/extcon/extcon-arizona.txt
+F:	Documentation/devicetree/bindings/regulator/arizona-regulator.txt
+F:	Documentation/devicetree/bindings/mfd/arizona.txt
 F:	arch/arm/mach-s3c64xx/mach-crag6410*
 F:	drivers/clk/clk-wm83*.c
 F:	drivers/extcon/extcon-arizona.c

Regards,
Chanwoo Choi

#10 lore raw

Re: [PATCH v3 4/4] MAINTAINERS: Add binding docs for Cirrus Logic/Wolfson Arizona devices

Quoted 28 lines · Chanwoo Choi

Hi Charles,

Quoted 25 lines · Charles Keepax

Add device tree binding documentation for the Arizona drivers to the MAINTAINERS file.

---

Changes since v2:
- Moved all the maintainer updates into this patch

Thanks,
Charles

 MAINTAINERS |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)
MAINTAINERS +2 -0
index 0658fec..4dc45de 100644
@@ -11392,6 +11392,9 @@ T:	git https://github.com/CirrusLogic/linux-drivers.git
 W:	https://github.com/CirrusLogic/linux-drivers/wiki
 S:	Supported
 F:	Documentation/hwmon/wm83??
+F:	Documentation/devicetree/bindings/extcon/extcon-arizona.txt
+F:	Documentation/devicetree/bindings/regulator/arizona-regulator.txt
Quoted 8 lines

MAINTAINERS T: git https://github.com/CirrusLogic/linux-drivers.git · line 11400

Quoted 5 lines
MAINTAINERS +1 -0
+F:	Documentation/devicetree/bindings/mfd/arizona.txt
 F:	arch/arm/mach-s3c64xx/mach-crag6410*
 F:	drivers/clk/clk-wm83*.c
 F:	drivers/extcon/extcon-arizona.c

Will apply this retroactively. Thanks.

Signature · 8 lines
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
#11 lore raw
In reply to Charles Keepax
Quoted 12 lines · Charles Keepax

Subsystem specific bindings for the Arizona devices are being factored out of the MFD binding document into separate documents for each subsystem. This patch adds a binding document that covers the existing extcon specific bindings.

---

Changes since v2:
- Moved the maintainer updates into a separate patch

Quoted 6 lines

Thanks,
Charles

 .../devicetree/bindings/extcon/extcon-arizona.txt  |   15 +++++++++++++++
 1 files changed, 15 insertions(+), 0 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/extcon/extcon-arizona.txt

Replied on Chanwoo's request.

Quoted 21 lines
Documentation/devicetree/bindings/extcon/extcon-arizona.txt new file +15 -0
new file mode 100644
index 0000000..e1705fa
@@ -0,0 +1,15 @@
+Cirrus Logic Arizona class audio SoCs
+
+These devices are audio SoCs with extensive digital capabilities and a range
+of analogue I/O.
+
+This document lists Extcon specific bindings, see the primary binding document:
+  ../mfd/arizona.txt
+
+Optional properties:
+
+  - wlf,hpdet-channel : Headphone detection channel.
+    ARIZONA_ACCDET_MODE_HPL or 1 - Headphone detect mode is set to HPDETL
+    ARIZONA_ACCDET_MODE_HPR or 2 - Headphone detect mode is set to HPDETR
+    If this node is not mentioned or if the value is unknown, then
+    headphone detection mode is set to HPDETL.
Signature · 4 lines
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog