Staging: sm750fb: Include appropriate KERN_ facility level
Subsystems (2)
PATCH 1/2 Staging: sm750fb: Include appropriate KERN_ facility level
Problem found using checkpatch.pl:
"WARNING: printk() should include KERN_ facility level"
--- drivers/staging/sm750fb/ddk750_help.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/sm750fb/ddk750_help.c +1 -1
@@ -11,7 +11,7 @@ void ddk750_set_mmio(void __iomem *addr, unsigned short devId, char revId) devId750 = devId; revId750 = revId;if (revId ==0xfe ) -printk ("found sm750le\n" ); +pr_info ("found sm750le\n" ); }
Signature · 1 line
1.9.1
PATCH 2/2 Staging: sm750fb: Remove multiple blank lines
Remove multiple blank lines. Problem found using checkpatch.pl
CHECK: Please don't use multiple blank lines.
--- drivers/staging/sm750fb/ddk750_help.c | 2 -- 1 file changed, 2 deletions(-)
drivers/staging/sm750fb/ddk750_help.c +0 -2
@@ -13,5 +13,3 @@ void ddk750_set_mmio(void __iomem *addr, unsigned short devId, char revId)if (revId ==0xfe )pr_info ("found sm750le\n" ); } - -
Signature · 1 line
1.9.1
Quoted 13 lines · Aybuke Ozdemir
Problem found using checkpatch.pl:
"WARNING:printk()should includeKERN_facility level"Signed-off-by Aybuke Ozdemir <[email protected]>--- drivers/staging/sm750fb/ddk750_help.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/staging/sm750fb/ddk750_help.c +0
-0
drivers/staging/sm750fb/ddk750_help.c void ddk750_set_mmio(void __iomem *addr, unsigned short devId, char revId) · line 14
Quoted 5 lines
drivers/staging/sm750fb/ddk750_help.c +1
-1@@ -11,7 +11,7 @@ void ddk750_set_mmio(void __iomem *addr, unsigned short devId, char revId) devId750 = devId; revId750 = revId;if (revId ==0xfe ) -printk ("found sm750le\n" ); +pr_info ("found sm750le\n" );
I believe that this change has been discussed already, but it seems that a satisfactory patch was never provided. The conclusion was that the function should be changed so that it receives a device-typed argument, so dev_info could be used. Maybe look at the places where ddk750_set_mmio is called, and see if such information is available.
julia
Quoted 13 lines
drivers/staging/sm750fb/ddk750_help.c +0
-0}Signature · 8 lines
1.9.1 -- You received this message because you are subscribed to the Google Groups "outreachy-kernel" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/1445023205-8484-1-git-send-email-aybuke.147%40gmail.com. For more options, visit https://groups.google.com/d/optout.