Skip to contentSkip to conversation

usb: remove unnecessary CONFIG_PM dependency from USB_OTG

PATCH Superseded Nathan Sullivan 2 participants 2 messages Oct 28, 2015 – Oct 29, 2015 USB

v3 of 4 Superseded Latest is v4 →

lore
Share & tools
lore
#0 lore raw

PATCH v3 1/1 usb: remove unnecessary CONFIG_PM dependency from USB_OTG

The USB OTG support currently depends on power management (CONFIG_PM) being enabled, but does not actually need it enabled. Remove this dependency.

Remove the unneeded "default n" from USB_OTG as well, the default is already n.

Tested on Bay Trail hardware with dwc3 USB.

---
 drivers/usb/core/Kconfig |    2 --
 1 file changed, 2 deletions(-)
drivers/usb/core/Kconfig +0 -2
index a99c89e..567454f 100644
@@ -43,8 +43,6 @@ config USB_DYNAMIC_MINORS
 
 config USB_OTG
 	bool "OTG support"
-	depends on PM
-	default n
 	help
 	  The most notable feature of USB OTG is support for a
 	  "Dual-Role" device, which can act as either a device
Signature · 1 line
1.7.10.4
#1 lore raw
Quoted 6 lines · Nathan Sullivan

The USB OTG support currently depends on power management (CONFIG_PM) being enabled, but does not actually need it enabled. Remove this dependency.

Remove the unneeded "default n" from USB_OTG as well, the default is already n.

I prefer not to remove it, since most of people may not want to enable it, you can grep the Kconfig in the kernel source, there are lots of "default n", especially, it can indicate people that if they are not sure, set 'n' for it.

Peter

Quoted 22 lines

Tested on Bay Trail hardware with dwc3 USB.

---
 drivers/usb/core/Kconfig |    2 --
 1 file changed, 2 deletions(-)
drivers/usb/core/Kconfig +0 -2
index a99c89e..567454f 100644
@@ -43,8 +43,6 @@ config USB_DYNAMIC_MINORS
 
 config USB_OTG
 	bool "OTG support"
-	depends on PM
-	default n
 	help
 	  The most notable feature of USB OTG is support for a
 	  "Dual-Role" device, which can act as either a device
Signature · 2 lines
Best Regards,
Peter Chen