Fix handling of compat_siginfo_t
v2 cover Fix handling of compat_siginfo_t
The current handling of compat_siginfo_t is a mess: each architecture has its own implementation, all of which are incorrect in different ways. This patch series replaces all of the arch-specific versions with a single generic one that is guaranteed to produce the same results as a 32-bit kernel.
Most architectures are able to use the generic compat_siginfo_t, except x86 and MIPS. MIPS uses a slightly different compat_siginfo_t structure for ABI reasons but can still use the generic copy_siginfo_{to,from}_user32. x86 can't use the generic versions because it needs special handling for __SI_CHLD for x32 tasks.
One issue that isn't resolved in this series is sending signals between a 32-bit process and 64-bit process. Sending a si_int will work correctly, but a si_ptr value will likely get corrupted due to the different layouts of the 32-bit and 64-bit siginfo_t structures.
signalfd_copyinfo was also modified to properly generate data for compat tasks. In particular the ssi_ptr and ssi_data members need to be sign-extended to 64 bits rather than zero-extended, since that is the behavior in 32-bit kernels.
This series has been tested on x86_64 and arm64.
Changes since v1:
- Properly copy padding bytes and avoid leaking uninitialized data to userspace
- Fixed compile errors on mips and powerpc
- Fixed some compiler warnings
- Fixed some formatting issues
Amanieu d'Antras (20):
compat: Add generic compat_siginfo_t
compat: Add generic copy_siginfo_{to,from}_user32
x86: Update compat_siginfo_t to be closer to the generic version
x86: Rewrite copy_siginfo_{to,from}_user32
mips: Clean up compat_siginfo_t
mips: Use generic copy_siginfo_{to,from}_user32
arm64: Use generic compat_siginfo_t
arm64: Use generic copy_siginfo_{to,from}_user32
parisc: Use generic compat_siginfo_t
parsic: Use generic copy_siginfo_{to,from}_user32
s390: Use generic compat_siginfo_t
s390: Use generic copy_siginfo_{to,from}_user32
powerpc: Use generic compat_siginfo_t
powerpc: Use generic copy_siginfo_{to,from}_user32
tile: Use generic compat_siginfo_t
tile: Use generic copy_siginfo_{to,from}_user32
sparc: Use generic compat_siginfo_t
sparc: Use generic copy_siginfo_{to,from}_user32
signalfd: Fix some issues in signalfd_copyinfo
signal: Remove unnecessary zero-initialization of siginfo_t
arch/arm64/include/asm/compat.h | 59 -------- arch/arm64/kernel/signal32.c | 85 ----------- arch/mips/include/asm/compat.h | 63 ++++---- arch/mips/kernel/signal32.c | 62 -------- arch/parisc/include/asm/compat.h | 52 ------- arch/parisc/kernel/signal32.c | 102 ------------- arch/powerpc/include/asm/compat.h | 60 -------- arch/powerpc/kernel/signal_32.c | 72 +--------- arch/s390/include/asm/compat.h | 51 ------- arch/s390/kernel/compat_signal.c | 102 ------------- arch/sparc/include/asm/compat.h | 54 ------- arch/sparc/kernel/signal32.c | 69 --------- arch/tile/include/asm/compat.h | 57 -------- arch/tile/kernel/compat_signal.c | 75 ---------- arch/x86/include/asm/compat.h | 39 +++-- arch/x86/kernel/signal_compat.c | 285 ++++++++++++++++++++++++++++--------- fs/signalfd.c | 58 +++++--- include/linux/compat.h | 66 ++++++++- include/uapi/asm-generic/siginfo.h | 1 + kernel/compat.c | 224 +++++++++++++++++++++++++++++ kernel/ptrace.c | 1 - kernel/signal.c | 16 ++- 22 files changed, 615 insertions(+), 1038 deletions(-)
Signature · 1 line
2.6.2
PATCH v2 1/20 compat: Add generic compat_siginfo_t
This matches the normal siginfo_t as closely as possible, unlike some architecture-specific versions which are missing some fields.
--- arch/arm64/include/asm/compat.h | 2 ++ arch/mips/include/asm/compat.h | 1 + arch/parisc/include/asm/compat.h | 2 ++ arch/powerpc/include/asm/compat.h | 1 + arch/s390/include/asm/compat.h | 2 ++ arch/sparc/include/asm/compat.h | 1 + arch/tile/include/asm/compat.h | 1 + arch/x86/include/asm/compat.h | 2 ++ include/linux/compat.h | 66 ++++++++++++++++++++++++++++++++++++++- 9 files changed, 77 insertions(+), 1 deletion(-)
arch/arm64/include/asm/compat.h +2 -0
@@ -155,6 +155,8 @@ typedef union compat_sigval {compat_uptr_t sival_ptr; } compat_sigval_t; +#define HAVE_ARCH_COMPAT_SIGINFO_T + typedef struct compat_siginfo { int si_signo; int si_errno;
arch/mips/include/asm/compat.h +1 -0
@@ -130,6 +130,7 @@ typedef union compat_sigval {compat_uptr_t sival_ptr; } compat_sigval_t; +#define HAVE_ARCH_COMPAT_SIGINFO_T #define SI_PAD_SIZE32 (128/sizeof(int) - 3) typedef struct compat_siginfo {
arch/parisc/include/asm/compat.h +2 -0
@@ -134,6 +134,8 @@ typedef union compat_sigval {compat_uptr_t sival_ptr; } compat_sigval_t; +#define HAVE_ARCH_COMPAT_SIGINFO_T + typedef struct compat_siginfo { int si_signo; int si_errno;
arch/powerpc/include/asm/compat.h +1 -0
@@ -124,6 +124,7 @@ typedef union compat_sigval {compat_uptr_t sival_ptr; } compat_sigval_t; +#define HAVE_ARCH_COMPAT_SIGINFO_T #define SI_PAD_SIZE32 (128/sizeof(int) - 3) typedef struct compat_siginfo {
arch/s390/include/asm/compat.h +2 -0
@@ -192,6 +192,8 @@ typedef union compat_sigval {compat_uptr_t sival_ptr; } compat_sigval_t; +#define HAVE_ARCH_COMPAT_SIGINFO_T + typedef struct compat_siginfo { int si_signo; int si_errno;
arch/sparc/include/asm/compat.h +1 -0
@@ -153,6 +153,7 @@ typedef union compat_sigval {compat_uptr_t sival_ptr; } compat_sigval_t; +#define HAVE_ARCH_COMPAT_SIGINFO_T #define SI_PAD_SIZE32 (128/sizeof(int) - 3) typedef struct compat_siginfo {
arch/tile/include/asm/compat.h +1 -0
@@ -115,6 +115,7 @@ typedef union compat_sigval {compat_uptr_t sival_ptr; } compat_sigval_t; +#define HAVE_ARCH_COMPAT_SIGINFO_T #define COMPAT_SI_PAD_SIZE (128/sizeof(int) - 3) typedef struct compat_siginfo {
arch/x86/include/asm/compat.h +2 -0
@@ -130,6 +130,8 @@ typedef union compat_sigval {compat_uptr_t sival_ptr; } compat_sigval_t; +#define HAVE_ARCH_COMPAT_SIGINFO_T + typedef struct compat_siginfo { int si_signo; int si_errno;
include/linux/compat.h +65 -1
72 lines not on this page · raw message
Signature · 1 line
2.6.2
PATCH v2 2/20 compat: Add generic copy_siginfo_{to,from}_user32
In reply to Amanieu d'AntrasThese routines try to match the behavior of native 32-bit kernels as closely as possible. They will replace architecture-specific versions that are missing support for some fields and have various bugs that cause behavior to diverge from that of a 32-bit kernel.
The only problematic situation is when sending a si_ptr from a 32-bit process to a 64-bit process or vice-versa, but this has never worked correctly in the past anyways.
One thing to note is that, because the size of the siginfo_t union differs between 32-bit and 64-bit systems, we need to stash the last 4 bytes of the union in the 4 bytes of padding between the 64-bit union and the initial 3 siginfo_t members.
--- arch/arm64/include/asm/compat.h | 2 + arch/mips/include/asm/compat.h | 2 + arch/parisc/include/asm/compat.h | 2 + arch/powerpc/include/asm/compat.h | 2 + arch/s390/include/asm/compat.h | 2 + arch/sparc/include/asm/compat.h | 2 + arch/tile/include/asm/compat.h | 2 + arch/x86/include/asm/compat.h | 2 + include/uapi/asm-generic/siginfo.h | 1 + kernel/compat.c | 224 +++++++++++++++++++++++++++++++++++++ kernel/signal.c | 12 +- 11 files changed, 248 insertions(+), 5 deletions(-)
arch/arm64/include/asm/compat.h +2 -0
@@ -156,6 +156,8 @@ typedef union compat_sigval { } compat_sigval_t;#define HAVE_ARCH_COMPAT_SIGINFO_T +#define HAVE_ARCH_COPY_SIGINFO_TO_USER32 +#define HAVE_ARCH_COPY_SIGINFO_FROM_USER32 typedef struct compat_siginfo { int si_signo;
arch/mips/include/asm/compat.h +2 -0
@@ -131,6 +131,8 @@ typedef union compat_sigval { } compat_sigval_t;#define HAVE_ARCH_COMPAT_SIGINFO_T +#define HAVE_ARCH_COPY_SIGINFO_TO_USER32 +#define HAVE_ARCH_COPY_SIGINFO_FROM_USER32 #define SI_PAD_SIZE32 (128/sizeof(int) - 3) typedef struct compat_siginfo {
arch/parisc/include/asm/compat.h +2 -0
@@ -135,6 +135,8 @@ typedef union compat_sigval { } compat_sigval_t;#define HAVE_ARCH_COMPAT_SIGINFO_T +#define HAVE_ARCH_COPY_SIGINFO_TO_USER32 +#define HAVE_ARCH_COPY_SIGINFO_FROM_USER32 typedef struct compat_siginfo { int si_signo;
arch/powerpc/include/asm/compat.h +2 -0
@@ -125,6 +125,8 @@ typedef union compat_sigval { } compat_sigval_t;#define HAVE_ARCH_COMPAT_SIGINFO_T +#define HAVE_ARCH_COPY_SIGINFO_TO_USER32 +#define HAVE_ARCH_COPY_SIGINFO_FROM_USER32 #define SI_PAD_SIZE32 (128/sizeof(int) - 3) typedef struct compat_siginfo {
arch/s390/include/asm/compat.h +2 -0
@@ -193,6 +193,8 @@ typedef union compat_sigval { } compat_sigval_t;#define HAVE_ARCH_COMPAT_SIGINFO_T +#define HAVE_ARCH_COPY_SIGINFO_TO_USER32 +#define HAVE_ARCH_COPY_SIGINFO_FROM_USER32 typedef struct compat_siginfo { int si_signo;
arch/sparc/include/asm/compat.h +2 -0
@@ -154,6 +154,8 @@ typedef union compat_sigval { } compat_sigval_t;#define HAVE_ARCH_COMPAT_SIGINFO_T +#define HAVE_ARCH_COPY_SIGINFO_TO_USER32 +#define HAVE_ARCH_COPY_SIGINFO_FROM_USER32 #define SI_PAD_SIZE32 (128/sizeof(int) - 3) typedef struct compat_siginfo {
arch/tile/include/asm/compat.h +2 -0
@@ -116,6 +116,8 @@ typedef union compat_sigval { } compat_sigval_t;#define HAVE_ARCH_COMPAT_SIGINFO_T +#define HAVE_ARCH_COPY_SIGINFO_TO_USER32 +#define HAVE_ARCH_COPY_SIGINFO_FROM_USER32 #define COMPAT_SI_PAD_SIZE (128/sizeof(int) - 3) typedef struct compat_siginfo {
arch/x86/include/asm/compat.h +2 -0
@@ -131,6 +131,8 @@ typedef union compat_sigval { } compat_sigval_t;#define HAVE_ARCH_COMPAT_SIGINFO_T +#define HAVE_ARCH_COPY_SIGINFO_TO_USER32 +#define HAVE_ARCH_COPY_SIGINFO_FROM_USER32 typedef struct compat_siginfo { int si_signo;
include/uapi/asm-generic/siginfo.h +1 -0
@@ -49,6 +49,7 @@ typedef struct siginfo {int si_signo;int si_errno;int si_code; +int _pad2[__ARCH_SI_PREAMBLE_SIZE /sizeof (int ) -3 ];union {int _pad[SI_PAD_SIZE ];
kernel/compat.c +224 -0
227 lines not on this page · raw message
kernel/signal.c +7 -5
@@ -2713,11 +2713,13 @@ int copy_siginfo_to_user(siginfo_t __user *to, const siginfo_t *from)return __copy_to_user (to, from,sizeof (siginfo_t)) ? -EFAULT :0 ;/* -* If you change siginfo_t structure, please be sure -* this code is fixed accordingly. -* Please remember to update the signalfd_copyinfo() function -* inside fs/signalfd.c too, in case siginfo_t changes. -* It should never copy any pad contained in the structure +* If you change siginfo_t structure, please be sure that +* all these functions are fixed accordingly: +* copy_siginfo_to_user +* copy_siginfo_to_user32 +* copy_siginfo_from_user32 +* signalfd_copyinfo +* They should never copy any pad contained in the structure * to avoid security leaks, but must copy the generic * 3 ints plus the relevant union member. */
Signature · 1 line
2.6.2
PATCH v2 3/20 x86: Update compat_siginfo_t to be closer to the generic version
In reply to Amanieu d'Antrasx86 can't use the generic compat_siginfo_t because it needs to support x32, so we just change it to be closer to the generic version.
The only significant change is the addition of several fields in _sigfault that were previously omitted.
--- arch/x86/include/asm/compat.h | 35 +++++++++++++++++++++-------------- 1 file changed, 21 insertions(+), 14 deletions(-)
arch/x86/include/asm/compat.h +21 -14
@@ -130,6 +130,7 @@ typedef union compat_sigval {compat_uptr_t sival_ptr; } compat_sigval_t; +/* Need special handling for SIGCHLD on x32 */ #define HAVE_ARCH_COMPAT_SIGINFO_T #define HAVE_ARCH_COPY_SIGINFO_TO_USER32 #define HAVE_ARCH_COPY_SIGINFO_FROM_USER32
@@ -140,12 +141,12 @@ typedef struct compat_siginfo {int si_code;union { -int _pad[128 /sizeof (int ) -3 ]; +int _pad[128 /sizeof (int ) -3 ];/* kill() */ struct { -unsigned int _pid;/* sender's pid */ -unsigned int _uid;/* sender's uid */ +compat_pid_t _pid;/* sender's pid */ +__compat_uid32_t _uid;/* sender's uid */ } _kill;/* POSIX.1b timers */
@@ -153,21 +154,19 @@ typedef struct compat_siginfo {compat_timer_t _tid;/* timer id */ int _overrun;/* overrun count */ compat_sigval_t _sigval;/* same as below */ -int _sys_private;/* not to be passed to user */ -int _overrun_incr;/* amount to add to overrun */ } _timer;/* POSIX.1b signals */ struct { -unsigned int _pid;/* sender's pid */ -unsigned int _uid;/* sender's uid */ +compat_pid_t _pid;/* sender's pid */ +__compat_uid32_t _uid;/* sender's uid */ compat_sigval_t _sigval; } _rt;/* SIGCHLD */ struct { -unsigned int _pid;/* which child */ -unsigned int _uid;/* sender's uid */ +compat_pid_t _pid;/* which child */ +__compat_uid32_t _uid;/* sender's uid */ int _status;/* exit code */ compat_clock_t _utime;compat_clock_t _stime;
@@ -175,7 +174,7 @@ typedef struct compat_siginfo {/* SIGCHLD (x32 version) */ struct { -unsigned int _pid;/* which child */ +compat_pid_t _pid;/* which child */ unsigned int _uid;/* sender's uid */ int _status;/* exit code */ compat_s64 _utime;
@@ -184,19 +183,27 @@ typedef struct compat_siginfo {/* SIGILL, SIGFPE, SIGSEGV, SIGBUS */ struct { -unsigned int _addr;/* faulting insn/memory ref. */ +compat_uptr_t _addr;/* faulting insn/memory ref. */ +#ifdef __ARCH_SI_TRAPNO +int _trapno;/* TRAP # which caused the signal */ +#endif +short _addr_lsb;/* LSB of the reported address */ +struct { +compat_uptr_t _lower; +compat_uptr_t _upper; + } _addr_bnd; } _sigfault;/* SIGPOLL */ struct { -int _band;/* POLL_IN, POLL_OUT, POLL_MSG */ +compat_long_t _band;/* POLL_IN, POLL_OUT, POLL_MSG */ int _fd; } _sigpoll;struct { -unsigned int _call_addr;/* calling insn */ +compat_uptr_t _call_addr;/* calling insn */ int _syscall;/* triggering system call number */ -unsigned int _arch;/* AUDIT_ARCH_* of syscall */ +compat_uint_t _arch;/* AUDIT_ARCH_* of syscall */ } _sigsys; } _sifields; } compat_siginfo_t;
Signature · 1 line
2.6.2
PATCH v2 4/20 x86: Rewrite copy_siginfo_{to,from}_user32
In reply to Amanieu d'Antrasx86 can't use the generic versions because it needs to support x32, so we replace the ad-hoc implementations with something that is closer to the generic versions.
This is done by completely replacing the existing code with the generic version, with some minor modifications to support x32. The new code is kept as close as possible to the generic version to make future changes to both functions easier.
Unlike the previous implementation, this one guarantees that the compat behavior is identical to that of a 32-bit kernel.
--- arch/x86/kernel/signal_compat.c | 285 ++++++++++++++++++++++++++++++---------- 1 file changed, 214 insertions(+), 71 deletions(-)
arch/x86/kernel/signal_compat.c +214 -71
@@ -3,93 +3,236 @@int copy_siginfo_to_user32 (compat_siginfo_t __user *to,const siginfo_t *from) { -int err =0 ; +int err, si_code;bool ia32 =test_thread_flag (TIF_IA32 );if (!access_ok (VERIFY_WRITE , to,sizeof (compat_siginfo_t)))return -EFAULT ; - put_user_try { -/* If you change siginfo_t structure, please make sure that -this code is fixed accordingly. -It should never copy any pad contained in the structure -to avoid security leaks, but must copy the generic -3 ints plus the relevant union member. */ -put_user_ex (from->si_signo, &to->si_signo); -put_user_ex (from->si_errno, &to->si_errno); -put_user_ex ((short )from->si_code, &to->si_code); +/* +* Get the user-visible si_code by hiding the top 16 bits if this is a +* kernel-generated signal. +*/ + si_code = from->si_code <0 ? from->si_code : (short )from->si_code; -if (from->si_code <0 ) { -put_user_ex (from->si_pid, &to->si_pid); -put_user_ex (from->si_uid, &to->si_uid); -put_user_ex (ptr_to_compat (from->si_ptr), &to->si_ptr); +/* +* If you change siginfo_t structure, please be sure that +* all these functions are fixed accordingly: +* copy_siginfo_to_user +* copy_siginfo_to_user32 +* copy_siginfo_from_user32 +* signalfd_copyinfo +* They should never copy any pad contained in the structure +* to avoid security leaks, but must copy the generic +* 3 ints plus the relevant union member. +*/ + err =__put_user (from->si_signo, &to->si_signo); + err |=__put_user (from->si_errno, &to->si_errno); + err |=__put_user (si_code, &to->si_code); +if (from->si_code <0 ) { +/* +* Copy the tail bytes of the union from the padding, see the +* comment in copy_siginfo_from_user32. Note that this padding +* is always initialized when si_code < 0. +*/ +BUILD_BUG_ON (sizeof (to->_sifields._pad) != +sizeof (from->_sifields._pad) +sizeof (from->_pad2)); + err |=__copy_to_user (to->_sifields._pad, from->_sifields._pad, +sizeof (from->_sifields._pad)) ? -EFAULT :0 ; + err |=__copy_to_user (to->_sifields._pad +SI_PAD_SIZE , + from->_pad2,sizeof (from->_pad2)) ? -EFAULT :0 ; +return err; + } +switch (from->si_code & __SI_MASK) { +case __SI_KILL: + err |=__put_user (from->si_pid, &to->si_pid); + err |=__put_user (from->si_uid, &to->si_uid); +break ; +case __SI_TIMER: + err |=__put_user (from->si_tid, &to->si_tid); + err |=__put_user (from->si_overrun, &to->si_overrun); +/* +* Get the sigval from si_int, which matches the convention +* used in get_compat_sigevent. +*/ + err |=__put_user (from->si_int, &to->si_int); +break ; +case __SI_POLL: + err |=__put_user (from->si_band, &to->si_band); + err |=__put_user (from->si_fd, &to->si_fd); +break ; +case __SI_FAULT: + err |=__put_user (ptr_to_compat (from->si_addr), &to->si_addr); +#ifdef __ARCH_SI_TRAPNO + err |=__put_user (from->si_trapno, &to->si_trapno); +#endif +#ifdef BUS_MCEERR_AO +/* +* Other callers might not initialize the si_lsb field, +* so check explicitly for the right codes here. +*/ +if (from->si_signo ==SIGBUS && + (from->si_code ==BUS_MCEERR_AR || + from->si_code ==BUS_MCEERR_AO )) + err |=__put_user (from->si_addr_lsb, &to->si_addr_lsb); +#endif +#ifdef SEGV_BNDERR +if (from->si_signo ==SIGSEGV && from->si_code ==SEGV_BNDERR ) { + err |=__put_user (ptr_to_compat (from->si_lower), + &to->si_lower); + err |=__put_user (ptr_to_compat (from->si_upper), + &to->si_upper); + } +#endif +break ; +case __SI_CHLD: + err |=__put_user (from->si_pid, &to->si_pid); + err |=__put_user (from->si_uid, &to->si_uid); + err |=__put_user (from->si_status, &to->si_status); +if (ia32) { + err |=__put_user (from->si_utime, &to->si_utime); + err |=__put_user (from->si_stime, &to->si_stime); }else { -/* -* First 32bits of unions are always present: -* si_pid === si_band === si_tid === si_addr(LS half) -*/ -put_user_ex (from->_sifields._pad[0 ], - &to->_sifields._pad[0 ]); -switch (from->si_code >>16 ) { -case __SI_FAULT >>16 : -break ; -case __SI_SYS >>16 : -put_user_ex (from->si_syscall, &to->si_syscall); -put_user_ex (from->si_arch, &to->si_arch); -break ; -case __SI_CHLD >>16 : -if (ia32) { -put_user_ex (from->si_utime, &to->si_utime); -put_user_ex (from->si_stime, &to->si_stime); - }else { -put_user_ex (from->si_utime, &to->_sifields._sigchld_x32._utime); -put_user_ex (from->si_stime, &to->_sifields._sigchld_x32._stime); - } -put_user_ex (from->si_status, &to->si_status); -/* FALL THROUGH */ -default : -case __SI_KILL >>16 : -put_user_ex (from->si_uid, &to->si_uid); -break ; -case __SI_POLL >>16 : -put_user_ex (from->si_fd, &to->si_fd); -break ; -case __SI_TIMER >>16 : -put_user_ex (from->si_overrun, &to->si_overrun); -put_user_ex (ptr_to_compat (from->si_ptr), - &to->si_ptr); -break ; -/* This is not generated by the kernel as of now. */ -case __SI_RT >>16 : -case __SI_MESGQ >>16 : -put_user_ex (from->si_uid, &to->si_uid); -put_user_ex (from->si_int, &to->si_int); -break ; - } + err |=__put_user (from->si_utime, + &to->_sifields._sigchld_x32._utime); + err |=__put_user (from->si_stime, + &to->_sifields._sigchld_x32._stime); } - }put_user_catch (err); - +break ; +case __SI_RT:/* This is not generated by the kernel as of now. */ +case __SI_MESGQ:/* But this is */ + err |=__put_user (from->si_pid, &to->si_pid); + err |=__put_user (from->si_uid, &to->si_uid); +/* +* Get the sigval from si_int, which matches the convention +* used in get_compat_sigevent. +*/ + err |=__put_user (from->si_int, &to->si_int); +break ; +#ifdef __ARCH_SIGSYS +case __SI_SYS: + err |=__put_user (ptr_to_compat (from->si_call_addr), + &to->si_call_addr); + err |=__put_user (from->si_syscall, &to->si_syscall); + err |=__put_user (from->si_arch, &to->si_arch); +break ; +#endif +default :/* this is just in case for now ... */ + err |=__put_user (from->si_pid, &to->si_pid); + err |=__put_user (from->si_uid, &to->si_uid); +break ; + }return err; }int copy_siginfo_from_user32 (siginfo_t *to,compat_siginfo_t __user *from) { -int err =0 ; -u32 ptr32; +int err; +compat_uptr_t ptr32; +bool ia32 =test_thread_flag (TIF_IA32 );if (!access_ok (VERIFY_READ , from,sizeof (compat_siginfo_t)))return -EFAULT ; - get_user_try { -get_user_ex (to->si_signo, &from->si_signo); -get_user_ex (to->si_errno, &from->si_errno); -get_user_ex (to->si_code, &from->si_code); - -get_user_ex (to->si_pid, &from->si_pid); -get_user_ex (to->si_uid, &from->si_uid); -get_user_ex (ptr32, &from->si_ptr); - to->si_ptr =compat_ptr (ptr32); - }get_user_catch (err); - +/* +* If you change siginfo_t structure, please be sure that +* all these functions are fixed accordingly: +* copy_siginfo_to_user +* copy_siginfo_to_user32 +* copy_siginfo_from_user32 +* signalfd_copyinfo +* They should never copy any pad contained in the structure +* to avoid security leaks, but must copy the generic +* 3 ints plus the relevant union member. +*/ + err =__get_user (to->si_signo, &from->si_signo); + err |=__get_user (to->si_errno, &from->si_errno); + err |=__get_user (to->si_code, &from->si_code); +if (to->si_code <0 ) { +/* +* Note that the compat union may be larger than the normal one +* due to alignment. We work around this by copying any data +* that doesn't fit in the normal union into the padding before +* the union. +*/ +BUILD_BUG_ON (sizeof (to->_sifields._pad) +sizeof (to->_pad2) != +sizeof (from->_sifields._pad)); + err |=__copy_from_user (to->_sifields._pad, + from->_sifields._pad, +sizeof (to->_sifields._pad)) ? -EFAULT :0 ; + err |=__copy_from_user (to->_pad2, + from->_sifields._pad +SI_PAD_SIZE ,sizeof (to->_pad2)) + ? -EFAULT :0 ; +return err; + } +switch (to->si_code & __SI_MASK) { +case __SI_KILL: + err |=__get_user (to->si_pid, &from->si_pid); + err |=__get_user (to->si_uid, &from->si_uid); +break ; +case __SI_TIMER: + err |=__get_user (to->si_tid, &from->si_tid); + err |=__get_user (to->si_overrun, &from->si_overrun); +/* +* Put the sigval in si_int, which matches the convention +* used in get_compat_sigevent. +*/ + to->si_ptr =NULL ;/* Avoid uninitialized bits in the union */ + err |=__get_user (to->si_int, &from->si_int); +break ; +case __SI_POLL: + err |=__get_user (to->si_band, &from->si_band); + err |=__get_user (to->si_fd, &from->si_fd); +break ; +case __SI_FAULT: + err |=__get_user (ptr32, &from->si_addr); + to->si_addr =compat_ptr (ptr32); +#ifdef __ARCH_SI_TRAPNO + err |=__get_user (to->si_trapno, &from->si_trapno); +#endif + err |=__get_user (to->si_addr_lsb, &from->si_addr_lsb); + err |=__get_user (ptr32, &from->si_lower); + to->si_lower =compat_ptr (ptr32); + err |=__get_user (ptr32, &from->si_upper); + to->si_upper =compat_ptr (ptr32); +break ; +case __SI_CHLD: + err |=__get_user (to->si_pid, &from->si_pid); + err |=__get_user (to->si_uid, &from->si_uid); + err |=__get_user (to->si_status, &from->si_status); +if (ia32) { + err |=__get_user (to->si_utime, &from->si_utime); + err |=__get_user (to->si_stime, &from->si_stime); + }else { + err |=__get_user (to->si_utime, + &from->_sifields._sigchld_x32._utime); + err |=__get_user (to->si_stime, + &from->_sifields._sigchld_x32._stime); + } +break ; +case __SI_RT:/* This is not generated by the kernel as of now. */ +case __SI_MESGQ:/* But this is */ + err |=__get_user (to->si_pid, &from->si_pid); + err |=__get_user (to->si_uid, &from->si_uid); +/* +* Put the sigval in si_int, which matches the convention +* used in get_compat_sigevent. +*/ + to->si_ptr =NULL ;/* Avoid uninitialized bits in the union */ + err |=__get_user (to->si_int, &from->si_int); +break ; +#ifdef __ARCH_SIGSYS +case __SI_SYS: + err |=__get_user (ptr32, &from->si_call_addr); + to->si_call_addr =compat_ptr (ptr32); + err |=__get_user (to->si_syscall, &from->si_syscall); + err |=__get_user (to->si_arch, &from->si_arch); +break ; +#endif +default :/* this is just in case for now ... */ + err |=__get_user (to->si_pid, &from->si_pid); + err |=__get_user (to->si_uid, &from->si_uid); +break ; + }return err; }
Signature · 1 line
2.6.2
H. Peter Anvin
reviewerRe: [PATCH v2 04/20] x86: Rewrite copy_siginfo_{to,from}_user32
Quoted 332 lines · Amanieu d'Antras
x86 can't use the generic versions because it needs to support x32, so we replace the ad-hoc implementations with something that is closer to the generic versions.
This is done by completely replacing the existing code with the generic version, with some minor modifications to support x32. The new code is kept as close as possible to the generic version to make future changes to both functions easier.
Unlike the previous implementation, this one guarantees that the compat behavior is identical to that of a 32-bit kernel.
Signed-off-by Amanieu d'Antras <[email protected]>---
arch/x86/kernel/signal_compat.c| 285
++++++++++++++++++++++++++++++----------1 file changed, 214 insertions(+), 71 deletions(-)arch/x86/kernel/signal_compat.c +0
-0@@ -3,93 +3,236 @@int
copy_siginfo_to_user32(compat_siginfo_t __user *to, const siginfo_t *from)
{arch/x86/kernel/signal_compat.c +1
-1-int err =0 ; +int err, si_code;bool ia32 = test_thread_flag(TIF_IA32); if (!access_ok(VERIFY_WRITE, to, sizeof(compat_siginfo_t))) return -EFAULT;arch/x86/kernel/signal_compat.c +2
-9- put_user_try { -/* If you change siginfo_t structure, please make sure that -this code is fixed accordingly. -It should never copy any pad contained in the structure -to avoid security leaks, but must copy the generic -3 ints plus the relevant union member. */ -put_user_ex (from->si_signo, &to->si_signo); -put_user_ex (from->si_errno, &to->si_errno); -put_user_ex ((short )from->si_code, &to->si_code); +/* +* Get the user-visible si_code by hiding the top 16 bits if this is a
arch/x86/kernel/signal_compat.c +80
-4+* kernel-generated signal. +*/ + si_code = from->si_code <0 ? from->si_code : (short )from->si_code; -if (from->si_code <0 ) { -put_user_ex (from->si_pid, &to->si_pid); -put_user_ex (from->si_uid, &to->si_uid); -put_user_ex (ptr_to_compat (from->si_ptr), &to->si_ptr); +/* +* If you change siginfo_t structure, please be sure that +* all these functions are fixed accordingly: +* copy_siginfo_to_user +* copy_siginfo_to_user32 +* copy_siginfo_from_user32 +* signalfd_copyinfo +* They should never copy any pad contained in the structure +* to avoid security leaks, but must copy the generic +* 3 ints plus the relevant union member. +*/ + err =__put_user (from->si_signo, &to->si_signo); + err |=__put_user (from->si_errno, &to->si_errno); + err |=__put_user (si_code, &to->si_code); +if (from->si_code <0 ) { +/* +* Copy the tail bytes of the union from the padding, see the +* comment in copy_siginfo_from_user32. Note that this padding +* is always initialized when si_code < 0. +*/ +BUILD_BUG_ON (sizeof (to->_sifields._pad) != +sizeof (from->_sifields._pad) +sizeof (from->_pad2)); + err |=__copy_to_user (to->_sifields._pad, from->_sifields._pad, +sizeof (from->_sifields._pad)) ? -EFAULT :0 ; + err |=__copy_to_user (to->_sifields._pad +SI_PAD_SIZE , + from->_pad2,sizeof (from->_pad2)) ? -EFAULT :0 ; +return err; + } +switch (from->si_code & __SI_MASK) { +case __SI_KILL: + err |=__put_user (from->si_pid, &to->si_pid); + err |=__put_user (from->si_uid, &to->si_uid); +break ; +case __SI_TIMER: + err |=__put_user (from->si_tid, &to->si_tid); + err |=__put_user (from->si_overrun, &to->si_overrun); +/* +* Get the sigval from si_int, which matches the convention +* used in get_compat_sigevent. +*/ + err |=__put_user (from->si_int, &to->si_int); +break ; +case __SI_POLL: + err |=__put_user (from->si_band, &to->si_band); + err |=__put_user (from->si_fd, &to->si_fd); +break ; +case __SI_FAULT: + err |=__put_user (ptr_to_compat (from->si_addr), &to->si_addr); +#ifdef __ARCH_SI_TRAPNO + err |=__put_user (from->si_trapno, &to->si_trapno); +#endif +#ifdef BUS_MCEERR_AO +/* +* Other callers might not initialize the si_lsb field, +* so check explicitly for the right codes here. +*/ +if (from->si_signo ==SIGBUS && + (from->si_code ==BUS_MCEERR_AR || + from->si_code ==BUS_MCEERR_AO )) + err |=__put_user (from->si_addr_lsb, &to->si_addr_lsb); +#endif +#ifdef SEGV_BNDERR +if (from->si_signo ==SIGSEGV && from->si_code ==SEGV_BNDERR ) { + err |=__put_user (ptr_to_compat (from->si_lower), + &to->si_lower); + err |=__put_user (ptr_to_compat (from->si_upper), + &to->si_upper); + } +#endif +break ; +case __SI_CHLD: + err |=__put_user (from->si_pid, &to->si_pid); + err |=__put_user (from->si_uid, &to->si_uid); + err |=__put_user (from->si_status, &to->si_status); +if (ia32) { + err |=__put_user (from->si_utime, &to->si_utime); + err |=__put_user (from->si_stime, &to->si_stime);} else {arch/x86/kernel/signal_compat.c +4
-42-/* -* First 32bits of unions are always present: -* si_pid === si_band === si_tid === si_addr(LS half) -*/ -put_user_ex (from->_sifields._pad[0 ], - &to->_sifields._pad[0 ]); -switch (from->si_code >>16 ) { -case __SI_FAULT >>16 : -break ; -case __SI_SYS >>16 : -put_user_ex (from->si_syscall, &to->si_syscall); -put_user_ex (from->si_arch, &to->si_arch); -break ; -case __SI_CHLD >>16 : -if (ia32) { -put_user_ex (from->si_utime, &to->si_utime); -put_user_ex (from->si_stime, &to->si_stime); - }else { -put_user_ex (from->si_utime, &to->_sifields._sigchld_x32._utime); -put_user_ex (from->si_stime, &to->_sifields._sigchld_x32._stime); - } -put_user_ex (from->si_status, &to->si_status); -/* FALL THROUGH */ -default : -case __SI_KILL >>16 : -put_user_ex (from->si_uid, &to->si_uid); -break ; -case __SI_POLL >>16 : -put_user_ex (from->si_fd, &to->si_fd); -break ; -case __SI_TIMER >>16 : -put_user_ex (from->si_overrun, &to->si_overrun); -put_user_ex (ptr_to_compat (from->si_ptr), - &to->si_ptr); -break ; -/* This is not generated by the kernel as of now. */ -case __SI_RT >>16 : -case __SI_MESGQ >>16 : -put_user_ex (from->si_uid, &to->si_uid); -put_user_ex (from->si_int, &to->si_int); -break ; - } + err |=__put_user (from->si_utime, + &to->_sifields._sigchld_x32._utime); + err |=__put_user (from->si_stime, + &to->_sifields._sigchld_x32._stime);}arch/x86/kernel/signal_compat.c +24
-2- }put_user_catch (err); - +break ; +case __SI_RT:/* This is not generated by the kernel as of now. */ +case __SI_MESGQ:/* But this is */ + err |=__put_user (from->si_pid, &to->si_pid); + err |=__put_user (from->si_uid, &to->si_uid); +/* +* Get the sigval from si_int, which matches the convention +* used in get_compat_sigevent. +*/ + err |=__put_user (from->si_int, &to->si_int); +break ; +#ifdef __ARCH_SIGSYS +case __SI_SYS: + err |=__put_user (ptr_to_compat (from->si_call_addr), + &to->si_call_addr); + err |=__put_user (from->si_syscall, &to->si_syscall); + err |=__put_user (from->si_arch, &to->si_arch); +break ; +#endif +default :/* this is just in case for now ... */ + err |=__put_user (from->si_pid, &to->si_pid); + err |=__put_user (from->si_uid, &to->si_uid); +break ; + }return err; }int
copy_siginfo_from_user32(siginfo_t *to, compat_siginfo_t __user *from)
{arch/x86/kernel/signal_compat.c +3
-2-int err =0 ; -u32 ptr32; +int err; +compat_uptr_t ptr32; +bool ia32 =test_thread_flag (TIF_IA32 );if (!access_ok(VERIFY_READ, from, sizeof(compat_siginfo_t))) return -EFAULT;arch/x86/kernel/signal_compat.c +100
-11- get_user_try { -get_user_ex (to->si_signo, &from->si_signo); -get_user_ex (to->si_errno, &from->si_errno); -get_user_ex (to->si_code, &from->si_code); - -get_user_ex (to->si_pid, &from->si_pid); -get_user_ex (to->si_uid, &from->si_uid); -get_user_ex (ptr32, &from->si_ptr); - to->si_ptr =compat_ptr (ptr32); - }get_user_catch (err); - +/* +* If you change siginfo_t structure, please be sure that +* all these functions are fixed accordingly: +* copy_siginfo_to_user +* copy_siginfo_to_user32 +* copy_siginfo_from_user32 +* signalfd_copyinfo +* They should never copy any pad contained in the structure +* to avoid security leaks, but must copy the generic +* 3 ints plus the relevant union member. +*/ + err =__get_user (to->si_signo, &from->si_signo); + err |=__get_user (to->si_errno, &from->si_errno); + err |=__get_user (to->si_code, &from->si_code); +if (to->si_code <0 ) { +/* +* Note that the compat union may be larger than the normal one +* due to alignment. We work around this by copying any data +* that doesn't fit in the normal union into the padding before +* the union. +*/ +BUILD_BUG_ON (sizeof (to->_sifields._pad) +sizeof (to->_pad2) != +sizeof (from->_sifields._pad)); + err |=__copy_from_user (to->_sifields._pad, + from->_sifields._pad, +sizeof (to->_sifields._pad)) ? -EFAULT :0 ; + err |=__copy_from_user (to->_pad2, + from->_sifields._pad +SI_PAD_SIZE ,sizeof (to->_pad2)) + ? -EFAULT :0 ; +return err; + } +switch (to->si_code & __SI_MASK) { +case __SI_KILL: + err |=__get_user (to->si_pid, &from->si_pid); + err |=__get_user (to->si_uid, &from->si_uid); +break ; +case __SI_TIMER: + err |=__get_user (to->si_tid, &from->si_tid); + err |=__get_user (to->si_overrun, &from->si_overrun); +/* +* Put the sigval in si_int, which matches the convention +* used in get_compat_sigevent. +*/ + to->si_ptr =NULL ;/* Avoid uninitialized bits in the union */ + err |=__get_user (to->si_int, &from->si_int); +break ; +case __SI_POLL: + err |=__get_user (to->si_band, &from->si_band); + err |=__get_user (to->si_fd, &from->si_fd); +break ; +case __SI_FAULT: + err |=__get_user (ptr32, &from->si_addr); + to->si_addr =compat_ptr (ptr32); +#ifdef __ARCH_SI_TRAPNO + err |=__get_user (to->si_trapno, &from->si_trapno); +#endif + err |=__get_user (to->si_addr_lsb, &from->si_addr_lsb); + err |=__get_user (ptr32, &from->si_lower); + to->si_lower =compat_ptr (ptr32); + err |=__get_user (ptr32, &from->si_upper); + to->si_upper =compat_ptr (ptr32); +break ; +case __SI_CHLD: + err |=__get_user (to->si_pid, &from->si_pid); + err |=__get_user (to->si_uid, &from->si_uid); + err |=__get_user (to->si_status, &from->si_status); +if (ia32) { + err |=__get_user (to->si_utime, &from->si_utime); + err |=__get_user (to->si_stime, &from->si_stime); + }else { + err |=__get_user (to->si_utime, + &from->_sifields._sigchld_x32._utime); + err |=__get_user (to->si_stime, + &from->_sifields._sigchld_x32._stime); + } +break ; +case __SI_RT:/* This is not generated by the kernel as of now. */ +case __SI_MESGQ:/* But this is */ + err |=__get_user (to->si_pid, &from->si_pid); + err |=__get_user (to->si_uid, &from->si_uid); +/* +* Put the sigval in si_int, which matches the convention +* used in get_compat_sigevent. +*/ + to->si_ptr =NULL ;/* Avoid uninitialized bits in the union */ + err |=__get_user (to->si_int, &from->si_int); +break ; +#ifdef __ARCH_SIGSYS +case __SI_SYS: + err |=__get_user (ptr32, &from->si_call_addr); + to->si_call_addr =compat_ptr (ptr32); + err |=__get_user (to->si_syscall, &from->si_syscall); + err |=__get_user (to->si_arch, &from->si_arch); +break ; +#endif +default :/* this is just in case for now ... */ + err |=__get_user (to->si_pid, &from->si_pid); + err |=__get_user (to->si_uid, &from->si_uid); +break ; + }
Quoted 2 lines
return err; }
Once again, NAK on removing get/user_put_ex for performance reasons (10x slowdown on SMAP-enabled hardware.)
DO NOT resubmit without addressing that issue. Period.
Signature · 1 line
Sent from my Android device with K-9 Mail. Please excuse my brevity.
PATCH v2 5/20 mips: Clean up compat_siginfo_t
In reply to Amanieu d'AntrasWhile mips can't use the generic compat_siginfo_t directly because its si_code and si_errno are inverted, we can still make it as close to the generic version as possible. This makes it easier to update when new members are added to siginfo_t.
The main changes are adding a missing _sigsys union member and eliminating the unused _irix_sigchld one.
--- arch/mips/include/asm/compat.h | 61 +++++++++++++++++++++++------------------- 1 file changed, 33 insertions(+), 28 deletions(-)
arch/mips/include/asm/compat.h +33 -28
@@ -130,6 +130,7 @@ typedef union compat_sigval {compat_uptr_t sival_ptr; } compat_sigval_t; +/* Can't use the generic version because si_code and si_errno are swapped */ #define HAVE_ARCH_COMPAT_SIGINFO_T #define HAVE_ARCH_COPY_SIGINFO_TO_USER32 #define HAVE_ARCH_COPY_SIGINFO_FROM_USER32
@@ -141,57 +142,61 @@ typedef struct compat_siginfo {int si_errno;union { -int _pad[SI_PAD_SIZE32 ]; +int _pad[128 /sizeof (int ) -3 ];/* kill() */ struct {compat_pid_t _pid;/* sender's pid */ -__compat_uid_t _uid;/* sender's uid */ +__compat_uid32_t _uid;/* sender's uid */ } _kill; +/* POSIX.1b timers */ +struct { +compat_timer_t _tid;/* timer id */ +int _overrun;/* overrun count */ +compat_sigval_t _sigval;/* same as below */ + } _timer; + +/* POSIX.1b signals */ +struct { +compat_pid_t _pid;/* sender's pid */ +__compat_uid32_t _uid;/* sender's uid */ +compat_sigval_t _sigval; + } _rt; +/* SIGCHLD */ struct {compat_pid_t _pid;/* which child */ -__compat_uid_t _uid;/* sender's uid */ +__compat_uid32_t _uid;/* sender's uid */ int _status;/* exit code */ compat_clock_t _utime;compat_clock_t _stime; } _sigchld; -/* IRIX SIGCHLD */ -struct { -compat_pid_t _pid;/* which child */ -compat_clock_t _utime; -int _status;/* exit code */ -compat_clock_t _stime; - } _irix_sigchld; -/* SIGILL, SIGFPE, SIGSEGV, SIGBUS */ struct { -s32 _addr;/* faulting insn/memory ref. */ +compat_uptr_t _addr;/* faulting insn/memory ref. */ +#ifdef __ARCH_SI_TRAPNO +int _trapno;/* TRAP # which caused the signal */ +#endif +short _addr_lsb;/* LSB of the reported address */ +struct { +compat_uptr_t _lower; +compat_uptr_t _upper; + } _addr_bnd; } _sigfault; -/* SIGPOLL, SIGXFSZ (To do ...) */ +/* SIGPOLL */ struct { -int _band;/* POLL_IN, POLL_OUT, POLL_MSG */ +compat_long_t _band;/* POLL_IN, POLL_OUT, POLL_MSG */ int _fd; } _sigpoll; -/* POSIX.1b timers */ -struct { -timer_t _tid;/* timer id */ -int _overrun;/* overrun count */ -compat_sigval_t _sigval;/* same as below */ -int _sys_private;/* not to be passed to user */ - } _timer; - -/* POSIX.1b signals */ struct { -compat_pid_t _pid;/* sender's pid */ -__compat_uid_t _uid;/* sender's uid */ -compat_sigval_t _sigval; - } _rt; - +compat_uptr_t _call_addr;/* calling insn */ +int _syscall;/* triggering system call number */ +compat_uint_t _arch;/* AUDIT_ARCH_* of syscall */ + } _sigsys; } _sifields; } compat_siginfo_t;
Signature · 1 line
2.6.2
PATCH v2 6/20 mips: Use generic copy_siginfo_{to,from}_user32
In reply to Amanieu d'Antras--- arch/mips/include/asm/compat.h | 3 -- arch/mips/kernel/signal32.c | 62 ------------------------------------------ 2 files changed, 65 deletions(-)
arch/mips/include/asm/compat.h +0 -3
@@ -132,9 +132,6 @@ typedef union compat_sigval {/* Can't use the generic version because si_code and si_errno are swapped */ #define HAVE_ARCH_COMPAT_SIGINFO_T -#define HAVE_ARCH_COPY_SIGINFO_TO_USER32 -#define HAVE_ARCH_COPY_SIGINFO_FROM_USER32 -#define SI_PAD_SIZE32 (128/sizeof(int) - 3) typedef struct compat_siginfo { int si_signo;
arch/mips/kernel/signal32.c +0 -62
68 lines not on this page · raw message
Signature · 1 line
2.6.2
PATCH v2 7/20 arm64: Use generic compat_siginfo_t
In reply to Amanieu d'Antras--- arch/arm64/include/asm/compat.h | 60 ----------------------------------------- 1 file changed, 60 deletions(-)
arch/arm64/include/asm/compat.h +0 -60
@@ -155,69 +155,9 @@ typedef union compat_sigval {compat_uptr_t sival_ptr; } compat_sigval_t; -#define HAVE_ARCH_COMPAT_SIGINFO_T #define HAVE_ARCH_COPY_SIGINFO_TO_USER32 #define HAVE_ARCH_COPY_SIGINFO_FROM_USER32 -typedef struct compat_siginfo { -int si_signo; -int si_errno; -int si_code; - -union { -int _pad[128 /sizeof (int ) -3 ]; - -/* kill() */ -struct { -compat_pid_t _pid;/* sender's pid */ -__compat_uid32_t _uid;/* sender's uid */ - } _kill; - -/* POSIX.1b timers */ -struct { -compat_timer_t _tid;/* timer id */ -int _overrun;/* overrun count */ -compat_sigval_t _sigval;/* same as below */ -int _sys_private;/* not to be passed to user */ - } _timer; - -/* POSIX.1b signals */ -struct { -compat_pid_t _pid;/* sender's pid */ -__compat_uid32_t _uid;/* sender's uid */ -compat_sigval_t _sigval; - } _rt; - -/* SIGCHLD */ -struct { -compat_pid_t _pid;/* which child */ -__compat_uid32_t _uid;/* sender's uid */ -int _status;/* exit code */ -compat_clock_t _utime; -compat_clock_t _stime; - } _sigchld; - -/* SIGILL, SIGFPE, SIGSEGV, SIGBUS */ -struct { -compat_uptr_t _addr;/* faulting insn/memory ref. */ -short _addr_lsb;/* LSB of the reported address */ - } _sigfault; - -/* SIGPOLL */ -struct { -compat_long_t _band;/* POLL_IN, POLL_OUT, POLL_MSG */ -int _fd; - } _sigpoll; - -/* SIGSYS */ -struct { -compat_uptr_t _call_addr;/* calling user insn */ -int _syscall;/* triggering system call number */ -compat_uint_t _arch;/* AUDIT_ARCH_* of syscall */ - } _sigsys; - } _sifields; -}compat_siginfo_t ; -#define COMPAT_OFF_T_MAX 0x7fffffff#define COMPAT_LOFF_T_MAX 0x7fffffffffffffffL
Signature · 1 line
2.6.2
PATCH v2 8/20 arm64: Use generic copy_siginfo_{to,from}_user32
In reply to Amanieu d'Antras--- arch/arm64/include/asm/compat.h | 3 -- arch/arm64/kernel/signal32.c | 85 ----------------------------------------- 2 files changed, 88 deletions(-)
arch/arm64/include/asm/compat.h +0 -3
@@ -155,9 +155,6 @@ typedef union compat_sigval {compat_uptr_t sival_ptr; } compat_sigval_t; -#define HAVE_ARCH_COPY_SIGINFO_TO_USER32 -#define HAVE_ARCH_COPY_SIGINFO_FROM_USER32 -#define COMPAT_OFF_T_MAX 0x7fffffff#define COMPAT_LOFF_T_MAX 0x7fffffffffffffffL
arch/arm64/kernel/signal32.c +0 -85
91 lines not on this page · raw message
Signature · 1 line
2.6.2
PATCH v2 9/20 parisc: Use generic compat_siginfo_t
In reply to Amanieu d'Antras--- arch/parisc/include/asm/compat.h | 53 ---------------------------------------- 1 file changed, 53 deletions(-)
arch/parisc/include/asm/compat.h +0 -53
@@ -134,62 +134,9 @@ typedef union compat_sigval {compat_uptr_t sival_ptr; } compat_sigval_t; -#define HAVE_ARCH_COMPAT_SIGINFO_T #define HAVE_ARCH_COPY_SIGINFO_TO_USER32 #define HAVE_ARCH_COPY_SIGINFO_FROM_USER32 -typedef struct compat_siginfo { -int si_signo; -int si_errno; -int si_code; - -union { -int _pad[128 /sizeof (int ) -3 ]; - -/* kill() */ -struct { -unsigned int _pid;/* sender's pid */ -unsigned int _uid;/* sender's uid */ - } _kill; - -/* POSIX.1b timers */ -struct { -compat_timer_t _tid;/* timer id */ -int _overrun;/* overrun count */ -char _pad[sizeof (unsigned int ) -sizeof (int )]; -compat_sigval_t _sigval;/* same as below */ -int _sys_private;/* not to be passed to user */ - } _timer; - -/* POSIX.1b signals */ -struct { -unsigned int _pid;/* sender's pid */ -unsigned int _uid;/* sender's uid */ -compat_sigval_t _sigval; - } _rt; - -/* SIGCHLD */ -struct { -unsigned int _pid;/* which child */ -unsigned int _uid;/* sender's uid */ -int _status;/* exit code */ -compat_clock_t _utime; -compat_clock_t _stime; - } _sigchld; - -/* SIGILL, SIGFPE, SIGSEGV, SIGBUS */ -struct { -unsigned int _addr;/* faulting insn/memory ref. */ - } _sigfault; - -/* SIGPOLL */ -struct { -int _band;/* POLL_IN, POLL_OUT, POLL_MSG */ -int _fd; - } _sigpoll; - } _sifields; -}compat_siginfo_t ; -#define COMPAT_OFF_T_MAX 0x7fffffff#define COMPAT_LOFF_T_MAX 0x7fffffffffffffffL
Signature · 1 line
2.6.2
PATCH v2 10/20 parsic: Use generic copy_siginfo_{to,from}_user32
In reply to Amanieu d'Antras--- arch/parisc/include/asm/compat.h | 3 -- arch/parisc/kernel/signal32.c | 102 --------------------------------------- 2 files changed, 105 deletions(-)
arch/parisc/include/asm/compat.h +0 -3
@@ -134,9 +134,6 @@ typedef union compat_sigval {compat_uptr_t sival_ptr; } compat_sigval_t; -#define HAVE_ARCH_COPY_SIGINFO_TO_USER32 -#define HAVE_ARCH_COPY_SIGINFO_FROM_USER32 -#define COMPAT_OFF_T_MAX 0x7fffffff#define COMPAT_LOFF_T_MAX 0x7fffffffffffffffL
arch/parisc/kernel/signal32.c +0 -102
105 lines not on this page · raw message
Signature · 1 line
2.6.2
PATCH v2 11/20 s390: Use generic compat_siginfo_t
In reply to Amanieu d'Antras--- arch/s390/include/asm/compat.h | 52 ------------------------------------------ 1 file changed, 52 deletions(-)
arch/s390/include/asm/compat.h +0 -52
@@ -192,61 +192,9 @@ typedef union compat_sigval {compat_uptr_t sival_ptr; } compat_sigval_t; -#define HAVE_ARCH_COMPAT_SIGINFO_T #define HAVE_ARCH_COPY_SIGINFO_TO_USER32 #define HAVE_ARCH_COPY_SIGINFO_FROM_USER32 -typedef struct compat_siginfo { -int si_signo; -int si_errno; -int si_code; - -union { -int _pad[128 /sizeof (int ) -3 ]; - -/* kill() */ -struct { -pid_t _pid;/* sender's pid */ -uid_t _uid;/* sender's uid */ - } _kill; - -/* POSIX.1b timers */ -struct { -compat_timer_t _tid;/* timer id */ -int _overrun;/* overrun count */ -compat_sigval_t _sigval;/* same as below */ -int _sys_private;/* not to be passed to user */ - } _timer; - -/* POSIX.1b signals */ -struct { -pid_t _pid;/* sender's pid */ -uid_t _uid;/* sender's uid */ -compat_sigval_t _sigval; - } _rt; - -/* SIGCHLD */ -struct { -pid_t _pid;/* which child */ -uid_t _uid;/* sender's uid */ -int _status;/* exit code */ -compat_clock_t _utime; -compat_clock_t _stime; - } _sigchld; - -/* SIGILL, SIGFPE, SIGSEGV, SIGBUS */ -struct { -__u32 _addr;/* faulting insn/memory ref. - pointer */ - } _sigfault; - -/* SIGPOLL */ -struct { -int _band;/* POLL_IN, POLL_OUT, POLL_MSG */ -int _fd; - } _sigpoll; - } _sifields; -}compat_siginfo_t ; -/* * How these fields are to be accessed. */
Signature · 1 line
2.6.2
PATCH v2 12/20 s390: Use generic copy_siginfo_{to,from}_user32
In reply to Amanieu d'Antras--- arch/s390/include/asm/compat.h | 3 -- arch/s390/kernel/compat_signal.c | 102 --------------------------------------- 2 files changed, 105 deletions(-)
arch/s390/include/asm/compat.h +0 -3
@@ -192,9 +192,6 @@ typedef union compat_sigval {compat_uptr_t sival_ptr; } compat_sigval_t; -#define HAVE_ARCH_COPY_SIGINFO_TO_USER32 -#define HAVE_ARCH_COPY_SIGINFO_FROM_USER32 -/* * How these fields are to be accessed. */
arch/s390/kernel/compat_signal.c +0 -102
108 lines not on this page · raw message
Signature · 1 line
2.6.2
PATCH v2 13/20 powerpc: Use generic compat_siginfo_t
In reply to Amanieu d'Antras--- arch/powerpc/include/asm/compat.h | 62 ++------------------------------------- 1 file changed, 2 insertions(+), 60 deletions(-)
arch/powerpc/include/asm/compat.h +2 -60
@@ -124,68 +124,10 @@ typedef union compat_sigval {compat_uptr_t sival_ptr; } compat_sigval_t; -#define HAVE_ARCH_COMPAT_SIGINFO_T -#define HAVE_ARCH_COPY_SIGINFO_TO_USER32 -#define HAVE_ARCH_COPY_SIGINFO_FROM_USER32 #define SI_PAD_SIZE32 (128/sizeof(int) - 3) -typedef struct compat_siginfo { -int si_signo; -int si_errno; -int si_code; - -union { -int _pad[SI_PAD_SIZE32 ]; - -/* kill() */ -struct { -compat_pid_t _pid;/* sender's pid */ -__compat_uid_t _uid;/* sender's uid */ - } _kill; - -/* POSIX.1b timers */ -struct { -compat_timer_t _tid;/* timer id */ -int _overrun;/* overrun count */ -compat_sigval_t _sigval;/* same as below */ -int _sys_private;/* not to be passed to user */ - } _timer; - -/* POSIX.1b signals */ -struct { -compat_pid_t _pid;/* sender's pid */ -__compat_uid_t _uid;/* sender's uid */ -compat_sigval_t _sigval; - } _rt; - -/* SIGCHLD */ -struct { -compat_pid_t _pid;/* which child */ -__compat_uid_t _uid;/* sender's uid */ -int _status;/* exit code */ -compat_clock_t _utime; -compat_clock_t _stime; - } _sigchld; - -/* SIGILL, SIGFPE, SIGSEGV, SIGBUS, SIGEMT */ -struct { -unsigned int _addr;/* faulting insn/memory ref. */ - } _sigfault; - -/* SIGPOLL */ -struct { -int _band;/* POLL_IN, POLL_OUT, POLL_MSG */ -int _fd; - } _sigpoll; - -/* SIGSYS */ -struct { -unsigned int _call_addr;/* calling insn */ -int _syscall;/* triggering system call number */ -unsigned int _arch;/* AUDIT_ARCH_* of syscall */ - } _sigsys; - } _sifields; -}compat_siginfo_t ; +#define HAVE_ARCH_COPY_SIGINFO_TO_USER32 +#define HAVE_ARCH_COPY_SIGINFO_FROM_USER32 #define COMPAT_OFF_T_MAX 0x7fffffff#define COMPAT_LOFF_T_MAX 0x7fffffffffffffffL
Signature · 1 line
2.6.2
PATCH v2 14/20 powerpc: Use generic copy_siginfo_{to,from}_user32
In reply to Amanieu d'Antras--- arch/powerpc/include/asm/compat.h | 5 --- arch/powerpc/kernel/signal_32.c | 72 +-------------------------------------- 2 files changed, 1 insertion(+), 76 deletions(-)
arch/powerpc/include/asm/compat.h +0 -5
@@ -124,11 +124,6 @@ typedef union compat_sigval {compat_uptr_t sival_ptr; } compat_sigval_t; -#define SI_PAD_SIZE32 (128/sizeof(int) - 3) - -#define HAVE_ARCH_COPY_SIGINFO_TO_USER32 -#define HAVE_ARCH_COPY_SIGINFO_FROM_USER32 -#define COMPAT_OFF_T_MAX 0x7fffffff#define COMPAT_LOFF_T_MAX 0x7fffffffffffffffL
arch/powerpc/kernel/signal_32.c +1 -71
79 lines not on this page · raw message
Signature · 1 line
2.6.2
PATCH v2 15/20 tile: Use generic compat_siginfo_t
In reply to Amanieu d'Antras--- arch/tile/include/asm/compat.h | 57 ------------------------------------------ 1 file changed, 57 deletions(-)
arch/tile/include/asm/compat.h +0 -57
@@ -115,65 +115,8 @@ typedef union compat_sigval {compat_uptr_t sival_ptr; } compat_sigval_t; -#define HAVE_ARCH_COMPAT_SIGINFO_T #define HAVE_ARCH_COPY_SIGINFO_TO_USER32 #define HAVE_ARCH_COPY_SIGINFO_FROM_USER32 -#define COMPAT_SI_PAD_SIZE (128/sizeof(int) - 3) - -typedef struct compat_siginfo { -int si_signo; -int si_errno; -int si_code; - -union { -int _pad[COMPAT_SI_PAD_SIZE ]; - -/* kill() */ -struct { -unsigned int _pid;/* sender's pid */ -unsigned int _uid;/* sender's uid */ - } _kill; - -/* POSIX.1b timers */ -struct { -compat_timer_t _tid;/* timer id */ -int _overrun;/* overrun count */ -compat_sigval_t _sigval;/* same as below */ -int _sys_private;/* not to be passed to user */ -int _overrun_incr;/* amount to add to overrun */ - } _timer; - -/* POSIX.1b signals */ -struct { -unsigned int _pid;/* sender's pid */ -unsigned int _uid;/* sender's uid */ -compat_sigval_t _sigval; - } _rt; - -/* SIGCHLD */ -struct { -unsigned int _pid;/* which child */ -unsigned int _uid;/* sender's uid */ -int _status;/* exit code */ -compat_clock_t _utime; -compat_clock_t _stime; - } _sigchld; - -/* SIGILL, SIGFPE, SIGSEGV, SIGBUS */ -struct { -unsigned int _addr;/* faulting insn/memory ref. */ -#ifdef __ARCH_SI_TRAPNO -int _trapno;/* TRAP # which caused the signal */ -#endif - } _sigfault; - -/* SIGPOLL */ -struct { -int _band;/* POLL_IN, POLL_OUT, POLL_MSG */ -int _fd; - } _sigpoll; - } _sifields; -}compat_siginfo_t ;#define COMPAT_OFF_T_MAX 0x7fffffff#define COMPAT_LOFF_T_MAX 0x7fffffffffffffffL
Signature · 1 line
2.6.2
PATCH v2 16/20 tile: Use generic copy_siginfo_{to,from}_user32
In reply to Amanieu d'Antras--- arch/tile/include/asm/compat.h | 3 -- arch/tile/kernel/compat_signal.c | 75 ---------------------------------------- 2 files changed, 78 deletions(-)
arch/tile/include/asm/compat.h +0 -3
@@ -115,9 +115,6 @@ typedef union compat_sigval {compat_uptr_t sival_ptr; } compat_sigval_t; -#define HAVE_ARCH_COPY_SIGINFO_TO_USER32 -#define HAVE_ARCH_COPY_SIGINFO_FROM_USER32 -#define COMPAT_OFF_T_MAX 0x7fffffff#define COMPAT_LOFF_T_MAX 0x7fffffffffffffffL
arch/tile/kernel/compat_signal.c +0 -75
81 lines not on this page · raw message
Signature · 1 line
2.6.2
PATCH v2 17/20 sparc: Use generic compat_siginfo_t
In reply to Amanieu d'Antras--- arch/sparc/include/asm/compat.h | 54 ----------------------------------------- 1 file changed, 54 deletions(-)
arch/sparc/include/asm/compat.h +0 -54
@@ -153,62 +153,8 @@ typedef union compat_sigval {compat_uptr_t sival_ptr; } compat_sigval_t; -#define HAVE_ARCH_COMPAT_SIGINFO_T #define HAVE_ARCH_COPY_SIGINFO_TO_USER32 #define HAVE_ARCH_COPY_SIGINFO_FROM_USER32 -#define SI_PAD_SIZE32 (128/sizeof(int) - 3) - -typedef struct compat_siginfo { -int si_signo; -int si_errno; -int si_code; - -union { -int _pad[SI_PAD_SIZE32 ]; - -/* kill() */ -struct { -compat_pid_t _pid;/* sender's pid */ -unsigned int _uid;/* sender's uid */ - } _kill; - -/* POSIX.1b timers */ -struct { -compat_timer_t _tid;/* timer id */ -int _overrun;/* overrun count */ -compat_sigval_t _sigval;/* same as below */ -int _sys_private;/* not to be passed to user */ - } _timer; - -/* POSIX.1b signals */ -struct { -compat_pid_t _pid;/* sender's pid */ -unsigned int _uid;/* sender's uid */ -compat_sigval_t _sigval; - } _rt; - -/* SIGCHLD */ -struct { -compat_pid_t _pid;/* which child */ -unsigned int _uid;/* sender's uid */ -int _status;/* exit code */ -compat_clock_t _utime; -compat_clock_t _stime; - } _sigchld; - -/* SIGILL, SIGFPE, SIGSEGV, SIGBUS, SIGEMT */ -struct { -u32 _addr;/* faulting insn/memory ref. */ -int _trapno; - } _sigfault; - -/* SIGPOLL */ -struct { -int _band;/* POLL_IN, POLL_OUT, POLL_MSG */ -int _fd; - } _sigpoll; - } _sifields; -}compat_siginfo_t ;#define COMPAT_OFF_T_MAX 0x7fffffff#define COMPAT_LOFF_T_MAX 0x7fffffffffffffffL
Signature · 1 line
2.6.2
PATCH v2 18/20 sparc: Use generic copy_siginfo_{to,from}_user32
In reply to Amanieu d'Antras--- arch/sparc/include/asm/compat.h | 3 -- arch/sparc/kernel/signal32.c | 69 ----------------------------------------- 2 files changed, 72 deletions(-)
arch/sparc/include/asm/compat.h +0 -3
@@ -153,9 +153,6 @@ typedef union compat_sigval {compat_uptr_t sival_ptr; } compat_sigval_t; -#define HAVE_ARCH_COPY_SIGINFO_TO_USER32 -#define HAVE_ARCH_COPY_SIGINFO_FROM_USER32 -#define COMPAT_OFF_T_MAX 0x7fffffff#define COMPAT_LOFF_T_MAX 0x7fffffffffffffffL
arch/sparc/kernel/signal32.c +0 -69
75 lines not on this page · raw message
Signature · 1 line
2.6.2
PATCH v2 19/20 signalfd: Fix some issues in signalfd_copyinfo
In reply to Amanieu d'AntrasThere are several issues here:
1) The value of ssi_ptr was incorrect for compat tasks. It was previously copied directly from si_ptr, which contains garbage for 32-bit processes, especially on big-endian architectures.
2) A SIGSYS would cause various fields to be filled with incorrect values. SIGSYS fields are not in signalfd_siginfo, and it should avoid filling in unrelated fields.
3) ssi_ptr and ssi_int should not be filled in for any unrecognized si_code, but only for those generated by sigqueue. The si_ptr and si_int fields in siginfo_t may not be initialized otherwise.
4) ssi_ptr and ssi_addr values for compat tasks did not match those generated by 32-bit kernels. The values need to be sign-extended to 64 bits rather than zero-extended.
--- fs/signalfd.c | 58 ++++++++++++++++++++++++++++++++++++++++++---------------- 1 file changed, 42 insertions(+), 16 deletions(-)
fs/signalfd.c +42 -16
@@ -80,39 +80,66 @@ static unsigned int signalfd_poll(struct file *file, poll_table *wait)static int signalfd_copyinfo (struct signalfd_siginfo __user *uinfo,siginfo_t const *kinfo) { -long err; +long err, ssi_ptr, ssi_addr;BUILD_BUG_ON (sizeof (struct signalfd_siginfo ) !=128 );/* +* ssi_ptr for a compat task should be sourced from si_int instead +* of si_ptr since that is what copy_siginfo_from_user32 and +* get_compat_sigevent use. 32-bit pointer values are sign-extended +* to 64 bits when written to ssi_ptr, which matches the behavior of +* 32-bit kernels. +*/ + ssi_ptr =is_compat_task () ? kinfo->si_int : (long ) kinfo->si_ptr; + +/* * Unused members should be zero ... */ err =__clear_user (uinfo,sizeof (*uinfo));/* -* If you change siginfo_t structure, please be sure -* this code is fixed accordingly. +* If you change siginfo_t structure, please be sure that +* all these functions are fixed accordingly: +* copy_siginfo_to_user +* copy_siginfo_to_user32 +* copy_siginfo_from_user32 +* signalfd_copyinfo +* They should never copy any pad contained in the structure +* to avoid security leaks, but must copy the generic +* 3 ints plus the relevant union member. */ err |=__put_user (kinfo->si_signo, &uinfo->ssi_signo); err |=__put_user (kinfo->si_errno, &uinfo->ssi_errno); err |=__put_user ((short ) kinfo->si_code, &uinfo->ssi_code); +if (kinfo->si_code <0 ) { +/* Grab some standard fields for sigqueue()-generated signals */ + err |=__put_user (kinfo->si_pid, &uinfo->ssi_pid); + err |=__put_user (kinfo->si_uid, &uinfo->ssi_uid); + err |=__put_user (ssi_ptr, &uinfo->ssi_ptr); + err |=__put_user (kinfo->si_int, &uinfo->ssi_int); +return err ? -EFAULT :sizeof (*uinfo); + }switch (kinfo->si_code & __SI_MASK) {case __SI_KILL: err |=__put_user (kinfo->si_pid, &uinfo->ssi_pid); err |=__put_user (kinfo->si_uid, &uinfo->ssi_uid);break ;case __SI_TIMER: - err |=__put_user (kinfo->si_tid, &uinfo->ssi_tid); - err |=__put_user (kinfo->si_overrun, &uinfo->ssi_overrun); - err |=__put_user ((long ) kinfo->si_ptr, &uinfo->ssi_ptr); - err |=__put_user (kinfo->si_int, &uinfo->ssi_int); + err |=__put_user (kinfo->si_tid, &uinfo->ssi_tid); + err |=__put_user (kinfo->si_overrun, &uinfo->ssi_overrun); + err |=__put_user (ssi_ptr, &uinfo->ssi_ptr); + err |=__put_user (kinfo->si_int, &uinfo->ssi_int);break ;case __SI_POLL: err |=__put_user (kinfo->si_band, &uinfo->ssi_band); err |=__put_user (kinfo->si_fd, &uinfo->ssi_fd);break ;case __SI_FAULT: - err |=__put_user ((long ) kinfo->si_addr, &uinfo->ssi_addr); +/* Ensure that ssi_addr is sign-extended to 64 bits */ + ssi_addr =is_compat_task () ? (int )(long ) kinfo->si_addr : + (long ) kinfo->si_addr; + err |=__put_user (ssi_addr, &uinfo->ssi_addr);#ifdef __ARCH_SI_TRAPNO err |=__put_user (kinfo->si_trapno, &uinfo->ssi_trapno);#endif
@@ -139,21 +166,20 @@ static int signalfd_copyinfo(struct signalfd_siginfo __user *uinfo,case __SI_MESGQ:/* But this is */ err |=__put_user (kinfo->si_pid, &uinfo->ssi_pid); err |=__put_user (kinfo->si_uid, &uinfo->ssi_uid); - err |=__put_user ((long ) kinfo->si_ptr, &uinfo->ssi_ptr); + err |=__put_user (ssi_ptr, &uinfo->ssi_ptr); err |=__put_user (kinfo->si_int, &uinfo->ssi_int);break ; -default : -/* -* This case catches also the signals queued by sigqueue(). -*/ +#ifdef __ARCH_SIGSYS +case __SI_SYS:/* SIGSYS fields are not in signalfd_siginfo */ +break ; +#endif +default :/* this is just in case for now ... */ err |=__put_user (kinfo->si_pid, &uinfo->ssi_pid); err |=__put_user (kinfo->si_uid, &uinfo->ssi_uid); - err |=__put_user ((long ) kinfo->si_ptr, &uinfo->ssi_ptr); - err |=__put_user (kinfo->si_int, &uinfo->ssi_int);break ; } -return err ? -EFAULT :sizeof (*uinfo); +return err ? -EFAULT :sizeof (*uinfo); } static ssize_t signalfd_dequeue(struct signalfd_ctx *ctx, siginfo_t *info,
Signature · 1 line
2.6.2
PATCH v2 20/20 signal: Remove unnecessary zero-initialization of siginfo_t
In reply to Amanieu d'AntrasThis is no longer required since copy_siginfo_from_user32 now initializes all siginfo_t fields properly.
--- kernel/ptrace.c | 1 - kernel/signal.c | 4 ++-- 2 files changed, 2 insertions(+), 3 deletions(-)
kernel/ptrace.c +0 -1
@@ -1147,7 +1147,6 @@ int compat_ptrace_request(struct task_struct *child, compat_long_t request,break ;case PTRACE_SETSIGINFO : -memset (&siginfo,0 ,sizeof siginfo);if (copy_siginfo_from_user32 ( &siginfo, (struct compat_siginfo __user *) datap)) ret = -EFAULT ;
kernel/signal.c +2 -2
@@ -3022,7 +3022,7 @@ COMPAT_SYSCALL_DEFINE3(rt_sigqueueinfo, int, sig, struct compat_siginfo __user *, uinfo) { - siginfo_t info = {}; + siginfo_t info;int ret =copy_siginfo_from_user32 (&info, uinfo);if (unlikely (ret))return ret;
@@ -3066,7 +3066,7 @@ COMPAT_SYSCALL_DEFINE4(rt_tgsigqueueinfo, int, sig, struct compat_siginfo __user *, uinfo) { - siginfo_t info = {}; + siginfo_t info;if (copy_siginfo_from_user32 (&info, uinfo))return -EFAULT ;
Signature · 1 line
2.6.2
Quoted 4 lines · Amanieu d'Antras
One issue that isn't resolved in this series is sending signals between a 32-bit process and 64-bit process. Sending a
si_intwill work correctly, but asi_ptrvalue will likely get corrupted due to the different layouts of the 32-bit and 64-bitsiginfo_tstructures.
This is so screwed up it's not even funny.
A 64-bit big-endian compat calls rt_sigqueueinfo. It passes in (among other things) a sigval_t. The kernel can choose to interpret it as a pointer (call it p) or an integer (call it i). Then (unsigned long)p = (i<<32) | [something]. If the number was an integer to begin with *and* user code zeroed out the mess first, then [something] will be 0. Regardless, p != i unless they're both zero.
If the result gets delivered to a signalfd, then it's plausible that everything could work. If it gets delivered to a 64-bit siginfo, then all is well because it's in exactly the same screwed up state it was in when the signal gets sent.
If, however, it's delivered to a compat task, wtf is the kernel supposed to do? We're effectively supposed to convert a 64-bit sigval_t to a 32-bit sigval_t. On a little-endian architecture, we can fudge it because it doesn't really matter whether we consider the pointer or the int to be authoritative. I think that, on big-endian, we're screwed.
BTW, x86 has its own set of screwups here. Somehow cr2 and error_code ended up as part of ucontext instead of siginfo, which makes absolutely no sense to me and bloats task_struct.
--Andy
Oleg Nesterov
maintainerQuoted 8 lines · Andy Lutomirski
Quoted 4 lines · Amanieu d'Antras
One issue that isn't resolved in this series is sending signals between a 32-bit process and 64-bit process. Sending a
si_intwill work correctly, but asi_ptrvalue will likely get corrupted due to the different layouts of the 32-bit and 64-bitsiginfo_tstructures.This is so screwed up it's not even funny.
Agreed,
Quoted 2 lines
A 64-bit big-endian compat calls
rt_sigqueueinfo. It passes in (among other things) asigval_t. The kernel can choose to interpret it
I always thought that the kernel should not interpret it at all. And indeed, copy_siginfo_to_user() does
if (from->si_code < 0) return __copy_to_user(to, from, sizeof(siginfo_t))
probably copy_siginfo_to_user32() should do something similar, at least it should not truncate ->si_code it it is less than zero.
Not sure what signalfd_copyinfo() should do.
But perhaps I was wrong, I failed to find man sigqueueinfo, and man sigqueue() documents that it passes sigval_t.
Quoted 3 lines
BTW, x86 has its own set of screwups here. Somehow cr2 and
error_codeended up as part of ucontext instead of siginfo, which makes absolutely no sense to me and bloatstask_struct.
Yes, and probably ->ip should have been the part of siginfo too. Say, if you get SIGBUS you can't trust sc->ip if another signal was dequeued before SIGBUS, in this case sc->ip will point to the handler of that another signal. That is why we have SYNCHRONOUS_MASK and it helps, but still this doesn't look nice.
Oleg.