fpga: FPGA_MGR_ZYNQ_FPGA should depend on HAS_DMA
PATCH 1/1 fpga: FPGA_MGR_ZYNQ_FPGA should depend on HAS_DMA
If NO_DMA=y:
ERROR: "dma_free_coherent" [drivers/fpga/zynq-fpga.ko] undefined!
ERROR: "dma_alloc_coherent" [drivers/fpga/zynq-fpga.ko] undefined!
Add a dependency on HAS_DMA to fix this.
--- drivers/fpga/Kconfig | 1 + 1 file changed, 1 insertion(+)
drivers/fpga/Kconfig +1 -0
@@ -21,6 +21,7 @@ config FPGA_MGR_SOCFPGA config FPGA_MGR_ZYNQ_FPGA tristate "Xilinx Zynq FPGA" + depends on HAS_DMA help FPGA manager driver support for Xilinx Zynq FPGAs.
Signature · 1 line
1.9.1
On Mon, 9 Nov 2015, Geert Uytterhoeven wrote:
+ Moritz
Quoted 28 lines
If NO_DMA=y:
ERROR: "
dma_free_coherent" [drivers/fpga/zynq-fpga.ko] undefined!
ERROR: "dma_alloc_coherent" [drivers/fpga/zynq-fpga.ko] undefined!Add a dependency on
HAS_DMAto fix this.Signed-off-by Geert Uytterhoeven <[email protected]>--- drivers/fpga/Kconfig | 1 + 1 file changed, 1 insertion(+)drivers/fpga/Kconfig +1
-0@@ -21,6 +21,7 @@ config FPGA_MGR_SOCFPGA config FPGA_MGR_ZYNQ_FPGA tristate "Xilinx Zynq FPGA" + depends on HAS_DMA help FPGA manager driver support for Xilinx Zynq FPGAs.Signature · 1 line
1.9.1
On Mon, 9 Nov 2015, Geert Uytterhoeven wrote:
+Moritz
Quoted 28 lines
If NO_DMA=y:
ERROR: "
dma_free_coherent" [drivers/fpga/zynq-fpga.ko] undefined!
ERROR: "dma_alloc_coherent" [drivers/fpga/zynq-fpga.ko] undefined!Add a dependency on
HAS_DMAto fix this.Signed-off-by Geert Uytterhoeven <[email protected]>--- drivers/fpga/Kconfig | 1 + 1 file changed, 1 insertion(+)drivers/fpga/Kconfig +1
-0@@ -21,6 +21,7 @@ config FPGA_MGR_SOCFPGA config FPGA_MGR_ZYNQ_FPGA tristate "Xilinx Zynq FPGA" + depends on HAS_DMA help FPGA manager driver support for Xilinx Zynq FPGAs.Signature · 1 line
1.9.1
Moritz Fischer
Reviewed-byHi Alan, Geert
Quoted 28 lines · atull
On Mon, 9 Nov 2015, Geert Uytterhoeven wrote:
+Moritz
Quoted 24 lines
If NO_DMA=y:
ERROR: "
dma_free_coherent" [drivers/fpga/zynq-fpga.ko] undefined!
ERROR: "dma_alloc_coherent" [drivers/fpga/zynq-fpga.ko] undefined!Add a dependency on
HAS_DMAto fix this.Signed-off-by Geert Uytterhoeven <[email protected]>--- drivers/fpga/Kconfig | 1 + 1 file changed, 1 insertion(+)drivers/fpga/Kconfig +1
-0@@ -21,6 +21,7 @@ config FPGA_MGR_SOCFPGA config FPGA_MGR_ZYNQ_FPGA tristate "Xilinx Zynq FPGA" + depends on HAS_DMA help FPGA manager driver support for Xilinx Zynq FPGAs.
Quoted 4 lines
Quoted 4 lines
--
1.9.1
Good catch!
Alan,
if you don't mind I'll send you (or gregkh?) a patch with adding me as (co) maintainer, or Reviewer to the MAINTAINERS file so you don't have to forward manually next time
any more ;-) I doubt Geert's patch caught the last issue in zynq-fpga ;-)
Cheers,
Moritz
Quoted 42 lines · Moritz Fischer
Hi Alan, Geert
Quoted 28 lines · atull
On Mon, 9 Nov 2015, Geert Uytterhoeven wrote:
+Moritz
Quoted 24 lines
If NO_DMA=y:
ERROR: "
dma_free_coherent" [drivers/fpga/zynq-fpga.ko] undefined!
ERROR: "dma_alloc_coherent" [drivers/fpga/zynq-fpga.ko] undefined!Add a dependency on
HAS_DMAto fix this.Signed-off-by Geert Uytterhoeven <[email protected]>--- drivers/fpga/Kconfig | 1 + 1 file changed, 1 insertion(+)drivers/fpga/Kconfig +1
-0@@ -21,6 +21,7 @@ config FPGA_MGR_SOCFPGA config FPGA_MGR_ZYNQ_FPGA tristate "Xilinx Zynq FPGA" + depends on HAS_DMA help FPGA manager driver support for Xilinx Zynq FPGAs.Quoted 4 lines
Quoted 4 lines
--
1.9.1Good catch!
Reviewed-by Moritz Fischer <[email protected]>Alan,
Quoted 9 lines
if you don't mind I'll send you (or gregkh?) a patch with adding me as (co) maintainer, or Reviewer to the
MAINTAINERSfile so you don't have to forward manually next time
any more ;-) I doubt Geert's patch caught the last issue in zynq-fpga ;-)Cheers,
Moritz
Hi Moritz,
It would be great if you could be added as a Reviewer. Please submit the patch to Greg.
Alan