Skip to contentSkip to conversation

fpga: FPGA_MGR_ZYNQ_FPGA should depend on HAS_DMA

PATCH Superseded Geert Uytterhoeven 3 participants 5 messages Nov 9, 2015 – Nov 10, 2015 FPGA manager framework

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 fpga: FPGA_MGR_ZYNQ_FPGA should depend on HAS_DMA

If NO_DMA=y:

ERROR: "dma_free_coherent" [drivers/fpga/zynq-fpga.ko] undefined!
ERROR: "dma_alloc_coherent" [drivers/fpga/zynq-fpga.ko] undefined!

Add a dependency on HAS_DMA to fix this.

---
 drivers/fpga/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/fpga/Kconfig +1 -0
index c9b9fdf6cfbbeb6d..d61410299ec0cf80 100644
@@ -21,6 +21,7 @@ config FPGA_MGR_SOCFPGA
 
 config FPGA_MGR_ZYNQ_FPGA
 	tristate "Xilinx Zynq FPGA"
+	depends on HAS_DMA
 	help
 	  FPGA manager driver support for Xilinx Zynq FPGAs.
 
Signature · 1 line
1.9.1
#1 lore raw

On Mon, 9 Nov 2015, Geert Uytterhoeven wrote:
+ Moritz

Quoted 28 lines

If NO_DMA=y:

ERROR: "dma_free_coherent" [drivers/fpga/zynq-fpga.ko] undefined!
ERROR: "dma_alloc_coherent" [drivers/fpga/zynq-fpga.ko] undefined!

Add a dependency on HAS_DMA to fix this.

---
 drivers/fpga/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/fpga/Kconfig +1 -0
index c9b9fdf6cfbbeb6d..d61410299ec0cf80 100644
@@ -21,6 +21,7 @@ config FPGA_MGR_SOCFPGA
 
 config FPGA_MGR_ZYNQ_FPGA
 	tristate "Xilinx Zynq FPGA"
+	depends on HAS_DMA
 	help
 	  FPGA manager driver support for Xilinx Zynq FPGAs.
 
Signature · 1 line
1.9.1
#2 lore raw
In reply to Geert Uytterhoeven

On Mon, 9 Nov 2015, Geert Uytterhoeven wrote:

+Moritz

Quoted 28 lines

If NO_DMA=y:

ERROR: "dma_free_coherent" [drivers/fpga/zynq-fpga.ko] undefined!
ERROR: "dma_alloc_coherent" [drivers/fpga/zynq-fpga.ko] undefined!

Add a dependency on HAS_DMA to fix this.

---
 drivers/fpga/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/fpga/Kconfig +1 -0
index c9b9fdf6cfbbeb6d..d61410299ec0cf80 100644
@@ -21,6 +21,7 @@ config FPGA_MGR_SOCFPGA
 
 config FPGA_MGR_ZYNQ_FPGA
 	tristate "Xilinx Zynq FPGA"
+	depends on HAS_DMA
 	help
 	  FPGA manager driver support for Xilinx Zynq FPGAs.
 
Signature · 1 line
1.9.1
Reviewed-by
#3 lore raw

Hi Alan, Geert

Quoted 28 lines · atull

On Mon, 9 Nov 2015, Geert Uytterhoeven wrote:

+Moritz

Quoted 24 lines

If NO_DMA=y:

ERROR: "dma_free_coherent" [drivers/fpga/zynq-fpga.ko] undefined!
ERROR: "dma_alloc_coherent" [drivers/fpga/zynq-fpga.ko] undefined!

Add a dependency on HAS_DMA to fix this.

---
 drivers/fpga/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/fpga/Kconfig +1 -0
index c9b9fdf6cfbbeb6d..d61410299ec0cf80 100644
@@ -21,6 +21,7 @@ config FPGA_MGR_SOCFPGA
 
 config FPGA_MGR_ZYNQ_FPGA
      tristate "Xilinx Zynq FPGA"
+     depends on HAS_DMA
      help
        FPGA manager driver support for Xilinx Zynq FPGAs.
 
Quoted 4 lines
Quoted 4 lines

--
1.9.1

Good catch!

Alan,

if you don't mind I'll send you (or gregkh?) a patch with adding me as (co) maintainer, or Reviewer to the MAINTAINERS file so you don't have to forward manually next time
any more ;-) I doubt Geert's patch caught the last issue in zynq-fpga ;-)

Cheers,

Moritz

#4 lore raw
Quoted 42 lines · Moritz Fischer

Hi Alan, Geert

Quoted 28 lines · atull

On Mon, 9 Nov 2015, Geert Uytterhoeven wrote:

+Moritz

Quoted 24 lines

If NO_DMA=y:

ERROR: "dma_free_coherent" [drivers/fpga/zynq-fpga.ko] undefined!
ERROR: "dma_alloc_coherent" [drivers/fpga/zynq-fpga.ko] undefined!

Add a dependency on HAS_DMA to fix this.

---
 drivers/fpga/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/fpga/Kconfig +1 -0
index c9b9fdf6cfbbeb6d..d61410299ec0cf80 100644
@@ -21,6 +21,7 @@ config FPGA_MGR_SOCFPGA
 
 config FPGA_MGR_ZYNQ_FPGA
      tristate "Xilinx Zynq FPGA"
+     depends on HAS_DMA
      help
        FPGA manager driver support for Xilinx Zynq FPGAs.
 
Quoted 4 lines
Quoted 4 lines

--
1.9.1

Good catch!

Alan,

Quoted 9 lines

if you don't mind I'll send you (or gregkh?) a patch with adding me as (co) maintainer, or Reviewer to the MAINTAINERS file so you don't have to forward manually next time
any more ;-) I doubt Geert's patch caught the last issue in zynq-fpga ;-)

Cheers,

Moritz

Hi Moritz,

It would be great if you could be added as a Reviewer. Please submit the patch to Greg.

Alan