block: Call external_snapshot_clean after blockdev-snapshot
PATCH 1/1 block: Call external_snapshot_clean after blockdev-snapshot
Otherwise the AioContext will never be released.
Signed-off-by Alberto Garcia <[email protected]>
--- blockdev.c | 1 + 1 file changed, 1 insertion(+)
blockdev.c +1 -0
@@ -2070,6 +2070,7 @@ static const BlkActionOps actions[] = { .prepare = external_snapshot_prepare, .commit = external_snapshot_commit, .abort = external_snapshot_abort, + .clean = external_snapshot_clean, }, [TRANSACTION_ACTION_KIND_BLOCKDEV_SNAPSHOT_SYNC] = { .instance_size = sizeof(ExternalSnapshotState),
Signature · 1 line
2.6.2
Quoted 22 lines · Alberto Garcia
Otherwise the AioContext will never be released.
Signed-off-by Alberto Garcia <[email protected]>--- blockdev.c | 1 + 1 file changed, 1 insertion(+)blockdev.c +1
-0@@ -2070,6 +2070,7 @@ static const BlkActionOps actions[] = { .prepare = external_snapshot_prepare, .commit = external_snapshot_commit, .abort = external_snapshot_abort, + .clean = external_snapshot_clean, }, [TRANSACTION_ACTION_KIND_BLOCKDEV_SNAPSHOT_SYNC] = { .instance_size = sizeof(ExternalSnapshotState),Signature · 1 line
2.6.2
Reviewed-by Fam Zheng <[email protected]>
Max Reitz
AppliedQuoted 12 lines · Alberto Garcia
Otherwise the AioContext will never be released.
Signed-off-by Alberto Garcia <[email protected]>--- blockdev.c | 1 + 1 file changed, 1 insertion(+)blockdev.c +0
-0
blockdev.c static const BlkActionOps actions[] = { · line 2076
Quoted 7 lines
blockdev.c +1
-0@@ -2070,6 +2070,7 @@ static const BlkActionOps actions[] = { .prepare = external_snapshot_prepare, .commit = external_snapshot_commit, .abort = external_snapshot_abort, + .clean = external_snapshot_clean, }, [TRANSACTION_ACTION_KIND_BLOCKDEV_SNAPSHOT_SYNC] = { .instance_size = sizeof(ExternalSnapshotState),
Thanks, applied to my block tree:
https://github.com/XanClic/qemu/commits/block
Max