Skip to contentSkip to conversation

block: Call external_snapshot_clean after blockdev-snapshot

PATCH Applied Alberto Garcia 3 participants 3 messages Nov 13, 2015 – Nov 16, 2015

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 block: Call external_snapshot_clean after blockdev-snapshot

Otherwise the AioContext will never be released.

---
 blockdev.c | 1 +
 1 file changed, 1 insertion(+)
blockdev.c +1 -0
index fc85128..4dcc510 100644
@@ -2070,6 +2070,7 @@ static const BlkActionOps actions[] = {
         .prepare  = external_snapshot_prepare,
         .commit   = external_snapshot_commit,
         .abort = external_snapshot_abort,
+        .clean = external_snapshot_clean,
     },
     [TRANSACTION_ACTION_KIND_BLOCKDEV_SNAPSHOT_SYNC] = {
         .instance_size = sizeof(ExternalSnapshotState),
Signature · 1 line
2.6.2
Reviewed-by on v1 1/1
#1 lore raw
Quoted 22 lines · Alberto Garcia

Otherwise the AioContext will never be released.

---
 blockdev.c | 1 +
 1 file changed, 1 insertion(+)
blockdev.c +1 -0
index fc85128..4dcc510 100644
@@ -2070,6 +2070,7 @@ static const BlkActionOps actions[] = {
         .prepare  = external_snapshot_prepare,
         .commit   = external_snapshot_commit,
         .abort = external_snapshot_abort,
+        .clean = external_snapshot_clean,
     },
     [TRANSACTION_ACTION_KIND_BLOCKDEV_SNAPSHOT_SYNC] = {
         .instance_size = sizeof(ExternalSnapshotState),
Signature · 1 line
2.6.2
Applied
#2 lore raw
In reply to Alberto Garcia
Quoted 12 lines · Alberto Garcia

Otherwise the AioContext will never be released.

---
 blockdev.c | 1 +
 1 file changed, 1 insertion(+)
blockdev.c +0 -0
index fc85128..4dcc510 100644

blockdev.c static const BlkActionOps actions[] = { · line 2076

Quoted 7 lines
blockdev.c +1 -0
@@ -2070,6 +2070,7 @@ static const BlkActionOps actions[] = {
         .prepare  = external_snapshot_prepare,
         .commit   = external_snapshot_commit,
         .abort = external_snapshot_abort,
+        .clean = external_snapshot_clean,
     },
     [TRANSACTION_ACTION_KIND_BLOCKDEV_SNAPSHOT_SYNC] = {
         .instance_size = sizeof(ExternalSnapshotState),

Thanks, applied to my block tree:

https://github.com/XanClic/qemu/commits/block

Max