ia64: bitvector_process could read out of bounds
PATCH 1/1 ia64: bitvector_process could read out of bounds
The units[] array could be accessed out of its bounds due the lack of verification of the max vector value.
To make this function not prone to error "P" and "E" suffixes were added. Despite the new suffixes are unrelated to current ia64 vm magnitudes, they make the code ready for it and avoid misleadings.
Catched using static analysis (cppcheck).
--- arch/ia64/kernel/palinfo.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/ia64/kernel/palinfo.c +1 -1
@@ -126,7 +126,7 @@ static const char *mem_attrib[]={static void bitvector_process (struct seq_file *m,u64 vector) {int i,j; -static const char *units[]={"" ,"K" ,"M" ,"G" ,"T" }; +static const char *units[] = {"" ,"K" ,"M" ,"G" ,"T" ,"P" ,"E" };for (i=0 , j=0 ; i <64 ; i++ , j=i/10 ) {if (vector &0x1 )
Signature · 1 line
2.6.2
Quoted 6 lines · Geyslan G. Bem
The units[] array could be accessed out of its bounds due the lack of verification of the max vector value.
To make this function not prone to error "P" and "E" suffixes were added. Despite the new suffixes are unrelated to current ia64 vm magnitudes, they make the code ready for it and avoid misleadings.
I would mention that you also fix some white space issues, but other than that:
Quoted 25 lines
Catched using static analysis (cppcheck).
Signed-off-by Geyslan G. Bem <[email protected]>--- arch/ia64/kernel/palinfo.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)arch/ia64/kernel/palinfo.c +1
-2@@ -126,7 +126,7 @@ static const char *mem_attrib[]={static void bitvector_process (struct seq_file *m,u64 vector) {int i,j; -static const char *units[]={"" ,"K" ,"M" ,"G" ,"T" }; +static const char *units[] = {"" ,"K" ,"M" ,"G" ,"T" ,"P" ,"E" };for (i=0 , j=0 ; i <64 ; i++ , j=i/10 ) {if (vector &0x1 ) --2.6.2
Signature · 1 line
Peter