Skip to contentSkip to conversation

netfilter: Initialize local variables to NULL, to prevent using them when uninitialized.

PATCH In review Tomer Barletz 2 participants 2 messages Dec 5, 2015 – Dec 9, 2015

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 netfilter: Initialize local variables to NULL, to prevent using them when uninitialized.

---
 net/netfilter/nfnetlink_queue.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
net/netfilter/nfnetlink_queue.c +2 -2
index 7d81d28..e8be660 100644
@@ -313,7 +313,7 @@ nfqnl_build_packet_message(struct net *net, struct nfqnl_instance *queue,
 	struct net_device *outdev;
 	struct nf_conn *ct = NULL;
 	enum ip_conntrack_info uninitialized_var(ctinfo);
-	struct nfnl_ct_hook *nfnl_ct;
+	struct nfnl_ct_hook *nfnl_ct = NULL;
 	bool csum_verify;
 	char *secdata = NULL;
 	u32 seclen = 0;
@@ -1041,7 +1041,7 @@ nfqnl_recv_verdict(struct sock *ctnl, struct sk_buff *skb,
 	unsigned int verdict;
 	struct nf_queue_entry *entry;
 	enum ip_conntrack_info uninitialized_var(ctinfo);
-	struct nfnl_ct_hook *nfnl_ct;
+	struct nfnl_ct_hook *nfnl_ct = NULL;
 	struct nf_conn *ct = NULL;
 
 	struct net *net = sock_net(ctnl);
Signature · 1 line
2.5.0