netfilter: Initialize local variables to NULL, to prevent using them when uninitialized.
Subsystems (3)
PATCH 1/1 netfilter: Initialize local variables to NULL, to prevent using them when uninitialized.
Signed-off-by Tomer Barletz <[email protected]>
--- net/netfilter/nfnetlink_queue.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
net/netfilter/nfnetlink_queue.c +2 -2
@@ -313,7 +313,7 @@ nfqnl_build_packet_message(struct net *net, struct nfqnl_instance *queue,struct net_device *outdev;struct nf_conn *ct =NULL ;enum ip_conntrack_info uninitialized_var (ctinfo ); -struct nfnl_ct_hook *nfnl_ct; +struct nfnl_ct_hook *nfnl_ct =NULL ;bool csum_verify;char *secdata =NULL ;u32 seclen =0 ;
@@ -1041,7 +1041,7 @@ nfqnl_recv_verdict(struct sock *ctnl, struct sk_buff *skb,unsigned int verdict;struct nf_queue_entry *entry;enum ip_conntrack_info uninitialized_var (ctinfo ); -struct nfnl_ct_hook *nfnl_ct; +struct nfnl_ct_hook *nfnl_ct =NULL ;struct nf_conn *ct =NULL ;struct net *net =sock_net (ctnl);
Signature · 1 line
2.5.0
Pablo Neira Ayuso
maintainerWe already have this:
We'll be sending this today to David to avoid this annoyance.
Thanks for you patch anyway.