vmcore-dmesg: Define _GNU_SOURCE
Subsystems (2)
PATCH 1/1 vmcore-dmesg: Define _GNU_SOURCE
loff_t is guarded with _GNU_SOURCE on some C library implementations e.g. musl since this type is not defined by POSIX. Define _GNU_SOURCE to include this define, it should help compiling on musl while nothing changes for glibc based systems since there _GNU_SOURCE is already defined
--- vmcore-dmesg/vmcore-dmesg.c | 1 + 1 file changed, 1 insertion(+)
vmcore-dmesg/vmcore-dmesg.c +1 -0
@@ -1,4 +1,5 @@#define _XOPEN_SOURCE 600 +#define _GNU_SOURCE#define _LARGEFILE_SOURCE 1#define _FILE_OFFSET_BITS 64#include <endian.h>
Signature · 7 lines
2.7.0 _______________________________________________ kexec mailing list [email protected] http://lists.infradead.org/mailman/listinfo/kexec
Quoted 7 lines · Khem Raj
loff_tis guarded with_GNU_SOURCEon some C library implementations e.g. musl since this type is not defined by POSIX. Define_GNU_SOURCEto include this define, it should help compiling on musl while nothing changes for glibc based systems since there_GNU_SOURCEis already definedSigned-off-by Khem Raj <[email protected]>
This appears to still be needed...
Quoted 9 lines
---
vmcore-dmesg/vmcore-dmesg.c | 1 +1 file changed, 1 insertion(+)vmcore-dmesg/vmcore-dmesg.c +0
-0
vmcore-dmesg/vmcore-dmesg.c line 5
Quoted 5 lines
vmcore-dmesg/vmcore-dmesg.c +1
-0@@ -1,4 +1,5 @@ #define _XOPEN_SOURCE 600 +#define _GNU_SOURCE #define _LARGEFILE_SOURCE 1 #define _FILE_OFFSET_BITS 64 #include
_______________________________________________
kexec mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/kexec
Quoted 10 lines · David Woodhouse
Quoted 7 lines · Khem Raj
loff_tis guarded with_GNU_SOURCEon some C library implementations e.g. musl since this type is not defined by POSIX. Define_GNU_SOURCEto include this define, it should help compiling on musl while nothing changes for glibc based systems since there_GNU_SOURCEis already definedSigned-off-by Khem Raj <[email protected]>This appears to still be needed...
For some reason it did not hit my inbox :(
Shall I pick up the version you reposted as PATCH 7/7 ?
Quoted 13 lines
Quoted 13 lines
---
vmcore-dmesg/vmcore-dmesg.c | 1 +1 file changed, 1 insertion(+)vmcore-dmesg/vmcore-dmesg.c +1
-0@@ -1,4 +1,5 @@ #define _XOPEN_SOURCE 600 +#define _GNU_SOURCE #define _LARGEFILE_SOURCE 1 #define _FILE_OFFSET_BITS 64
Quoted 8 lines
vmcore-dmesg/vmcore-dmesg.c line 5
Quoted 1 line
vmcore-dmesg/vmcore-dmesg.c +0
-0#include_______________________________________________
kexec mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/kexec
_______________________________________________
kexec mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/kexec
Quoted 4 lines · Simon Horman
For some reason it did not hit my inbox :(
Shall I pick up the version you reposted as PATCH 7/7 ?
That works. There's a github PR too if that's easier to consume. Which wasn't *intended* to include this patch as it was for the uImage bits, but I made it from the wrong branch and didn't bother to redo it.
_______________________________________________
kexec mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/kexec
Quoted 9 lines · David Woodhouse
Quoted 4 lines · Simon Horman
For some reason it did not hit my inbox :(
Shall I pick up the version you reposted as PATCH 7/7 ?
That works. There's a github PR too if that's easier to consume. Which wasn't *intended* to include this patch as it was for the uImage bits, but I made it from the wrong branch and didn't bother to redo it.
Thanks, its rather convenient for me that it did include the patch in question. I have applied the series.
_______________________________________________
kexec mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/kexec