Skip to contentSkip to conversation

vmcore-dmesg: Define _GNU_SOURCE

PATCH In review Khem Raj 3 participants 5 messages Jan 10, 2016 – Mar 13, 2017

Subsystems (2)
lore
Share & tools
lore

Khem Raj

author
#0 lore raw

PATCH 1/1 vmcore-dmesg: Define _GNU_SOURCE

loff_t is guarded with _GNU_SOURCE on some C library implementations e.g. musl since this type is not defined by POSIX. Define _GNU_SOURCE to include this define, it should help compiling on musl while nothing changes for glibc based systems since there _GNU_SOURCE is already defined

---
 vmcore-dmesg/vmcore-dmesg.c | 1 +
 1 file changed, 1 insertion(+)
vmcore-dmesg/vmcore-dmesg.c +1 -0
index 0364636..a8f56df 100644
@@ -1,4 +1,5 @@
 #define _XOPEN_SOURCE 600
+#define _GNU_SOURCE
 #define _LARGEFILE_SOURCE 1
 #define _FILE_OFFSET_BITS 64
 #include <endian.h>
Signature · 7 lines
2.7.0


_______________________________________________
kexec mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/kexec
#1 lore raw
Quoted 7 lines · Khem Raj

loff_t is guarded with _GNU_SOURCE on some C library implementations e.g. musl since this type is not defined by POSIX. Define _GNU_SOURCE to include this define, it should help compiling on musl while nothing changes for glibc based systems since there _GNU_SOURCE is already defined

This appears to still be needed...

Quoted 9 lines

---
 vmcore-dmesg/vmcore-dmesg.c | 1 +

 1 file changed, 1 insertion(+)
vmcore-dmesg/vmcore-dmesg.c +0 -0
index 0364636..a8f56df 100644

vmcore-dmesg/vmcore-dmesg.c line 5

Quoted 5 lines
vmcore-dmesg/vmcore-dmesg.c +1 -0
@@ -1,4 +1,5 @@
  #define _XOPEN_SOURCE 600
+#define _GNU_SOURCE
  #define _LARGEFILE_SOURCE 1
  #define _FILE_OFFSET_BITS 64
  #include 

_______________________________________________
kexec mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/kexec

#2 lore raw
Quoted 10 lines · David Woodhouse
Quoted 7 lines · Khem Raj

loff_t is guarded with _GNU_SOURCE on some C library implementations e.g. musl since this type is not defined by POSIX. Define _GNU_SOURCE to include this define, it should help compiling on musl while nothing changes for glibc based systems since there _GNU_SOURCE is already defined

This appears to still be needed...

For some reason it did not hit my inbox :(

Shall I pick up the version you reposted as PATCH 7/7 ?

Quoted 13 lines
Quoted 13 lines

---
 vmcore-dmesg/vmcore-dmesg.c | 1 +

 1 file changed, 1 insertion(+)
vmcore-dmesg/vmcore-dmesg.c +1 -0
index 0364636..a8f56df 100644
@@ -1,4 +1,5 @@
  #define _XOPEN_SOURCE 600
+#define _GNU_SOURCE
  #define _LARGEFILE_SOURCE 1
  #define _FILE_OFFSET_BITS 64
Quoted 8 lines

vmcore-dmesg/vmcore-dmesg.c line 5

Quoted 1 line
vmcore-dmesg/vmcore-dmesg.c +0 -0
  #include 

_______________________________________________
kexec mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/kexec

_______________________________________________
kexec mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/kexec

#3 lore raw
Quoted 4 lines · Simon Horman

For some reason it did not hit my inbox :(

Shall I pick up the version you reposted as PATCH 7/7 ?

That works. There's a github PR too if that's easier to consume. Which wasn't *intended* to include this patch as it was for the uImage bits, but I made it from the wrong branch and didn't bother to redo it.

_______________________________________________
kexec mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/kexec

#4 lore raw
Quoted 9 lines · David Woodhouse
Quoted 4 lines · Simon Horman

For some reason it did not hit my inbox :(

Shall I pick up the version you reposted as PATCH 7/7 ?

That works. There's a github PR too if that's easier to consume. Which wasn't *intended* to include this patch as it was for the uImage bits, but I made it from the wrong branch and didn't bother to redo it.

Thanks, its rather convenient for me that it did include the patch in question. I have applied the series.

_______________________________________________
kexec mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/kexec