Skip to contentSkip to conversation

hpet: drop stale link

PATCH In review Michael S. Tsirkin 4 participants 4 messages Feb 10, 2016 – Feb 18, 2016

Subsystems (5)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 hpet: drop stale link

Looks like the HPET spec at intel.com got moved. It isn't hard to find so drop the link, just mention the revision assumed.

---

Changes from v1:
actually drop the links, just say "revision 1" in case a new one ever comes out.

 drivers/char/hpet.c           | 2 +-
 Documentation/timers/hpet.txt | 4 +---
 arch/x86/Kconfig              | 4 ++--
 3 files changed, 4 insertions(+), 6 deletions(-)
drivers/char/hpet.c +1 -1
index 240b6cf..be54e53 100644
@@ -42,7 +42,7 @@
 /*
  * The High Precision Event Timer driver.
  * This driver is closely modelled after the rtc.c driver.
- * http://www.intel.com/hardwaredesign/hpetspec_1.pdf
+ * See HPET spec revision 1.
  */
 #define	HPET_USER_FREQ	(64)
 #define	HPET_DRIFT	(500)
Documentation/timers/hpet.txt +1 -3
index 767392f..a484d2c 100644
@@ -1,9 +1,7 @@
 		High Precision Event Timer Driver for Linux
 
 The High Precision Event Timer (HPET) hardware follows a specification
-by Intel and Microsoft which can be found at
-
-	http://www.intel.com/hardwaredesign/hpetspec_1.pdf
+by Intel and Microsoft, revision 1.
 
 Each HPET has one fixed-rate counter (at 10+ MHz, hence "High Precision")
 and up to 32 comparators.  Normally three or more comparators are provided,
arch/x86/Kconfig +2 -2
index 9af2e63..ae79bab 100644
@@ -777,8 +777,8 @@ config HPET_TIMER
 	  HPET is the next generation timer replacing legacy 8254s.
 	  The HPET provides a stable time base on SMP
 	  systems, unlike the TSC, but it is more expensive to access,
-	  as it is off-chip.  You can find the HPET spec at
-	  <http://www.intel.com/hardwaredesign/hpetspec_1.pdf>.
+	  as it is off-chip.  The interface used is documented
+	  in the HPET spec, revision 1.
 
 	  You can safely choose Y here.  However, HPET will only be
 	  activated if the platform and the BIOS support this feature.
Signature · 1 line
MST
maintainer Acked-by on v2 1/1
#1 lore raw
Quoted 8 lines · Michael S. Tsirkin

Looks like the HPET spec at intel.com got moved. It isn't hard to find so drop the link, just mention the revision assumed.

---

Quoted 9 lines

Changes from v1:
actually drop the links, just say "revision 1" in case a new one ever comes out.

 drivers/char/hpet.c           | 2 +-
 Documentation/timers/hpet.txt | 4 +---
 arch/x86/Kconfig              | 4 ++--
 3 files changed, 4 insertions(+), 6 deletions(-)
#2 lore raw

[tip:x86/urgent] hpet: Drop stale URLs

In reply to Michael S. Tsirkin
hpet: Drop stale URLs
Commit-ID:  4e7f9df25874cedbbc604a5c5c2e7a6efe662387
Gitweb:     http://git.kernel.org/tip/4e7f9df25874cedbbc604a5c5c2e7a6efe662387
Author:     Michael S. Tsirkin <[email protected]>
AuthorDate: Thu, 11 Feb 2016 01:05:01 +0200
Committer:  Ingo Molnar <[email protected]>
CommitDate: Wed, 17 Feb 2016 09:39:56 +0100

hpet: Drop stale URLs

Looks like the HPET spec at intel.com got moved. It isn't hard to find so drop the link, just mention the revision assumed.

---
 Documentation/timers/hpet.txt | 4 +---
 arch/x86/Kconfig              | 4 ++--
 drivers/char/hpet.c           | 2 +-
 3 files changed, 4 insertions(+), 6 deletions(-)
Documentation/timers/hpet.txt +1 -3
index 767392f..a484d2c 100644
@@ -1,9 +1,7 @@
 		High Precision Event Timer Driver for Linux
 
 The High Precision Event Timer (HPET) hardware follows a specification
-by Intel and Microsoft which can be found at
-
-	http://www.intel.com/hardwaredesign/hpetspec_1.pdf
+by Intel and Microsoft, revision 1.
 
 Each HPET has one fixed-rate counter (at 10+ MHz, hence "High Precision")
 and up to 32 comparators.  Normally three or more comparators are provided,
arch/x86/Kconfig +2 -2
index ab2ed53..c46662f 100644
@@ -778,8 +778,8 @@ config HPET_TIMER
 	  HPET is the next generation timer replacing legacy 8254s.
 	  The HPET provides a stable time base on SMP
 	  systems, unlike the TSC, but it is more expensive to access,
-	  as it is off-chip.  You can find the HPET spec at
-	  <http://www.intel.com/hardwaredesign/hpetspec_1.pdf>.
+	  as it is off-chip.  The interface used is documented
+	  in the HPET spec, revision 1.
 
 	  You can safely choose Y here.  However, HPET will only be
 	  activated if the platform and the BIOS support this feature.
drivers/char/hpet.c +1 -1
index 240b6cf..be54e53 100644
@@ -42,7 +42,7 @@
 /*
  * The High Precision Event Timer driver.
  * This driver is closely modelled after the rtc.c driver.
- * http://www.intel.com/hardwaredesign/hpetspec_1.pdf
+ * See HPET spec revision 1.
  */
 #define	HPET_USER_FREQ	(64)
 #define	HPET_DRIFT	(500)
#3 lore raw

Re: [tip:x86/urgent] hpet: Drop stale URLs

Hi,

Quoted 7 lines · tip-bot for Michael S. Tsirkin
Commit-ID:  4e7f9df25874cedbbc604a5c5c2e7a6efe662387
Gitweb:     http://git.kernel.org/tip/4e7f9df25874cedbbc604a5c5c2e7a6efe662387
Author:     Michael S. Tsirkin <[email protected]>
AuthorDate: Thu, 11 Feb 2016 01:05:01 +0200
Committer:  Ingo Molnar <[email protected]>
CommitDate: Wed, 17 Feb 2016 09:39:56 +0100
Quoted 5 lines

hpet: Drop stale URLs

Looks like the HPET spec at intel.com got moved. It isn't hard to find so drop the link, just mention the revision assumed.

While URLs unfortunately often are less permanent than possibly intended (details see useful entire sub content of
"Aw: Re: Checkout hangs on invalid external URL"
http://svn.haxx.se/users/archive-2015-11/0027.shtml)
and thus too often need to be updated or even removed as a consequence, I feel that once an URL as a very reliable reference has been lost, naming of a file likely is the next most reliable fallback reference (to at least have feeding into an Internet search engine
as the next fallback step).
An alternative/second reference
would have been listing the full title of this existing document, too.

Thus I'm questioning whether the exact file name
should in fact be removed here (at 3 locations even) by this commit, while at least usefully adding
a (albeit somewhat weak) reference of "revision 1".

Documentation/timers/hpet.txt line 4

Quoted 5 lines

The High Precision Event Timer (HPET) hardware follows a specification

Documentation/timers/hpet.txt +1 -3
-by Intel and Microsoft which can be found at
-
-	http://www.intel.com/hardwaredesign/hpetspec_1.pdf
+by Intel and Microsoft, revision 1.

Oh, and I noticed as a curiosity (or so I thought)
that this cleanup-style work is (to be made?) part of "x86/urgent", which I didn't expect to be defined as topically related.

Thanks,

Andreas Mohr