Skip to contentSkip to conversation

hpet: drop stale link

PATCH Superseded Michael S. Tsirkin 3 participants 5 messages Feb 1, 2016 – Feb 10, 2016

Subsystems (5)

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 hpet: drop stale link

Looks like the HPET spec at intel.com got moved. It isn't hard to find so drop the link, just mention the revision assumed.

---
 drivers/char/hpet.c           | 2 +-
 Documentation/timers/hpet.txt | 2 +-
 arch/x86/Kconfig              | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)
drivers/char/hpet.c +1 -1
index 240b6cf..86c5f4d 100644
@@ -42,7 +42,7 @@
 /*
  * The High Precision Event Timer driver.
  * This driver is closely modelled after the rtc.c driver.
- * http://www.intel.com/hardwaredesign/hpetspec_1.pdf
+ * http://www.intel.com/content/dam/www/public/us/en/documents/technical-specifications/software-developers-hpet-spec-1-0a.pdf
  */
 #define	HPET_USER_FREQ	(64)
 #define	HPET_DRIFT	(500)
Documentation/timers/hpet.txt +1 -1
index 767392f..f24e978 100644
@@ -3,7 +3,7 @@
 The High Precision Event Timer (HPET) hardware follows a specification
 by Intel and Microsoft which can be found at
 
-	http://www.intel.com/hardwaredesign/hpetspec_1.pdf
+http://www.intel.com/content/dam/www/public/us/en/documents/technical-specifications/software-developers-hpet-spec-1-0a.pdf
 
 Each HPET has one fixed-rate counter (at 10+ MHz, hence "High Precision")
 and up to 32 comparators.  Normally three or more comparators are provided,
arch/x86/Kconfig +1 -1
index 9af2e63..f32faba 100644
@@ -778,7 +778,7 @@ config HPET_TIMER
 	  The HPET provides a stable time base on SMP
 	  systems, unlike the TSC, but it is more expensive to access,
 	  as it is off-chip.  You can find the HPET spec at
-	  <http://www.intel.com/hardwaredesign/hpetspec_1.pdf>.
+	  <http://www.intel.com/content/dam/www/public/us/en/documents/technical-specifications/software-developers-hpet-spec-1-0a.pdf>.
 
 	  You can safely choose Y here.  However, HPET will only be
 	  activated if the platform and the BIOS support this feature.
Signature · 1 line
MST
#1 lore raw
Quoted 43 lines · Michael S. Tsirkin

Looks like the HPET spec at intel.com got moved. It isn't hard to find so drop the link, just mention the revision assumed.

---
 drivers/char/hpet.c           | 2 +-
 Documentation/timers/hpet.txt | 2 +-
 arch/x86/Kconfig              | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)
drivers/char/hpet.c +1 -1
index 240b6cf..86c5f4d 100644
@@ -42,7 +42,7 @@
 /*
  * The High Precision Event Timer driver.
  * This driver is closely modelled after the rtc.c driver.
- * http://www.intel.com/hardwaredesign/hpetspec_1.pdf
+ * http://www.intel.com/content/dam/www/public/us/en/documents/technical-specifications/software-developers-hpet-spec-1-0a.pdf
  */
 #define	HPET_USER_FREQ	(64)
 #define	HPET_DRIFT	(500)
Documentation/timers/hpet.txt +1 -1
index 767392f..f24e978 100644
@@ -3,7 +3,7 @@
 The High Precision Event Timer (HPET) hardware follows a specification
 by Intel and Microsoft which can be found at
 
-	http://www.intel.com/hardwaredesign/hpetspec_1.pdf
+http://www.intel.com/content/dam/www/public/us/en/documents/technical-specifications/software-developers-hpet-spec-1-0a.pdf
 
 Each HPET has one fixed-rate counter (at 10+ MHz, hence "High Precision")
 and up to 32 comparators.  Normally three or more comparators are provided,
arch/x86/Kconfig +0 -0
index 9af2e63..f32faba 100644

arch/x86/Kconfig config HPET_TIMER · line 784

Quoted 8 lines
arch/x86/Kconfig +1 -1
@@ -778,7 +778,7 @@ config HPET_TIMER
 	  The HPET provides a stable time base on SMP
 	  systems, unlike the TSC, but it is more expensive to access,
 	  as it is off-chip.  You can find the HPET spec at
-	  <http://www.intel.com/hardwaredesign/hpetspec_1.pdf>.
+	  <http://www.intel.com/content/dam/www/public/us/en/documents/technical-specifications/software-developers-hpet-spec-1-0a.pdf>.
 
 	  You can safely choose Y here.  However, HPET will only be
 	  activated if the platform and the BIOS support this feature.

In fact we can also remove the link from this Kconfig entry, as it's highly unlikely that a user doing kernel configuration would want to start reading a spec.

Thanks,

Ingo

#2 lore raw
Quoted 59 lines · Ingo Molnar
Quoted 43 lines · Michael S. Tsirkin

Looks like the HPET spec at intel.com got moved. It isn't hard to find so drop the link, just mention the revision assumed.

---
 drivers/char/hpet.c           | 2 +-
 Documentation/timers/hpet.txt | 2 +-
 arch/x86/Kconfig              | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)
drivers/char/hpet.c +1 -1
index 240b6cf..86c5f4d 100644
@@ -42,7 +42,7 @@
 /*
  * The High Precision Event Timer driver.
  * This driver is closely modelled after the rtc.c driver.
- * http://www.intel.com/hardwaredesign/hpetspec_1.pdf
+ * http://www.intel.com/content/dam/www/public/us/en/documents/technical-specifications/software-developers-hpet-spec-1-0a.pdf
  */
 #define	HPET_USER_FREQ	(64)
 #define	HPET_DRIFT	(500)
Documentation/timers/hpet.txt +1 -1
index 767392f..f24e978 100644
@@ -3,7 +3,7 @@
 The High Precision Event Timer (HPET) hardware follows a specification
 by Intel and Microsoft which can be found at
 
-	http://www.intel.com/hardwaredesign/hpetspec_1.pdf
+http://www.intel.com/content/dam/www/public/us/en/documents/technical-specifications/software-developers-hpet-spec-1-0a.pdf
 
 Each HPET has one fixed-rate counter (at 10+ MHz, hence "High Precision")
 and up to 32 comparators.  Normally three or more comparators are provided,
arch/x86/Kconfig +0 -0
index 9af2e63..f32faba 100644

arch/x86/Kconfig config HPET_TIMER · line 784

Quoted 8 lines
arch/x86/Kconfig +1 -1
@@ -778,7 +778,7 @@ config HPET_TIMER
 	  The HPET provides a stable time base on SMP
 	  systems, unlike the TSC, but it is more expensive to access,
 	  as it is off-chip.  You can find the HPET spec at
-	  <http://www.intel.com/hardwaredesign/hpetspec_1.pdf>.
+	  <http://www.intel.com/content/dam/www/public/us/en/documents/technical-specifications/software-developers-hpet-spec-1-0a.pdf>.
 
 	  You can safely choose Y here.  However, HPET will only be
 	  activated if the platform and the BIOS support this feature.

In fact we can also remove the link from this Kconfig entry, as it's highly unlikely that a user doing kernel configuration would want to start reading a spec.

Quoted 3 lines

Thanks,

Ingo

Hmm looks like the patch does not match the description. Maybe I forgot to commit, or something.
Sorry - will repost.

maintainer
#3 lore raw
In reply to Michael S. Tsirkin
Quoted 3 lines · On Mon, 1 Feb 2016 13:32:56 +0200 "Michael S. Tsirkin" <[email protected]> wrote:

Looks like the HPET spec at intel.com got moved. It isn't hard to find so drop the link, just mention the revision assumed.

Hmm...what I see suggests this patch doesn't do that...

Quoted 3 lines

- * http://www.intel.com/hardwaredesign/hpetspec_1.pdf
+ * http://www.intel.com/content/dam/www/public/us/en/documents/technical-specifications/software-developers-hpet-spec-1-0a.pdf

..?

jon

#4 lore raw
Quoted 9 lines · Jonathan Corbet
Quoted 3 lines · On Mon, 1 Feb 2016 13:32:56 +0200 "Michael S. Tsirkin" <[email protected]> wrote:

Looks like the HPET spec at intel.com got moved. It isn't hard to find so drop the link, just mention the revision assumed.

Hmm...what I see suggests this patch doesn't do that...

Quoted 7 lines
Quoted 3 lines

- * http://www.intel.com/hardwaredesign/hpetspec_1.pdf
+ * http://www.intel.com/content/dam/www/public/us/en/documents/technical-specifications/software-developers-hpet-spec-1-0a.pdf

..?

jon

Did it again: edit code, run git commit --amend and edited commit log but forgot -a so new code didn't get included in the commit, run git format-patch and then send-email without reviewing the result :(

Sorry about that - posted v2 which does what it says.

Signature · 1 line
MST