a late clone fix
Not sure why I messed up the return value for a missing clone_file_range method, but EBADF is a really bad choice.
PATCH 1/1 fs: return -EOPNOTSUPP if clone is not supported
-EBADF is a rather confusing error if an operations is not supported, and nfsd gets rather upset about it.
Signed-off-by Christoph Hellwig <[email protected]>
--- fs/read_write.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)
fs/read_write.c +4 -2
@@ -1532,10 +1532,12 @@ int vfs_clone_file_range(struct file *file_in, loff_t pos_in,if (!(file_in->f_mode &FMODE_READ ) || !(file_out->f_mode &FMODE_WRITE ) || - (file_out->f_flags &O_APPEND ) || - !file_in->f_op->clone_file_range) + (file_out->f_flags &O_APPEND ))return -EBADF ; +if (!file_in->f_op->clone_file_range) +return -EOPNOTSUPP ; + ret =clone_verify_area (file_in, pos_in, len, false);if (ret)return ret;
Signature · 1 line
2.1.4
Re: [PATCH] fs: return -EOPNOTSUPP if clone is not supported
Quoted 2 lines · Christoph Hellwig
-EBADFis a rather confusing error if an operations is not supported, and nfsd gets rather upset about it.
I was wondering why I kept getting EBADF trying to run xfstests over NFS before I figured out to pass -o nfsvers=4.2 to mount.
Anyhow,
Reviewed-by Darrick J. Wong <[email protected]>
--D
Quoted 28 lines
Signed-off-by Christoph Hellwig <[email protected]>--- fs/read_write.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)fs/read_write.c +4
-2@@ -1532,10 +1532,12 @@ int vfs_clone_file_range(struct file *file_in, loff_t pos_in,if (!(file_in->f_mode &FMODE_READ ) || !(file_out->f_mode &FMODE_WRITE ) || - (file_out->f_flags &O_APPEND ) || - !file_in->f_op->clone_file_range) + (file_out->f_flags &O_APPEND ))return -EBADF ; +if (!file_in->f_op->clone_file_range) +return -EOPNOTSUPP ; + ret =clone_verify_area (file_in, pos_in, len, false);if (ret)return ret;Signature · 1 line
2.1.4