armv8: ls2080a: remove obsolete stream ID partitioning support
Subsystems (2)
A message that is not in the archive (sent off-list or not yet received): [email protected]
PATCH v5 1/7 armv8: ls2080a: remove obsolete stream ID partitioning support
From: Stuart Yoder <[email protected]>
Remove stream ID partitioning support that has been made obsolete by upstream device tree bindings that specify how representing how PCI requester IDs are mapped to MSI specifiers and SMMU stream IDs.
---
-v5: no change
arch/arm/cpu/armv8/fsl-layerscape/fdt.c | 113 ------------------------------- drivers/pci/pcie_layerscape.c | 70 ------------------- 2 files changed, 183 deletions(-)
arch/arm/cpu/armv8/fsl-layerscape/fdt.c +0 -113
@@ -70,115 +70,6 @@ void ft_fixup_cpu(void *blob) }#endif -/* -* the burden is on the the caller to not request a count -* exceeding the bounds of the stream_ids[] array -*/ -void alloc_stream_ids (int start_id,int count,u32 *stream_ids,int max_cnt) -{ -int i; - -if (count > max_cnt) { -printf ("\n%s: ERROR: max per-device stream ID count exceed\n" , - __func__); -return ; - } - -for (i =0 ; i < count; i++) - stream_ids[i] = start_id++; -} - -/* -* This function updates the mmu-masters property on the SMMU -* node as per the SMMU binding-- phandle and list of stream IDs -* for each MMU master. -*/ -void append_mmu_masters (void *blob,const char *smmu_path, -const char *master_name,u32 *stream_ids,int count) -{ -u32 phandle; -int smmu_nodeoffset; -int master_nodeoffset; -int i; - -/* get phandle of mmu master device */ - master_nodeoffset =fdt_path_offset (blob, master_name); -if (master_nodeoffset <0 ) { -printf ("\n%s: ERROR: master not found\n" , __func__); -return ; - } - phandle =fdt_get_phandle (blob, master_nodeoffset); -if (!phandle) {/* if master has no phandle, create one */ - phandle =fdt_create_phandle (blob, master_nodeoffset); -if (!phandle) { -printf ("\n%s: ERROR: unable to create phandle\n" , - __func__); -return ; - } - } - -/* append it to mmu-masters */ - smmu_nodeoffset =fdt_path_offset (blob, smmu_path); -if (fdt_appendprop_u32 (blob, smmu_nodeoffset,"mmu-masters" , - phandle) <0 ) { -printf ("\n%s: ERROR: unable to update SMMU node\n" , __func__); -return ; - } - -/* for each stream ID, append to mmu-masters */ -for (i =0 ; i < count; i++) { -fdt_appendprop_u32 (blob, smmu_nodeoffset,"mmu-masters" , - stream_ids[i]); - } - -/* fix up #stream-id-cells with stream ID count */ -if (fdt_setprop_u32 (blob, master_nodeoffset,"#stream-id-cells" , - count) <0 ) -printf ("\n%s: ERROR: unable to update #stream-id-cells\n" , - __func__); -} - - -/* -* The info below summarizes how streamID partitioning works -* for ls2080a and how it is conveyed to the OS via the device tree. -* -* -non-PCI legacy, platform devices (USB, SD/MMC, SATA, DMA) -* -all legacy devices get a unique ICID assigned and programmed in -* their AMQR registers by u-boot -* -u-boot updates the hardware device tree with streamID properties -* for each platform/legacy device (smmu-masters property) -* -* -PCIe -* -for each PCI controller that is active (as per RCW settings), -* u-boot will allocate a range of ICID and convey that to Linux via -* the device tree (smmu-masters property) -* -* -DPAA2 -* -u-boot will allocate a range of ICIDs to be used by the Management -* Complex for containers and will set these values in the MC DPC image. -* -the MC is responsible for allocating and setting up ICIDs -* for all DPAA2 devices. -* -*/ -#ifdef CONFIG_FSL_LSCH3 -static void fdt_fixup_smmu (void *blob) -{ -int nodeoffset; - - nodeoffset =fdt_path_offset (blob,"/iommu at 5000000" ); -if (nodeoffset <0 ) { -printf ("\n%s: WARNING: no SMMU node found\n" , __func__); -return ; - } - -/* fixup for all PCI controllers */ -#ifdef CONFIG_PCI -fdt_fixup_smmu_pcie (blob); -#endif -} -#endif -void ft_cpu_setup (void *blob,bd_t *bd) {#ifdef CONFIG_MP
@@ -200,8 +91,4 @@ void ft_cpu_setup(void *blob, bd_t *bd)#ifdef CONFIG_FSL_ESDHC fdt_fixup_esdhc (blob, bd);#endif - -#ifdef CONFIG_FSL_LSCH3 -fdt_fixup_smmu (blob); -#endif }
drivers/pci/pcie_layerscape.c +0 -70
73 lines not on this page · raw message
Signature · 1 line
1.7.9.5
PATCH v5 2/7 armv8: ls2080a: update stream ID partitioning info
In reply to a message not in the archiveFrom: Stuart Yoder <[email protected]>
-update comments around how stream IDs are partitioned
-stream IDs allocated to PCI are no longer divided up by
controller, but are instead a contiguous range
---
-v5: no change
.../asm/arch-fsl-layerscape/ls2080a_stream_id.h | 55 ++++++++++++-------- 1 file changed, 34 insertions(+), 21 deletions(-)
arch/arm/include/asm/arch-fsl-layerscape/ls2080a_stream_id.h +34 -21
@@ -7,28 +7,48 @@#ifndef __FSL_STREAM_ID_H#define __FSL_STREAM_ID_H -/* Stream IDs on ls2080a devices are not hardwired and are +/* +* Stream IDs on ls2080a devices are not hardwired and are * programmed by sw. There are a limited number of stream IDs * available, and the partitioning of them is scenario dependent. * This header defines the partitioning between legacy, PCI, * and DPAA2 devices. * -* This partitiong can be customized in this file depending -* on the specific hardware config-- e.g. perhaps not all -* PEX controllers are in use. +* This partitioning can be customized in this file depending +* on the specific hardware config: +* +* -non-PCI legacy, platform devices (USB, SD/MMC, SATA, DMA) +* -all legacy devices get a unique stream ID assigned and programmed in +* their AMQR registers by u-boot +* +* -PCIe +* -there is a range of stream IDs set aside for PCI in this +* file. U-boot will scan the PCI bus and for each device discovered: +* -allocate a streamID +* -set a PEXn LUT table entry mapping 'requester ID' to 'stream ID' +* -set a msi-map entry in the PEXn controller node in the +* device tree (see Documentation/devicetree/bindings/pci/pci-msi.txt +* for more info on the msi-map definition) * -* On LS2080 stream IDs are programmed in AMQ registers (32-bits) for +* -DPAA2 +* -u-boot will allocate a range of stream IDs to be used by the Management +* Complex for containers and will set these values in the MC DPC image. +* -the MC is responsible for allocating and setting up 'isolation context +* IDs (ICIDs) based on the allocated stream IDs for all DPAA2 devices. +* +* On ls2080a SoCs stream IDs are programmed in AMQ registers (32-bits) for * each of the different bus masters. The relationship between * the AMQ registers and stream IDs is defined in the table below: * AMQ bit streamID bit * --------------------------- -* PL[18] 9 -* BMT[17] 8 -* VA[16] 7 -* [15] - -* ICID[14:7] - -* ICID[6:0] 6-0 +* PL[18] 9 // privilege bit +* BMT[17] 8 // bypass translation +* VA[16] 7 // reserved +* [15] - // unused +* ICID[14:7] - // unused +* ICID[6:0] 6-0 // isolation context id * ---------------------------- +* */ #define AMQ_PL_MASK (0x1 << 18)/* priviledge bit */
@@ -46,16 +66,9 @@#define FSL_SATA2_STREAM_ID 5#define FSL_DMA_STREAM_ID 6 -/* PCI - programmed in PEXn_LUT by OS */ -/* 4 IDs per controller */ -#define FSL_PEX1_STREAM_ID_START 7 -#define FSL_PEX1_STREAM_ID_END 10 -#define FSL_PEX2_STREAM_ID_START 11 -#define FSL_PEX2_STREAM_ID_END 14 -#define FSL_PEX3_STREAM_ID_START 15 -#define FSL_PEX3_STREAM_ID_END 18 -#define FSL_PEX4_STREAM_ID_START 19 -#define FSL_PEX4_STREAM_ID_END 22 +/* PCI - programmed in PEXn_LUT */ +#define FSL_PEX_STREAM_ID_START 7 +#define FSL_PEX_STREAM_ID_END 22/* DPAA2 - set in MC DPC and alloced by MC */ #define FSL_DPAA2_STREAM_ID_START 23
Signature · 1 line
1.7.9.5
PATCH v5 4/7 pci/layerscape: add support for LUT
In reply to a message not in the archiveFrom: Stuart Yoder <[email protected]>
The per-PCI controller LUT (Look-Up-Table) is a 32-entry table that maps PCI requester IDs (bus/dev/fun) to a stream ID.
This patch implements infrastructure to enable LUT initialization:
-define registers offsets
-add an index to 'struct ls_pcie' to track next available slot in LUT -add function to allocate the next available entry index -add function to program a LUT entry
---
-v5: check CONFIG_FSL_LSCH3 instead of SoC specific defines
.../include/asm/arch-fsl-layerscape/immap_lsch3.h | 4 +++ drivers/pci/pcie_layerscape.c | 30 ++++++++++++++++++++ 2 files changed, 34 insertions(+)
arch/arm/include/asm/arch-fsl-layerscape/immap_lsch3.h +4 -0
@@ -86,6 +86,10 @@#define PCIE_LUT_BASE 0x80000#define PCIE_LUT_LCTRL0 0x7F8#define PCIE_LUT_DBG 0x7FC +#define PCIE_LUT_UDR (n) (0x800 + (n) * 8) +#define PCIE_LUT_LDR (n) (0x804 + (n) * 8) +#define PCIE_LUT_ENABLE (1 << 31) +#define PCIE_LUT_ENTRY_COUNT 32/* Device Configuration */ #define DCFG_BASE 0x01e00000
drivers/pci/pcie_layerscape.c +30 -0
@@ -93,6 +93,7 @@ struct ls_pcie {void __iomem *dbi;void __iomem *va_cfg0;void __iomem *va_cfg1; +int next_lut_index;struct pci_controller hose; };
@@ -482,6 +483,34 @@ static void ls_pcie_setup_ep(struct ls_pcie *pcie, struct ls_pcie_info *info) } } +#ifdef CONFIG_FSL_LSCH3 +/* +* Return next available LUT index. +*/ +static int ls_pcie_next_lut_index (struct ls_pcie *pcie) +{ +if (pcie->next_lut_index <PCIE_LUT_ENTRY_COUNT ) +return pcie->next_lut_index++; +else +return -1 ;/* LUT is full */ +} + +/* +* Program a single LUT entry +*/ +static void ls_pcie_lut_set_mapping (struct ls_pcie *pcie,int index,u32 devid, +u32 streamid) +{ +void __iomem *lut; + + lut = pcie->dbi +PCIE_LUT_BASE ; + +/* leave mask as all zeroes, want to match all bits */ +writel ((devid <<16 ), lut +PCIE_LUT_UDR (index)); +writel (streamid |PCIE_LUT_ENABLE , lut +PCIE_LUT_LDR (index)); +} +#endif +int ls_pcie_init_ctrl (int busno,enum srds_prtcl dev,struct ls_pcie_info *info) {struct ls_pcie *pcie;
@@ -513,6 +542,7 @@ int ls_pcie_init_ctrl(int busno, enum srds_prtcl dev, struct ls_pcie_info *info) pcie->va_cfg1 =map_physmem (info->cfg1_phys, info->cfg1_size,MAP_NOCACHE ); + pcie->next_lut_index =0 ;/* outbound memory */ pci_set_region(&hose->regions[0],
Signature · 1 line
1.7.9.5
PATCH v5 6/7 pci/layerscape: fdt: function to set msi-map entries
In reply to a message not in the archiveFrom: Stuart Yoder <[email protected]>
msi-map properties are used to tell an OS how PCI requester IDs are mapped to ARM SMMU stream IDs. This patch defines a function to append a single msi-map entry to a given PCI controller device tree node.
---
-v5: no change
drivers/pci/pcie_layerscape.c | 42 +++++++++++++++++++++++++++++++++++++++++ 1 file changed, 42 insertions(+)
drivers/pci/pcie_layerscape.c +42 -0
@@ -520,6 +520,48 @@ static u32 ls_pcie_next_streamid(void) return next_stream_id++; } + +/* +* An msi-map is a property to be added to the pci controller +* node. It is a table, where each entry consists of 4 fields +* e.g.: +* +* msi-map = <[devid] [phandle-to-msi-ctrl] [stream-id] [count] +* [devid] [phandle-to-msi-ctrl] [stream-id] [count]>; +*/ +static void fdt_pcie_set_msi_map_entry (void *blob,struct ls_pcie *pcie, +u32 devid,u32 streamid) +{ +char pcie_path[19 ]; +u32 *prop; +u32 phandle; +int nodeoffset; + +/* find pci controller node */ +snprintf (pcie_path,sizeof (pcie_path),"/soc/pcie@%llx" , + (u64 )pcie->dbi); + nodeoffset =fdt_path_offset (blob, pcie_path); +if (nodeoffset <0 ) { +printf ("\n%s: ERROR: unable to update PCIe node: %s\n" , + __func__, pcie_path); +return ; + } + +/* get phandle to MSI controller */ + prop = (u32 *)fdt_getprop (blob, nodeoffset,"msi-parent" ,0 ); +if (prop ==NULL ) { +printf ("\n%s: ERROR: missing msi-parent: %s\n" , __func__, + pcie_path); +return ; + } + phandle =be32_to_cpu (*prop); + +/* set one msi-map row */ +fdt_appendprop_u32 (blob, nodeoffset,"msi-map" , devid); +fdt_appendprop_u32 (blob, nodeoffset,"msi-map" , phandle); +fdt_appendprop_u32 (blob, nodeoffset,"msi-map" , streamid); +fdt_appendprop_u32 (blob, nodeoffset,"msi-map" ,1 ); +}#endif int ls_pcie_init_ctrl (int busno,enum srds_prtcl dev,struct ls_pcie_info *info)
Signature · 1 line
1.7.9.5