Skip to contentSkip to conversation

staging: netlogic: Fixed alignment of parentheseis checkpatch warning

PATCH In review Parth Sane 3 participants 5 messages Mar 20, 2016 – Mar 21, 2016 Staging

lore
Share & tools
lore

Parth Sane

author
#0 lore raw

PATCH v3 1/1 staging: netlogic: Fixed alignment of parentheseis checkpatch warning

Fixed alignment of parenthesis checkpatch warning to fit coding standards.

---
 drivers/staging/netlogic/platform_net.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
drivers/staging/netlogic/platform_net.c +3 -2
index dde20d5..c967543 100644
@@ -168,8 +168,9 @@ static void xls_gmac_init(void)
 
 		xlr_net_dev0.num_resources = 2;
 
-		xlr_resource_init(&xlr_net0_res[0], xlr_gmac_offsets[0],
-				xlr_gmac_irqs[0]);
+		xlr_resource_init(&xlr_net0_res[0],
+				  xlr_gmac_offsets[0],
+				  xlr_gmac_irqs[0]);
 		platform_device_register(&xlr_net_dev0);
 
 		/* second block is XAUI, not supported yet */
Signature · 1 line
1.9.1
#1 lore raw
Quoted 2 lines · Parth Sane

Fixed alignment of parenthesis checkpatch warning to fit coding standards.

This isn't the same code block as your previous patch.

Previously you were modifying the block starting at line 120, this is starting at 168 and it doesn't actually need modification.

Also, you are not making this patch against either Greg KH's staging-next or Stephen Rothwell's -next

This change has already been done by:

commit 3a694d0c294a081cc13a16c7e43d8cb473edf350
Author: Laura Garcia Liebana <[email protected]>
Date:   Wed Feb 17 09:46:35 2016 +0100

    staging: netlogic: Fix several parentheses alignments

    Align arguments with the open parenthesis. Checkpatch found these issues.

author
#2 lore raw

Hi,
Thanks for pointing out that the changes have been done. Nevertheless this was a good learning exercise. How do I check which changes have already been done? I’m planning to send in another patch on a blank line warning on the same file. I don’t want to overburden the mailing list by repeating work. I apologise for any inconvenience. Regards,
Parth Sane

#4 lore raw
Quoted 9 lines · Joe Perches
Quoted 4 lines · Parth Sane

Hi,
Thanks for pointing out that the changes have been done. Nevertheless this was a good learning exercise. How do I check which changes have already been done?

Use this tree:

http://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git

And note that doing a 'git clone' of this won't do what you want..

What you *want* to do:

$ git clone git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
$ git remote add linux-next git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
$ git fetch --tags linux-next

This will get you a tree that you can actually work with... ... # later on (linux-next is updated most weekdays)

$ git remote update
to find out what the current tree looks like.

You do *not* want to use 'git pull' against linux-next because it rebases every night....