Skip to contentSkip to conversation

staging: netlogic: Fixed alignment of parantheseis checkpatch warning

PATCH Superseded Parth Sane 2 participants 2 messages Mar 20, 2016 Staging

v1 of 3 Superseded Latest is v3 →

lore
Share & tools
lore

Parth Sane

author
#0 lore raw

PATCH 1/1 staging: netlogic: Fixed alignment of parantheseis checkpatch warning

Fixed alignment of paranthesis as per checkpatch. Please ignore earlier sent patch for paranthesis check and use this one.

---
 drivers/staging/netlogic/platform_net.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)
drivers/staging/netlogic/platform_net.c +2 -3
index daee1b2..dde20d5 100644
@@ -120,10 +120,9 @@ static struct platform_device *gmac_controller2_init(void *gmac0_addr)
 	for (mac = 0; mac < 4; mac++) {
 		ndata1.tx_stnid[mac] = FMN_STNID_GMAC1_TX0 + mac;
 		ndata1.phy_addr[mac] = mac + 4 + 0x10;
-
 		xlr_resource_init(&xlr_net1_res[mac * 2],
-				xlr_gmac_offsets[mac + 4],
-				xlr_gmac_irqs[mac + 4]);
+				  xlr_gmac_offsets[mac + 4],
+				  xlr_gmac_irqs[mac + 4]);
 	}
 	xlr_net_dev1.num_resources = 8;
 
Signature · 1 line
1.9.1
#1 lore raw
Quoted 1 line · Parth Sane

Fixed alignment of paranthesis as per checkpatch.

The subject prefix [PATCH] should be numbered
with the revision like [PATCH v2]

Quoted 1 line

Please ignore earlier sent patch for paranthesis check and use this one.

This bit of your email should go below the ---
separator line.

Otherwise it goes into the git commit log which
isn't desired.

Trivially, you've misspelled parenthesis

Quoted 11 lines

---
 drivers/staging/netlogic/platform_net.c | 5 ++---

 1 file changed, 2 insertions(+), 3 deletions(-)
drivers/staging/netlogic/platform_net.c +0 -0
index daee1b2..dde20d5 100644

drivers/staging/netlogic/platform_net.c static struct platform_device *gmac_controller2_init(void *gmac0_addr) · line 123

Quoted 4 lines
drivers/staging/netlogic/platform_net.c +0 -1
@@ -120,10 +120,9 @@ static struct platform_device *gmac_controller2_init(void *gmac0_addr)
  	for (mac = 0; mac < 4; mac++) {
  		ndata1.tx_stnid[mac] = FMN_STNID_GMAC1_TX0 + mac;
  		ndata1.phy_addr[mac] = mac + 4 + 0x10;
-

Also trivially, there's no reason to delete this line.

Quoted 8 lines
drivers/staging/netlogic/platform_net.c +2 -2
  		xlr_resource_init(&xlr_net1_res[mac * 2],
-				xlr_gmac_offsets[mac + 4],
-				xlr_gmac_irqs[mac + 4]);
+				  xlr_gmac_offsets[mac + 4],
+				  xlr_gmac_irqs[mac + 4]);
  	}
  	xlr_net_dev1.num_resources = 8;