dim: Resist committing patches that modify files outside of i915
PATCH v2 1/1 dim: Resist committing patches that modify files outside of i915
If committing to drm-intel-next-queued branch, require the committer to be aware that they are committing outside of drm/i915 maintenance scope.
v2:
- Do not use warn_or_fail (Jani)
- Only apply to drm-intel-next-queued branch (Daniel)
--- dim | 11 +++++++++++ 1 file changed, 11 insertions(+)
dim +11 -0
@@ -691,6 +691,17 @@ function checkpatch_commit if test "$bug_lines" -eq 1; then warn_or_fail "New BUG macro added" fi + + if [ "$branch" = "drm-intel-next-queued" ]; then + local non_i915_files=$(git diff-tree --no-commit-id --name-only -r HEAD | \ + grep -v "^\(drivers/gpu/drm/i915/\|include/drm/i915\|include/uapi/drm/i915\)") + + if [ -n "$non_i915_files" ]; then + echo -e "The following files are outside of i915 maintenance scope:\n" + echo "$non_i915_files" + echo -e "\nConfirm you have appropriate Acked-by and Reviewed-by for above files." + fi + fi } # turn $1 in to a git commit range
Signature · 6 lines
2.5.5 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 20 lines · Joonas Lahtinen
If committing to drm-intel-next-queued branch, require the committer to be aware that they are committing outside of drm/i915 maintenance scope.
v2:
- Do not usewarn_or_fail(Jani)
- Only apply to drm-intel-next-queued branch (Daniel)Cc Daniel Vetter <[email protected]>Cc Jani Nikula <[email protected]>Signed-off-by Joonas Lahtinen <[email protected]>--- dim | 11 +++++++++++ 1 file changed, 11 insertions(+)dim +0
-0
dim function checkpatch_commit · line 696
Quoted 6 lines
dim +3
-0@@ -691,6 +691,17 @@ function checkpatch_commit if test "$bug_lines" -eq 1; then warn_or_fail "New BUG macro added" fi + + if [ "$branch" = "drm-intel-next-queued" ]; then + local non_i915_files=$(git diff-tree --no-commit-id --name-only -r HEAD | \
Using HEAD doesn't fly. dim checkpatch supports giving an arbitrary commit range to check, and this function is given the commit to check as parameter.
BR,
Jani.
Quoted 11 lines
dim +8
-0+ grep -v "^\(drivers/gpu/drm/i915/\|include/drm/i915\|include/uapi/drm/i915\)") + + if [ -n "$non_i915_files" ]; then + echo -e "The following files are outside of i915 maintenance scope:\n" + echo "$non_i915_files" + echo -e "\nConfirm you have appropriate Acked-by and Reviewed-by for above files." + fi + fi } # turn $1 in to a git commit range
Signature · 5 lines
Jani Nikula, Intel Open Source Technology Center _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v3 1/1 dim: Resist committing patches that modify files outside of i915
If committing to drm-intel-next-queued branch, require the committer to be aware that they are committing outside of drm/i915 maintenance scope.
v2:
- Do not use warn_or_fail (Jani)
- Only apply to drm-intel-next-queued branch (Daniel)
v3:
- Do not use HEAD but $commit (Jani)
--- dim | 11 +++++++++++ 1 file changed, 11 insertions(+)
dim +11 -0
@@ -691,6 +691,17 @@ function checkpatch_commit if test "$bug_lines" -eq 1; then warn_or_fail "New BUG macro added" fi + + if [ "$branch" = "drm-intel-next-queued" ]; then + local non_i915_files=$(git diff-tree --no-commit-id --name-only -r HEAD | \ + grep -v "^\(drivers/gpu/drm/i915/\|include/drm/i915\|include/uapi/drm/i915\)") + + if [ -n "$non_i915_files" ]; then + echo -e "The following files are outside of i915 maintenance scope:\n" + echo "$non_i915_files" + echo -e "\nConfirm you have appropriate Acked-by and Reviewed-by for above files." + fi + fi } # turn $1 in to a git commit range
Signature · 6 lines
2.5.5 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Disregard this v3.
Quoted 40 lines · Joonas Lahtinen
If committing to drm-intel-next-queued branch, require the committer to be aware that they are committing outside of drm/i915 maintenance scope.
v2:
- Do not usewarn_or_fail(Jani)
- Only apply to drm-intel-next-queued branch (Daniel)v3:
- Do not use HEAD but $commit (Jani)Cc Daniel Vetter <[email protected]>Cc Jani Nikula <[email protected]>Signed-off-by Joonas Lahtinen <[email protected]>---
dim | 11 +++++++++++1 file changed, 11 insertions(+)dim +0
-0@@ -691,6 +691,17 @@ function checkpatch_commitif test "$bug_lines" -eq 1; then
warn_or_fail"New BUG macro added" fidim +11
-0+ + if [ "$branch" = "drm-intel-next-queued" ]; then + local non_i915_files=$(git diff-tree --no-commit-id --name-only -r HEAD | \ + grep -v "^\(drivers/gpu/drm/i915/\|include/drm/i915\|include/uapi/drm/i915\)") + + if [ -n "$non_i915_files" ]; then + echo -e "The following files are outside of i915 maintenance scope:\n" + echo "$non_i915_files" + echo -e "\nConfirm you have appropriate Acked-by and Reviewed-by for above files." + fi + fi}
# turn $1 in to a git commit range
Signature · 7 lines
Joonas Lahtinen Open Source Technology Center Intel Corporation _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v4 1/1 dim: Resist committing patches that modify files outside of i915
In reply to Jani NikulaIf committing to drm-intel-next-queued branch, require the committer to be aware that they are committing outside of drm/i915 maintenance scope.
v2:
- Do not use warn_or_fail (Jani)
- Only apply to drm-intel-next-queued branch (Daniel)
v3:
- Do not use HEAD but $commit (Jani)
--- dim | 11 +++++++++++ 1 file changed, 11 insertions(+)
dim +11 -0
@@ -691,6 +691,17 @@ function checkpatch_commit if test "$bug_lines" -eq 1; then warn_or_fail "New BUG macro added" fi + + if [ "$branch" = "drm-intel-next-queued" ]; then + local non_i915_files=$(git diff-tree --no-commit-id --name-only -r $commit | \ + grep -v "^\(drivers/gpu/drm/i915/\|include/drm/i915\|include/uapi/drm/i915\)") + + if [ -n "$non_i915_files" ]; then + echo -e "The following files are outside of i915 maintenance scope:\n" + echo "$non_i915_files" + echo -e "\nConfirm you have appropriate Acked-by and Reviewed-by for above files." + fi + fi } # turn $1 in to a git commit range
Signature · 6 lines
2.5.5 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 8 lines · Joonas Lahtinen
If committing to drm-intel-next-queued branch, require the committer to be aware that they are committing outside of drm/i915 maintenance scope.
v2:
- Do not usewarn_or_fail(Jani)
- Only apply to drm-intel-next-queued branch (Daniel)
Quoted 6 lines
v3:
- Do not use HEAD but $commit (Jani)Cc Daniel Vetter <[email protected]>Cc Jani Nikula <[email protected]>Signed-off-by Joonas Lahtinen <[email protected]>
Quoted 26 lines
--- dim | 11 +++++++++++ 1 file changed, 11 insertions(+)dim +11
-0@@ -691,6 +691,17 @@ function checkpatch_commit if test "$bug_lines" -eq 1; then warn_or_fail "New BUG macro added" fi + + if [ "$branch" = "drm-intel-next-queued" ]; then + local non_i915_files=$(git diff-tree --no-commit-id --name-only -r $commit | \ + grep -v "^\(drivers/gpu/drm/i915/\|include/drm/i915\|include/uapi/drm/i915\)") + + if [ -n "$non_i915_files" ]; then + echo -e "The following files are outside of i915 maintenance scope:\n" + echo "$non_i915_files" + echo -e "\nConfirm you have appropriate Acked-by and Reviewed-by for above files." + fi + fi } # turn $1 in to a git commit range
Signature · 5 lines
Jani Nikula, Intel Open Source Technology Center _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Joonas Lahtinen
AppliedQuoted 1 line · Jani Nikula
Acked-by Jani Nikula <[email protected]>
Pushed to maintainer-tools.
Signature · 8 lines
Joonas Lahtinen Open Source Technology Center Intel Corporation _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx