Skip to contentSkip to conversation

dim: Resist committing patches that modify files outside of i915

PATCH Superseded Joonas Lahtinen 2 participants 7 messages May 10, 2016

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 dim: Resist committing patches that modify files outside of i915

If committing to drm-intel-next-queued branch, require the committer to be aware that they are committing outside of drm/i915 maintenance scope.

v2:
- Do not use warn_or_fail (Jani)
- Only apply to drm-intel-next-queued branch (Daniel)

Cc Daniel Vetter <[email protected]>
Cc Jani Nikula <[email protected]>
---
 dim | 11 +++++++++++
 1 file changed, 11 insertions(+)
dim +11 -0
index d9c1be5..cbdae85 100755
@@ -691,6 +691,17 @@ function checkpatch_commit
 	if test "$bug_lines" -eq 1; then
 		warn_or_fail "New BUG macro added"
 	fi
+
+        if [ "$branch" = "drm-intel-next-queued" ]; then
+		local non_i915_files=$(git diff-tree --no-commit-id --name-only -r HEAD | \
+			grep -v "^\(drivers/gpu/drm/i915/\|include/drm/i915\|include/uapi/drm/i915\)")
+
+		if [ -n "$non_i915_files" ]; then
+			echo -e "The following files are outside of i915 maintenance scope:\n"
+			echo "$non_i915_files"
+			echo -e "\nConfirm you have appropriate Acked-by and Reviewed-by for above files."
+		fi
+	fi
 }
 
 # turn $1 in to a git commit range
Signature · 6 lines
2.5.5

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#1 lore raw
Quoted 20 lines · Joonas Lahtinen

If committing to drm-intel-next-queued branch, require the committer to be aware that they are committing outside of drm/i915 maintenance scope.

v2:
- Do not use warn_or_fail (Jani)
- Only apply to drm-intel-next-queued branch (Daniel)

Cc Daniel Vetter <[email protected]>
Cc Jani Nikula <[email protected]>
---
 dim | 11 +++++++++++
 1 file changed, 11 insertions(+)
dim +0 -0
index d9c1be5..cbdae85 100755

dim function checkpatch_commit · line 696

Quoted 6 lines
dim +3 -0
@@ -691,6 +691,17 @@ function checkpatch_commit
 	if test "$bug_lines" -eq 1; then
 		warn_or_fail "New BUG macro added"
 	fi
+
+        if [ "$branch" = "drm-intel-next-queued" ]; then
+		local non_i915_files=$(git diff-tree --no-commit-id --name-only -r HEAD | \

Using HEAD doesn't fly. dim checkpatch supports giving an arbitrary commit range to check, and this function is given the commit to check as parameter.

BR,
Jani.

Quoted 11 lines
dim +8 -0
+			grep -v "^\(drivers/gpu/drm/i915/\|include/drm/i915\|include/uapi/drm/i915\)")
+
+		if [ -n "$non_i915_files" ]; then
+			echo -e "The following files are outside of i915 maintenance scope:\n"
+			echo "$non_i915_files"
+			echo -e "\nConfirm you have appropriate Acked-by and Reviewed-by for above files."
+		fi
+	fi
 }
 
 # turn $1 in to a git commit range
Signature · 5 lines
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#2 lore raw

PATCH v3 1/1 dim: Resist committing patches that modify files outside of i915

If committing to drm-intel-next-queued branch, require the committer to be aware that they are committing outside of drm/i915 maintenance scope.

v2:
- Do not use warn_or_fail (Jani)
- Only apply to drm-intel-next-queued branch (Daniel)

v3:
- Do not use HEAD but $commit (Jani)

Cc Daniel Vetter <[email protected]>
Cc Jani Nikula <[email protected]>
---
 dim | 11 +++++++++++
 1 file changed, 11 insertions(+)
dim +11 -0
index d9c1be5..cbdae85 100755
@@ -691,6 +691,17 @@ function checkpatch_commit
 	if test "$bug_lines" -eq 1; then
 		warn_or_fail "New BUG macro added"
 	fi
+
+        if [ "$branch" = "drm-intel-next-queued" ]; then
+		local non_i915_files=$(git diff-tree --no-commit-id --name-only -r HEAD | \
+			grep -v "^\(drivers/gpu/drm/i915/\|include/drm/i915\|include/uapi/drm/i915\)")
+
+		if [ -n "$non_i915_files" ]; then
+			echo -e "The following files are outside of i915 maintenance scope:\n"
+			echo "$non_i915_files"
+			echo -e "\nConfirm you have appropriate Acked-by and Reviewed-by for above files."
+		fi
+	fi
 }
 
 # turn $1 in to a git commit range
Signature · 6 lines
2.5.5

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#3 lore raw

Disregard this v3.

Quoted 40 lines · Joonas Lahtinen

If committing to drm-intel-next-queued branch, require the committer to be aware that they are committing outside of drm/i915 maintenance scope.

v2:
- Do not use warn_or_fail (Jani)
- Only apply to drm-intel-next-queued branch (Daniel)

v3:
- Do not use HEAD but $commit (Jani)

Cc Daniel Vetter <[email protected]>
Cc Jani Nikula <[email protected]>

---
 dim | 11 +++++++++++

 1 file changed, 11 insertions(+)
dim +0 -0
index d9c1be5..cbdae85 100755
@@ -691,6 +691,17 @@ function checkpatch_commit

  if test "$bug_lines" -eq 1; then warn_or_fail "New BUG macro added" fi

dim +11 -0
+
+        if [ "$branch" = "drm-intel-next-queued" ]; then
+		local non_i915_files=$(git diff-tree --no-commit-id --name-only -r HEAD | \
+			grep -v "^\(drivers/gpu/drm/i915/\|include/drm/i915\|include/uapi/drm/i915\)")
+
+		if [ -n "$non_i915_files" ]; then
+			echo -e "The following files are outside of i915 maintenance scope:\n"
+			echo "$non_i915_files"
+			echo -e "\nConfirm you have appropriate Acked-by and Reviewed-by for above files."
+		fi
+	fi

 }

 # turn $1 in to a git commit range
Signature · 7 lines
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#4 lore raw

PATCH v4 1/1 dim: Resist committing patches that modify files outside of i915

In reply to Jani Nikula

If committing to drm-intel-next-queued branch, require the committer to be aware that they are committing outside of drm/i915 maintenance scope.

v2:
- Do not use warn_or_fail (Jani)
- Only apply to drm-intel-next-queued branch (Daniel)

v3:
- Do not use HEAD but $commit (Jani)

Cc Daniel Vetter <[email protected]>
Cc Jani Nikula <[email protected]>
---
 dim | 11 +++++++++++
 1 file changed, 11 insertions(+)
dim +11 -0
index d9c1be5..fa307d5 100755
@@ -691,6 +691,17 @@ function checkpatch_commit
 	if test "$bug_lines" -eq 1; then
 		warn_or_fail "New BUG macro added"
 	fi
+
+        if [ "$branch" = "drm-intel-next-queued" ]; then
+		local non_i915_files=$(git diff-tree --no-commit-id --name-only -r $commit | \
+			grep -v "^\(drivers/gpu/drm/i915/\|include/drm/i915\|include/uapi/drm/i915\)")
+
+		if [ -n "$non_i915_files" ]; then
+			echo -e "The following files are outside of i915 maintenance scope:\n"
+			echo "$non_i915_files"
+			echo -e "\nConfirm you have appropriate Acked-by and Reviewed-by for above files."
+		fi
+	fi
 }
 
 # turn $1 in to a git commit range
Signature · 6 lines
2.5.5

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Acked-by on v4 1/1
#5 lore raw
Quoted 8 lines · Joonas Lahtinen

If committing to drm-intel-next-queued branch, require the committer to be aware that they are committing outside of drm/i915 maintenance scope.

v2:
- Do not use warn_or_fail (Jani)
- Only apply to drm-intel-next-queued branch (Daniel)

Quoted 6 lines

v3:
- Do not use HEAD but $commit (Jani)

Cc Daniel Vetter <[email protected]>
Cc Jani Nikula <[email protected]>
Quoted 26 lines
---
 dim | 11 +++++++++++
 1 file changed, 11 insertions(+)
dim +11 -0
index d9c1be5..fa307d5 100755
@@ -691,6 +691,17 @@ function checkpatch_commit
 	if test "$bug_lines" -eq 1; then
 		warn_or_fail "New BUG macro added"
 	fi
+
+        if [ "$branch" = "drm-intel-next-queued" ]; then
+		local non_i915_files=$(git diff-tree --no-commit-id --name-only -r $commit | \
+			grep -v "^\(drivers/gpu/drm/i915/\|include/drm/i915\|include/uapi/drm/i915\)")
+
+		if [ -n "$non_i915_files" ]; then
+			echo -e "The following files are outside of i915 maintenance scope:\n"
+			echo "$non_i915_files"
+			echo -e "\nConfirm you have appropriate Acked-by and Reviewed-by for above files."
+		fi
+	fi
 }
 
 # turn $1 in to a git commit range
Signature · 5 lines
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
author Applied
#6 lore raw
Quoted 1 line · Jani Nikula

Pushed to maintainer-tools.

Signature · 8 lines
Joonas Lahtinen
Open Source Technology Center
Intel Corporation

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx