Skip to contentSkip to conversation

?hci-platform: Add support for controllers with more then one reset line

PATCH RESEND New Hans de Goede 3 participants 7 messages Jun 2, 2016 – Jun 8, 2016

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

v5 cover ?hci-platform: Add support for controllers with more then one reset line

Here is a resend of my last version of the patch set to support usb controllers which have multiple resets.

The shared reset controller support this depends on has landed in 4.7-rc1, so this patch-set should be ready for merging now.

Changes in v2:
-Switch to now shared reset_[de]assert functions

Changes in v3:
-Adjust for changes to shared-reset reset-controller functions

Changes in v4:
-Fix Ugly continuation line
-Add Acked-by: Alan Stern <stern <at> xxxxxxxxxxxxxxxxxxx>

Changes in v5:
-No changes, resend for merging into 4.7

Thanks & Regards,

Hans

#1 lore raw

PATCH RESEND v5 1/2 ehci-platform: Add support for controllers with multiple reset lines

From: Reinder de Haan <[email protected]>

At least the EHCI/OHCI found on the Allwinnner H3 SoC needs multiple reset lines, the controller will not initialize while the reset for its companion is still asserted, which means we need to de-assert 2 resets for the controller to work.

---
Changes in v2:
-Use the new reset_control_[de]assert_shared reset-controller functions

---
 Documentation/devicetree/bindings/usb/usb-ehci.txt |  2 +-
 drivers/usb/host/ehci-platform.c                   | 41 ++++++++++++----------
 2 files changed, 24 insertions(+), 19 deletions(-)
Documentation/devicetree/bindings/usb/usb-ehci.txt +1 -1
index a12d601..0701812 100644
@@ -18,7 +18,7 @@ Optional properties:
  - clocks : a list of phandle + clock specifier pairs
  - phys : phandle + phy specifier pair
  - phy-names : "usb"
- - resets : phandle + reset specifier pair
+ - resets : a list of phandle + reset specifier pairs
 
 Example (Sequoia 440EPx):
     ehci at e0000300 {
drivers/usb/host/ehci-platform.c +23 -18

82 lines not on this page · raw message

Signature · 1 line
2.7.4
maintainer
#2 lore raw

PATCH RESEND v5 1/2 ehci-platform: Add support for controllers with multiple reset lines

Quoted 7 lines · Hans de Goede

From: Reinder de Haan <[email protected]>

At least the EHCI/OHCI found on the Allwinnner H3 SoC needs multiple reset lines, the controller will not initialize while the reset for its companion is still asserted, which means we need to de-assert 2 resets for the controller to work.

Quoted 7 lines

---
Changes in v2:
-Use the new reset_control_[de]assert_shared reset-controller functions

---
 Documentation/devicetree/bindings/usb/usb-ehci.txt |  2 +-

I acked v4. Please add acks when posting new versions.

Rob

Quoted 2 lines
 drivers/usb/host/ehci-platform.c                   | 41 ++++++++++++----------
 2 files changed, 24 insertions(+), 19 deletions(-)
#3 lore raw

PATCH RESEND v5 1/2 ehci-platform: Add support for controllers with multiple reset lines

In reply to Hans de Goede
Quoted 9 lines · Hans de Goede

From: Reinder de Haan <[email protected]>

At least the EHCI/OHCI found on the Allwinnner H3 SoC needs multiple reset lines, the controller will not initialize while the reset for its companion is still asserted, which means we need to de-assert 2 resets for the controller to work.

Quoted 7 lines

---
Changes in v2:
-Use the new reset_control_[de]assert_shared reset-controller functions

---
 Documentation/devicetree/bindings/usb/usb-ehci.txt |  2 +-
 drivers/usb/host/ehci-platform.c                   | 41 ++++++++++++----------
 2 files changed, 24 insertions(+), 19 deletions(-)

This patch doesn't apply to my usb-testing branch at all, what went wrong?

thanks,

greg k-h

#4 lore raw

PATCH RESEND v5 1/2 ehci-platform: Add support for controllers with multiple reset lines

Hi,

Quoted 18 lines · Greg Kroah-Hartman
Quoted 9 lines · Hans de Goede

From: Reinder de Haan <[email protected]>

At least the EHCI/OHCI found on the Allwinnner H3 SoC needs multiple reset lines, the controller will not initialize while the reset for its companion is still asserted, which means we need to de-assert 2 resets for the controller to work.

Quoted 7 lines

---
Changes in v2:
-Use the new reset_control_[de]assert_shared reset-controller functions

---
 Documentation/devicetree/bindings/usb/usb-ehci.txt |  2 +-
 drivers/usb/host/ehci-platform.c                   | 41 ++++++++++++----------
 2 files changed, 24 insertions(+), 19 deletions(-)
Quoted 2 lines

This patch doesn't apply to my usb-testing branch at all, what went wrong?

You merged this patch:

https://git.kernel.org/cgit/linux/kernel/git/gregkh/usb.git/commit/?id=d0e08b0077f49e209bc90305ddf1ca434ac6cc0e

Which does almost the same, except that it only supports dedicated reset controllers and not shared reset controllers.

I'll send a new patch which changes things to add support for shared reset controllers.

This will also bring the ehci-platform reset handling code inline with ohci-platform again.

Regards,

Hans

#5 lore raw

PATCH RESEND v5 1/2 ehci-platform: Add support for controllers with multiple reset lines

Quoted 28 lines · Hans de Goede

Hi,

Quoted 18 lines · Greg Kroah-Hartman
Quoted 9 lines · Hans de Goede

From: Reinder de Haan <[email protected]>

At least the EHCI/OHCI found on the Allwinnner H3 SoC needs multiple reset lines, the controller will not initialize while the reset for its companion is still asserted, which means we need to de-assert 2 resets for the controller to work.

Quoted 7 lines

---
Changes in v2:
-Use the new reset_control_[de]assert_shared reset-controller functions

---
 Documentation/devicetree/bindings/usb/usb-ehci.txt |  2 +-
 drivers/usb/host/ehci-platform.c                   | 41 ++++++++++++----------
 2 files changed, 24 insertions(+), 19 deletions(-)
Quoted 2 lines

This patch doesn't apply to my usb-testing branch at all, what went wrong?

You merged this patch:

https://git.kernel.org/cgit/linux/kernel/git/gregkh/usb.git/commit/?id=d0e08b0077f49e209bc90305ddf1ca434ac6cc0e

Quoted 8 lines

Which does almost the same, except that it only supports dedicated reset controllers and not shared reset controllers.

I'll send a new patch which changes things to add support for shared reset controllers.

This will also bring the ehci-platform reset handling code inline with ohci-platform again.

Thanks, I've merged your new patch now.

greg k-h

#6 lore raw

PATCH RESEND v5 2/2 ohci-platform: Add support for controllers with multiple reset lines

In reply to Hans de Goede

At least the EHCI/OHCI found on the Allwinnner H3 SoC needs multiple reset lines, the controller will not initialize while the reset for its companion is still asserted, which means we need to de-assert 2 resets for the controller to work.

---
Changes in v2:
-New patch in v2 of this patch-set, to complement the identical patch for
the ehci-platform code

---
 Documentation/devicetree/bindings/usb/usb-ohci.txt |  2 +-
 drivers/usb/host/ohci-platform.c                   | 43 ++++++++++++----------
 2 files changed, 24 insertions(+), 21 deletions(-)
Documentation/devicetree/bindings/usb/usb-ohci.txt +1 -1
index 19233b7..9df4569 100644
@@ -14,7 +14,7 @@ Optional properties:
 - clocks : a list of phandle + clock specifier pairs
 - phys : phandle + phy specifier pair
 - phy-names : "usb"
-- resets : phandle + reset specifier pair
+- resets : a list of phandle + reset specifier pairs
 
 Example:
 
drivers/usb/host/ohci-platform.c +23 -20

83 lines not on this page · raw message

Signature · 1 line
2.7.4