?hci-platform: Add support for controllers with more then one reset line
Subsystems (4)
v5 cover ?hci-platform: Add support for controllers with more then one reset line
Here is a resend of my last version of the patch set to support usb controllers which have multiple resets.
The shared reset controller support this depends on has landed in 4.7-rc1, so this patch-set should be ready for merging now.
Changes in v2:
-Switch to now shared reset_[de]assert functions
Changes in v3:
-Adjust for changes to shared-reset reset-controller functions
Changes in v4:
-Fix Ugly continuation line
-Add Acked-by: Alan Stern <stern <at> xxxxxxxxxxxxxxxxxxx>
Changes in v5:
-No changes, resend for merging into 4.7
Thanks & Regards,
Hans
PATCH RESEND v5 1/2 ehci-platform: Add support for controllers with multiple reset lines
From: Reinder de Haan <[email protected]>
At least the EHCI/OHCI found on the Allwinnner H3 SoC needs multiple reset lines, the controller will not initialize while the reset for its companion is still asserted, which means we need to de-assert 2 resets for the controller to work.
---
Changes in v2:
-Use the new reset_control_[de]assert_shared reset-controller functions
--- Documentation/devicetree/bindings/usb/usb-ehci.txt | 2 +- drivers/usb/host/ehci-platform.c | 41 ++++++++++++---------- 2 files changed, 24 insertions(+), 19 deletions(-)
Documentation/devicetree/bindings/usb/usb-ehci.txt +1 -1
@@ -18,7 +18,7 @@ Optional properties: - clocks : a list of phandle + clock specifier pairs - phys : phandle + phy specifier pair - phy-names : "usb" - - resets : phandle + reset specifier pair + - resets : a list of phandle + reset specifier pairs Example (Sequoia 440EPx): ehci at e0000300 {
drivers/usb/host/ehci-platform.c +23 -18
82 lines not on this page · raw message
Signature · 1 line
2.7.4
Rob Herring
maintainerPATCH RESEND v5 1/2 ehci-platform: Add support for controllers with multiple reset lines
Quoted 7 lines · Hans de Goede
From: Reinder de Haan <[email protected]>
At least the EHCI/OHCI found on the Allwinnner H3 SoC needs multiple reset lines, the controller will not initialize while the reset for its companion is still asserted, which means we need to de-assert 2 resets for the controller to work.
Quoted 7 lines
Signed-off-by Reinder de Haan <[email protected]>Signed-off-by Hans de Goede <[email protected]>---
Changes in v2:
-Use the new reset_control_[de]assert_shared reset-controller functions--- Documentation/devicetree/bindings/usb/usb-ehci.txt | 2 +-
I acked v4. Please add acks when posting new versions.
Rob
Quoted 2 lines
drivers/usb/host/ehci-platform.c | 41 ++++++++++++---------- 2 files changed, 24 insertions(+), 19 deletions(-)
Greg Kroah-Hartman
maintainerPATCH RESEND v5 1/2 ehci-platform: Add support for controllers with multiple reset lines
In reply to Hans de GoedeQuoted 9 lines · Hans de Goede
From: Reinder de Haan <[email protected]>
At least the EHCI/OHCI found on the Allwinnner H3 SoC needs multiple reset lines, the controller will not initialize while the reset for its companion is still asserted, which means we need to de-assert 2 resets for the controller to work.
Signed-off-by Reinder de Haan <[email protected]>Signed-off-by Hans de Goede <[email protected]>
Quoted 7 lines
---
Changes in v2:
-Use the new reset_control_[de]assert_shared reset-controller functions--- Documentation/devicetree/bindings/usb/usb-ehci.txt | 2 +- drivers/usb/host/ehci-platform.c | 41 ++++++++++++---------- 2 files changed, 24 insertions(+), 19 deletions(-)
This patch doesn't apply to my usb-testing branch at all, what went wrong?
thanks,
greg k-h
PATCH RESEND v5 1/2 ehci-platform: Add support for controllers with multiple reset lines
Hi,
Quoted 18 lines · Greg Kroah-Hartman
Quoted 9 lines · Hans de Goede
From: Reinder de Haan <[email protected]>
At least the EHCI/OHCI found on the Allwinnner H3 SoC needs multiple reset lines, the controller will not initialize while the reset for its companion is still asserted, which means we need to de-assert 2 resets for the controller to work.
Signed-off-by Reinder de Haan <[email protected]>Signed-off-by Hans de Goede <[email protected]>Quoted 7 lines
---
Changes in v2:
-Use the new reset_control_[de]assert_shared reset-controller functions--- Documentation/devicetree/bindings/usb/usb-ehci.txt | 2 +- drivers/usb/host/ehci-platform.c | 41 ++++++++++++---------- 2 files changed, 24 insertions(+), 19 deletions(-)
Quoted 2 lines
This patch doesn't apply to my usb-testing branch at all, what went wrong?
You merged this patch:
Which does almost the same, except that it only supports dedicated reset controllers and not shared reset controllers.
I'll send a new patch which changes things to add support for shared reset controllers.
This will also bring the ehci-platform reset handling code inline with ohci-platform again.
Regards,
Hans
Greg Kroah-Hartman
maintainerPATCH RESEND v5 1/2 ehci-platform: Add support for controllers with multiple reset lines
Quoted 28 lines · Hans de Goede
Hi,
Quoted 18 lines · Greg Kroah-Hartman
Quoted 9 lines · Hans de Goede
From: Reinder de Haan <[email protected]>
At least the EHCI/OHCI found on the Allwinnner H3 SoC needs multiple reset lines, the controller will not initialize while the reset for its companion is still asserted, which means we need to de-assert 2 resets for the controller to work.
Signed-off-by Reinder de Haan <[email protected]>Signed-off-by Hans de Goede <[email protected]>Quoted 7 lines
---
Changes in v2:
-Use the new reset_control_[de]assert_shared reset-controller functions--- Documentation/devicetree/bindings/usb/usb-ehci.txt | 2 +- drivers/usb/host/ehci-platform.c | 41 ++++++++++++---------- 2 files changed, 24 insertions(+), 19 deletions(-)Quoted 2 lines
This patch doesn't apply to my usb-testing branch at all, what went wrong?
You merged this patch:
Quoted 8 lines
Which does almost the same, except that it only supports dedicated reset controllers and not shared reset controllers.
I'll send a new patch which changes things to add support for shared reset controllers.
This will also bring the ehci-platform reset handling code inline with ohci-platform again.
Thanks, I've merged your new patch now.
greg k-h
PATCH RESEND v5 2/2 ohci-platform: Add support for controllers with multiple reset lines
In reply to Hans de GoedeAt least the EHCI/OHCI found on the Allwinnner H3 SoC needs multiple reset lines, the controller will not initialize while the reset for its companion is still asserted, which means we need to de-assert 2 resets for the controller to work.
---
Changes in v2:
-New patch in v2 of this patch-set, to complement the identical patch for
the ehci-platform code
--- Documentation/devicetree/bindings/usb/usb-ohci.txt | 2 +- drivers/usb/host/ohci-platform.c | 43 ++++++++++++---------- 2 files changed, 24 insertions(+), 21 deletions(-)
Documentation/devicetree/bindings/usb/usb-ohci.txt +1 -1
@@ -14,7 +14,7 @@ Optional properties: - clocks : a list of phandle + clock specifier pairs - phys : phandle + phy specifier pair - phy-names : "usb" -- resets : phandle + reset specifier pair +- resets : a list of phandle + reset specifier pairs Example:
drivers/usb/host/ohci-platform.c +23 -20
83 lines not on this page · raw message
Signature · 1 line
2.7.4