Skip to contentSkip to conversation

netfilter: nf_tables_netdev: remove redundant ip_hdr assignment

PATCH Applied Liping Zhang 2 participants 2 messages Aug 28, 2016 – Aug 30, 2016

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 netfilter: nf_tables_netdev: remove redundant ip_hdr assignment

From: Liping Zhang <[email protected]>

We have already use skb_header_pointer to get the ip header pointer, so there's no need to use ip_hdr again. Moreover, in NETDEV INGRESS hook, ip header maybe not linear, so use ip_hdr is not appropriate, remove it.

---
 net/netfilter/nf_tables_netdev.c | 1 -
 1 file changed, 1 deletion(-)
net/netfilter/nf_tables_netdev.c +0 -1
index 5eefe4a..75d696f 100644
@@ -30,7 +30,6 @@ nft_netdev_set_pktinfo_ipv4(struct nft_pktinfo *pkt,
 	if (!iph)
 		return;
 
-	iph = ip_hdr(skb);
 	if (iph->ihl < 5 || iph->version != 4)
 		return;
 
Signature · 1 line
2.5.5
maintainer Applied
#1 lore raw
Quoted 6 lines · Liping Zhang

From: Liping Zhang <[email protected]>

We have already use skb_header_pointer to get the ip header pointer, so there's no need to use ip_hdr again. Moreover, in NETDEV INGRESS hook, ip header maybe not linear, so use ip_hdr is not appropriate, remove it.

Applied, thanks!