netfilter: nf_tables_netdev: remove redundant ip_hdr assignment
Subsystems (2)
PATCH 1/1 netfilter: nf_tables_netdev: remove redundant ip_hdr assignment
From: Liping Zhang <[email protected]>
We have already use skb_header_pointer to get the ip header pointer, so there's no need to use ip_hdr again. Moreover, in NETDEV INGRESS hook, ip header maybe not linear, so use ip_hdr is not appropriate, remove it.
Signed-off-by Liping Zhang <[email protected]>
--- net/netfilter/nf_tables_netdev.c | 1 - 1 file changed, 1 deletion(-)
net/netfilter/nf_tables_netdev.c +0 -1
@@ -30,7 +30,6 @@ nft_netdev_set_pktinfo_ipv4(struct nft_pktinfo *pkt,if (!iph)return ; - iph =ip_hdr (skb);if (iph->ihl <5 || iph->version !=4 )return ;
Signature · 1 line
2.5.5
Quoted 6 lines · Liping Zhang
From: Liping Zhang <[email protected]>
We have already use
skb_header_pointerto get the ip header pointer, so there's no need to useip_hdragain. Moreover, in NETDEV INGRESS hook, ip header maybe not linear, so useip_hdris not appropriate, remove it.
Applied, thanks!