Skip to contentSkip to conversation

Remove unused HIDDEN gcc attribute

PATCH In review Leon Romanovsky 2 participants 2 messages Oct 5, 2016 1 message not in the archive InfiniBand

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Remove unused HIDDEN gcc attribute

The attribute HIDDEN was declared is almost every provider, but it wasn't used, except in libibverbs. Let's remove it.

---
 libhfi1verbs/src/hfiverbs.h    | 2 --
 libi40iw/src/i40iw_umain.h     | 2 --
 libipathverbs/src/ipathverbs.h | 2 --
 libmlx4/src/mlx4.h             | 2 --
 libmlx5/src/mlx5.h             | 2 --
 libmthca/src/mthca.h           | 2 --
 libnes/src/nes_umain.h         | 2 --
 7 files changed, 14 deletions(-)
libhfi1verbs/src/hfiverbs.h +0 -2
index deebc65..e82ba2b 100644
@@ -67,8 +67,6 @@
 #include <infiniband/arch.h>
 #include <infiniband/verbs.h>
 
-#define HIDDEN		__attribute__((visibility ("hidden")))
-
 #define PFX		"hfi1: "
 
 struct hfi1_device {
libi40iw/src/i40iw_umain.h +0 -2
index 13d3da8..719aefc 100644
@@ -54,8 +54,6 @@
 #define unlikely(x) __builtin_expect((x), 0)
 #endif
 
-#define HIDDEN __attribute__((visibility("hidden")))
-
 #define PFX "libi40iw-"
 
 #define  I40IW_BASE_PUSH_PAGE	1
libipathverbs/src/ipathverbs.h +0 -2
index 05e1c71..ff25854 100644
@@ -47,8 +47,6 @@
 #include <infiniband/arch.h>
 #include <infiniband/verbs.h>
 
-#define HIDDEN		__attribute__((visibility ("hidden")))
-
 #define PFX		"ipath: "
 
 struct ipath_device {
libmlx4/src/mlx4.h +0 -2
index 1855cfb..95a6521 100644
@@ -49,8 +49,6 @@
 
 #include <valgrind/memcheck.h>
 
-#define HIDDEN		__attribute__((visibility ("hidden")))
-
 #define PFX		"mlx4: "
 
 enum {
libmlx5/src/mlx5.h +0 -2
index c209a79..f8674c7 100644
@@ -54,8 +54,6 @@
 
 #include <valgrind/memcheck.h>
 
-#define HIDDEN		__attribute__((visibility("hidden")))
-
 #ifdef HAVE_FUNC_ATTRIBUTE_ALWAYS_INLINE
 #define ALWAYS_INLINE __attribute__((always_inline))
 #else
libmthca/src/mthca.h +0 -2
index da53010..b4b0b6a 100644
@@ -41,8 +41,6 @@
 
 #include <valgrind/memcheck.h>
 
-#define HIDDEN		__attribute__((visibility ("hidden")))
-
 #define PFX		"mthca: "
 
 enum mthca_hca_type {
libnes/src/nes_umain.h +0 -2
index 9129982..f3cc348 100644
@@ -48,8 +48,6 @@
 #define unlikely(x) __builtin_expect((x),0)
 #endif
 
-#define HIDDEN __attribute__((visibility ("hidden")))
-
 #define PFX	"libnes: "
 
 #define  NES_QP_MMAP		1

--
2.7.4

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html

A message that is not in the archive (sent off-list or not yet received): 1475665714-5885-1-git-send-email-leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org

Reviewed-by
#2 lore raw
Quoted 2 lines · Leon Romanovsky

The attribute HIDDEN was declared is almost every provider, but it wasn't used, except in libibverbs. Let's remove it.

There is no reason for libibverbs to use this either, please remove it completely.

All libraries and providers use a linker map file which superceeds the hidden attribute.

Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html