Remove unused HIDDEN gcc attribute
PATCH 1/1 Remove unused HIDDEN gcc attribute
The attribute HIDDEN was declared is almost every provider, but it wasn't used, except in libibverbs. Let's remove it.
--- libhfi1verbs/src/hfiverbs.h | 2 -- libi40iw/src/i40iw_umain.h | 2 -- libipathverbs/src/ipathverbs.h | 2 -- libmlx4/src/mlx4.h | 2 -- libmlx5/src/mlx5.h | 2 -- libmthca/src/mthca.h | 2 -- libnes/src/nes_umain.h | 2 -- 7 files changed, 14 deletions(-)
libhfi1verbs/src/hfiverbs.h +0 -2
@@ -67,8 +67,6 @@#include <infiniband/arch.h> #include <infiniband/verbs.h> -#define HIDDEN __attribute__((visibility ("hidden"))) -#define PFX "hfi1: "struct hfi1_device {
libi40iw/src/i40iw_umain.h +0 -2
@@ -54,8 +54,6 @@#define unlikely (x) __builtin_expect((x), 0)#endif -#define HIDDEN __attribute__((visibility("hidden"))) -#define PFX "libi40iw-"#define I40IW_BASE_PUSH_PAGE 1
libipathverbs/src/ipathverbs.h +0 -2
@@ -47,8 +47,6 @@#include <infiniband/arch.h> #include <infiniband/verbs.h> -#define HIDDEN __attribute__((visibility ("hidden"))) -#define PFX "ipath: "struct ipath_device {
libmlx4/src/mlx4.h +0 -2
@@ -49,8 +49,6 @@#include <valgrind/memcheck.h> -#define HIDDEN __attribute__((visibility ("hidden"))) -#define PFX "mlx4: "enum {
libmlx5/src/mlx5.h +0 -2
@@ -54,8 +54,6 @@#include <valgrind/memcheck.h> -#define HIDDEN __attribute__((visibility("hidden"))) -#ifdef HAVE_FUNC_ATTRIBUTE_ALWAYS_INLINE #define ALWAYS_INLINE __attribute__((always_inline))#else
libmthca/src/mthca.h +0 -2
@@ -41,8 +41,6 @@#include <valgrind/memcheck.h> -#define HIDDEN __attribute__((visibility ("hidden"))) -#define PFX "mthca: "enum mthca_hca_type {
libnes/src/nes_umain.h +0 -2
@@ -48,8 +48,6 @@#define unlikely (x) __builtin_expect((x),0)#endif -#define HIDDEN __attribute__((visibility ("hidden"))) -#define PFX "libnes: "#define NES_QP_MMAP 1
--
2.7.4
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
Jason Gunthorpe
Reviewed-byQuoted 2 lines · Leon Romanovsky
The attribute HIDDEN was declared is almost every provider, but it wasn't used, except in libibverbs. Let's remove it.
There is no reason for libibverbs to use this either, please remove it completely.
All libraries and providers use a linker map file which superceeds the hidden attribute.
Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html