Skip to contentSkip to conversation

staging: fbtft: fbtft-bus.c: Fix checkpatch error

PATCH In review Youngdo Lee 2 participants 2 messages Feb 4, 2017 – Feb 5, 2017

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 staging: fbtft: fbtft-bus.c: Fix checkpatch error

Fix checkpatch error:
ERROR: space prohibited before that close parenthesis ')'

---
 drivers/staging/fbtft/fbtft-bus.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
drivers/staging/fbtft/fbtft-bus.c +3 -2
index ec45043..3ce265d 100644
@@ -10,6 +10,7 @@
  *
  *****************************************************************************/
 
+#define	nop_modifier(expr)		(expr)
 #define define_fbtft_write_reg(func, type, modifier)                          \
 void func(struct fbtft_par *par, int len, ...)                                \
 {                                                                             \
@@ -68,9 +69,9 @@ void func(struct fbtft_par *par, int len, ...)                                \
 }                                                                             \
 EXPORT_SYMBOL(func);
 
-define_fbtft_write_reg(fbtft_write_reg8_bus8, u8, )
+define_fbtft_write_reg(fbtft_write_reg8_bus8, u8, nop_modifier)
 define_fbtft_write_reg(fbtft_write_reg16_bus8, u16, cpu_to_be16)
-define_fbtft_write_reg(fbtft_write_reg16_bus16, u16, )
+define_fbtft_write_reg(fbtft_write_reg16_bus16, u16, nop_modifier)
 
 void fbtft_write_reg8_bus9(struct fbtft_par *par, int len, ...)
 {
Signature · 1 line
1.9.1
maintainer
#1 lore raw
Quoted 13 lines · Youngdo Lee

Fix checkpatch error:
ERROR: space prohibited before that close parenthesis ')'

---
 drivers/staging/fbtft/fbtft-bus.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
drivers/staging/fbtft/fbtft-bus.c +0 -0
index ec45043..3ce265d 100644

drivers/staging/fbtft/fbtft-bus.c line 13

Quoted 4 lines
drivers/staging/fbtft/fbtft-bus.c +1 -0
@@ -10,6 +10,7 @@
  *
  *****************************************************************************/
 
+#define	nop_modifier(expr)		(expr)

What?

drivers/staging/fbtft/fbtft-bus.c void func(struct fbtft_par *par, int len, ...) \ · line 72

Quoted 9 lines
drivers/staging/fbtft/fbtft-bus.c +1 -1
 #define define_fbtft_write_reg(func, type, modifier)                          \
 void func(struct fbtft_par *par, int len, ...)                                \
 {                                                                             \
@@ -68,9 +69,9 @@ void func(struct fbtft_par *par, int len, ...)                                \
 }                                                                             \
 EXPORT_SYMBOL(func);
 
-define_fbtft_write_reg(fbtft_write_reg8_bus8, u8, )
+define_fbtft_write_reg(fbtft_write_reg8_bus8, u8, nop_modifier)

That's really odd. Don't do crazy things like this to fix odd code. Fix up the code to not do such looney things in the first place.

thanks,

greg k-h