staging: fbtft: fbtft-bus.c: Fix checkpatch error
Subsystems (2)
PATCH 1/1 staging: fbtft: fbtft-bus.c: Fix checkpatch error
Fix checkpatch error:
ERROR: space prohibited before that close parenthesis ')'
Signed-off-by Youngdo Lee <[email protected]>
--- drivers/staging/fbtft/fbtft-bus.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)
drivers/staging/fbtft/fbtft-bus.c +3 -2
@@ -10,6 +10,7 @@* *****************************************************************************/ +#define nop_modifier (expr) (expr)#define define_fbtft_write_reg (func, type, modifier) \ void func(struct fbtft_par *par, int len, ...) \ { \
@@ -68,9 +69,9 @@ void func(struct fbtft_par *par, int len, ...) \ } \EXPORT_SYMBOL (func); -define_fbtft_write_reg(fbtft_write_reg8_bus8, u8, ) +define_fbtft_write_reg(fbtft_write_reg8_bus8, u8, nop_modifier) define_fbtft_write_reg(fbtft_write_reg16_bus8, u16, cpu_to_be16) -define_fbtft_write_reg(fbtft_write_reg16_bus16, u16, ) +define_fbtft_write_reg(fbtft_write_reg16_bus16, u16, nop_modifier)void fbtft_write_reg8_bus9 (struct fbtft_par *par,int len, ...) {
Signature · 1 line
1.9.1
Greg KH
maintainerQuoted 13 lines · Youngdo Lee
Fix checkpatch error:
ERROR: space prohibited before that close parenthesis ')'Signed-off-by Youngdo Lee <[email protected]>--- drivers/staging/fbtft/fbtft-bus.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)drivers/staging/fbtft/fbtft-bus.c +0
-0
drivers/staging/fbtft/fbtft-bus.c line 13
Quoted 4 lines
drivers/staging/fbtft/fbtft-bus.c +1
-0@@ -10,6 +10,7 @@* *****************************************************************************/ +#define nop_modifier (expr) (expr)
What?
drivers/staging/fbtft/fbtft-bus.c void func(struct fbtft_par *par, int len, ...) \ · line 72
Quoted 9 lines
drivers/staging/fbtft/fbtft-bus.c +1
-1#define define_fbtft_write_reg (func, type, modifier) \ void func(struct fbtft_par *par, int len, ...) \ { \@@ -68,9 +69,9 @@ void func(struct fbtft_par *par, int len, ...) \ } \EXPORT_SYMBOL (func); -define_fbtft_write_reg(fbtft_write_reg8_bus8, u8, ) +define_fbtft_write_reg (fbtft_write_reg8_bus8, u8, nop_modifier)
That's really odd. Don't do crazy things like this to fix odd code. Fix up the code to not do such looney things in the first place.
thanks,
greg k-h