Skip to contentSkip to conversation

script: fix double free in lexer

PATCH In review Andrei Borzenkov 2 participants 2 messages Feb 11, 2017

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 script: fix double free in lexer

yylex_destroy() already frees scanner.

Found by: Coverity scan.
CID: 176636

---
 grub-core/script/lexer.c | 1 -
 1 file changed, 1 deletion(-)
grub-core/script/lexer.c +0 -1
index 89cf677..c6bd317 100644
@@ -251,7 +251,6 @@ grub_script_lexer_init (struct grub_parser_param *parser, char *script,
     {
       parser->lexerstate = 0;
       yylex_destroy (lexerstate->yyscanner);
-      grub_free (lexerstate->yyscanner);
       grub_free (lexerstate->text);
       grub_free (lexerstate);
       return 0;
Signature · 1 line
tg: (5298187..) coverity/176636 (depends on: master)
#1 lore raw

Go ahead

Quoted 30 lines · On Sat, 11 Feb 2017, 21:53 Andrei Borzenkov <[email protected]> wrote:

yylex_destroy() already frees scanner.

Found by: Coverity scan.
CID: 176636

---
 grub-core/script/lexer.c | 1 -
 1 file changed, 1 deletion(-)
grub-core/script/lexer.c +0 -1
index 89cf677..c6bd317 100644
@@ -251,7 +251,6 @@ grub_script_lexer_init (struct grub_parser_param
 *parser, char *script,
     {
       parser->lexerstate = 0;
       yylex_destroy (lexerstate->yyscanner);
-      grub_free (lexerstate->yyscanner);
       grub_free (lexerstate->text);
       grub_free (lexerstate);
       return 0;

--
tg: (5298187..) coverity/176636 (depends on: master)

_______________________________________________
Grub-devel mailing list
[email protected]
https://lists.gnu.org/mailman/listinfo/grub-devel