drm/i915/bxt: use NULL for GPIO connection ID
Subsystems (2)
PATCH 1/1 drm/i915/bxt: use NULL for GPIO connection ID
The commit 213e08ad60ba ("drm/i915/bxt: add bxt dsi gpio element support") enables GPIO support for Broxton based platforms.
While using that API we might get into troubles in the future, because we can't rely on label "panel" in the driver since vendor firmware might provide any GPIO pin there, e.g. "reset", and even mark it in _DSD (in which case the request will fail).
To avoid inconsistency and potential issues we have two options:
a) generate GPIO ACPI mapping table and supply it via acpi_dev_add_driver_gpios(), or
b) just pass NULL as connection ID.
The b) approach is much simplier and would work since the driver relies on GPIO indeces only. Moreover, the _CRS fallback mechanism, when requesting GPIO, is going to be stricter, and supplying non-NULL connection ID when neither _DSD, nor GPIO ACPI mapping is present, will make request fail.
--- drivers/gpu/drm/i915/intel_dsi_panel_vbt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/i915/intel_dsi_panel_vbt.c +1 -1
@@ -315,7 +315,7 @@ static void bxt_exec_gpio(struct drm_i915_private *dev_priv,if (!gpio_desc) { gpio_desc =devm_gpiod_get_index (dev_priv->drm.dev, -"panel" , gpio_index, +NULL , gpio_index, value ?GPIOD_OUT_LOW :GPIOD_OUT_HIGH );
Signature · 6 lines
2.11.0 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✓ Fi.CI.BAT: success for drm/i915/bxt: use NULL for GPIO connection ID
== Series Details ==
== Series Details ==
Series: drm/i915/bxt: use NULL for GPIO connection ID
URL : https://patchwork.freedesktop.org/series/20011/
State : success
== Summary ==
Series 20011v1 drm/i915/bxt: use NULL for GPIO connection ID
https://patchwork.freedesktop.org/api/1.0/series/20011/revisions/1/mbox/
Test gem_exec_basic:
Subgroup gtt-render:
incomplete -> PASS (fi-byt-j1900)fi-bdw-5557u total:253 pass:242 dwarn:0 dfail:0 fail:0 skip:11 fi-bsw-n3050 total:253 pass:214 dwarn:0 dfail:0 fail:0 skip:39 fi-bxt-j4205 total:253 pass:234 dwarn:0 dfail:0 fail:0 skip:19 fi-bxt-t5700 total:83 pass:70 dwarn:0 dfail:0 fail:0 skip:12 fi-byt-j1900 total:253 pass:226 dwarn:0 dfail:0 fail:0 skip:27 fi-byt-n2820 total:253 pass:222 dwarn:0 dfail:0 fail:0 skip:31 fi-hsw-4770 total:253 pass:237 dwarn:0 dfail:0 fail:0 skip:16 fi-hsw-4770r total:253 pass:237 dwarn:0 dfail:0 fail:0 skip:16 fi-ilk-650 total:253 pass:203 dwarn:0 dfail:0 fail:0 skip:50 fi-ivb-3520m total:253 pass:235 dwarn:0 dfail:0 fail:0 skip:18 fi-ivb-3770 total:253 pass:235 dwarn:0 dfail:0 fail:0 skip:18 fi-kbl-7500u total:253 pass:235 dwarn:0 dfail:0 fail:0 skip:18 fi-skl-6260u total:253 pass:243 dwarn:0 dfail:0 fail:0 skip:10 fi-skl-6700hq total:253 pass:236 dwarn:0 dfail:0 fail:0 skip:17 fi-skl-6700k total:253 pass:231 dwarn:4 dfail:0 fail:0 skip:18 fi-skl-6770hq total:253 pass:243 dwarn:0 dfail:0 fail:0 skip:10 fi-snb-2520m total:253 pass:225 dwarn:0 dfail:0 fail:0 skip:28 fi-snb-2600 total:253 pass:224 dwarn:0 dfail:0 fail:0 skip:29
3d47f9476bdc68afdb73ddbc96375366ea689a79 drm-tip: 2017y-02m-21d-14h-13m-06s UTC integration manifest fbeb942 drm/i915/bxt: use NULL for GPIO connection ID
== Logs ==
For more details see: https://intel-gfx-ci.01.org/CI/Patchwork_3914/
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 13 lines · Andy Shevchenko
The commit
213e08ad60ba("drm/i915/bxt: add bxt dsi gpio element support") enables GPIO support for Broxton based platforms.While using that API we might get into troubles in the future, because we can't rely on label "panel" in the driver since vendor firmware might provide any GPIO pin there, e.g. "reset", and even mark it in
_DSD(in which case the request will fail).To avoid inconsistency and potential issues we have two options:
a) generate GPIO ACPI mapping table and supply it viaacpi_dev_add_driver_gpios(), or
b) just pass NULL as connection ID.
Quoted 5 lines
The b) approach is much simplier and would work since the driver relies on GPIO indeces only. Moreover, the
_CRSfallback mechanism, when requesting GPIO, is going to be stricter, and supplying non-NULL connection ID when neither_DSD, nor GPIO ACPI mapping is present, will make request fail.
The patch version log in the commit suggests otherwise; we'd tried and failed with NULL, until Mika realized passing "panel" works:
v2 by Mika: switch *NULL* to *"panel"* when requesting gpio for MIPI/DSI panel.
See also [1]. What has changed since then that should make this work now? We shouldn't apply until we get Tested-by's.
BR,
Jani.
[1] http://mid.mail-archive.com/[email protected]
Quoted 20 lines
Cc Mika Kahola <[email protected]>Cc Jani Nikula <[email protected]>Signed-off-by Andy Shevchenko <[email protected]>--- drivers/gpu/drm/i915/intel_dsi_panel_vbt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/gpu/drm/i915/intel_dsi_panel_vbt.c +1
-1@@ -315,7 +315,7 @@ static void bxt_exec_gpio(struct drm_i915_private *dev_priv,if (!gpio_desc) { gpio_desc =devm_gpiod_get_index (dev_priv->drm.dev, -"panel" , gpio_index, +NULL , gpio_index, value ?GPIOD_OUT_LOW :GPIOD_OUT_HIGH );
Signature · 5 lines
Jani Nikula, Intel Open Source Technology Center _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 26 lines · Jani Nikula
Quoted 16 lines · Andy Shevchenko
The commit
213e08ad60ba("drm/i915/bxt: add bxt dsi gpio element support") enables GPIO support for Broxton based platforms.While using that API we might get into troubles in the future, because
we can't rely on label "panel" in the driver since vendor firmware might
provide any GPIO pin there, e.g. "reset", and even mark it in_DSD(in
which case the request will fail).To avoid inconsistency and potential issues we have two options:
a) generate GPIO ACPI mapping table and supply it viaacpi_dev_add_driver_gpios(), or
b) just pass NULL as connection ID.Quoted 7 lines
The b) approach is much simplier and would work since the driver relies
on GPIO indeces only. Moreover, the_CRSfallback mechanism, when requesting GPIO, is going to be stricter, and supplying non-NULL connection ID when neither_DSD, nor GPIO ACPI mapping is present, will
make request fail.
Quoted 2 lines
The patch version log in the commit suggests otherwise; we'd tried and failed with NULL,
Can I see DSDT excerpts of the platform that fails?
Quoted 9 lines
until Mika realized passing "panel" works:
v2 by Mika: switch *NULL* to *"panel"* when requesting gpio for MIPI/DSI
panel.See also [1]. What has changed since then that should make this work now? We shouldn't apply until we get Tested-by's.
Not changed yet, but *going to be*. See my repository here [2]. To fix the mess with GPIO ACPI stuff we are going to make request stricter as I pointed in commit message above, i.e. asking for a GPIO by connection ID without _DSD present will guarantee -ENOENT since it will be no fallback to _CRS. You may follow discussion in our internal mailing list for drivers.
Quoted 1 line
[2] http://bitbucket.org/andy-shev/linux/branch/topic%2Fuart%2frpm
Signature · 6 lines
Andy Shevchenko <[email protected]> Intel Finland Oy _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 42 lines · Andy Shevchenko
Quoted 26 lines · Jani Nikula
Quoted 16 lines · Andy Shevchenko
The commit
213e08ad60ba("drm/i915/bxt: add bxt dsi gpio element support") enables GPIO support for Broxton based platforms.While using that API we might get into troubles in the future, because
we can't rely on label "panel" in the driver since vendor firmware might
provide any GPIO pin there, e.g. "reset", and even mark it in_DSD(in
which case the request will fail).To avoid inconsistency and potential issues we have two options:
a) generate GPIO ACPI mapping table and supply it viaacpi_dev_add_driver_gpios(), or
b) just pass NULL as connection ID.Quoted 7 lines
The b) approach is much simplier and would work since the driver relies
on GPIO indeces only. Moreover, the_CRSfallback mechanism, when requesting GPIO, is going to be stricter, and supplying non-NULL connection ID when neither_DSD, nor GPIO ACPI mapping is present, will
make request fail.Quoted 2 lines
The patch version log in the commit suggests otherwise; we'd tried and failed with NULL,
Can I see DSDT excerpts of the platform that fails?
Quoted 9 lines
until Mika realized passing "panel" works:
v2 by Mika: switch *NULL* to *"panel"* when requesting gpio for MIPI/DSI
panel.See also [1]. What has changed since then that should make this work now? We shouldn't apply until we get Tested-by's.
Quoted 6 lines
Not changed yet, but *going to be*. See my repository here [2]. To fix the mess with GPIO ACPI stuff we are going to make request stricter as I pointed in commit message above, i.e. asking for a GPIO by connection ID without
_DSDpresent will guarantee-ENOENTsince it will be no fallback to_CRS. You may follow discussion in our internal mailing list for drivers.
Why exactly is this being discussed on an internal mailing list? Upstream happens in public ...
-Daniel
Signature · 7 lines
Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
Quoted 59 lines · Daniel Vetter
Quoted 49 lines · Andy Shevchenko
Quoted 31 lines · Jani Nikula
Quoted 18 lines · Andy Shevchenko
The commit
213e08ad60ba("drm/i915/bxt: add bxt dsi gpio element support") enables GPIO support for Broxton based platforms.While using that API we might get into troubles in the future, because
we can't rely on label "panel" in the driver since vendor firmware
might
provide any GPIO pin there, e.g. "reset", and even mark it in_DSD
(in
which case the request will fail).To avoid inconsistency and potential issues we have two options:
a) generate GPIO ACPI mapping table and supply it viaacpi_dev_add_driver_gpios(), or
b) just pass NULL as connection ID.Quoted 9 lines
The b) approach is much simplier and would work since the driver relies
on GPIO indeces only. Moreover, the_CRSfallback mechanism, when
requesting GPIO, is going to be stricter, and supplying non-NULL connection ID when neither_DSD, nor GPIO ACPI mapping is present,
will
make request fail.Quoted 3 lines
The patch version log in the commit suggests otherwise; we'd tried and
failed with NULL,Can I see DSDT excerpts of the platform that fails?
Quoted 10 lines
until Mika realized passing "panel" works:
v2 by Mika: switch *NULL* to *"panel"* when requesting gpio for
MIPI/DSI
panel.See also [1]. What has changed since then that should make this work
now? We shouldn't apply until we get Tested-by's.Quoted 8 lines
Not changed yet, but *going to be*. See my repository here [2]. To fix the mess with GPIO ACPI stuff we are going to make request stricter as I pointed in commit message above, i.e. asking for a GPIO by
connection ID without_DSDpresent will guarantee-ENOENTsince it will
be no fallback to_CRS. You may follow discussion in our internal mailing list for drivers.
Quoted 3 lines
Why exactly is this being discussed on an internal mailing list? Upstream
happens in public ...
It was a prelininary discussion and it's sad you didn't notice it.
Nevertheless, Hans started it in public mailing list here [1].
I would include you in Cc list for my further replies there.
Mika K., my branch is here [2] with above patch included. Can you, please, test your use case? Because it sounds too strange to me that connection ID in there affects somehow the PM flow. It very likely unveils a bug somewhere else.
[1] https://www.spinics.net/lists/linux-input/msg49127.html
[2] http://bitbucket.org/andy-shev/linux/branch/topic%2Fuart%2frpm
Signature · 6 lines
Andy Shevchenko <[email protected]> Intel Finland Oy _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 60 lines · Andy Shevchenko
Quoted 59 lines · Daniel Vetter
Quoted 57 lines · Andy Shevchenko
Quoted 31 lines · Jani Nikula
Quoted 18 lines · Andy Shevchenko
The commit
213e08ad60ba("drm/i915/bxt: add bxt dsi gpio element support") enables GPIO support for Broxton based platforms.While using that API we might get into troubles in the future, because
we can't rely on label "panel" in the driver since vendor firmware
might
provide any GPIO pin there, e.g. "reset", and even mark it in_DSD
(in
which case the request will fail).To avoid inconsistency and potential issues we have two options:
a) generate GPIO ACPI mapping table and supply it viaacpi_dev_add_driver_gpios(), or
b) just pass NULL as connection ID.Quoted 9 lines
The b) approach is much simplier and would work since the driver relies
on GPIO indeces only. Moreover, the_CRSfallback mechanism, when
requesting GPIO, is going to be stricter, and supplying non-NULL connection ID when neither_DSD, nor GPIO ACPI mapping is present,
will
make request fail.Quoted 3 lines
The patch version log in the commit suggests otherwise; we'd tried and
failed with NULL,Can I see DSDT excerpts of the platform that fails?
Quoted 10 lines
until Mika realized passing "panel" works:
v2 by Mika: switch *NULL* to *"panel"* when requesting gpio for
MIPI/DSI
panel.See also [1]. What has changed since then that should make this work
now? We shouldn't apply until we get Tested-by's.Not changed yet, but *going to be*. See my repository here [2]. To fix the mess with GPIO ACPI stuff we are going to make request stricter as I pointed in commit message above, i.e. asking for a GPIO by
connection ID without_DSDpresent will guarantee-ENOENTsince it will
be no fallback to_CRS. You may follow discussion in our internal mailing list for drivers.
Quoted 5 lines
Quoted 3 lines
Why exactly is this being discussed on an internal mailing list? Upstream
happens in public ...It was a prelininary discussion and it's sad you didn't notice it.
The problem isn't that I didn't notice (I don't think I can provide anything of value here), but that technical discussion should happen in the open, on public mailing lists, because otherwise we just have a big coordination chaos. GFX is huge, and just the automatic public archiving mailing lists provides is super important to get people up to speed when suddenly you realize you need them.
-Daniel
Signature · 7 lines
Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx