Skip to contentSkip to conversation

staging: ks7010: fixed warning of avoiding line over 80 characters

PATCH Superseded Chetan Sethi 2 participants 14 messages Feb 26, 2017 – Feb 28, 2017 Staging

lore
Share & tools
lore
#0 lore raw

PATCH v4 1/6 staging: ks7010: fixed warning of avoiding line over 80 characters

This patch fixes warning of line over 80 characters, as issued by checkpatch.pl

---
v2:
- split multiple changes across different patches
v3:
- mentioned patch revision in subject
v4:
- modified description to exclude mention of patch number from changelog

 drivers/staging/ks7010/ks_wlan.h | 11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)
drivers/staging/ks7010/ks_wlan.h +6 -5
index 9ab80e1..668202d 100644
@@ -18,10 +18,10 @@
 #include <linux/kernel.h>
 #include <linux/module.h>
 
-#include <linux/spinlock.h>	/* spinlock_t                                   */
-#include <linux/sched.h>	/* wait_queue_head_t                            */
-#include <linux/types.h>	/* pid_t                                        */
-#include <linux/netdevice.h>	/* struct net_device_stats,  struct sk_buff     */
+#include <linux/spinlock.h>	/* spinlock_t */
+#include <linux/sched.h>	/* wait_queue_head_t */
+#include <linux/types.h>	/* pid_t */
+#include <linux/netdevice.h>	/* struct net_device_stats,  struct sk_buff */
 #include <linux/etherdevice.h>
 #include <linux/wireless.h>
 #include <linux/atomic.h>	/* struct atomic_t */
@@ -36,7 +36,8 @@
 
 #ifdef KS_WLAN_DEBUG
 #define DPRINTK(n, fmt, args...) \
-                 if (KS_WLAN_DEBUG > (n)) printk(KERN_NOTICE "%s: "fmt, __FUNCTION__, ## args)
+                 if (KS_WLAN_DEBUG > (n)) \
+			printk(KERN_NOTICE "%s: "fmt, __FUNCTION__, ## args)
 #else
 #define DPRINTK(n, fmt, args...)
 #endif
Signature · 1 line
2.7.4
#1 lore raw

PATCH v4 2/6 staging: ks7010: fix coding style issue of enclosing complex macro value in parentheses

This patch fixes error of enclosing complex macro value in parentheses, error as issued by checkpatch

---
v2:
- split multiple changes across different patches
v3:
- mentioned patch revision in subject
- incorporated review comment of correct indentation for do statement
v4:
- modified description to exclude mention of patch number from changelog

 drivers/staging/ks7010/ks_wlan.h | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
drivers/staging/ks7010/ks_wlan.h +4 -2
index 668202d..33d6b28 100644
@@ -36,8 +36,10 @@
 
 #ifdef KS_WLAN_DEBUG
 #define DPRINTK(n, fmt, args...) \
-                 if (KS_WLAN_DEBUG > (n)) \
-			printk(KERN_NOTICE "%s: "fmt, __FUNCTION__, ## args)
+        do { \
+		if (KS_WLAN_DEBUG > (n)) \
+			printk(KERN_NOTICE "%s: "fmt, __FUNCTION__, ## args); \
+	} while (0)
 #else
 #define DPRINTK(n, fmt, args...)
 #endif
Signature · 1 line
2.7.4
maintainer
#2 lore raw

Re: [PATCH v4 2/6] staging: ks7010: fix coding style issue of enclosing complex macro value in parentheses

Quoted 21 lines · Chetan Sethi

This patch fixes error of enclosing complex macro value in parentheses, error as issued by checkpatch

---
v2:
- split multiple changes across different patches
v3:
- mentioned patch revision in subject
- incorporated review comment of correct indentation for do statement
v4:
- modified description to exclude mention of patch number from changelog

 drivers/staging/ks7010/ks_wlan.h | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
drivers/staging/ks7010/ks_wlan.h +0 -0
index 668202d..33d6b28 100644

drivers/staging/ks7010/ks_wlan.h line 39

Quoted 6 lines
drivers/staging/ks7010/ks_wlan.h +1 -2
@@ -36,8 +36,10 @@
 
 #ifdef KS_WLAN_DEBUG
 #define DPRINTK(n, fmt, args...) \
-                 if (KS_WLAN_DEBUG > (n)) \
-			printk(KERN_NOTICE "%s: "fmt, __FUNCTION__, ## args)
+        do { \

This line is not correct, again, it's ok if existing code has checkpatch issues, but you should never _add_ any new ones.

Please fix this up and resend the series.

thanks,

greg k-h

#3 lore raw

PATCH v5 1/5 staging: ks7010: fixed warning of avoiding line over 80 characters

This patch fixes warning of line over 80 characters, as issued by checkpatch.pl

---
v2:
- split multiple changes across different patches
v3:
- mentioned patch revision in subject
v4:
- modified description to exclude mention of patch number from changelog
v5:
- updated series for removing additional checkpatch error introduced

 drivers/staging/ks7010/ks_wlan.h | 11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)
drivers/staging/ks7010/ks_wlan.h +6 -5
index 9ab80e1..668202d 100644
@@ -18,10 +18,10 @@
 #include <linux/kernel.h>
 #include <linux/module.h>
 
-#include <linux/spinlock.h>	/* spinlock_t                                   */
-#include <linux/sched.h>	/* wait_queue_head_t                            */
-#include <linux/types.h>	/* pid_t                                        */
-#include <linux/netdevice.h>	/* struct net_device_stats,  struct sk_buff     */
+#include <linux/spinlock.h>	/* spinlock_t */
+#include <linux/sched.h>	/* wait_queue_head_t */
+#include <linux/types.h>	/* pid_t */
+#include <linux/netdevice.h>	/* struct net_device_stats,  struct sk_buff */
 #include <linux/etherdevice.h>
 #include <linux/wireless.h>
 #include <linux/atomic.h>	/* struct atomic_t */
@@ -36,7 +36,8 @@
 
 #ifdef KS_WLAN_DEBUG
 #define DPRINTK(n, fmt, args...) \
-                 if (KS_WLAN_DEBUG > (n)) printk(KERN_NOTICE "%s: "fmt, __FUNCTION__, ## args)
+                 if (KS_WLAN_DEBUG > (n)) \
+			printk(KERN_NOTICE "%s: "fmt, __FUNCTION__, ## args)
 #else
 #define DPRINTK(n, fmt, args...)
 #endif
Signature · 1 line
2.7.4
#4 lore raw

PATCH v5 2/5 staging: ks7010: fix coding style issue of enclosing complex macro value in parentheses

This patch fixes error of enclosing complex macro value in parentheses, error as issued by checkpatch

---
v2:
- split multiple changes across different patches
v3:
- mentioned patch revision in subject
- incorporated review comment of correct indentation for do statement
v4:
- modified description to exclude mention of patch number from changelog
v5:
- updated series for removing additional checkpatch error introduced

 drivers/staging/ks7010/ks_wlan.h | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
drivers/staging/ks7010/ks_wlan.h +4 -2
index 668202d..94b648b 100644
@@ -36,8 +36,10 @@
 
 #ifdef KS_WLAN_DEBUG
 #define DPRINTK(n, fmt, args...) \
-                 if (KS_WLAN_DEBUG > (n)) \
-			printk(KERN_NOTICE "%s: "fmt, __FUNCTION__, ## args)
+	do { \
+		if (KS_WLAN_DEBUG > (n)) \
+			printk(KERN_NOTICE "%s: "fmt, __FUNCTION__, ## args); \
+	} while (0)
 #else
 #define DPRINTK(n, fmt, args...)
 #endif
Signature · 1 line
2.7.4
#5 lore raw

PATCH v5 3/5 staging: ks7010: fix coding style issue of using pr_notice instead of printk

In reply to Chetan Sethi

---
v2:
- split multiple changes across different patches
v3:
- mentioned patch revision in subject
v4:
- modified description to exclude mention of patch number from changelog
- updated subject to include driver name
v5:
- updated series for removing additional checkpatch error introduced

 drivers/staging/ks7010/ks_wlan.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/ks7010/ks_wlan.h +1 -1
index 94b648b..78beca7 100644
@@ -38,7 +38,7 @@
 #define DPRINTK(n, fmt, args...) \
 	do { \
 		if (KS_WLAN_DEBUG > (n)) \
-			printk(KERN_NOTICE "%s: "fmt, __FUNCTION__, ## args); \
+			pr_notice("%s: "fmt, __FUNCTION__, ## args); \
 	} while (0)
 #else
 #define DPRINTK(n, fmt, args...)
Signature · 1 line
2.7.4
#6 lore raw

PATCH v5 4/5 staging: ks7010: fix coding style issue of using __func__ instead of __FUNCTION__

In reply to Chetan Sethi

This patch fixes coding style issue of using __func__ instead of gcc specific __FUNCTION__, warning as issued by checkpatch

---
v2:
- split multiple changes across different patches
v3:
- mentioned patch revision in subject
v4:
- modified description to exclude mention of patch number from changelog
- updated subject to include driver name
v5:
- updated series for removing additional checkpatch error introduced

 drivers/staging/ks7010/ks_wlan.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/ks7010/ks_wlan.h +1 -1
index 78beca7..79737bf 100644
@@ -38,7 +38,7 @@
 #define DPRINTK(n, fmt, args...) \
 	do { \
 		if (KS_WLAN_DEBUG > (n)) \
-			pr_notice("%s: "fmt, __FUNCTION__, ## args); \
+			pr_notice("%s: "fmt, __func__, ## args); \
 	} while (0)
 #else
 #define DPRINTK(n, fmt, args...)
Signature · 1 line
2.7.4
#7 lore raw

PATCH v5 5/5 staging: ks7010: fix coding style issue of aligning comments properly

In reply to Chetan Sethi

This patch fixes coding style issue of having block comments using a trailing */ on a separate line, warning as issued by checkpatch

---
v2:
- split multiple changes across different patches
v3:
- mentioned patch revision in subject
v4:
- modified description to exclude mention of patch number from changelog
- updated subject to include driver name
v5:
- updated series for removing additional checkpatch error introduced

 drivers/staging/ks7010/ks_wlan.h | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/staging/ks7010/ks_wlan.h +2 -1
index 79737bf..1a63704 100644
@@ -359,7 +359,8 @@ struct wpa_key_t {
 	u8 rx_seq[IW_ENCODE_SEQ_MAX_SIZE];	/* LSB first */
 	struct sockaddr addr;	/* ff:ff:ff:ff:ff:ff for broadcast/multicast
 				 * (group) keys or unicast address for
-				 * individual keys */
+				 * individual keys
+				 */
 	u16 alg;
 	u16 key_len;	/* WEP: 5 or 13, TKIP: 32, CCMP: 16 */
 	u8 key_val[IW_ENCODING_TOKEN_MAX];
Signature · 1 line
2.7.4
maintainer
#8 lore raw
In reply to Chetan Sethi
Quoted 37 lines · Chetan Sethi

This patch fixes warning of line over 80 characters, as issued by checkpatch.pl

---
v2:
- split multiple changes across different patches
v3:
- mentioned patch revision in subject
v4:
- modified description to exclude mention of patch number from changelog
v5:
- updated series for removing additional checkpatch error introduced

 drivers/staging/ks7010/ks_wlan.h | 11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)
drivers/staging/ks7010/ks_wlan.h +4 -4
index 9ab80e1..668202d 100644
@@ -18,10 +18,10 @@
 #include <linux/kernel.h>
 #include <linux/module.h>
 
-#include <linux/spinlock.h>	/* spinlock_t                                   */
-#include <linux/sched.h>	/* wait_queue_head_t                            */
-#include <linux/types.h>	/* pid_t                                        */
-#include <linux/netdevice.h>	/* struct net_device_stats,  struct sk_buff     */
+#include <linux/spinlock.h>	/* spinlock_t */
+#include <linux/sched.h>	/* wait_queue_head_t */
+#include <linux/types.h>	/* pid_t */
+#include <linux/netdevice.h>	/* struct net_device_stats,  struct sk_buff */
 #include <linux/etherdevice.h>
 #include <linux/wireless.h>
 #include <linux/atomic.h>	/* struct atomic_t */

drivers/staging/ks7010/ks_wlan.h line 39

Quoted 5 lines
drivers/staging/ks7010/ks_wlan.h +1 -1
@@ -36,7 +36,8 @@
 
 #ifdef KS_WLAN_DEBUG
 #define DPRINTK(n, fmt, args...) \
-                 if (KS_WLAN_DEBUG > (n)) printk(KERN_NOTICE "%s: "fmt, __FUNCTION__, ## args)
+                 if (KS_WLAN_DEBUG > (n)) \

Why did you not use a tab here to indent this line as you were modifying it?

thanks,

greg k-h

maintainer
#9 lore raw
Quoted 39 lines · Greg KH
Quoted 38 lines · Chetan Sethi

This patch fixes warning of line over 80 characters, as issued by checkpatch.pl

---
v2:
- split multiple changes across different patches
v3:
- mentioned patch revision in subject
v4:
- modified description to exclude mention of patch number from changelog
v5:
- updated series for removing additional checkpatch error introduced

 drivers/staging/ks7010/ks_wlan.h | 11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)
drivers/staging/ks7010/ks_wlan.h +4 -4
index 9ab80e1..668202d 100644
@@ -18,10 +18,10 @@
 #include <linux/kernel.h>
 #include <linux/module.h>
 
-#include <linux/spinlock.h>	/* spinlock_t                                   */
-#include <linux/sched.h>	/* wait_queue_head_t                            */
-#include <linux/types.h>	/* pid_t                                        */
-#include <linux/netdevice.h>	/* struct net_device_stats,  struct sk_buff     */
+#include <linux/spinlock.h>	/* spinlock_t */
+#include <linux/sched.h>	/* wait_queue_head_t */
+#include <linux/types.h>	/* pid_t */
+#include <linux/netdevice.h>	/* struct net_device_stats,  struct sk_buff */
 #include <linux/etherdevice.h>
 #include <linux/wireless.h>
 #include <linux/atomic.h>	/* struct atomic_t */
@@ -36,7 +36,8 @@
 
Quoted 7 lines

drivers/staging/ks7010/ks_wlan.h line 39

Quoted 4 lines
drivers/staging/ks7010/ks_wlan.h +1 -1
 #ifdef KS_WLAN_DEBUG
 #define DPRINTK(n, fmt, args...) \
-                 if (KS_WLAN_DEBUG > (n)) printk(KERN_NOTICE "%s: "fmt, __FUNCTION__, ## args)
+                 if (KS_WLAN_DEBUG > (n)) \

Why did you not use a tab here to indent this line as you were modifying it?

Oh nevermind, you change this up later on in the series...

#10 lore raw

PATCH v4 3/6 staging: ks7010: fix coding style issue of using tabs instead of spaces

In reply to Chetan Sethi

This patch fixes coding style issue of using tabs instead of spaces at start of line, error as issued by checkpatch.pl

---
v2:
- split multiple changes across different patches
v3:
- mentioned patch revision in subject
v4:
- modified description to exclude mention of patch number from changelog

 drivers/staging/ks7010/ks_wlan.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/ks7010/ks_wlan.h +1 -1
index 33d6b28..94b648b 100644
@@ -36,7 +36,7 @@
 
 #ifdef KS_WLAN_DEBUG
 #define DPRINTK(n, fmt, args...) \
-        do { \
+	do { \
 		if (KS_WLAN_DEBUG > (n)) \
 			printk(KERN_NOTICE "%s: "fmt, __FUNCTION__, ## args); \
 	} while (0)
Signature · 1 line
2.7.4
#11 lore raw

PATCH v4 4/6 staging: ks7010: fix coding style issue of using pr_notice instead of printk

In reply to Chetan Sethi

This patch fixes coding style issue of using pr_notice instead of printk, warning as issued by checkpatch.pl

---
v2:
- split multiple changes across different patches
v3:
- mentioned patch revision in subject
v4:
- modified description to exclude mention of patch number from changelog
- updated subject to include driver name

 drivers/staging/ks7010/ks_wlan.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/ks7010/ks_wlan.h +1 -1
index 94b648b..78beca7 100644
@@ -38,7 +38,7 @@
 #define DPRINTK(n, fmt, args...) \
 	do { \
 		if (KS_WLAN_DEBUG > (n)) \
-			printk(KERN_NOTICE "%s: "fmt, __FUNCTION__, ## args); \
+			pr_notice("%s: "fmt, __FUNCTION__, ## args); \
 	} while (0)
 #else
 #define DPRINTK(n, fmt, args...)
Signature · 1 line
2.7.4
#12 lore raw

PATCH v4 5/6 staging: ks7010: fix coding style issue of using __func__ instead of __FUNCTION__

In reply to Chetan Sethi

This patch fixes coding style issue of using __func__ instead of gcc specific __FUNCTION__, warning as issued by checkpatch

---
v2:
- split multiple changes across different patches
v3:
- mentioned patch revision in subject
v4:
- modified description to exclude mention of patch number from changelog
- updated subject to include driver name

 drivers/staging/ks7010/ks_wlan.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/ks7010/ks_wlan.h +1 -1
index 78beca7..79737bf 100644
@@ -38,7 +38,7 @@
 #define DPRINTK(n, fmt, args...) \
 	do { \
 		if (KS_WLAN_DEBUG > (n)) \
-			pr_notice("%s: "fmt, __FUNCTION__, ## args); \
+			pr_notice("%s: "fmt, __func__, ## args); \
 	} while (0)
 #else
 #define DPRINTK(n, fmt, args...)
Signature · 1 line
2.7.4
#13 lore raw

PATCH v4 6/6 staging: ks7010: fix coding style issue of aligning comments properly

In reply to Chetan Sethi

This patch fixes coding style issue of having block comments using a trailing */ on a separate line, warning as issued by checkpatch

---
v2:
- split multiple changes across different patches
v3:
- mentioned patch revision in subject
v4:
- modified description to exclude mention of patch number from changelog
- updated subject to include driver name

 drivers/staging/ks7010/ks_wlan.h | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/staging/ks7010/ks_wlan.h +2 -1
index 79737bf..1a63704 100644
@@ -359,7 +359,8 @@ struct wpa_key_t {
 	u8 rx_seq[IW_ENCODE_SEQ_MAX_SIZE];	/* LSB first */
 	struct sockaddr addr;	/* ff:ff:ff:ff:ff:ff for broadcast/multicast
 				 * (group) keys or unicast address for
-				 * individual keys */
+				 * individual keys
+				 */
 	u16 alg;
 	u16 key_len;	/* WEP: 5 or 13, TKIP: 32, CCMP: 16 */
 	u8 key_val[IW_ENCODING_TOKEN_MAX];
Signature · 1 line
2.7.4