Skip to contentSkip to conversation

staging: ks7010: fixed warning of avoiding line over 80 characters

PATCH Superseded Chetan Sethi 2 participants 8 messages Feb 17, 2017 – Feb 24, 2017 1 message not in the archive Staging

v3 of 5 Superseded Latest is v5 →

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw

PATCH v3 1/6 staging: ks7010: fixed warning of avoiding line over 80 characters

This is patch 01 to ks_wlan.h file in order to fix warning of line over 80 characters, as issued by checkpatch.pl

---
v2:
- split multiple changes across different patches
v3:
- mentioned patch revision in subject

 drivers/staging/ks7010/ks_wlan.h | 11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)
drivers/staging/ks7010/ks_wlan.h +6 -5
index 9ab80e1..668202d 100644
@@ -18,10 +18,10 @@
 #include <linux/kernel.h>
 #include <linux/module.h>
 
-#include <linux/spinlock.h>	/* spinlock_t                                   */
-#include <linux/sched.h>	/* wait_queue_head_t                            */
-#include <linux/types.h>	/* pid_t                                        */
-#include <linux/netdevice.h>	/* struct net_device_stats,  struct sk_buff     */
+#include <linux/spinlock.h>	/* spinlock_t */
+#include <linux/sched.h>	/* wait_queue_head_t */
+#include <linux/types.h>	/* pid_t */
+#include <linux/netdevice.h>	/* struct net_device_stats,  struct sk_buff */
 #include <linux/etherdevice.h>
 #include <linux/wireless.h>
 #include <linux/atomic.h>	/* struct atomic_t */
@@ -36,7 +36,8 @@
 
 #ifdef KS_WLAN_DEBUG
 #define DPRINTK(n, fmt, args...) \
-                 if (KS_WLAN_DEBUG > (n)) printk(KERN_NOTICE "%s: "fmt, __FUNCTION__, ## args)
+                 if (KS_WLAN_DEBUG > (n)) \
+			printk(KERN_NOTICE "%s: "fmt, __FUNCTION__, ## args)
 #else
 #define DPRINTK(n, fmt, args...)
 #endif
Signature · 1 line
2.7.4
#2 lore raw

PATCH v3 2/6 staging: ks7010: fix coding style issue of enclosing complex macro value in parentheses

This is 02nd patch to file ks_wlan.h file fixing error of enclosing complex macro value in parentheses

---
v2:
- split multiple changes across different patches
v3:
- mentioned patch revision in subject
- incorporated review comment of correct indentation for do statement

 drivers/staging/ks7010/ks_wlan.h | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
drivers/staging/ks7010/ks_wlan.h +4 -2
index 668202d..33d6b28 100644
@@ -36,8 +36,10 @@
 
 #ifdef KS_WLAN_DEBUG
 #define DPRINTK(n, fmt, args...) \
-                 if (KS_WLAN_DEBUG > (n)) \
-			printk(KERN_NOTICE "%s: "fmt, __FUNCTION__, ## args)
+        do { \
+		if (KS_WLAN_DEBUG > (n)) \
+			printk(KERN_NOTICE "%s: "fmt, __FUNCTION__, ## args); \
+	} while (0)
 #else
 #define DPRINTK(n, fmt, args...)
 #endif
Signature · 1 line
2.7.4
maintainer
#3 lore raw

Re: [PATCH v3 2/6] staging: ks7010: fix coding style issue of enclosing complex macro value in parentheses

Quoted 2 lines · Chetan Sethi

This is 02nd patch to file ks_wlan.h file fixing error of enclosing complex macro value in parentheses

No need to have the "This is the XXX patch..." in the changelog text, you don't see that in any other commit logs, right?

Quoted 17 lines

---
v2:
- split multiple changes across different patches
v3:
- mentioned patch revision in subject
- incorporated review comment of correct indentation for do statement

 drivers/staging/ks7010/ks_wlan.h | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
drivers/staging/ks7010/ks_wlan.h +0 -0
index 668202d..33d6b28 100644

drivers/staging/ks7010/ks_wlan.h line 39

Quoted 6 lines
drivers/staging/ks7010/ks_wlan.h +1 -2
@@ -36,8 +36,10 @@
 
 #ifdef KS_WLAN_DEBUG
 #define DPRINTK(n, fmt, args...) \
-                 if (KS_WLAN_DEBUG > (n)) \
-			printk(KERN_NOTICE "%s: "fmt, __FUNCTION__, ## args)
+        do { \

Always run checkpatch on your patches so you don't get a grumpy maintainer telling you to run your patches through checkpatch!

Please fix up all 3 of these and resend.

thanks,

greg k-h

#4 lore raw

PATCH v3 3/6 staging: ks7010: fix coding style issue of using tabs instead of spaces

In reply to Chetan Sethi

This is 03rd patch to file ks_wlan.h fixing coding style issue of using tabs instead of spaces at start of line, error as issued by checkpatch.pl

---
v2:
- split multiple changes across different patches
v3:
- mentioned patch revision in subject

 drivers/staging/ks7010/ks_wlan.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/ks7010/ks_wlan.h +1 -1
index 33d6b28..94b648b 100644
@@ -36,7 +36,7 @@
 
 #ifdef KS_WLAN_DEBUG
 #define DPRINTK(n, fmt, args...) \
-        do { \
+	do { \
 		if (KS_WLAN_DEBUG > (n)) \
 			printk(KERN_NOTICE "%s: "fmt, __FUNCTION__, ## args); \
 	} while (0)
Signature · 1 line
2.7.4
#5 lore raw

PATCH v3 4/6 drivers: staging: fix coding style issue of using pr_notice instead of printk

In reply to Chetan Sethi

This is 04th patch to ks_wlan.h fixing coding style issue of using pr_notice instead of printk, warning as issued by checkpatch.pl

---
v2:
- split multiple changes across different patches
v3:
- mentioned patch revision in subject

 drivers/staging/ks7010/ks_wlan.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/ks7010/ks_wlan.h +1 -1
index 94b648b..78beca7 100644
@@ -38,7 +38,7 @@
 #define DPRINTK(n, fmt, args...) \
 	do { \
 		if (KS_WLAN_DEBUG > (n)) \
-			printk(KERN_NOTICE "%s: "fmt, __FUNCTION__, ## args); \
+			pr_notice("%s: "fmt, __FUNCTION__, ## args); \
 	} while (0)
 #else
 #define DPRINTK(n, fmt, args...)
Signature · 1 line
2.7.4
maintainer
#6 lore raw

Re: [PATCH v3 4/6] drivers: staging: fix coding style issue of using pr_notice instead of printk

Quoted 9 lines · Chetan Sethi

This is 04th patch to ks_wlan.h fixing coding style issue of using pr_notice instead of printk, warning as issued by checkpatch.pl

---
v2:
- split multiple changes across different patches
v3:
- mentioned patch revision in subject

Does not apply to my tree, did I miss some previous patches? Please resend the whole series.

thanks,

greg k-h

#7 lore raw

PATCH v3 5/6 drivers: staging: fix coding style issue of using __func__ instead of __FUNCTION__

In reply to Chetan Sethi

This is 05th patch to file ks_wlan.h which fixes coding style issue of using __func__ instead of gcc specific __FUNCTION__, warning as issued by checkpatch.pl

---
v2:
- split multiple changes across different patches
v3:
- mentioned patch revision in subject

 drivers/staging/ks7010/ks_wlan.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/ks7010/ks_wlan.h +1 -1
index 78beca7..79737bf 100644
@@ -38,7 +38,7 @@
 #define DPRINTK(n, fmt, args...) \
 	do { \
 		if (KS_WLAN_DEBUG > (n)) \
-			pr_notice("%s: "fmt, __FUNCTION__, ## args); \
+			pr_notice("%s: "fmt, __func__, ## args); \
 	} while (0)
 #else
 #define DPRINTK(n, fmt, args...)
Signature · 1 line
2.7.4
#8 lore raw

PATCH v3 6/6 drivers: staging: fix coding style issue of aligning comments properly

In reply to Chetan Sethi

This is 06th patch to file ks_wlan.h in order to fix coding style issue of having block comments using a trailing */ on a separate line, warning as issued by checkpatch.pl

---
v2:
- split multiple changes across different patches
v3:
- mentioned patch revision in subject

 drivers/staging/ks7010/ks_wlan.h | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/staging/ks7010/ks_wlan.h +2 -1
index 79737bf..1a63704 100644
@@ -359,7 +359,8 @@ struct wpa_key_t {
 	u8 rx_seq[IW_ENCODE_SEQ_MAX_SIZE];	/* LSB first */
 	struct sockaddr addr;	/* ff:ff:ff:ff:ff:ff for broadcast/multicast
 				 * (group) keys or unicast address for
-				 * individual keys */
+				 * individual keys
+				 */
 	u16 alg;
 	u16 key_len;	/* WEP: 5 or 13, TKIP: 32, CCMP: 16 */
 	u8 key_val[IW_ENCODING_TOKEN_MAX];
Signature · 1 line
2.7.4